3dcf6abbd991c966346cceb334e8c0f1bd823152: Bug 1458049 - Implement ability to move a selection of tabs into a new window through tab context menu. r?jaws draft multiselect_move_ok
Abdoulaye O. Ly <ablayelyfondou@gmail.com> - Fri, 13 Jul 2018 19:30:58 +0000 - rev 817994
Push 116233 by bmo:ablayelyfondou@gmail.com at Fri, 13 Jul 2018 19:32:16 +0000
Bug 1458049 - Implement ability to move a selection of tabs into a new window through tab context menu. r?jaws MozReview-Commit-ID: KrjavwyoF4s
751e2fa4c3e1c2e57d0350535ae81c63d452a6a3: Bug 1465616 - Add a mochitest for fixed position hit-testing. r?botond draft
Kashav Madan <kmadan@mozilla.com> - Wed, 04 Jul 2018 16:17:31 -0400 - rev 817993
Push 116232 by bmo:kmadan@mozilla.com at Fri, 13 Jul 2018 19:31:40 +0000
Bug 1465616 - Add a mochitest for fixed position hit-testing. r?botond MozReview-Commit-ID: IC82JZoVgPs
9c849fe3da347a73853e97db2b2a5abf44de8d0a: Bug 1465616 - Add reftests for fixed and sticky elements. r?botond draft
Kashav Madan <kmadan@mozilla.com> - Wed, 04 Jul 2018 16:16:09 -0400 - rev 817992
Push 116232 by bmo:kmadan@mozilla.com at Fri, 13 Jul 2018 19:31:40 +0000
Bug 1465616 - Add reftests for fixed and sticky elements. r?botond MozReview-Commit-ID: IzSUQqvjrUp
fbd7ee49e77a19cb82463a480f607133fe4887a8: Bug 1473872 - Start targeting API 26; r?nalexander draft
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 06 Jul 2018 16:57:36 +0300 - rev 817991
Push 116231 by plingurar@mozilla.com at Fri, 13 Jul 2018 19:23:06 +0000
Bug 1473872 - Start targeting API 26; r?nalexander MozReview-Commit-ID: GqBiQbRy4bu
2d87fc6f48a95558acf268bf1669510abb1d4c02: Bug 1474961 - Change StumblerService to a foreground service when targeting Android Oreo. r?sdaswani draft
Vlad Baicu <vlad.baicu@softvision.ro> - Wed, 11 Jul 2018 20:02:24 +0300 - rev 817990
Push 116231 by plingurar@mozilla.com at Fri, 13 Jul 2018 19:23:06 +0000
Bug 1474961 - Change StumblerService to a foreground service when targeting Android Oreo. r?sdaswani Also made broadcasts involving Stumbler explicit. MozReview-Commit-ID: 7CK2Cr2JqX0
4c5c44eb7dd068f4be4245d4fd09e919503c5faf: Bug 1451061 - Review Permissions usage for Android 8 behaviour changes r?JanH draft
Andrei Lazar <andrei.a.lazar@softvision.ro> - Thu, 05 Jul 2018 13:15:10 +0300 - rev 817989
Push 116231 by plingurar@mozilla.com at Fri, 13 Jul 2018 19:23:06 +0000
Bug 1451061 - Review Permissions usage for Android 8 behaviour changes r?JanH Added reading permission as a safety measure for any future android updates. MozReview-Commit-ID: Be6V8hn9KF8 ***
9a91c36b6e3c6278f13a0c942d0bdf1f238aeb4d: Bug 1465102 - Updated NotificationService for Oreo. r?sdaswani draft
Vlad Baicu <vlad.baicu@softvision.ro> - Thu, 05 Jul 2018 19:35:16 +0300 - rev 817988
Push 116231 by plingurar@mozilla.com at Fri, 13 Jul 2018 19:23:06 +0000
Bug 1465102 - Updated NotificationService for Oreo. r?sdaswani Modified NotificationClient to use new start/stop intents for NotificationService for Android O. We are keeping a reference to the notification the service was first started with in order to comply with the mandatory startForeground call for Oreo. MozReview-Commit-ID: 4CzM4pvANJt
60f381e7555e5fe68e84c86da6c868a7a3b004ca: Bug 1384866 - Refactored MediaControlService logic to GeckoMediaControlAgent. r?sdaswani draft
Vlad Baicu <vlad.baicu@softvision.ro> - Fri, 22 Jun 2018 19:02:54 +0300 - rev 817987
Push 116231 by plingurar@mozilla.com at Fri, 13 Jul 2018 19:23:06 +0000
Bug 1384866 - Refactored MediaControlService logic to GeckoMediaControlAgent. r?sdaswani Moved the logic ouf of MediaControlService to a new singleton GeckoMediaControlAgent, which delegates all media-related actions.Currently, MediaControlService is used for the foreground notification and to retrieve actions from the notification pending intents. Removed redundant test cases. MozReview-Commit-ID: KukAmpnn33S
16f0d980b7ab320f512f7e705f26dd7f58de7d51: Bug 1473518 - Abide by Android Oreo background execution limits [Leanplum after upgrade] r?sdaswani draft
Andrei Lazar <andrei.a.lazar@softvision.ro> - Fri, 06 Jul 2018 13:21:27 +0300 - rev 817986
Push 116231 by plingurar@mozilla.com at Fri, 13 Jul 2018 19:23:06 +0000
Bug 1473518 - Abide by Android Oreo background execution limits [Leanplum after upgrade] r?sdaswani Refactored existing LeanplumPushInstanceIDService to support Oreo background execution limits in Leanplum after upgrade. MozReview-Commit-ID: JjUlrOv34KR ***
00a3b199cd673687fb03b8b59600dd00f69fcb29: Bug 1450447 - Start using notification channels. r?jchen draft
Andrei Lazar <andrei.a.lazar@softvision.ro> - Fri, 06 Jul 2018 17:57:22 +0300 - rev 817985
Push 116231 by plingurar@mozilla.com at Fri, 13 Jul 2018 19:23:06 +0000
Bug 1450447 - Start using notification channels. r?jchen Made all the notifications within the app to use notification channel for devices with API26 and higher. MozReview-Commit-ID: CVmpitNsS66
b20c9125e9ba3e1ae7de5ba0616cb02c4bc7b2cc: Bug 1465323 - Update PackageAddedReceiver; r?JanH draft
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 26 Jun 2018 12:09:41 +0300 - rev 817984
Push 116231 by plingurar@mozilla.com at Fri, 13 Jul 2018 19:23:06 +0000
Bug 1465323 - Update PackageAddedReceiver; r?JanH This Receiver was used for implicit broadcasts and registered statically. Refactored MmaDelegate() to register it dynamically in the init() method, called in activity's onCreate and unregister it in activity's onDestroy. This way we will still get notified immediately if the user installs any of the apps we are interested in, even though he might not return to Fennec immediately after. This will help to better asses the impact of suggestions to install recommended packages. For the cases in which the user installs the packages without us suggesting to or if he kills our app before completing the new install, we will trigger a check for the install status of the packages in MmaDelegate().init(). Also cleaned the code a little. MozReview-Commit-ID: I00mLS2snzj
42ac3d92b32fad825d64411ebefd0d48207f1f3d: Bug 1465323 - Update NotificationReceiver; r?JanH draft
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 12 Jun 2018 13:01:23 +0300 - rev 817983
Push 116231 by plingurar@mozilla.com at Fri, 13 Jul 2018 19:23:06 +0000
Bug 1465323 - Update NotificationReceiver; r?JanH The only change needed was to make sure the broadcast for NotificationHelper.HELPER_BROADCAST_ACTION is sent explicitly to our receiver. The other 2 broadcasts that this receiver listens for are already explicit. MozReview-Commit-ID: C3A88ijqIsd
fdd4bf6ff67f07d93233f1e964e6321326696ca0: Bug 1465323 - Update WhatsNewReceiver; r?JanH draft
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 12 Jun 2018 12:43:55 +0300 - rev 817982
Push 116231 by plingurar@mozilla.com at Fri, 13 Jul 2018 19:23:06 +0000
Bug 1465323 - Update WhatsNewReceiver; r?JanH Listening for `ACTION_MY_PACKAGE_REPLACED` [1] is the easiest way to get notified when the app has been updated. This broadcast, while not explicitly exempt from Oreo's Background Execution Limits [2] is considered explicit because it is sent only to the package being replaced and so it is compatible with the new limitations. The previous intent action was chosen because at that time this action was not supported by all platforms Fennec ran on [3], but this is not the case anymore. The other broadcast - `ACTION_NOTIFICATION_CANCELLED` that this receiver listens to is send explicitly. [1] https://developer.android.com/reference/android/content/Intent.html#ACTION_MY_PACKAGE_REPLACED [2] https://developer.android.com/guide/components/broadcast-exceptions [3] https://github.com/mozilla-services/android-sync/pull/442/commits/5c06063be6f6ae33f3624474c0ee11e4f3ff5142 MozReview-Commit-ID: DLUdw906i3P
86dc30aed7445e07f38ea95cba9d58f162178b67: Bug 1467840 - Use a JobIntentService for GCM token refresh; r?sdaswani draft
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 26 Jun 2018 19:04:10 +0300 - rev 817981
Push 116231 by plingurar@mozilla.com at Fri, 13 Jul 2018 19:23:06 +0000
Bug 1467840 - Use a JobIntentService for GCM token refresh; r?sdaswani Whenever the GCM token expires it need to be refreshed. For this, after targeting Android 8.0 (API level 26) or higher Google recommends using a JobIntentService https://developers.google.com/cloud-messaging/android/client MozReview-Commit-ID: 1vz092TQfbz
859985b9eb7b9dd6c69b9eb4b9534896dfa053f6: Bug 1467840 - Migrate GeckoService to JobIntentService; r?JanH draft
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 26 Jun 2018 18:41:38 +0300 - rev 817980
Push 116231 by plingurar@mozilla.com at Fri, 13 Jul 2018 19:23:06 +0000
Bug 1467840 - Migrate GeckoService to JobIntentService; r?JanH This simple Service needed to be migrated to JobIntentService because it could be started from background and we don't want it as a foreground service (with a notification). (For example: when the app is updated org.mozilla.gecko.PackageReplacedReceiver would try and start this service. If in background, the app would crash) Had to break the initial Service into separate JobIntentServices because in the event that there are concurrent calls (even with different Intent actions) JobScheduler would assume they are for the same already running service. INTENT_ACTION_UPDATE_ADDONS was removed as it was being unused. MozReview-Commit-ID: 2GiWFZdAVvp
b6dd3347bba6f86e934ca0b256b3629f7eed39ef: Bug 1467461 - Migrate CrashReportingService to JobIntentService; r?snorp draft
Petru Lingurar <petru.lingurar@softvision.ro> - Mon, 02 Jul 2018 17:32:10 +0300 - rev 817979
Push 116231 by plingurar@mozilla.com at Fri, 13 Jul 2018 19:23:06 +0000
Bug 1467461 - Migrate CrashReportingService to JobIntentService; r?snorp Use the fact that a JobIntentService is still a Service to keep most of the previous implementation and method of starting CrashReportingService. On 26+ devices it will be called with "start-foreground-service". This ensures it can be started even from background and the crash reporting process would work as before but ActivityManager will post an ANR error to logcat after 5 seconds because we aren't calling Service.startForeground() (which would mean a user visible notification). Will use different Job Ids depending on if the app is Firefox Release or Firefox Beta. The Job Id will be passed to GeckoThread when first initializing and then be made available to CrashHandler and nsExceptionHandler.cpp to be sent in the Intent that starts the CrashReporterService. MozReview-Commit-ID: GATl6Waa9St
51994cdd3714040d2e834c5125d057e365b5fba3: Bug 1407046 - Migrate UpdateService to JobIntentService; r?jchen draft
Petru Lingurar <petru.lingurar@softvision.ro> - Fri, 13 Jul 2018 20:53:38 +0300 - rev 817978
Push 116231 by plingurar@mozilla.com at Fri, 13 Jul 2018 19:23:06 +0000
Bug 1407046 - Migrate UpdateService to JobIntentService; r?jchen Broke the big IntentService into four small JobIntentServices because the same JobIntentService class cannot be used with multiple JobIds (https://github.com/aosp-mirror/platform_frameworks_support/blob/b6838fd2d2e834fdd38aab34511d385cb7108f63/compat/src/main/java/android/support/v4/app/JobIntentService.java#L121) Also: - will make the code easier to be migrated to WorkManager in the future - more in line with SRP. It was initially doing too much. All the functionality of the big UpdateService class has been incorporated in Updater.java, UpdatesPrefs.java and UpdatesServiceHelper.java with the main logic to drive the important actions inside the new Services. UpdaterService is used as parent of the newly created service to help avoid duplicated code. Created an inner BroadcastReceiver to act upon notification actions while the service which posted it is running as it's state needed to be modified. Created a BroadcastReceiver to act on actions from notifications which remained posted after the service that posted them finished. This receiver will just start another UpdaterService. Otherwise the services are to be started from the UpdateServiceHelper class. MozReview-Commit-ID: 2OyBZ4YYvgh
d29ab8574fc1a514b8152d62de664571129a5c32: Bug 1407046 - Migrate FileCleanupService to JobIntentService; r?JanH draft
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 26 Jun 2018 17:42:28 +0300 - rev 817977
Push 116231 by plingurar@mozilla.com at Fri, 13 Jul 2018 19:23:06 +0000
Bug 1407046 - Migrate FileCleanupService to JobIntentService; r?JanH Also cleaned the code a little. MozReview-Commit-ID: Bs3bUdxxz8k
8cb852a499b01ab9601b6e720559ffe088c719de: Bug 1407046 - Migrate TelemetryUploadService to JobIntentService; r?JanH draft
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 26 Jun 2018 17:40:48 +0300 - rev 817976
Push 116231 by plingurar@mozilla.com at Fri, 13 Jul 2018 19:23:06 +0000
Bug 1407046 - Migrate TelemetryUploadService to JobIntentService; r?JanH MozReview-Commit-ID: 8UGDzgmY81y
1aebce47373ff58f7f566dfb03603cc5c512478b: Bug 1407046 - Migrate FxAccountDeletedService to JobIntentService; r?jchen draft
Petru Lingurar <petru.lingurar@softvision.ro> - Tue, 26 Jun 2018 17:38:30 +0300 - rev 817975
Push 116231 by plingurar@mozilla.com at Fri, 13 Jul 2018 19:23:06 +0000
Bug 1407046 - Migrate FxAccountDeletedService to JobIntentService; r?jchen MozReview-Commit-ID: 5ksrTc1Stre
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip