3c606cacdd1de0f2db50ccbe34799c1f701f1a8c: bug 1277504 - Support aggregated child histograms in about:telemetry r=gfritzsche
Chris H-C <chutten@mozilla.com> - Fri, 26 Aug 2016 08:06:00 +0700 - rev 407555
Push 27992 by bmo:rail@mozilla.com at Tue, 30 Aug 2016 16:51:23 +0000
bug 1277504 - Support aggregated child histograms in about:telemetry r=gfritzsche Throw some process selectors in the Histograms and Keyed Histograms sections to allow users to choose which process type's histograms they'd like to see.
ce72d25d0c5ba9122ec69bc60f8ec9a7c6c5cd54: bug 1218576 - Test child categorical histogram aggregation r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 23 Aug 2016 08:36:00 +0700 - rev 407554
Push 27992 by bmo:rail@mozilla.com at Tue, 30 Aug 2016 16:51:23 +0000
bug 1218576 - Test child categorical histogram aggregation r=gfritzsche It's new, it wasn't tested, and my patches broke it earlier so we should have coverage for it. MozReview-Commit-ID: B25bFOJHMSQ
3c5d66ad69a053028c742e217820935c6eacb868: bug 1218576 - Aggregate child categorical histograms in the parent process. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Thu, 18 Aug 2016 14:06:00 +0700 - rev 407553
Push 27992 by bmo:rail@mozilla.com at Tue, 30 Aug 2016 16:51:23 +0000
bug 1218576 - Aggregate child categorical histograms in the parent process. r=gfritzsche Rewrite the categorical histogram accumulation code to use the common path. This way it gets remote accumulation for cheap. MozReview-Commit-ID: 3q6gdSvBix
80b0680f916f33c7f764e23ed738f0a21e3f5333: bug 1218576 - Ensure we can record before trying to record categorical histograms. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 16 Aug 2016 12:42:00 +0700 - rev 407552
Push 27992 by bmo:rail@mozilla.com at Tue, 30 Aug 2016 16:51:23 +0000
bug 1218576 - Ensure we can record before trying to record categorical histograms. r=gfritzsche Every other Accumulate call has it :S MozReview-Commit-ID: 8uWtADebuJ1
aee17ede1c0e61e711b21cd1653a53c9a800e290: bug 1218576 - Ensure Telemetry IDs coming from IPC are valid r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 16 Aug 2016 12:42:00 +0700 - rev 407551
Push 27992 by bmo:rail@mozilla.com at Tue, 30 Aug 2016 16:51:23 +0000
bug 1218576 - Ensure Telemetry IDs coming from IPC are valid r=gfritzsche I saw a one-off crash on try in internal_GetHistogramByEnumId. Not reproducible but maybe possible if we're trying to accumulate using an invalid ID. So let's guard against that. MozReview-Commit-ID: Ei6eTlV91mJ
7f8e3d336e2fff09ad372ee8fc56a84b44a6f49a: bug 1218576 - Ensure remaining batched telemetry is flushed on content process shutdown r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 16 Aug 2016 12:41:00 +0700 - rev 407550
Push 27992 by bmo:rail@mozilla.com at Tue, 30 Aug 2016 16:51:23 +0000
bug 1218576 - Ensure remaining batched telemetry is flushed on content process shutdown r=gfritzsche On content process shutdown we send a content process ping to ensure we have up-to-date data from the content process before it goes away. Now we need to also flush the batched telemetry accumulations to the parent so that it can be present in the ping. No attempt is made to synchronize access to IPCTimerFired. It is safe to re-enter. No attempt is made to cancel the timer as its firing is benign. MozReview-Commit-ID: 1gjNH9IPhKf
283cee5fb8a77e2c5d5055874277310b17bf15ce: bug 1218576 - Assert we're the parent process when clearing histograms. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 16 Aug 2016 12:41:00 +0700 - rev 407549
Push 27992 by bmo:rail@mozilla.com at Tue, 30 Aug 2016 16:51:23 +0000
bug 1218576 - Assert we're the parent process when clearing histograms. r=gfritzsche Clear isn't generally called at all, and isn't dispatched to the parent process for child telemetry aggregation. Clear should only be called on the parent process. MozReview-Commit-ID: stIutvAO6h
0397f79f86ad40c340b126f893be837e4873ea41: bug 1218576 - Update test browser_use_counters.js to use aggregated child telemetry r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 16 Aug 2016 12:40:00 +0700 - rev 407548
Push 27992 by bmo:rail@mozilla.com at Tue, 30 Aug 2016 16:51:23 +0000
bug 1218576 - Update test browser_use_counters.js to use aggregated child telemetry r=gfritzsche waitOnCondition is used to wait for the telemetry batch to be processed (roughly every 2s). It resolves and rejects to the same value as there are a couple of xfail tests that need the wrong answer. MozReview-Commit-ID: I1JqEXQSL7d
59b0fb3fa328da507179fb448f4db1c2a0a6ac09: bug 1218576 - Update test_ChildHistograms for child telemetry aggregation r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 16 Aug 2016 12:40:00 +0700 - rev 407547
Push 27992 by bmo:rail@mozilla.com at Tue, 30 Aug 2016 16:51:23 +0000
bug 1218576 - Update test_ChildHistograms for child telemetry aggregation r=gfritzsche No more requestChildPayloads (or need for it). MozReview-Commit-ID: AmPuT04HjWx
2d375de6447779e8b88e6a4cb385d5ef1ce2cc30: bug 1218576 - Support remote accumulation via JS histograms. r=gfritzsche
Chris H-C <chutten@mozilla.com> - Fri, 19 Aug 2016 08:41:00 +0700 - rev 407546
Push 27992 by bmo:rail@mozilla.com at Tue, 30 Aug 2016 16:51:23 +0000
bug 1218576 - Support remote accumulation via JS histograms. r=gfritzsche The JS histograms, too, need to dispatch their accumulations from child to parent. JSHistograms_Add now only supports histograms that are in gHistogramsMap or that were created in the parent process. After bug 1288745, maybe we'll be able to change this to be less convoluted. MozReview-Commit-ID: 3qTH89YKbGP
6e4a7610406a330d941bfd2a1d366f8e17c7eac6: bug 1218576 - Move aggregated child telemetry to processes.content r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 16 Aug 2016 12:39:00 +0700 - rev 407545
Push 27992 by bmo:rail@mozilla.com at Tue, 30 Aug 2016 16:51:23 +0000
bug 1218576 - Move aggregated child telemetry to processes.content r=gfritzsche Take the opportunity presented through changing child telemetry accumulation to bring the ping form closer to the ideas expressed in bug 1281795. childPayloads still exists, but without histograms or keyedHistograms which are now at root.processes.content.{keyedH|h}istograms. This will require coordinated changes in the aggregator and moztelemetry libraries. MozReview-Commit-ID: AqG2jmBBC2W
cd80494752245b67d2e37f163e902b570b7ac40c: bug 1218576 - Remove requestChildPayloads r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 16 Aug 2016 12:39:00 +0700 - rev 407544
Push 27992 by bmo:rail@mozilla.com at Tue, 30 Aug 2016 16:51:23 +0000
bug 1218576 - Remove requestChildPayloads r=gfritzsche To simplify using child telemetry from the parent process, only allow child telemetry payloads to be generated once per child process, on shut down. This will allow us to use the child telemetry's subsession information to leave childPayloads the way it currently is. Will need to update test_ChildHistograms.js as it is the only consumer. MozReview-Commit-ID: 2qSztg0QHV5
2310da8e494211c513b8db014bafc36bec03f1f2: bug 1218576 - Pre-allocate child keyed histograms in the parent process r=gfritzsche
Chris H-C <chutten@mozilla.com> - Tue, 16 Aug 2016 12:38:00 +0700 - rev 407543
Push 27992 by bmo:rail@mozilla.com at Tue, 30 Aug 2016 16:51:23 +0000
bug 1218576 - Pre-allocate child keyed histograms in the parent process r=gfritzsche I originally thought we'd be able to avoid the previous implementation's waste of a map full of every kind of keyed histogram. Unfortunately, other code (TelemetrySession at the very least) depends on this (and will throw if a keyed histogram isn't present, even if it is empty) MozReview-Commit-ID: 8MCGVa595UB
7537a79e91a4880bf1dd17cdede0a672b167846a: bug 1218577 - Support subsession hgrams for child aggregation r=gfritzsche
Chris H-C <chutten@mozilla.com> - Mon, 22 Aug 2016 12:26:00 +0700 - rev 407542
Push 27992 by bmo:rail@mozilla.com at Tue, 30 Aug 2016 16:51:23 +0000
bug 1218577 - Support subsession hgrams for child aggregation r=gfritzsche The original commit didn't properly support subsession histograms, so rectify that lapse by adding support for stripping out the base name of a histogram when trying to determine its id. MozReview-Commit-ID: LvUek6f5WUx
74b9b3f4ce25cc4fb26fbf102aae04829ada3403: bug 1218576 - Accumulate child histograms in the parent process r=froydnj
Chris H-C <chutten@mozilla.com> - Tue, 23 Aug 2016 08:35:00 +0700 - rev 407541
Push 27992 by bmo:rail@mozilla.com at Tue, 30 Aug 2016 16:51:23 +0000
bug 1218576 - Accumulate child histograms in the parent process r=froydnj Batch the accumulations to only transmit every so often, so we don't incur too much in the way of IPC overhead penalties. What this doesn't do: * remove or restructure child telemetry code to adapt to the new way * send the telemetry anywhere * allow for the child process to clear child histograms * support anything but histograms (but this is expected and okay) MozReview-Commit-ID: JnUkcmN3Ya7
d349c7c048450b18367682154d74dc5acc1da0a4: Bug 1290548 - Unbranded add-on developer builds are updating to branded Firefox builds r=jlund DONTBUILD
Kim Moir <kmoir@mozilla.com> - Tue, 30 Aug 2016 08:20:08 -0400 - rev 407540
Push 27992 by bmo:rail@mozilla.com at Tue, 30 Aug 2016 16:51:23 +0000
Bug 1290548 - Unbranded add-on developer builds are updating to branded Firefox builds r=jlund DONTBUILD
bfa7a5faf3b3fa940287745f65cedbb3a551c358: Backed out changeset a8ff54e28b15 (bug 1088300) for unused variable error in SingleTiledContentClient.h. r=backout on a CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Tue, 30 Aug 2016 14:06:14 +0200 - rev 407539
Push 27992 by bmo:rail@mozilla.com at Tue, 30 Aug 2016 16:51:23 +0000
Backed out changeset a8ff54e28b15 (bug 1088300) for unused variable error in SingleTiledContentClient.h. r=backout on a CLOSED TREE
b6211770c5dda33f7b503336b00815a676822a01: Backed out changeset 1ec40ecc63f8 (bug 1088300)
Sebastian Hengst <archaeopteryx@coole-files.de> - Tue, 30 Aug 2016 14:05:23 +0200 - rev 407538
Push 27992 by bmo:rail@mozilla.com at Tue, 30 Aug 2016 16:51:23 +0000
Backed out changeset 1ec40ecc63f8 (bug 1088300)
1ec40ecc63f835c2f1347daeb3759fd95e5f8592: Bug 1088300 - Null-check TileClient::mAllocator. r=milan
Nicolas Silva <nsilva@mozilla.com> - Tue, 30 Aug 2016 13:48:29 +0200 - rev 407537
Push 27992 by bmo:rail@mozilla.com at Tue, 30 Aug 2016 16:51:23 +0000
Bug 1088300 - Null-check TileClient::mAllocator. r=milan
a8ff54e28b156458a93d51152c7adb40f97aa227: Bug 1088300 - Remove mCompositableClient from TileClient, pass the compositable and layer by reference to remove the possibility of unexpectedly storing null pointers. r=milan
Nicolas Silva <nsilva@mozilla.com> - Tue, 30 Aug 2016 13:48:20 +0200 - rev 407536
Push 27992 by bmo:rail@mozilla.com at Tue, 30 Aug 2016 16:51:23 +0000
Bug 1088300 - Remove mCompositableClient from TileClient, pass the compositable and layer by reference to remove the possibility of unexpectedly storing null pointers. r=milan
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip