3c3be02271337ec3d23c4515f2aa7041c8ee4c09: Bug 1335306 Append active keyboard layout information into crash report when NativeKey crashes due to detecting impossible case caused by 3rd party's keyboard layout or utils r=m_kato a=jcristau
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 31 Jan 2017 23:23:06 +0900 - rev 482611
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1335306 Append active keyboard layout information into crash report when NativeKey crashes due to detecting impossible case caused by 3rd party's keyboard layout or utils r=m_kato a=jcristau When NativeKey crashes by itself, it means that we detect an impossible situation in usual environment. In such case, active 3rd party's keyboard layout or something other utility may hook API and returns odd result to us. For investigating the cause and deciding what we should do in such cases, we should collect active keyboard layout name via crash reports. MozReview-Commit-ID: HYRj24GwDHZ
a4e9d4072936261641774d5b135f12a4b1b23db5: Bug 1334314 - Fix debug mode OSR exception handling for IteratorClose trynotes. r=jandem a=lizzard
Shu-yu Guo <shu@rfrn.org> - Mon, 30 Jan 2017 13:36:43 -0800 - rev 482610
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1334314 - Fix debug mode OSR exception handling for IteratorClose trynotes. r=jandem a=lizzard
04285da3f4044e85ab25544ffe5d7f00be4a9a27: Bug 1334102 - If the uploadRect is empty post-transform abort the function. The graphics driver may try to read from the given address even though it's told width or height are empty. r=milan a=jcristau
Bas Schouten <bschouten@mozilla.com> - Tue, 31 Jan 2017 14:01:50 +0000 - rev 482609
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1334102 - If the uploadRect is empty post-transform abort the function. The graphics driver may try to read from the given address even though it's told width or height are empty. r=milan a=jcristau MozReview-Commit-ID: DxNOzU0SNHK
7b67691e8a2efd7e78dbeb3a3befde298f749b8d: Bug 1333734 - fix chrome password import if it contains items we can't read as a URI, r=mak a=jcristau
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 30 Jan 2017 10:51:21 +0100 - rev 482608
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1333734 - fix chrome password import if it contains items we can't read as a URI, r=mak a=jcristau MozReview-Commit-ID: CAwIVNz70hs
8da1a1906fe681f4d263277587eb23fe7514a655: Bug 1333567 - Send the notification expected by the session store when restarting, too. r=sebastian, a=jcristau
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 25 Jan 2017 20:31:30 +0100 - rev 482607
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1333567 - Send the notification expected by the session store when restarting, too. r=sebastian, a=jcristau Since bug 1228593, the mobile session store - once again flushes its data when we are quitting, to make sure the latest state (including any potential cleaning of history/tabs) is flushed to disk - ignores windows/tabs closing as a byproduct of shutdown The latter point is dependent on a new shutdown notification introduced in that bug. Because we forgot to add that notification to the restart code used for add-on updates, in that case the session store currently doesn't enter shutdown mode and therefore records the window being closed during shutdown before flushing its data to disk, which means that all open tabs are lost. MozReview-Commit-ID: LgtdQoYwacM
6666c83998afcafe9b3657c29588daaaf64f1980: Bug 1333514 - fix race between PDocAccessibleConstructor messages and PBrowser::Destroy messages r=billm, a=lizzard
Trevor Saunders <tbsaunde@tbsaunde.org> - Wed, 25 Jan 2017 16:44:09 -0500 - rev 482606
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1333514 - fix race between PDocAccessibleConstructor messages and PBrowser::Destroy messages r=billm, a=lizzard
49268ecb72fbc8daf6d28e9be88fa5c4a55c2223: Bug 1333285 - Add null check to nsHttpPipeline::OnHeadersAvailable() r=mcmanus a=lizzard
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 30 Jan 2017 13:15:34 +0100 - rev 482605
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1333285 - Add null check to nsHttpPipeline::OnHeadersAvailable() r=mcmanus a=lizzard MozReview-Commit-ID: 9vvpEIUtDkv
f80dc144cdd03a4999b4c527d13538316eb19fdc: Bug 1333112 - Fix windowClient.Navigate leak. r=bkelly a=jcristau
Catalin Badea <catalin.badea392@gmail.com> - Thu, 26 Jan 2017 21:37:17 +0200 - rev 482604
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1333112 - Fix windowClient.Navigate leak. r=bkelly a=jcristau
4d570c752fc9249899dac5a9ae98cc35e4061084: Bug 1333084 - Add WebAuthn to test_interfaces r=bz a=lizzard
J.C. Jones <jjones@mozilla.com> - Mon, 23 Jan 2017 09:20:56 -0700 - rev 482603
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1333084 - Add WebAuthn to test_interfaces r=bz a=lizzard Should have happened in Bug 1309284 but was missed since test_interfaces' scheme wasn't https. Update: Disable all WebAuthn webidl interfaces. MozReview-Commit-ID: CSeGLoIGKvf
fcb2593e3808492dcf2e0dc3519ef31796ae128d: Bug 1332952 - Implement GetAsSourceSurface() for SharedRGBImage. r=mattwoodrow a=lizzard
karo <kkoorts@mozilla.com> - Mon, 23 Jan 2017 11:06:17 +1300 - rev 482602
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1332952 - Implement GetAsSourceSurface() for SharedRGBImage. r=mattwoodrow a=lizzard MozReview-Commit-ID: E9zl5FchvZG
18731e46b2eae085d2a665713acb2d3b03d6b097: Bug 1332307 - Add GPUVideoTextureHost::Unlock() r=nical a=lizzard
Sotaro Ikeda <sotaro.ikeda.g@gmail.com> - Mon, 23 Jan 2017 12:34:59 -0800 - rev 482601
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1332307 - Add GPUVideoTextureHost::Unlock() r=nical a=lizzard
fee1e9a5de81307c6f059008afd608a9b0a0e976: Bug 1332165 - Trim values for the purposes of 'skipEmptyFields' in _getPasswordFields. r=Dolske a=jcristau
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 23 Jan 2017 23:31:34 -0800 - rev 482600
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1332165 - Trim values for the purposes of 'skipEmptyFields' in _getPasswordFields. r=Dolske a=jcristau We will no longer prompt to save passwords consisting solely of whitespace. MozReview-Commit-ID: FknB39TCHEa
f851b8e0286b680d8f792d023369e32887d8260c: Bug 1331579 - Explicitly update the identity block on re-requesting expired permissions. r=Paolo a=jcristau
Johann Hofmann <jhofmann@mozilla.com> - Mon, 23 Jan 2017 11:44:03 +0100 - rev 482599
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1331579 - Explicitly update the identity block on re-requesting expired permissions. r=Paolo a=jcristau MozReview-Commit-ID: CxvHSp1NjFg
c76aa324c7c2b57ce42a8b26c48778782b41be76: Bug 1328053 - Correct thumb position when shift-click scrolling r=mats a=jcristau
Kearwood Gilbert <kgilbert@mozilla.com> - Wed, 25 Jan 2017 14:45:23 -0800 - rev 482598
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1328053 - Correct thumb position when shift-click scrolling r=mats a=jcristau During the refactoring of nsSliderFrame::SetCurrentPositionInternal in Bug 957445, one of the two calls to nsSliderFrame::UpdateAttribute was missed. This resulted in the position, identified with nsGkAtoms::curpos, not being updated immediately after the call to nsSliderFrame::SetCurrentThumbPosition MozReview-Commit-ID: 6gedouG4OFX
46497fa848f7b678b5d1bbfd28ed8d1828443b9b: Bug 1328023 - Part 2. Add test for undo. r=masayuki, a=jcristau
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 30 Jan 2017 17:27:26 +0900 - rev 482597
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1328023 - Part 2. Add test for undo. r=masayuki, a=jcristau MozReview-Commit-ID: 6ZuluRWrYxb
e235e56f062a8bb2bfec3ea17fa098ecd422b476: Bug 1328023 - Part 1. Don't use RangeUpdater except to composition transaction. r=masayuki, a=jcristau
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 30 Jan 2017 17:25:43 +0900 - rev 482596
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1328023 - Part 1. Don't use RangeUpdater except to composition transaction. r=masayuki, a=jcristau Part 3 fix of bug 1310912 is incorrect for not composition transaction. PlaceholderTransation is for saving and restoring current selection for undo. So we shouldn't use range updater to normal transaction. Composition transaction can modify multiple nodes and it merges text node for ime into single text node. So if current selection is into IME text node, it might be failed to restore selection by UndoTransaction. So we need update selection by range updater to work UndoTransaction. Also, CompositionTransaction::UndoTransaction will set selection after committed text. So at finally, selection will set correct position that composition transaction wants. MozReview-Commit-ID: 1NcH32YoKPQ
0e1d4619f4c6e18f9add95dce45a6969f7310a00: Bug 1327953 - Fix enabling the 'Restore Default Search Engines' button when removing a default engine, r=Standard8 a=jcristau
Florian Quèze <florian@queze.net> - Mon, 30 Jan 2017 08:10:00 +0100 - rev 482595
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1327953 - Fix enabling the 'Restore Default Search Engines' button when removing a default engine, r=Standard8 a=jcristau
a8eefd5c63efa9ed822399b161a702cdae2cf4f8: Bug 1327946 - Remove conditional moz-user-focus on identity block from urlbar. r=Gijs, a=lizzard
Johann Hofmann <jhofmann@mozilla.com> - Tue, 24 Jan 2017 11:42:09 +0100 - rev 482594
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1327946 - Remove conditional moz-user-focus on identity block from urlbar. r=Gijs, a=lizzard MozReview-Commit-ID: 9F39TeDIGUf
5ae7001fbd3f6441525f70a8c4c2db12c5ce5b00: Bug 1319660 - Fix possible crash when editing contentEditable; r=esawin r=masayuki r=smaug a=lizzard a=jcristau
Jim Chen <nchen@mozilla.com> - Mon, 23 Jan 2017 14:35:04 -0500 - rev 482593
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1319660 - Fix possible crash when editing contentEditable; r=esawin r=masayuki r=smaug a=lizzard a=jcristau Bug 1319660 - 1. Don't take shortcut if old replacement ranges don't match; r=esawin The block at [1] is a shortcut we take when we reconcile Java text changes with Gecko text changes. However, we only checked that the new ranges are the same, i.e. that the new Gecko text is the same as the new Java text. We should also be checking that the old ranges are the same, i.e. that the replaced Gecko text is the same as the replaced Java text. [1] https://dxr.mozilla.org/mozilla-central/rev/bbbd2f7539f224a482cc6d2dd10e6a5f31c8baf3/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoEditable.java#1233 Bug 1319660 - 2. Use previous node instead of sibling when adjusting last node; r=masayuki r=smaug nsContentIterator in pre mode adjusts its last node if the node is a childless node like <br>. However, right now it's using GetPrevSibling, which can lead to error in some edge cases such as: <p></p><div><br></div> In this case, if the last node is <br> with offset 0, GetPrevSibling will return <p> because <p> is <br>'s parent's previous sibling, and the last node will be set to <p>. However, the correct last node in this case is <div>, because <br> with offset 0 refers to the position to the left of <br>, which is <div> with offset 0. In this case, PrevNode returns the correct <div> value, so we should set the last node to the result of PrevNode. For the first node, for a childless node in pre mode, GetNextSibling and NextNode are the same, so there is no bug in this case. Nevertheless, this patch changes the call to NextNode to be consistent with calling PrevNode for the last node. Bug 1319660 - 3. Add test for correctly adjusting last node in content iterator; r=masayuki Add a test for the previous patch that makes sure querying selected text in an edge case works correctly. Bug 1319660 - 4. Add test for start node regression; r=me Add a new test case for the NextNode() regression. r=me for trivial test-only patch. Bug 1319660 - 5. Restore GetNextSibling call for first node of pre-content-iterator; r=smaug The last patch changed the `GetNextSibling()` call to `NextNode()` because I assumed they're equivalent in this case. That turned out to not be the case because we can reach this line even if the node has children -- the index just has to be after the last child. So this patch restores the `GetNextSibling` call to restore the correct behavior. I also added some comment to clarify that we can reach this line due to one of two conditions: 1) the node has no children; 2) the node has children but the index is after the last child. This patch also replaces the `HasChildren()` check when setting `cChild`. If the index is after the last child (i.e. index == childCount), `GetChildAt()` fails and we erroneously log an assertion warning, even though the input was valid. The new check handles all cases whether start node has children or not.
e388fdc06380d4689d5a914fa7708452cc223e8b: Bug 1315450 EditorEventListener::MouseClick() should check if mEditorBase is available before calling its ForceCompositionEnd() r=smaug, a=jcristau
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 30 Jan 2017 17:03:02 +0900 - rev 482592
Push 45112 by mchiang@mozilla.com at Mon, 13 Feb 2017 05:49:16 +0000
Bug 1315450 EditorEventListener::MouseClick() should check if mEditorBase is available before calling its ForceCompositionEnd() r=smaug, a=jcristau IMEStateManager::OnClickInEditor() may cause anything because it may set input context. For example, it may cause opening VKB, changing focus or reflow. So, mEditorBase here might have been gone. MozReview-Commit-ID: C0SVzb5SueS
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip