3c314aca75241b32a11365f5eb00442ed34d5768: Bug 1347712 - Add the tree-wide rules and config to the recommended eslint-plugin-mozilla config, to make it easier for outside projects. r?jaws draft
Mark Banner <standard8@mozilla.com> - Tue, 21 Mar 2017 15:40:33 +0100 - rev 502277
Push 50238 by mbanner@mozilla.com at Tue, 21 Mar 2017 15:39:18 +0000
Bug 1347712 - Add the tree-wide rules and config to the recommended eslint-plugin-mozilla config, to make it easier for outside projects. r?jaws MozReview-Commit-ID: 9ZzjSyu9rU7
f80dc6ef6d636da8036df6356520a9583095d66f: Bug 1347712 - Move toolkit/.eslintrc.js rules into a 'recommended' set within eslint-plugin-mozilla. r?jaws draft
Mark Banner <standard8@mozilla.com> - Tue, 21 Mar 2017 16:37:58 +0100 - rev 502276
Push 50238 by mbanner@mozilla.com at Tue, 21 Mar 2017 15:39:18 +0000
Bug 1347712 - Move toolkit/.eslintrc.js rules into a 'recommended' set within eslint-plugin-mozilla. r?jaws MozReview-Commit-ID: IwTLOLlUrVV
fb4e2a8b3015fb5bdddf5389b45c5dd92247c126: Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r?jaws draft
Mark Banner <standard8@mozilla.com> - Mon, 20 Mar 2017 12:36:37 +0100 - rev 502275
Push 50238 by mbanner@mozilla.com at Tue, 21 Mar 2017 15:39:18 +0000
Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r?jaws MozReview-Commit-ID: LH0CQOPfoe6
7586cee5ac274b2eaa08a5938044e95e0fcd4325: Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - structural changes. r?jaws draft
Mark Banner <standard8@mozilla.com> - Tue, 21 Mar 2017 16:37:25 +0100 - rev 502274
Push 50238 by mbanner@mozilla.com at Tue, 21 Mar 2017 15:39:18 +0000
Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - structural changes. r?jaws MozReview-Commit-ID: HmNYrVyNiMr
1c453d2c476eb8f756194e76b91a88677e4d0e98: Bug 1347894 convert uses of "defer" to "new Promise" in client/scratchpad directory r?tromey draft
Subhdeep Saha <subhdeepsaha@gmail.com> - Tue, 21 Mar 2017 21:06:49 +0530 - rev 502273
Push 50237 by bmo:subhdeepsaha@gmail.com at Tue, 21 Mar 2017 15:34:52 +0000
Bug 1347894 convert uses of "defer" to "new Promise" in client/scratchpad directory r?tromey MozReview-Commit-ID: CnCOTW6TJ1B
43ef6295699f14019a77a2e38247cb7da9e34f3b: Bug 1333114 - Refactor wpt TestRunner, r=Ms2ger draft
James Graham <james@hoppipolla.co.uk> - Mon, 30 Jan 2017 08:06:44 -0800 - rev 502272
Push 50236 by bmo:james@hoppipolla.co.uk at Tue, 21 Mar 2017 15:33:35 +0000
Bug 1333114 - Refactor wpt TestRunner, r=Ms2ger In order to support leak checking in web-platform-tests, we have to support restarting the browser before a test starts, which is complicated by the architecture of wptrunner that puts the TestRunner and associated Executor in a separate process. In the previous architecture the Executor process grabbed the test to run from the queue so it wasn't possible to restart the browser once the test was known without considerable difficulty. The primary goal of this refactor is to give the TestRunner access to the test before it is passed to the executor. However imlementing this was complicated by the poor structure of the existing code. To make things more comprehensible the TestRunner class is factored into a more explicit state machine, with a run() loop that either transitions the runner into the next state or waits for an external command which causes such a state transition. MozReview-Commit-ID: 7cvSkYlCSKe
07b102170222b7e2108cf1fbaa5b742f58ca491c: Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - structural changes. r?jaws draft
Mark Banner <standard8@mozilla.com> - Tue, 21 Mar 2017 16:26:09 +0100 - rev 502271
Push 50235 by mbanner@mozilla.com at Tue, 21 Mar 2017 15:32:07 +0000
Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - structural changes. r?jaws MozReview-Commit-ID: HmNYrVyNiMr
3f5f1ced0fbd84be67a980ead6e30356bddc98d3: Bug 1348564 - Part 3. Fix assertion in nsSVGIntegrationUtils::GetSVGBBoxForNonSVGFrame. draft
cku <cku@mozilla.com> - Tue, 21 Mar 2017 20:24:51 +0800 - rev 502270
Push 50234 by bmo:cku@mozilla.com at Tue, 21 Mar 2017 15:07:45 +0000
Bug 1348564 - Part 3. Fix assertion in nsSVGIntegrationUtils::GetSVGBBoxForNonSVGFrame. This issue exists even before we landed bug 1320036. nsSVGIntegrationUtils::GetSVGBBoxForNonSVGFrame is called under the following conditions: 1. (Before bug 1320036 landed) The target frame is not inherited from nsISVGChildFrame or is not an SVG frame. 2. (After bug 1320036 landed) The target frame is not inherited from nsISVGChildFrame or is not an SVG frame, except SVG-outer frame. So if you pass a nsGradientFrame object, which is not inherited from nsISVGChildFrame, to nsSVGUtils::GetBBox, this assertion always fails. MozReview-Commit-ID: IvQApquMPhp
0d29f60c6e744541bf61241bf263e8594d2fc8fc: Bug 1348564 - Part 2. Crash test. draft
cku <cku@mozilla.com> - Tue, 21 Mar 2017 18:27:28 +0800 - rev 502269
Push 50234 by bmo:cku@mozilla.com at Tue, 21 Mar 2017 15:07:45 +0000
Bug 1348564 - Part 2. Crash test. MozReview-Commit-ID: 6u7vqwFHynP
c1712e4af75240c9408685909204e0dbbf546b93: Bug 1348617 - Use the alpha channel of custom styled select backgrounds by applying the requested color on top of the system's background. r?mossop draft
Jared Wein <jwein@mozilla.com> - Tue, 21 Mar 2017 10:51:40 -0400 - rev 502268
Push 50233 by jwein@mozilla.com at Tue, 21 Mar 2017 14:53:45 +0000
Bug 1348617 - Use the alpha channel of custom styled select backgrounds by applying the requested color on top of the system's background. r?mossop This matches parity with Google Chrome Canary Version 59.0.3046.0 (Official Build) canary (64-bit). MozReview-Commit-ID: 3rkhiFv8ezX
91557797eee41bd91b2b4b95e109949a455ab345: Bug 1347711 - Refactor error reporting out of TokenStream;r?shu draft
David Teller <dteller@mozilla.com> - Mon, 20 Mar 2017 16:22:19 +0100 - rev 502267
Push 50232 by dteller@mozilla.com at Tue, 21 Mar 2017 14:44:52 +0000
Bug 1347711 - Refactor error reporting out of TokenStream;r?shu Prior to a large refactoring/templatization on TokenStream, let's get error reporting out of the way. MozReview-Commit-ID: 9fMWfOhRHSL
ac10417bad42204a2943be4673619ba9b8244810: Bug 1349187 - Ensure the Rollup implementations clear the out-pointer even upon returning false. r?enndeakin draft
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 21 Mar 2017 10:32:56 -0400 - rev 502266
Push 50231 by kgupta@mozilla.com at Tue, 21 Mar 2017 14:33:29 +0000
Bug 1349187 - Ensure the Rollup implementations clear the out-pointer even upon returning false. r?enndeakin This ensures that the pointer is always either null or a valid nsIContent after the call to Rollup returns, and avoids potentially leaving it as garbage. An alternative approach would be to make the call sites responsible for ensuring it is set to nullptr if the function returns false, but this seems safer. MozReview-Commit-ID: BXxPBgs6MZL
3e95473c4f504997615f3ed6b169190981add2f3: Bug 1301385 - input type='search' subrole on OS X is wrong; r?surkov draft
Federico Padua <federico_padua@yahoo.it> - Tue, 21 Mar 2017 15:32:14 +0100 - rev 502265
Push 50230 by bmo:federico_padua@yahoo.it at Tue, 21 Mar 2017 14:33:04 +0000
Bug 1301385 - input type='search' subrole on OS X is wrong; r?surkov This patch makes Accessible::IsSearchbox() check for nsGkAtoms::search value instead of nsGkAtoms::textInputType as noted in the bug description. MozReview-Commit-ID: DSNrNwUwREa
4e6325541a87240cf089f0b869561bfe5152ff09: Bug 1342928 - Keep the commands / buttons state in sync; r=jwalker draft
Matteo Ferretti <mferretti@mozilla.com> - Mon, 20 Mar 2017 14:54:03 +0100 - rev 502264
Push 50229 by bmo:zer0@mozilla.com at Tue, 21 Mar 2017 14:22:07 +0000
Bug 1342928 - Keep the commands / buttons state in sync; r=jwalker This was a regression given by bug 1320149; in order to keep the performance gain I created a lightweight object (`CommandState`) that is required from both gcli's command and toolbox so that the last one doesn't need to be strong coupled with the first one. MozReview-Commit-ID: 3NcTt6i4ezx
bd7af7e530068aeebf1c357bfed8e8d4c43e2d05: Bug 1302054 - Part 3: Remove mention of nsChangeHint_Hints_NotHandledForDescendants in RestyleManager::ChangeHintToString. r=dbaron
Cameron McCormack <cam@mcc.id.au> - Tue, 21 Mar 2017 16:33:05 +0800 - rev 502263
Push 50229 by bmo:zer0@mozilla.com at Tue, 21 Mar 2017 14:22:07 +0000
Bug 1302054 - Part 3: Remove mention of nsChangeHint_Hints_NotHandledForDescendants in RestyleManager::ChangeHintToString. r=dbaron MozReview-Commit-ID: K21VDcNd9Oy
a60081798b342f5d18128648ea1578fdf98e5757: Bug 1302054 - Part 2: Remove no longer useful nsStyleContext::CalcDifference optimization that handles the same-rule-node case. r=dbaron
Cameron McCormack <cam@mcc.id.au> - Tue, 21 Mar 2017 16:33:05 +0800 - rev 502262
Push 50229 by bmo:zer0@mozilla.com at Tue, 21 Mar 2017 14:22:07 +0000
Bug 1302054 - Part 2: Remove no longer useful nsStyleContext::CalcDifference optimization that handles the same-rule-node case. r=dbaron nsStyleContext::CalcDifference had an optimization where, when we knew that the old and new style context have the same rule node, we knew that the only change hints that would need to be handled are those in the "not handled for descendants" category, generated due to explicit 'inherit' values on reset properties. This was because any changes due to differences in inherited properties should only have generated "handled for descendants" change hints (and thus would already have been handled on an ancestor). Before bug 931668, this let us avoid calling CalcDifference on structs that only would have generated hints that we knew we already would have handled. However, after bug 931668, we compare all structs anyway so that we can set the aEqualStructs outparam, so we don't gain anything from this optimization. We can still return these change hints we know will not need to be handled, and rely on ElementRestyler::CaptureChange to filter them out. MozReview-Commit-ID: Ld1s2Js0i6r
6a196410f140cb1186508f9c218ff8f9651505e9: Bug 1302054 - Part 1: Avoid computing style differences when we just want to ensure structs are cached on the new context. r=dbaron
Cameron McCormack <cam@mcc.id.au> - Tue, 21 Mar 2017 16:33:05 +0800 - rev 502261
Push 50229 by bmo:zer0@mozilla.com at Tue, 21 Mar 2017 14:22:07 +0000
Bug 1302054 - Part 1: Avoid computing style differences when we just want to ensure structs are cached on the new context. r=dbaron MozReview-Commit-ID: DLhHcCD4GQS
70914315e02b97090945edfe996b7c8604c55d00: Bug 1301258 - Part 2: Remove all subsumed hints when generating changes from restyles. r=dbaron
Cameron McCormack <cam@mcc.id.au> - Tue, 21 Mar 2017 16:33:05 +0800 - rev 502260
Push 50229 by bmo:zer0@mozilla.com at Tue, 21 Mar 2017 14:22:07 +0000
Bug 1301258 - Part 2: Remove all subsumed hints when generating changes from restyles. r=dbaron This changes ElementRestyler::CaptureChange so that it avoids generating the current frame's entire set of change hints, if only some of the hints were handled by ancestors, and instead to remove the hints that we know are subsumed. MozReview-Commit-ID: JvhxeQC6MmQ
3fa7dc151849b50e6a9478ad29cb3665289fb3b2: Bug 1301258 - Part 1.5: Tweak some comments around change hints. r=dbaron
Cameron McCormack <cam@mcc.id.au> - Tue, 21 Mar 2017 16:33:05 +0800 - rev 502259
Push 50229 by bmo:zer0@mozilla.com at Tue, 21 Mar 2017 14:22:07 +0000
Bug 1301258 - Part 1.5: Tweak some comments around change hints. r=dbaron MozReview-Commit-ID: Gze6SFaXvSA
22e3e7b047903ae1c9b47d9aeb3206e417ef66c0: Bug 1301258 - Part 1: Define macros for change hints always, never and sometimes handled for descendants. r=dbaron
Cameron McCormack <cam@mcc.id.au> - Tue, 21 Mar 2017 16:33:05 +0800 - rev 502258
Push 50229 by bmo:zer0@mozilla.com at Tue, 21 Mar 2017 14:22:07 +0000
Bug 1301258 - Part 1: Define macros for change hints always, never and sometimes handled for descendants. r=dbaron MozReview-Commit-ID: 1lOl7U6rlC5
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip