3c256721c4f0dd24368c522c8e7f015c4a672935: Bug 1338848 - Skip browser_newtab_bug725996.js for mac/win debug. r?jmaher
draft
Ed Lee <edilee@mozilla.com> - Wed, 23 Aug 2017 13:48:46 -0700 - rev 651533
Push
75760 by bmo:edilee@mozilla.com at Wed, 23 Aug 2017 20:50:53 +0000
Bug 1338848 - Skip browser_newtab_bug725996.js for mac/win debug. r?jmaher
MozReview-Commit-ID: 6i2x1FAdBwk
d82c8757e42e09da0eb2c29f77bc693bdeea86e5: Bug 1393216 Disable unknown pragma warnings when compiling for Windows with gcc r?froydnj
draft
Tom Ritter <tom@mozilla.com> - Wed, 23 Aug 2017 15:48:41 -0500 - rev 651532
Push
75759 by bmo:tom@mozilla.com at Wed, 23 Aug 2017 20:48:56 +0000
Bug 1393216 Disable unknown pragma warnings when compiling for Windows with gcc r?froydnj
MozReview-Commit-ID: 6cZ96xe4h8C
481e609513de96c8f759666e32b70d89e9879fbb: Try disabling warnings as errors
draft
Tom Ritter <tom@mozilla.com> - Wed, 23 Aug 2017 12:55:23 -0500 - rev 651531
Push
75759 by bmo:tom@mozilla.com at Wed, 23 Aug 2017 20:48:56 +0000
Try disabling warnings as errors
MozReview-Commit-ID: BvrMazmzNDH
76341519de5c370da036df164fd7f1db1cf8cd76: Bug 1393196 Some illustrative examples of gfx/ signed/unsigned comparisons
draft
Tom Ritter <tom@mozilla.com> - Wed, 23 Aug 2017 15:07:32 -0500 - rev 651530
Push
75759 by bmo:tom@mozilla.com at Wed, 23 Aug 2017 20:48:56 +0000
Bug 1393196 Some illustrative examples of gfx/ signed/unsigned comparisons
MozReview-Commit-ID: 3JAolFMhZ9N
9dc40ca0105e10d38d88b01db13c93024ec16bb1: Temporary fix for some warnings I need to investigate more
draft
Tom Ritter <tom@mozilla.com> - Wed, 23 Aug 2017 15:07:19 -0500 - rev 651529
Push
75759 by bmo:tom@mozilla.com at Wed, 23 Aug 2017 20:48:56 +0000
Temporary fix for some warnings I need to investigate more
MozReview-Commit-ID: 8kFGo8itvZz
b14686f6f34e6d9eb72ab2170a3d880f3c98ba64: Silence unused function warnings
draft
Tom Ritter <tom@mozilla.com> - Tue, 22 Aug 2017 23:57:21 -0500 - rev 651528
Push
75759 by bmo:tom@mozilla.com at Wed, 23 Aug 2017 20:48:56 +0000
Silence unused function warnings
MozReview-Commit-ID: JHqMbncwFuq
60af2e7b6144e539c8116ad69295257a881d368a: Silence warnings about enumeration value 'X' not handled in switch
draft
Tom Ritter <tom@mozilla.com> - Tue, 22 Aug 2017 23:47:17 -0500 - rev 651527
Push
75759 by bmo:tom@mozilla.com at Wed, 23 Aug 2017 20:48:56 +0000
Silence warnings about enumeration value 'X' not handled in switch
MozReview-Commit-ID: 2GvDiGCKz7F
3537a835330b88f4f2672d8272553abde2658b03: Bypass an error until I can investigate more
draft
Tom Ritter <tom@mozilla.com> - Tue, 22 Aug 2017 23:24:12 -0500 - rev 651526
Push
75759 by bmo:tom@mozilla.com at Wed, 23 Aug 2017 20:48:56 +0000
Bypass an error until I can investigate more
/home/worker/workspace/build/src/mozglue/build/WindowsDllBlocklist.cpp:816:1: error: 'noreturn' function does return [-Werror]
MozReview-Commit-ID: SYgPDW0sMV
de1961e37c73ccdaeb1750e6de9ce4c3bfe866dd: Fix a signedness comparison warning in WindowsDllBlocklist.cpp
draft
Tom Ritter <tom@mozilla.com> - Tue, 22 Aug 2017 23:21:22 -0500 - rev 651525
Push
75759 by bmo:tom@mozilla.com at Wed, 23 Aug 2017 20:48:56 +0000
Fix a signedness comparison warning in WindowsDllBlocklist.cpp
MozReview-Commit-ID: 3qH0PU2gBur
95390568842285941f3524dfc628cd0423e94194: Silence unknown pragmas for WindowsDllBlocklist.cpp
draft
Tom Ritter <tom@mozilla.com> - Tue, 22 Aug 2017 23:20:16 -0500 - rev 651524
Push
75759 by bmo:tom@mozilla.com at Wed, 23 Aug 2017 20:48:56 +0000
Silence unknown pragmas for WindowsDllBlocklist.cpp
MozReview-Commit-ID: HyK8Mgs2Aka
76a791152e0b87f61c838fc8adf8de772fd249be: Silence unused function warning
draft
Tom Ritter <tom@mozilla.com> - Tue, 22 Aug 2017 23:18:36 -0500 - rev 651523
Push
75759 by bmo:tom@mozilla.com at Wed, 23 Aug 2017 20:48:56 +0000
Silence unused function warning
gfx/2d/HelpersWinFonts.h:53:1: error: 'mozilla::gfx::AntialiasMode mozilla::gfx::GetSystemDefaultAAMode()' defined but not used [-Werror=unused-function]
MozReview-Commit-ID: 5SaaYzOk2F1
0a6a33cf653b93186f7dd028ee29c16f5dedb77e: Cast to HRESULT
draft
Tom Ritter <tom@mozilla.com> - Tue, 22 Aug 2017 22:56:17 -0500 - rev 651522
Push
75759 by bmo:tom@mozilla.com at Wed, 23 Aug 2017 20:48:56 +0000
Cast to HRESULT
MozReview-Commit-ID: Fc01RHPqCbg
e0b25871bbd496f225336c450bcfce7822736f01: Silence overloaded-virtual warnings-as-errors
draft
Tom Ritter <tom@mozilla.com> - Tue, 22 Aug 2017 18:12:59 -0500 - rev 651521
Push
75759 by bmo:tom@mozilla.com at Wed, 23 Aug 2017 20:48:56 +0000
Silence overloaded-virtual warnings-as-errors
MozReview-Commit-ID: GoSg3nrVmsk
f1ad54830e870f179454049e402784ceeb83b487: Bug 1393201 Signed/Unsigned comparison warning in nsMIMEInfoWin.cpp - Find returns an int, not a unit
draft
Tom Ritter <tom@mozilla.com> - Tue, 22 Aug 2017 16:59:31 -0500 - rev 651520
Push
75759 by bmo:tom@mozilla.com at Wed, 23 Aug 2017 20:48:56 +0000
Bug 1393201 Signed/Unsigned comparison warning in nsMIMEInfoWin.cpp - Find returns an int, not a unit
MozReview-Commit-ID: 3qxIGFPkPXW
534d95a0b08b536865e5ee1b6ff76503f77d777f: Bug 1392688 Make variable DebugOnly to silence warning about it being unused
draft
Tom Ritter <tom@mozilla.com> - Tue, 22 Aug 2017 12:41:24 -0500 - rev 651519
Push
75759 by bmo:tom@mozilla.com at Wed, 23 Aug 2017 20:48:56 +0000
Bug 1392688 Make variable DebugOnly to silence warning about it being unused
MozReview-Commit-ID: 7wSkP2Lcd0W
50ee6754950fd0b9141d54c5260f861024fc7b21: Bug 1392684 Remove const qualifier that gets discarded after function return in mscom::AgileReference
draft
Tom Ritter <tom@mozilla.com> - Tue, 22 Aug 2017 17:25:27 -0500 - rev 651518
Push
75759 by bmo:tom@mozilla.com at Wed, 23 Aug 2017 20:48:56 +0000
Bug 1392684 Remove const qualifier that gets discarded after function return in mscom::AgileReference
gcc throws a warning-as-error saying that the const qualifier will be ignored by function callers.
Remove the const qualifier to remove the warning.
MozReview-Commit-ID: JRQMz6Zdcdz
6a004bb45a1d88d8f0c028a5304042a31eca52d3: Bug 1390356 - review: getMetadataSlow -> getImageUrl in Item interface. r=mcomella
draft
Michael Comella <michael.l.comella@gmail.com> - Wed, 23 Aug 2017 13:43:59 -0700 - rev 651517
Push
75758 by michael.l.comella@gmail.com at Wed, 23 Aug 2017 20:44:41 +0000
Bug 1390356 - review: getMetadataSlow -> getImageUrl in Item interface. r=mcomella
MozReview-Commit-ID: 8pFmBQf4fzp
2714873c2c22173dbc54ecffb8aa35e80bf1210f: Bug 1388574 - Use the correct pref to gate the Application Reputation lists. r?hchang
draft
Francois Marier <francois@mozilla.com> - Wed, 23 Aug 2017 13:40:50 -0700 - rev 651516
Push
75757 by fmarier@mozilla.com at Wed, 23 Aug 2017 20:41:16 +0000
Bug 1388574 - Use the correct pref to gate the Application Reputation lists. r?hchang
MozReview-Commit-ID: 1ZuxnbgsOMX
25602f90c48eac484191123a1d891f6bfe878b28: Bug 1393212 Resolve signed/unsigned comparison warnings in ipc/chromium via casting
draft
Tom Ritter <tom@mozilla.com> - Wed, 23 Aug 2017 15:38:48 -0500 - rev 651515
Push
75756 by bmo:tom@mozilla.com at Wed, 23 Aug 2017 20:40:11 +0000
Bug 1393212 Resolve signed/unsigned comparison warnings in ipc/chromium via casting
Many of these are caused by TLS_OUT_OF_INDEXES. It is a DWORD according to
microsoft, which is an unsigned int. We treat it as a long.
MozReview-Commit-ID: DCkWSO1YBIP
a6fdac3ca8ec9a812a23df1026eb9c157e65bbed: Bug 1393212 Ignore unknown pragmas and unused variables and functions in ipc/chromium in MinGW build
draft
Tom Ritter <tom@mozilla.com> - Wed, 23 Aug 2017 15:37:40 -0500 - rev 651514
Push
75756 by bmo:tom@mozilla.com at Wed, 23 Aug 2017 20:40:11 +0000
Bug 1393212 Ignore unknown pragmas and unused variables and functions in ipc/chromium in MinGW build
MozReview-Commit-ID: BBYo8H26uSe