3bf765ad6bc6d21e36aff2f5bcfc7968d62825c2: Bug 1256024 - Disable C4838 to unblock compilation on VS2015; r?aklotz draft
Gregory Szorc <gps@mozilla.com> - Mon, 14 Mar 2016 15:21:09 -0700 - rev 340036
Push 12889 by gszorc@mozilla.com at Mon, 14 Mar 2016 22:21:24 +0000
Bug 1256024 - Disable C4838 to unblock compilation on VS2015; r?aklotz As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully this patch never lands because someone insists of fixing the underlying problem instead. But if it does land, hopefully the workaround is only temporary. MozReview-Commit-ID: Gcq3Qna02iB
038c2fe02074d03a6c34d44f68cb5f078a2472cc: Bug 1092004 - Use getdtablesize for non-gonk builds as well. r=glandium draft
Nathan Toone <nathan@toonetown.com> - Mon, 14 Mar 2016 16:19:12 -0600 - rev 340035
Push 12888 by nathan@toonetown.com at Mon, 14 Mar 2016 22:20:15 +0000
Bug 1092004 - Use getdtablesize for non-gonk builds as well. r=glandium When building non-gonk builds, ANDROID_VERSION is not set. Beginning with NDK 11, getdtablesize is no longer included. This means that we should use the stub version of the function that is defined in android_stub.h for all android platforms. This patch moves the function out of the "#if ANDROID_VERSION >=21" block so that all android code can use it. Adding glandium as the reviewer, because he reviewed the original patch at bug 1103816. MozReview-Commit-ID: 2NmUl5XuvDS
62d93df1226482ed0a284ad22359dc48d8b47600: Bug 1256464 - Disable C4477 to unblock compilation on VS2015; r?froydnj draft
Gregory Szorc <gps@mozilla.com> - Mon, 14 Mar 2016 15:14:57 -0700 - rev 340034
Push 12887 by gszorc@mozilla.com at Mon, 14 Mar 2016 22:15:17 +0000
Bug 1256464 - Disable C4477 to unblock compilation on VS2015; r?froydnj As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully this patch never lands because someone insists of fixing the underlying problem instead. But if it does land, hopefully the workaround is only temporary. MozReview-Commit-ID: 9Dc5eeXw52R
01fa28d57f53278f8af1a24150ab11daf21440f6: Bug 1186060 - Build with Visual Studio 2015 Update 1; r?ted, ehsan draft
Gregory Szorc <gps@mozilla.com> - Thu, 10 Mar 2016 21:13:20 -0800 - rev 340033
Push 12887 by gszorc@mozilla.com at Mon, 14 Mar 2016 22:15:17 +0000
Bug 1186060 - Build with Visual Studio 2015 Update 1; r?ted, ehsan This commit switches Windows builds from Visual Studio 2013 to Visual Studio 2015 Update 1. Previously, Visual Studio was installed on the builers as part of the base system image. Starting with this commit, we obtain Visual Studio from a pre-generated, self-contained archive containing the executables, Windows SDK, and other support files. This means that new Windows toolchains can be installed without having to modify configuration of machines in automation! The mozconfigs for Visual Studio 2015 are a bit different from existing mozconfigs. Because it appears to be completely redundant and not necessary, the LIBPATH variable has been dropped. The order of paths in PATH, LIB, and INCLUDE has changed. The new order more accurately reflects what would be defined by vcvarsall.bat. As part of switching to Visual Studio 2015, the Universal CRT is now required. So, the 2015 mozconfigs export WIN_UCRT_REDIST_DIR to define the location to those files. The switch to Visual Studio 2015 also involves the switch from the Windows 8.1 SDK to the Windows 10 SDK. However, we still target an old version of Windows, so this hopefully shouldn't have any significant fallout. It's worth noting that switching to Visual Studio 2015 makes builds - especially PGO builds - significantly faster. Our PGO build times in automation are ~1 hour faster. Our regular builds appear to be a few minutes faster. MozReview-Commit-ID: Pa5GW8V87Q
74585a90d492bba3fbdef725bf7c7d57707cd5c5: Bug 1253707 - Script to generate visual studio toolchain archive; r?ted draft
Gregory Szorc <gps@mozilla.com> - Fri, 11 Mar 2016 15:00:02 -0800 - rev 340032
Push 12887 by gszorc@mozilla.com at Mon, 14 Mar 2016 22:15:17 +0000
Bug 1253707 - Script to generate visual studio toolchain archive; r?ted Previously, Windows toolchains and related dependencies (SDKs, etc) were installed on Windows builders by people responsible for maintaining those machines. This commit takes a step in a new direction. We introduce a script (complete with documentation) that can produce a zip archive (or any archive format if people want to implement support) of the toolchain files. Basically, you install Visual Studio 2015 Community, run the script, and produce a self-contained zip file containing everything from Microsoft you need to build Firefox. With a copy of this archive and an installation of MozillaBuild, it is possible to build Firefox on a fresh Windows installation. No time-consuming Visual Studio installation needed. The goal is to upload these archives to tooltool and have our Windows builders download and extract them at run-time. At which time, we can remove all the other Visual Studio and SDK files from builders because they don't need to be baked into the image. We may find tooltool's caching isn't good enough and we have to more aggressively caching the standalone toolchain files. But that is a problem for another day. Whatever happens, we'll need the functionality in this script to produce a self-contained archive of the toolchain. There are certainly files in the produced archive that aren't needed. I think perfect is the enemy of done and we can prune the archive over time, if wanted. MozReview-Commit-ID: EckEK1a6vA3
3375c2b043a0b3313e5976eda11db69b3f79a4cb: Bug 1124033 - Replace blanket disabling of VS2015 warnings with C5026 and C5027; r?ehsan draft
Gregory Szorc <gps@mozilla.com> - Mon, 14 Mar 2016 14:38:12 -0700 - rev 340031
Push 12887 by gszorc@mozilla.com at Mon, 14 Mar 2016 22:15:17 +0000
Bug 1124033 - Replace blanket disabling of VS2015 warnings with C5026 and C5027; r?ehsan Wv:18 was added in bug 1119072 as a quick way to get the tree building with VS2015. Now that we're closer to rolling out VS2015 support, we want to expose its new warnings. This patch replaces the blanket disabling of new warnings in VS2015 with just disabling C5026 and C5027, which relate to symbols being implicitly defined as deleted. MozReview-Commit-ID: 8uniydfNJns
40a4d8a9325fa903245cff348782f30e1662d832: Bug 1256408 - Add graphics microbenchmarking. r? draft
Benoit Girard <b56girard@gmail.com> - Mon, 14 Mar 2016 17:30:48 -0400 - rev 340030
Push 12886 by b56girard@gmail.com at Mon, 14 Mar 2016 21:31:04 +0000
Bug 1256408 - Add graphics microbenchmarking. r? MozReview-Commit-ID: 4YT4OPMTgvv
0ddf2275c70f9e3b65c9718d704430b591878301: Bug 1124033 - Replace blanket disabling of VS2015 warnings with C5026 and C5027; r?ehsan draft
Gregory Szorc <gps@mozilla.com> - Mon, 14 Mar 2016 14:27:32 -0700 - rev 340029
Push 12885 by gszorc@mozilla.com at Mon, 14 Mar 2016 21:28:58 +0000
Bug 1124033 - Replace blanket disabling of VS2015 warnings with C5026 and C5027; r?ehsan Wv:18 was added in bug 1119072 as a quick way to get the tree building with VS2015. Now that we're closer to rolling out VS2015 support, we want to expose its new warnings. This patch replaces the blanket disabling of new warnings in VS2015 with just disabling C5026 and C5027, which relate to symbols being implicitly defined as deleted. MozReview-Commit-ID: 8uniydfNJns
948a412a26628133758e978202c0b9f30daece8c: Bug 1242005 - Disable C4359 to allow compilation on VS2015; r?kip draft
Gregory Szorc <gps@mozilla.com> - Mon, 14 Mar 2016 14:11:40 -0700 - rev 340028
Push 12884 by gszorc@mozilla.com at Mon, 14 Mar 2016 21:14:42 +0000
Bug 1242005 - Disable C4359 to allow compilation on VS2015; r?kip The proper fix is to fix the underlying problem. However, I haven't touched C++ in months and I'm lazy. So I'm going for the quick fix so Visual Studio 2015 rollout is unblocked. MozReview-Commit-ID: 14cZCGPkx0V
61da0ac6e1948003090c1731784770d7ef38329a: Bug 1256427 - Investigate moving from Pair in support library to framework. draft
Michael Comella <michael.l.comella@gmail.com> - Mon, 14 Mar 2016 14:05:12 -0700 - rev 340027
Push 12883 by michael.l.comella@gmail.com at Mon, 14 Mar 2016 21:06:00 +0000
Bug 1256427 - Investigate moving from Pair in support library to framework. We're looking to investigate changes in APK size after proguarding. MozReview-Commit-ID: K5MXXGG52I0
ed9a510679288e6e4bd0f200180df12369a03c99: Bug 1225633 - Add better default styles to WebExtension panels. ui-r=shorlander, r=kmag draft
Blake Winton <bwinton@latte.ca> - Mon, 22 Feb 2016 15:21:34 -0500 - rev 340026
Push 12882 by bwinton@latte.ca at Mon, 14 Mar 2016 20:59:24 +0000
Bug 1225633 - Add better default styles to WebExtension panels. ui-r=shorlander, r=kmag MozReview-Commit-ID: 8D7BipQtQYz
9d8cafa28cca0db545aec628b5a6a96fffbda0cb: Bug 1242851 - adding keyboard focus styles for better accessibility. r=bgrins draft
Yura Zenevich <yzenevich@mozilla.com> - Mon, 14 Mar 2016 16:49:45 -0400 - rev 340025
Push 12881 by yura.zenevich@gmail.com at Mon, 14 Mar 2016 20:50:26 +0000
Bug 1242851 - adding keyboard focus styles for better accessibility. r=bgrins MozReview-Commit-ID: Cb6JO5OxAay --- devtools/client/shared/widgets/widgets.css | 8 +++++ devtools/client/themes/common.css | 13 +++++++ devtools/client/themes/computed.css | 4 +++ devtools/client/themes/markup.css | 4 +++ devtools/client/themes/netmonitor.css | 12 +++++++ devtools/client/themes/performance.css | 4 +++ devtools/client/themes/rules.css | 4 +++ devtools/client/themes/toolbars.css | 29 +++++++++++++++- devtools/client/themes/variables.css | 54 ++++++++++++++++++++++++++++++ devtools/client/themes/webconsole.css | 13 ++++++- devtools/client/themes/widgets.css | 15 +++++++++ 11 files changed, 158 insertions(+), 2 deletions(-)
1d8603c2677499cea23d9c72863e171f419023da: Bug 1242852 - making inspector toolbar keyboard accessible draft
Yura Zenevich <yzenevich@mozilla.com> - Mon, 14 Mar 2016 16:49:10 -0400 - rev 340024
Push 12881 by yura.zenevich@gmail.com at Mon, 14 Mar 2016 20:50:26 +0000
Bug 1242852 - making inspector toolbar keyboard accessible MozReview-Commit-ID: EYYNyTx0Cpo --- devtools/client/inspector/breadcrumbs.js | 36 +++++++++++++++++++++++++++ devtools/client/inspector/inspector-search.js | 6 +++++ 2 files changed, 42 insertions(+)
352f6649d900be010a501e61ef44e94ae6799856: Bug 1242852 - making top dev tools toolbar keyboard accessible. draft
Yura Zenevich <yzenevich@mozilla.com> - Mon, 14 Mar 2016 16:48:52 -0400 - rev 340023
Push 12881 by yura.zenevich@gmail.com at Mon, 14 Mar 2016 20:50:26 +0000
Bug 1242852 - making top dev tools toolbar keyboard accessible. MozReview-Commit-ID: 9s70n9mVi9i --- devtools/client/framework/toolbox.js | 67 +++++++++++++++++++++++++++++ devtools/client/shared/developer-toolbar.js | 8 ++++ devtools/client/themes/toolbars.css | 11 +++++ 3 files changed, 86 insertions(+)
3568d2a9826ae4af1ab5e3ac53dcb1e4b7ce9e66: Bug 1256405 - Add deprecation warning to SimpleCursorLoader. r=ahunt draft
Michael Comella <michael.l.comella@gmail.com> - Mon, 14 Mar 2016 12:18:25 -0700 - rev 340022
Push 12880 by michael.l.comella@gmail.com at Mon, 14 Mar 2016 20:29:04 +0000
Bug 1256405 - Add deprecation warning to SimpleCursorLoader. r=ahunt Surprisingly, this didn't set off lint locally. MozReview-Commit-ID: 5SvDS6jalS2
61bc5a4a25873bd16355047e89bd5b7b2cc739a7: Bug 1249288 - review: Correct concurrency issues with searchEngineManager. r=rnewman draft
Michael Comella <michael.l.comella@gmail.com> - Thu, 10 Mar 2016 17:37:56 -0800 - rev 340021
Push 12879 by michael.l.comella@gmail.com at Mon, 14 Mar 2016 20:24:50 +0000
Bug 1249288 - review: Correct concurrency issues with searchEngineManager. r=rnewman MozReview-Commit-ID: KaWlw14uOoN
efe16c91b9c00a805b9176a0742c191429cae02c: Bug 1249288 - Update telemetry docs to include defaultSearch. r=gfritzsche,rnewman draft
Michael Comella <michael.l.comella@gmail.com> - Thu, 10 Mar 2016 16:23:13 -0800 - rev 340020
Push 12879 by michael.l.comella@gmail.com at Mon, 14 Mar 2016 20:24:50 +0000
Bug 1249288 - Update telemetry docs to include defaultSearch. r=gfritzsche,rnewman MozReview-Commit-ID: 4pihITjabns
717ade0a87054cc5a6e4cf9dc485d1fb681784ae: Bug 1249288 - Don't call SearchEngineManager change callback if it's null. r=margaret draft
Michael Comella <michael.l.comella@gmail.com> - Tue, 23 Feb 2016 18:11:57 -0800 - rev 340019
Push 12879 by michael.l.comella@gmail.com at Mon, 14 Mar 2016 20:24:50 +0000
Bug 1249288 - Don't call SearchEngineManager change callback if it's null. r=margaret The callback may be null if setChangeCallback is never called and would cause a crash. MozReview-Commit-ID: BNd16Db1A8Q
efa0fe0add83085961a16769350d2dd9f2ce11c2: Bug 1249288 - Add default search engine to core ping. r=rnewman draft
Michael Comella <michael.l.comella@gmail.com> - Thu, 10 Mar 2016 16:00:15 -0800 - rev 340018
Push 12879 by michael.l.comella@gmail.com at Mon, 14 Mar 2016 20:24:50 +0000
Bug 1249288 - Add default search engine to core ping. r=rnewman The default search engine attribute may be null in the core ping if we haven't been able to retrieve the value yet. It's unclear when this might be, but the possibility is in the javadoc of `SearchEngineManager.getEngine`. MozReview-Commit-ID: IrJB6GyjyTO
6e46d916bbb34d645f6b0c465edc3992d5531782: bug 1255153 - (re)move redundant xpcshell name constraint tests to gtests r?Cykesiopka r?jcj draft
David Keeler <dkeeler@mozilla.com> - Wed, 09 Mar 2016 14:33:31 -0800 - rev 340017
Push 12878 by dkeeler@mozilla.com at Mon, 14 Mar 2016 19:36:12 +0000
bug 1255153 - (re)move redundant xpcshell name constraint tests to gtests r?Cykesiopka r?jcj MozReview-Commit-ID: 8eFSIhB1RId
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip