3bef51b87130787241687b6c5de174740160dd26: Bug 1287007 - Use child's Extension instead of the process' draft
Rob Wu <rob@robwu.nl> - Tue, 06 Sep 2016 15:31:33 -0700 - rev 411561
Push 28922 by bmo:rob@robwu.nl at Thu, 08 Sep 2016 08:44:00 +0000
Bug 1287007 - Use child's Extension instead of the process' MozReview-Commit-ID: 9o8tOuUbchn
8892fd45b9eda3d670d0181fc5ee79a2c7094832: Bug 1287007 - Fix test_ext_api_permissions.js draft
Rob Wu <rob@robwu.nl> - Wed, 07 Sep 2016 17:10:33 -0700 - rev 411560
Push 28922 by bmo:rob@robwu.nl at Thu, 08 Sep 2016 08:44:00 +0000
Bug 1287007 - Fix test_ext_api_permissions.js "extension.views" will only be available in content, so use the "proxy-context-load" event to detect new views. MozReview-Commit-ID: K86Be5IDk42
7cda1873a83ad40eb088d86d77f68c90f4d920d1: Bug 1287007 - Use IPC to share viewType, tabId and windowId draft
Rob Wu <rob@robwu.nl> - Tue, 06 Sep 2016 15:25:10 -0700 - rev 411559
Push 28922 by bmo:rob@robwu.nl at Thu, 08 Sep 2016 08:44:00 +0000
Bug 1287007 - Use IPC to share viewType, tabId and windowId Accessing <browser> in ContentChild does not work when extensions run in a separate process. MozReview-Commit-ID: EK0aOYeGaZ5
21f5c7656f50866a02c2e3806fc4047c0e6407a1: Bug 1287007 - Fix timing issue in browser_ext_tabs_getCurrent.js draft
Rob Wu <rob@robwu.nl> - Tue, 06 Sep 2016 14:45:58 -0700 - rev 411558
Push 28922 by bmo:rob@robwu.nl at Thu, 08 Sep 2016 08:44:00 +0000
Bug 1287007 - Fix timing issue in browser_ext_tabs_getCurrent.js browser.test.sendMessage goes through the ChildAPIManager, whereas tabs.remove is currently a direct call MozReview-Commit-ID: 1mmGZOi9fzm
151436b11b91267bef9183ac00d70ab894e38b7b: Bug 1287007 - Move extension context initialization to ExtensionContent draft
Rob Wu <rob@robwu.nl> - Mon, 05 Sep 2016 23:50:11 -0700 - rev 411557
Push 28922 by bmo:rob@robwu.nl at Thu, 08 Sep 2016 08:44:00 +0000
Bug 1287007 - Move extension context initialization to ExtensionContent This is a simple move of ExtensionContext creation logic to ExtensionChild. Before the change, ExtensionContext was initialized as follows: 1. (ext-backgroundPage.js) Create background page 2. (Extension.jsm) document-element-inserted observed. 3. (Extension.jsm) new ExtensionContext + unload observer. After this commit: 1. (ext-backgroundPage.js) Create background page 2. (ext-backgroundPage.js) emit extension-browser-inserted event 3. (Extension.jsm) Pass global to ExtensionContent + unload listener. 4. (ExtensionContent.jsm) document-element-inserted observed. 5. (ExtensionChild.jsm) new ExtensionContext The next step is to use frame scripts and synchronize state. MozReview-Commit-ID: K6mPdq7KQ2T
8699ea7b9d6ec7691d586d4aed09e962aa17d949: Bug 1287007 - Move extension.getViews to child draft
Rob Wu <rob@robwu.nl> - Wed, 07 Sep 2016 22:54:07 -0700 - rev 411556
Push 28922 by bmo:rob@robwu.nl at Thu, 08 Sep 2016 08:44:00 +0000
Bug 1287007 - Move extension.getViews to child MozReview-Commit-ID: SG2pmulzaP
af16dba6990aa0b33a7e841a9db29026b3b2c686: Bug 1287007 - Move background page API logic to child draft
Rob Wu <rob@robwu.nl> - Mon, 05 Sep 2016 22:34:44 -0700 - rev 411555
Push 28922 by bmo:rob@robwu.nl at Thu, 08 Sep 2016 08:44:00 +0000
Bug 1287007 - Move background page API logic to child MozReview-Commit-ID: iGROahhkhn
da1534dc164642e1a34047952d8ea753948fd705: Bug 1287007 - Rename "context.type" to "context.viewType" draft
Rob Wu <rob@robwu.nl> - Mon, 05 Sep 2016 22:26:56 -0700 - rev 411554
Push 28922 by bmo:rob@robwu.nl at Thu, 08 Sep 2016 08:44:00 +0000
Bug 1287007 - Rename "context.type" to "context.viewType" "viewType" is more easily searchable and not as ambiguous as "type". MozReview-Commit-ID: 8sG4qagFCBu
a63f1b6ad722cd2c3e2834dc52e280c3be024e7a: Bug 1287007 - Introduce ChildAPIManager to addon code draft
Rob Wu <rob@robwu.nl> - Mon, 05 Sep 2016 18:57:38 -0700 - rev 411553
Push 28922 by bmo:rob@robwu.nl at Thu, 08 Sep 2016 08:44:00 +0000
Bug 1287007 - Introduce ChildAPIManager to addon code This is the bare minimum to separate the generation of addon_parent and addon_child APIs. Now it is possible to have methods with the same name but different implementations in the parent and child. Many APIs are not compatible with the proxied API implementation, so they temporarily fall back to directly invoking the parent API, just as before this commit. MozReview-Commit-ID: fwuZUvD8tY
c8204bd45b6f9e48bfe27ba6f0464ba3c2e8fb65: Bug 1287007 - Do not neuter error messages from the same principal draft
Rob Wu <rob@robwu.nl> - Mon, 05 Sep 2016 17:04:28 -0700 - rev 411552
Push 28922 by bmo:rob@robwu.nl at Thu, 08 Sep 2016 08:44:00 +0000
Bug 1287007 - Do not neuter error messages from the same principal With an upcoming change that introduces another ProxyContext, errors from a different scope may bubble up. These messages should be reported, not replaced with "An unexpected error occurred". MozReview-Commit-ID: ByUktVkhDyx
bb36a764a97dec24b28ca6cbec11e817e797bda8: Bug 1287007 - Move ExtensionContext to separate file draft
Rob Wu <rob@robwu.nl> - Mon, 05 Sep 2016 00:15:18 -0700 - rev 411551
Push 28922 by bmo:rob@robwu.nl at Thu, 08 Sep 2016 08:44:00 +0000
Bug 1287007 - Move ExtensionContext to separate file This is just a mechanical change, literally nothing more than cutting ExtensionContext from Extension.jsm, pasting it in ExtensionChild.jsm and adding the minimal imoort boilerplate. MozReview-Commit-ID: 5uVt1IOdEFU
6690c74b4cab7067d24e0b29797c988285375150: Bug 1287007 - Harden browser.storage.local serialization draft
Rob Wu <rob@robwu.nl> - Sun, 04 Sep 2016 19:19:17 -0700 - rev 411550
Push 28922 by bmo:rob@robwu.nl at Thu, 08 Sep 2016 08:44:00 +0000
Bug 1287007 - Harden browser.storage.local serialization - Lazily initialize file IO-specific stuff in ExtensionStorage.jsm, and limit this work to the main process. - Add local versions of the `storage.local.get` and `storage.local.set` implementations that perform sanitization (without the change, values are improperly serialized over IPC). - Switch from JSON.stringify to a custom serializer, because: - The serialization of the value is affected by the context's override of methods such as `toJSON` and `toString`. - Nested objects with function values trigger the following error: > XrayWrapper denied access to property "foo" (reason: value is callable). > See https://developer.mozilla.org/en-US/docs/Xray_vision for more > information. Note that only the first denied property access from a > given global object will be reported. - Copied the `backgroundScript` test from xpcshell/test_ext_storage.js to mochitest/test_ext_storage_content.html because they should behave identical. Before this patch the test failed due to IPC serialization issues, now the test passes. Note that the old test also passes with the changes. MozReview-Commit-ID: 8J8CCdwMACN
bbf3c4655d18c74cb5a89fdccaf11f09ab8935ca: Bug 1287007 - Allow local implementations to call remote implementations draft
Rob Wu <rob@robwu.nl> - Sun, 04 Sep 2016 02:29:48 -0700 - rev 411549
Push 28922 by bmo:rob@robwu.nl at Thu, 08 Sep 2016 08:44:00 +0000
Bug 1287007 - Allow local implementations to call remote implementations - Add callParentFunctionNoReturn / callParentAsyncFunction to ChildAPIManager to implement remote calls. - Add in-process browser.test implementation that uses this. - Add tests to verify that the browser.test.assert* methods with the `allowAmbiguousOptionalArguments` schema attribute are working with objects that cannot be passed as-is over IPC. (except test.sendMessage, because stringifying the arguments has an observable impact on test behavior) MozReview-Commit-ID: 6cFVgmFfU93
b61f1597d5d8a182f8694cc4b1025c7d060642ce: Bug 1287007 - Mark all browserAction methods as async draft
Rob Wu <rob@robwu.nl> - Fri, 02 Sep 2016 14:22:09 -0700 - rev 411548
Push 28922 by bmo:rob@robwu.nl at Thu, 08 Sep 2016 08:44:00 +0000
Bug 1287007 - Mark all browserAction methods as async E.g. browser.browserAction.enable(...).then(...) now works as expected. Removed a Promise.resolve() because that is the default. MozReview-Commit-ID: 4Shxtn0rjYH
915f4602b377a5d0123164af1935cbca3b078120: Bug 1287007 - Require "async" in schemas to match name draft
Rob Wu <rob@robwu.nl> - Fri, 02 Sep 2016 03:37:55 -0700 - rev 411547
Push 28922 by bmo:rob@robwu.nl at Thu, 08 Sep 2016 08:44:00 +0000
Bug 1287007 - Require "async" in schemas to match name In the pageAction and browserAction schemas, several methods are declared with `"async": true` but without a specified callback in the `"parameters"` object, so callbacks are not allowed. However, when a callback is proxied, the `ParentAPIManager` will mirror the call by passing in an extra callback to the proxied API - and break. This patch fixes the issue by removing uses of async:true. Also for consistency between the browserAction and pageAction methods, the methods that were not declared as async have also been marked as async. MozReview-Commit-ID: JQqzmTUAotB
eff02c3958773152a9cb89a4c417c27fd23ec9d3: Bug 1287007 - Fix timing issue in browser/page action tests draft
Rob Wu <rob@robwu.nl> - Fri, 02 Sep 2016 16:33:32 -0700 - rev 411546
Push 28922 by bmo:rob@robwu.nl at Thu, 08 Sep 2016 08:44:00 +0000
Bug 1287007 - Fix timing issue in browser/page action tests MozReview-Commit-ID: 9L0ttaq42Ga
846bc2996410323e384113bdc2a428fe2be041a5: Bug 1287007 - Refactor test_ext_schemas_api_injection.js draft
Rob Wu <rob@robwu.nl> - Fri, 02 Sep 2016 05:36:33 -0700 - rev 411545
Push 28922 by bmo:rob@robwu.nl at Thu, 08 Sep 2016 08:44:00 +0000
Bug 1287007 - Refactor test_ext_schemas_api_injection.js When the background API move to a separate implementation, then the schema APIs will be generated (and ChildAPIManager will just delegate the implementation to the parent process). The purpose of the test is to verify that nested namespaces and null-feturn values work, so just use the base classes instead of a concrete implementation for BaseContext / SchemaAPIManager instead of setting up a full extension. MozReview-Commit-ID: CB5s7Ae24zS
bcfd6755b67b7b5f8d65ff68a0150b7c5341f4d1: Bug 1287007 - Improve errors for non-existing remote APIs draft
Rob Wu <rob@robwu.nl> - Thu, 01 Sep 2016 21:14:31 -0700 - rev 411544
Push 28922 by bmo:rob@robwu.nl at Thu, 08 Sep 2016 08:44:00 +0000
Bug 1287007 - Improve errors for non-existing remote APIs Currently, if the remote implementation is missing, the next unhelpful error message is logged to the console: "TypeError: findPathInObject(...) is not a function" or "TypeError: findPathInObject(...) is undefined", etc. This commit makes the message more useful: "WebExtension API tabs.create not found (it may be unimplemented by Firefox)" MozReview-Commit-ID: FhPEYKSjnLm
7dfd6765b9f0bddff1923dbe2127521f2ba655ec: Bug 1287007 - Fix some flaws in ProxyAPIImplementation draft
Rob Wu <rob@robwu.nl> - Thu, 01 Sep 2016 21:10:18 -0700 - rev 411543
Push 28922 by bmo:rob@robwu.nl at Thu, 08 Sep 2016 08:44:00 +0000
Bug 1287007 - Fix some flaws in ProxyAPIImplementation - removeListener: There is no set.remove, use set.delete. - Async callbacks: Do not unconditionally turn the result in a SpreadArgs because it causes the result to unconditionally be wrapped in an array (+test). MozReview-Commit-ID: LqwtBsHWJJr
a7641d6110943b4327db12915e941cf1ca331a53: Bug 599975 - Fire error event for images with empty string src value; r=bz draft
Edgar Chen <echen@mozilla.com> - Thu, 08 Sep 2016 16:27:03 +0800 - rev 411542
Push 28921 by echen@mozilla.com at Thu, 08 Sep 2016 08:37:36 +0000
Bug 599975 - Fire error event for images with empty string src value; r=bz MozReview-Commit-ID: AhXiTpgG9q3
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip