3bb32d2320f901959768c9e6b3c49a6c68d30171: Bug 1344629 bonus fix: Remove heap allocation in nsChromeTreeOwner. r?dbaron draft
David Major <dmajor@mozilla.com> - Sat, 11 Mar 2017 10:46:12 +1300 - rev 496906
Push 48740 by dmajor@mozilla.com at Fri, 10 Mar 2017 22:01:30 +0000
Bug 1344629 bonus fix: Remove heap allocation in nsChromeTreeOwner. r?dbaron Now that nsLiteralStrings are "free", they can just be static globals. MozReview-Commit-ID: 4d4ZObxiHF8
6d6413425a8fab53eee281bfbafb8563dde03d99: Bug 1344629: Make nsTLiteralString inherit from nsTStringRepr. r?dbaron draft
David Major <dmajor@mozilla.com> - Sat, 11 Mar 2017 10:45:49 +1300 - rev 496905
Push 48740 by dmajor@mozilla.com at Fri, 10 Mar 2017 22:01:30 +0000
Bug 1344629: Make nsTLiteralString inherit from nsTStringRepr. r?dbaron This is the patch that all the others have been leading up to: by inheriting from nsTStringRepr, nsTLiteralString loses its destructor (previously suppplied by nsTSubstring). I included an AsString() cast as an escape hatch for a few pieces of code that couldn't easily accommodate the new hierarchy, but I'm pretty pleased with how little I had to use it. MozReview-Commit-ID: 2zGkaw1sMUp
18f6c00423016a19c7babd72d33a08679de8183c: Bug 1344629: Rewrite a few other awkward uses of nsTLiteralString. r?dbaron draft
David Major <dmajor@mozilla.com> - Sat, 11 Mar 2017 10:44:47 +1300 - rev 496904
Push 48740 by dmajor@mozilla.com at Fri, 10 Mar 2017 22:01:30 +0000
Bug 1344629: Rewrite a few other awkward uses of nsTLiteralString. r?dbaron These would otherwise fail to compile after the next patch. If EventDispatcher.cpp looks questionable, check out https://dxr.mozilla.org/mozilla-central/rev/34585620e529614c79ecc007705646de748e592d/widget/android/jni/Refs.h#698 -- previously we were going through jni::String::Param::ToCString(), which called ToString() and then NS_ConvertUTF16toUTF8(). Now I just call those directly. MozReview-Commit-ID: DFvuESN8G5s
5307b03c775f977f815fbb8c96f3156a18b0e0f6: Bug 1344629: Rewrite callers of nsLiteralString::get(). r?dbaron draft
David Major <dmajor@mozilla.com> - Sat, 11 Mar 2017 10:23:15 +1300 - rev 496903
Push 48740 by dmajor@mozilla.com at Fri, 10 Mar 2017 22:01:30 +0000
Bug 1344629: Rewrite callers of nsLiteralString::get(). r?dbaron Because get() is defined on nsTString (not nsTSubstring!), literal strings will lose this method in the next patch, when they change to inherit from nsTStringRepr directly. In an earlier iteration of this patch, I simply moved get() up to nsTStringRepr, and everything worked. However, bug 1341513 convinced me that nsTLiteralString::get() is an antipattern, and the code I encountered in the course of this patch confirmed it. nsTLiteralString::get() is often used as an unnecessary intermediary in converting from CharT* to CharT*, and it's better to just remove it. In a few places where rewriting would be difficult, I "cheated" by switching to Data(), which returns the same thing. I guess this means that there's still the possibility for abuse via Data(), but somehow this feels less likely. (Maybe it's the name. Data() just doesn't sound quite as inviting.) MozReview-Commit-ID: Kh1rUziVllo
e36698e4b3c4af31f233ef84564ba724ff2d9522: Bug 1344629: Make string tuples work with nsTStringRepr. r?dbaron draft
David Major <dmajor@mozilla.com> - Sat, 11 Mar 2017 10:14:22 +1300 - rev 496902
Push 48740 by dmajor@mozilla.com at Fri, 10 Mar 2017 22:01:30 +0000
Bug 1344629: Make string tuples work with nsTStringRepr. r?dbaron This requires some adjustment to Equals(). Previously, when you wrote: fooString.Equals(barString + bazString) you'd get a tuple for the operator+, which implicitly converts to nsTSubstring, which resolves into nsTSubstring::Equals(const nsTSubstring&). Now that Equals has moved one level up: nsTStringRepr::Equals(const nsTStringRepr&) The compiler can't make the double-leap from nsTSubstringTuple -> nsTSubstring -> nsTStringRepr. So I implemented this manually. MozReview-Commit-ID: HFAu29THDWY
660cfd77b6e3b892a4054fc070345984a20ba486: Bug 1344629: Cleanup: make string tuples not think in terms of "substring". r?dbaron draft
David Major <dmajor@mozilla.com> - Sat, 11 Mar 2017 10:06:19 +1300 - rev 496901
Push 48740 by dmajor@mozilla.com at Fri, 10 Mar 2017 22:01:30 +0000
Bug 1344629: Cleanup: make string tuples not think in terms of "substring". r?dbaron In the next patch, tuples will work on nsTStringRepr rather than nsTSubstring, so the notions of TO_SUBSTRING and substring_type are not quite right. MozReview-Commit-ID: LpUwmGQAWVO
9539e79ba7c143e2631814f16c603d6cc8a12fbb: Bug 1344629: Move const accessors from nsTSubstring to nsTStringRepr. r?dbaron draft
David Major <dmajor@mozilla.com> - Sat, 11 Mar 2017 09:53:48 +1300 - rev 496900
Push 48740 by dmajor@mozilla.com at Fri, 10 Mar 2017 22:01:30 +0000
Bug 1344629: Move const accessors from nsTSubstring to nsTStringRepr. r?dbaron All nsTStringRepr methods must be const, so the mutators remain on nsTSubstring. I left a small number of const methods on nsTSubstring, e.g. Capacity(), the rationale being that you would only be interested in this method if you intend to mutate the string. I considered splitting up the typedefs block and leaving behind the ones related to mutation (e.g. nsWritingIterator) but I think it makes for clearer documentation to have them all in one place. MozReview-Commit-ID: 7dEaRgc8NLK
8235fc288b96cb28cdcabf0430b63b3430f2493b: Bug 1344629: Add nsTStringRepr as the new root of the string hierarchy. r?dbaron draft
David Major <dmajor@mozilla.com> - Sat, 11 Mar 2017 09:38:33 +1300 - rev 496899
Push 48740 by dmajor@mozilla.com at Fri, 10 Mar 2017 22:01:30 +0000
Bug 1344629: Add nsTStringRepr as the new root of the string hierarchy. r?dbaron I've named it after the similar ns(C)StringRepr in the rust bindings code. This is just the minimal definition of the structure. Bulk move of methods coming in next patch. MozReview-Commit-ID: 4aQrpIWRTm7
1a4fd9c98ddfb2f2c05929a99c6f82a37da870c4: Bug 1344629: String class cleanup and dead code removal. r?dbaron draft
David Major <dmajor@mozilla.com> - Sat, 11 Mar 2017 09:34:57 +1300 - rev 496898
Push 48740 by dmajor@mozilla.com at Fri, 10 Mar 2017 22:01:30 +0000
Bug 1344629: String class cleanup and dead code removal. r?dbaron Cleanup in preparation for upcoming patches: - By using an accessor method, nsTPromiseFlatString no longer needs to be a friend. - The explicit uint32_t constructors are unused. - The abstract_string_type typedef is unused (and will be potentially confusing in the next patch, so removing). - The three-param ctor for nsTSubstring no longer needs to be public "for convenience". - friend class nsTObsoleteAStringThunk_CharT no longer exists. MozReview-Commit-ID: 7rulW6Pbvcn
2d87e9590179bb786b82fc51b4217314ea890aa8: bug 1239344 - remove error alert for successful PKCS12 operations r?Cykesiopka draft
David Keeler <dkeeler@mozilla.com> - Fri, 03 Mar 2017 11:12:54 -0800 - rev 496897
Push 48739 by bmo:dkeeler@mozilla.com at Fri, 10 Mar 2017 21:58:21 +0000
bug 1239344 - remove error alert for successful PKCS12 operations r?Cykesiopka MozReview-Commit-ID: Hr6s2v2GmZQ
e6106c2dbdd84c4ea5c775acf5cfce346663c0ff: Bug 1345611 - Change behavior of subdocument Flash blocking to be Third-Party Flash blocking draft
Kirk Steuber <ksteuber@mozilla.com> - Fri, 10 Mar 2017 10:50:21 -0800 - rev 496896
Push 48738 by ksteuber@mozilla.com at Fri, 10 Mar 2017 21:53:01 +0000
Bug 1345611 - Change behavior of subdocument Flash blocking to be Third-Party Flash blocking The previous implementation regarding to the Flash Blocking Subdocument list blocked all subdocuments that matched the list. This patch changes that so that subdocuments are only blocked if they are on the Subdocument Block List and also are loaded in a Third-Party context. The changes to cert8.db and key3.db add the https certificate for subdocument.example.com so that testing can verify that a scheme mismatch between the document and its parent results in a third-party classification. MozReview-Commit-ID: IXnA4iPzB4y
8a727a2ca5e003111e36cc35489ac1b5fc2b1bcb: Bug 1346393 - Extend expiry of SCROLL_INPUT_METHODS telemetry probe to Firefox 60. r=kats draft
Botond Ballo <botond@mozilla.com> - Fri, 10 Mar 2017 16:38:58 -0500 - rev 496895
Push 48737 by bballo@mozilla.com at Fri, 10 Mar 2017 21:39:29 +0000
Bug 1346393 - Extend expiry of SCROLL_INPUT_METHODS telemetry probe to Firefox 60. r=kats MozReview-Commit-ID: I7axJBSlBTN
77eae80dd8f610a5cb303d367d114be0cfa6bc4b: Bug 1333714 - update grid highlighter and layout panel on markupmutation;r=gl draft
Julian Descottes <jdescottes@mozilla.com> - Tue, 07 Mar 2017 18:02:41 +0100 - rev 496894
Push 48736 by jdescottes@mozilla.com at Fri, 10 Mar 2017 21:28:21 +0000
Bug 1333714 - update grid highlighter and layout panel on markupmutation;r=gl MozReview-Commit-ID: 9TAUxqTiT4M
6dfbbdf78f7b59ab8264397f837fa61601bf72ee: Bug 1333714 - Allow highlighter to be hidden even if current node is not valid;r=zer0 draft
Julian Descottes <jdescottes@mozilla.com> - Fri, 10 Mar 2017 22:25:01 +0100 - rev 496893
Push 48736 by jdescottes@mozilla.com at Fri, 10 Mar 2017 21:28:21 +0000
Bug 1333714 - Allow highlighter to be hidden even if current node is not valid;r=zer0 When a highlighter was created for a node that has been removed, it can no longer be hidden due to a check performed in the hide method of the basic auto-refresh class. While it makes sense not to display a highlighter for an invalid node, hiding a highlighter should always remain possible. MozReview-Commit-ID: ChkmecJeqy9
d7a046be7bf1008386b4d3f19a3d7cc4e60145b0: Bug 1346341 - Ifdef more OSPreferences platform-specific calls that depend on ICU. r?jfkthame draft
Zibi Braniecki <gandalf@mozilla.com> - Fri, 10 Mar 2017 13:23:17 -0800 - rev 496892
Push 48735 by zbraniecki@mozilla.com at Fri, 10 Mar 2017 21:25:40 +0000
Bug 1346341 - Ifdef more OSPreferences platform-specific calls that depend on ICU. r?jfkthame MozReview-Commit-ID: F0H4LiXK1R6
6f23bf647d8547a2f711d418ba2801c5059e0ab8: Bug 1346390 - Use Long.parseLong instead of Long.valueOf for efficiency r=nalexander draft
Grigory Kruglov <gkruglov@mozilla.com> - Fri, 10 Mar 2017 13:17:51 -0800 - rev 496891
Push 48734 by gkruglov@mozilla.com at Fri, 10 Mar 2017 21:23:17 +0000
Bug 1346390 - Use Long.parseLong instead of Long.valueOf for efficiency r=nalexander MozReview-Commit-ID: 29fwjlxRqZ3
c8e3cad2f9b829603cdcab7a63530bd3ffd966a8: Bug 1346390 - Use Long.parseLong instead of Long.valueOf for efficiency r=nalexander draft
Grigory Kruglov <gkruglov@mozilla.com> - Fri, 10 Mar 2017 13:17:51 -0800 - rev 496890
Push 48733 by gkruglov@mozilla.com at Fri, 10 Mar 2017 21:16:16 +0000
Bug 1346390 - Use Long.parseLong instead of Long.valueOf for efficiency r=nalexander MozReview-Commit-ID: 29fwjlxRqZ3
dff3382f4935d645188a01660c3769ff6e6c64da: Bug 1345897 - Use a separate error function for sentinel errors. r=kanru draft
Andrew McCreight <continuation@gmail.com> - Thu, 09 Mar 2017 13:37:55 -0800 - rev 496889
Push 48732 by bmo:continuation@gmail.com at Fri, 10 Mar 2017 21:13:47 +0000
Bug 1345897 - Use a separate error function for sentinel errors. r=kanru Using a separate error function will distinguish mismatched sentinels from other errors, such as array length problems. MozReview-Commit-ID: Gl8swNhqLns
bbf1ba5db00b2b32af4b884b681c50619f1b58ab: Bug 1346345 - Implement != operator for IPDL structs. r=kanru draft
Andrew McCreight <continuation@gmail.com> - Fri, 10 Mar 2017 11:42:07 -0800 - rev 496888
Push 48732 by bmo:continuation@gmail.com at Fri, 10 Mar 2017 21:13:47 +0000
Bug 1346345 - Implement != operator for IPDL structs. r=kanru MozReview-Commit-ID: H1CDbuXZ5U0
0293381386c6acbdfb71a5466f81d27748c340ed: Bug 1342913: P2. Terminate draining operations when possible. r?gerald draft
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 07 Mar 2017 20:13:39 +1100 - rev 496887
Push 48731 by bmo:jyavenard@mozilla.com at Fri, 10 Mar 2017 21:08:33 +0000
Bug 1342913: P2. Terminate draining operations when possible. r?gerald An interesting intermittent condition not previously handled. We were incorrectly assuming that we always had a decode promise pending when a drain was requested. If a change of content occurred when resuming from a waiting for data condition: we would have stalled forever as the waiting promise would never have been resolved even after new data was appended. MozReview-Commit-ID: BQSRSHYqTSe
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip