3b9c92da35352893d8322b352d5cd4b78d08b167: Bug 1304886 - Part 10: Add rotate3d test case. r?boris draft
Hiroyuki Ikezoe <hiikezoe@mozilla-japan.org> - Wed, 16 Nov 2016 20:32:33 +0900 - rev 439615
Push 36059 by hiikezoe@mozilla-japan.org at Wed, 16 Nov 2016 11:32:59 +0000
Bug 1304886 - Part 10: Add rotate3d test case. r?boris MozReview-Commit-ID: 6gDhughPrps
c36e1b115b6bafaf7801bdc9f26efff2f25fbb1b: Bug 1304886 - Part 9: Accumulate mismatched transform list properly. r?boris draft
Hiroyuki Ikezoe <hiikezoe@mozilla-japan.org> - Wed, 16 Nov 2016 20:32:33 +0900 - rev 439614
Push 36059 by hiikezoe@mozilla-japan.org at Wed, 16 Nov 2016 11:32:59 +0000
Bug 1304886 - Part 9: Accumulate mismatched transform list properly. r?boris MozReview-Commit-ID: LTz4TkCsMbQ
b639a35b96358bd00676f2d0111b9c155b8d2441: Bug 1304886 - Part 8: Add Accumulate operator. r?boris, derf draft
Hiroyuki Ikezoe <hiikezoe@mozilla-japan.org> - Wed, 16 Nov 2016 20:32:33 +0900 - rev 439613
Push 36059 by hiikezoe@mozilla-japan.org at Wed, 16 Nov 2016 11:32:59 +0000
Bug 1304886 - Part 8: Add Accumulate operator. r?boris, derf MozReview-Commit-ID: Bzcn3IRSx6L
8a363012210a7e18f86415104f57fc839b16a95f: Bug 1304886 - Part 7: Add mulitiplications for quaternions. r?boris, derf draft
Hiroyuki Ikezoe <hiikezoe@mozilla-japan.org> - Wed, 16 Nov 2016 20:32:33 +0900 - rev 439612
Push 36059 by hiikezoe@mozilla-japan.org at Wed, 16 Nov 2016 11:32:59 +0000
Bug 1304886 - Part 7: Add mulitiplications for quaternions. r?boris, derf MozReview-Commit-ID: IZDnU26wj2Y
01bfa6e4ecc7c2e6edfee510a31618f4103b8bdd: Bug 1304886 - Part 6: Make ProcessInterpolateMatrix template. r?boris draft
Hiroyuki Ikezoe <hiikezoe@mozilla-japan.org> - Wed, 16 Nov 2016 20:32:32 +0900 - rev 439611
Push 36059 by hiikezoe@mozilla-japan.org at Wed, 16 Nov 2016 11:32:59 +0000
Bug 1304886 - Part 6: Make ProcessInterpolateMatrix template. r?boris To avoid exposing the template ProcessInterpolateMatrix is left because it is used in AddTransformFunctions in nsDisplayList.cpp. MozReview-Commit-ID: D9KW7du5j04
4c62d1637175ea29ca0093a1f08daf4f772ff349: Bug 1304886 - Part 5: Make InterpolateTransformMatrix template to calculate accumulation. r?boris draft
Hiroyuki Ikezoe <hiikezoe@mozilla-japan.org> - Wed, 16 Nov 2016 20:32:32 +0900 - rev 439610
Push 36059 by hiikezoe@mozilla-japan.org at Wed, 16 Nov 2016 11:32:59 +0000
Bug 1304886 - Part 5: Make InterpolateTransformMatrix template to calculate accumulation. r?boris InterpolateTransformMatrix renamed to OperateTransformMatrix. MozReview-Commit-ID: 3IpkAIa3cBN
b2a605588e13c3e165cf3617aae72ac236ce2bcb: Bug 1304886 - Part 4: Mark gfxQuaternion::Slerp and ToMatrix const. r?boris draft
Hiroyuki Ikezoe <hiikezoe@mozilla-japan.org> - Wed, 16 Nov 2016 20:32:32 +0900 - rev 439609
Push 36059 by hiikezoe@mozilla-japan.org at Wed, 16 Nov 2016 11:32:59 +0000
Bug 1304886 - Part 4: Mark gfxQuaternion::Slerp and ToMatrix const. r?boris We will use them for const gfxQuaternion in subsequent patches. MozReview-Commit-ID: 7CBjnklpxUQ
c5cf349e36f1f14db4e0244e5519c66013e16050: Bug 1304886 - Part 3: Move InterpolateTransformMatrix into nsStyleTransformMatrix. r?boris draft
Hiroyuki Ikezoe <hiikezoe@mozilla-japan.org> - Wed, 16 Nov 2016 20:32:32 +0900 - rev 439608
Push 36059 by hiikezoe@mozilla-japan.org at Wed, 16 Nov 2016 11:32:59 +0000
Bug 1304886 - Part 3: Move InterpolateTransformMatrix into nsStyleTransformMatrix. r?boris MozReview-Commit-ID: 7GV6B7AwNcg
19dd1af1cbbcc95c046885ce3531219ef93002c3: Bug 1304886 - Part 2: Factor out TransformFunctionListsMatch. r?boris draft
Hiroyuki Ikezoe <hiikezoe@mozilla-japan.org> - Wed, 16 Nov 2016 20:32:32 +0900 - rev 439607
Push 36059 by hiikezoe@mozilla-japan.org at Wed, 16 Nov 2016 11:32:59 +0000
Bug 1304886 - Part 2: Factor out TransformFunctionListsMatch. r?boris MozReview-Commit-ID: BhRkF6ClJjv
b69626c2b214005ad953571716b691cfd0fbd9a6: Bug 1304886 - Part 1: Make StyleAnimationValue::Accumulate() infallible. r?birtles draft
Hiroyuki Ikezoe <hiikezoe@mozilla-japan.org> - Wed, 16 Nov 2016 20:32:26 +0900 - rev 439606
Push 36059 by hiikezoe@mozilla-japan.org at Wed, 16 Nov 2016 11:32:59 +0000
Bug 1304886 - Part 1: Make StyleAnimationValue::Accumulate() infallible. r?birtles MozReview-Commit-ID: 9ve3k6a3eAg
e541e365f1426b5547fade323fd36c5f3cbf9984: Bug 1316302 part.5 Minimize variable scopes in HTMLEditRules::TryToJoinBlocks() r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 16 Nov 2016 13:08:50 +0900 - rev 439605
Push 36058 by masayuki@d-toybox.com at Wed, 16 Nov 2016 11:23:22 +0000
Bug 1316302 part.5 Minimize variable scopes in HTMLEditRules::TryToJoinBlocks() r?smaug Because of using early return style in HTMLEditRules::TryToJoinBlocks(), we can minimize the scope of EditActionResult variable in it. MozReview-Commit-ID: jXVolNw41a
3f709be90884ffa67f20812e90bd9c1e83e5a5a3: Bug 1316302 part.4 Refine HTMLEditRules::TryToJoinBlocks() and HTMLEditRules::MoveNodeSmart() with early return style r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 16 Nov 2016 11:13:40 +0900 - rev 439604
Push 36058 by masayuki@d-toybox.com at Wed, 16 Nov 2016 11:23:22 +0000
Bug 1316302 part.4 Refine HTMLEditRules::TryToJoinBlocks() and HTMLEditRules::MoveNodeSmart() with early return style r?smaug MozReview-Commit-ID: 9vDoU9bUdVO
e948cc22afe1be80cb4e0e1076d0dd6546f04f59: Bug 1316302 part.3 Create EditActionResult class for making the methods which return nsresult, handled and canceled with out params r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 16 Nov 2016 14:04:23 +0900 - rev 439603
Push 36058 by masayuki@d-toybox.com at Wed, 16 Nov 2016 11:23:22 +0000
Bug 1316302 part.3 Create EditActionResult class for making the methods which return nsresult, handled and canceled with out params r?smaug In a lot of places, edit action handlers and their helper methods return nsresult and aHandled and aCanceled with out params. However, the out params cause the code complicated since: * it's not unclear if the method will overwrite aHandled and aCanceled value. * callers need to create temporary variable event if some of them are not necessary. This patch rewrites the helper methods of HTMLEditRules::WillDeleteSelection() with it. MozReview-Commit-ID: CJv75KdOdXf
0aaa7642795b288b2df070e6bb83ac3e8fb6c9bd: Bug 1316302 part.2 WillDeleteSelection() should retry to handle it when selection is collapsed and JoinBlocks() doesn't handle nor cancel the action r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 16 Nov 2016 20:20:41 +0900 - rev 439602
Push 36058 by masayuki@d-toybox.com at Wed, 16 Nov 2016 11:23:22 +0000
Bug 1316302 part.2 WillDeleteSelection() should retry to handle it when selection is collapsed and JoinBlocks() doesn't handle nor cancel the action r?smaug When selection is collapsed and JoinBlocks() doesn't handle nor cancel the action, WillDeleteSelection() should move selection to the start/end of leftmost/rightmost editable leaf node and retry to handle the action again. For avoiding infinite loop, it checks if selected node is changed actually before calling itself again. MozReview-Commit-ID: GtEC4dim3r9
f4f8b12809b0dacca236dbadf2834ae3a9713022: Bug 1316302 part.5 Minimize variable scopes in HTMLEditRules::TryToJoinBlocks() r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 16 Nov 2016 13:08:50 +0900 - rev 439601
Push 36057 by masayuki@d-toybox.com at Wed, 16 Nov 2016 11:17:12 +0000
Bug 1316302 part.5 Minimize variable scopes in HTMLEditRules::TryToJoinBlocks() r?smaug Because of using early return style in HTMLEditRules::TryToJoinBlocks(), we can minimize the scope of EditActionResult variable in it. MozReview-Commit-ID: jXVolNw41a
e0ca6dba05d736c54b459f0ce1fc7fc00152f83c: Bug 1316302 part.4 Refine HTMLEditRules::TryToJoinBlocks() and HTMLEditRules::MoveNodeSmart() with early return style r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 16 Nov 2016 11:13:40 +0900 - rev 439600
Push 36057 by masayuki@d-toybox.com at Wed, 16 Nov 2016 11:17:12 +0000
Bug 1316302 part.4 Refine HTMLEditRules::TryToJoinBlocks() and HTMLEditRules::MoveNodeSmart() with early return style r?smaug MozReview-Commit-ID: 9vDoU9bUdVO
8af44a431ad4d0942fcb552a4db36ddbe8ca39f0: Bug 1316302 part.3 Create EditActionResult class for making the methods which return nsresult, handled and canceled with out params r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 16 Nov 2016 14:04:23 +0900 - rev 439599
Push 36057 by masayuki@d-toybox.com at Wed, 16 Nov 2016 11:17:12 +0000
Bug 1316302 part.3 Create EditActionResult class for making the methods which return nsresult, handled and canceled with out params r?smaug In a lot of places, edit action handlers and their helper methods return nsresult and aHandled and aCanceled with out params. However, the out params cause the code complicated since: * it's not unclear if the method will overwrite aHandled and aCanceled value. * callers need to create temporary variable event if some of them are not necessary. This patch rewrites the helper methods of HTMLEditRules::WillDeleteSelection() with it. MozReview-Commit-ID: CJv75KdOdXf
71091e4fc79d1659f5dcdff6a761c2580a7842a7: Bug 1316302 part.2 WillDeleteSelection() should retry to handle it when selection is collapsed and JoinBlocks() doesn't handle nor cancel the action r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 Nov 2016 18:40:32 +0900 - rev 439598
Push 36057 by masayuki@d-toybox.com at Wed, 16 Nov 2016 11:17:12 +0000
Bug 1316302 part.2 WillDeleteSelection() should retry to handle it when selection is collapsed and JoinBlocks() doesn't handle nor cancel the action r?smaug When selection is collapsed and JoinBlocks() doesn't handle nor cancel the action, WillDeleteSelection() should move selection to the start/end of leftmost/rightmost editable leaf node and retry to handle the action again. For avoiding infinite loop, it checks if selected node is changed actually before calling itself again. MozReview-Commit-ID: GtEC4dim3r9
d201b4136a52f28cfc3f37fcbbb545c6a6fab99c: Bug 1316302 part.1 Helper methods for HTMLEditRules::WillDeleteSelection() should have an out argument to indicates if it actually handles the action r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 15 Nov 2016 18:27:24 +0900 - rev 439597
Push 36057 by masayuki@d-toybox.com at Wed, 16 Nov 2016 11:17:12 +0000
Bug 1316302 part.1 Helper methods for HTMLEditRules::WillDeleteSelection() should have an out argument to indicates if it actually handles the action r?smaug When HTMLEditRules::WillDeleteSelection() tries to remove something from the end/start of a block to its last/first text node but it's contained by block elements, it tries to join the container and the block. However, JoinBlocks() always fails to join them since it's impossible operation. In this case, HTMLEditRules::WillDeleteSelection() should retry to remove something in the leaf, however, it's impossible for now because JoinBlocks() and its helper methods don't return if it handles the action actually. This patch renames |JoinBlocks()| to |TryToJoinBlocks()| for representing what it is. And this patch adds |bool* aHandled| to the helper methods. Then, *aHandled and *aCancel are now always returns the result of each method. Therefore, for merging the result of multiple helper methods, callers need to receive the result with temporary variables and merge them by themselves. Note that when they modify DOM node actually or the action should do nothing (for example, selection is across tables), aHandled is set to true. MozReview-Commit-ID: 7ApUOgtLUog
42f705a3800d626012c9235cdecbe2def80646a9: Bug 1315152 - Temporarily change "Test PKCS11 Slot" in pkcs11testmodule.cpp to get MSVC builds working again on non-Western environments. draft
Cykesiopka <cykesiopka.bmo@gmail.com> - Mon, 07 Nov 2016 20:59:17 +0900 - rev 439596
Push 36057 by masayuki@d-toybox.com at Wed, 16 Nov 2016 11:17:12 +0000
Bug 1315152 - Temporarily change "Test PKCS11 Slot" in pkcs11testmodule.cpp to get MSVC builds working again on non-Western environments. MozReview-Commit-ID: LMHLQmRbfHo
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip