37a812ddbddcdfe3914dbff0d4c782d69f967ba4: Bug 1430841 Refactor ReduceTimePrecision and add (failing) gtests r?bkelly draft
Tom Ritter <tom@mozilla.com> - Thu, 25 Jan 2018 13:29:37 -0600 - rev 748506
Push 97192 by bmo:tom@mozilla.com at Mon, 29 Jan 2018 22:46:52 +0000
Bug 1430841 Refactor ReduceTimePrecision and add (failing) gtests r?bkelly This commit adds a gtest calling ReduceTimePrecision that illustrates several failing test cases from float fuzziness, as well as generating a ton of test cases at random that also fail. MozReview-Commit-ID: Epia5gm5Ahb
17d3681d2d580086eb4f8c224571f9b10eae6419: Bug 1433019 - Dispatch scroll events before dispatching animation events. r?mstange,botond draft
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Tue, 30 Jan 2018 07:21:11 +0900 - rev 748505
Push 97191 by bmo:hikezoe@mozilla.com at Mon, 29 Jan 2018 22:41:32 +0000
Bug 1433019 - Dispatch scroll events before dispatching animation events. r?mstange,botond See 7.6. in the section '8.1.4.2 Processing model'; https://html.spec.whatwg.org/multipage/webappapis.html#processing-model-8 Note that this dispatching scroll events should be done after we process WillRefresh() for FlushType::Style observers since main-thread scroll animations is one of the FlushType::Style observers, that means it affects scroll events. Also test_scroll_event_ordering.html was modified to check scroll events happen before requestAnimationFrame callbacks. MozReview-Commit-ID: LuV157XoRkJ
5001484185a5dd0662151c9d0c8c05709b1d6bda: Bug 1411977 - Part 6: Don't unwind the stack when firing onsignalingstatechange. r?drno draft
Byron Campen [:bwc] <docfaraday@gmail.com> - Thu, 25 Jan 2018 10:09:17 -0600 - rev 748504
Push 97190 by bcampen@mozilla.com at Mon, 29 Jan 2018 22:41:18 +0000
Bug 1411977 - Part 6: Don't unwind the stack when firing onsignalingstatechange. r?drno MozReview-Commit-ID: 5qAlxKFzKQk
07bdde0c57c1effc5823aadbc68c39d90dd096ce: Bug 1411977 - Part 5: Don't pass a pointer to a temporary to NotifyDataChannel_m. r?drno draft
Byron Campen [:bwc] <docfaraday@gmail.com> - Thu, 25 Jan 2018 10:04:55 -0600 - rev 748503
Push 97190 by bcampen@mozilla.com at Mon, 29 Jan 2018 22:41:18 +0000
Bug 1411977 - Part 5: Don't pass a pointer to a temporary to NotifyDataChannel_m. r?drno MozReview-Commit-ID: 3ydeM9U1P4b
5e85c43884ed35648af92b08128ff6078099b083: Bug 1411977 - Part 4: Only try to dispatch the release of TransportLayers when there is a target thread. r?drno draft
Byron Campen [:bwc] <docfaraday@gmail.com> - Thu, 25 Jan 2018 09:55:12 -0600 - rev 748502
Push 97190 by bcampen@mozilla.com at Mon, 29 Jan 2018 22:41:18 +0000
Bug 1411977 - Part 4: Only try to dispatch the release of TransportLayers when there is a target thread. r?drno MozReview-Commit-ID: 8fOkZwcxKHy
4780c1c84e8e99b7a882cd952d56eda48f31b5a1: Bug 1411977 - Part 3: Clear the SingletonThreadHolder _after_ thread shutdowns are finished, not before they are started. r?drno draft
Byron Campen [:bwc] <docfaraday@gmail.com> - Thu, 25 Jan 2018 09:54:07 -0600 - rev 748501
Push 97190 by bcampen@mozilla.com at Mon, 29 Jan 2018 22:41:18 +0000
Bug 1411977 - Part 3: Clear the SingletonThreadHolder _after_ thread shutdowns are finished, not before they are started. r?drno MozReview-Commit-ID: Hgak51ReEOO
1948b816257188f5c71d8b9a44a6aad2aa8c6a57: Bug 1411977 - Part 2: Stop using sync dispatch and queue jumping with SingletonThreadHolder. r?drno draft
Byron Campen [:bwc] <docfaraday@gmail.com> - Thu, 25 Jan 2018 09:53:04 -0600 - rev 748500
Push 97190 by bcampen@mozilla.com at Mon, 29 Jan 2018 22:41:18 +0000
Bug 1411977 - Part 2: Stop using sync dispatch and queue jumping with SingletonThreadHolder. r?drno MozReview-Commit-ID: F2BbHI2kiK1
877716436601dc76d4135aaf1aeb9708812840b9: Bug 1428182 - 10. Add <malloc.h> include in pixman patch; r=lsalzman draft
Jim Chen <nchen@mozilla.com> - Mon, 29 Jan 2018 17:38:17 -0500 - rev 748499
Push 97189 by bmo:nchen@mozilla.com at Mon, 29 Jan 2018 22:39:03 +0000
Bug 1428182 - 10. Add <malloc.h> include in pixman patch; r=lsalzman pixman-8888-over-565.patch added a call to free(), which is apparently not included by the other headers when using the new NDK headers. MozReview-Commit-ID: 9fAuSano36N
194f107319a1cfb4d71372ce8a8b4dade9266efa: Bug 1428182 - 9. Apply Skia upstream commit to support NDK r16; r=lsalzman draft
Jim Chen <nchen@mozilla.com> - Mon, 29 Jan 2018 17:38:15 -0500 - rev 748498
Push 97189 by bmo:nchen@mozilla.com at Mon, 29 Jan 2018 22:39:03 +0000
Bug 1428182 - 9. Apply Skia upstream commit to support NDK r16; r=lsalzman Apply Skia upstream commit 592c225b03ca677a1217eabdbc38eede6afcdb14 to support building with NDK r16. MozReview-Commit-ID: B6popOoPTni
f46a84704c838db2e83e5adfdde68d5e6df1b20e: Bug 1428182 - 8. Don't redefine keycodes when using unified headers; r=esawin draft
Jim Chen <nchen@mozilla.com> - Mon, 29 Jan 2018 17:38:14 -0500 - rev 748497
Push 97189 by bmo:nchen@mozilla.com at Mon, 29 Jan 2018 22:39:03 +0000
Bug 1428182 - 8. Don't redefine keycodes when using unified headers; r=esawin The unified headers already define the keycodes in GeckoEditableSupport.cpp, so only define them ourselves when not using unified headers (by checking the __ANDROID_API_X__ macros). MozReview-Commit-ID: 3Ptakcm0rW
4d100e48de106d2d4de8eca2c94a8ef7849d0460: Bug 1428182 - 7. Include <link.h> in LUL for Android; r=jseward draft
Jim Chen <nchen@mozilla.com> - Mon, 29 Jan 2018 17:38:14 -0500 - rev 748496
Push 97189 by bmo:nchen@mozilla.com at Mon, 29 Jan 2018 22:39:03 +0000
Bug 1428182 - 7. Include <link.h> in LUL for Android; r=jseward Modern NDK headers all have <link.h>, so we should always include it, and still provide shims for anything we need that's not defined in <link.h>. MozReview-Commit-ID: GNBDIe73RFm
95624ed9ee1411020d8ae4aa765f028fcab628d3: Bug 1428182 - 6b. Support unified headers in Breakpad code; r=ted draft
Jim Chen <nchen@mozilla.com> - Mon, 29 Jan 2018 17:38:14 -0500 - rev 748495
Push 97189 by bmo:nchen@mozilla.com at Mon, 29 Jan 2018 22:39:03 +0000
Bug 1428182 - 6b. Support unified headers in Breakpad code; r=ted Fix several problems when building Breakpad with new NDK unified headers. - Unified headers define its own tgkill wrapper, so rename our own wrapper to __tgkill. - Unified headers define user_fpxregs_struct for all API levels, so don't redefine it. - Only the target sources under google-breakpad/src/common/linux should use custom Android headers, so change the includes line in moz.build to use OS_INCLUDES. MozReview-Commit-ID: HGnUMu5vDUM
634472be15d5382b754a00c8985db638a8734984: Bug 1428182 - 6a. Apply Breakpad upstream commit for building with NDK r16; r=ted draft
Jim Chen <nchen@mozilla.com> - Mon, 29 Jan 2018 17:38:14 -0500 - rev 748494
Push 97189 by bmo:nchen@mozilla.com at Mon, 29 Jan 2018 22:39:03 +0000
Bug 1428182 - 6a. Apply Breakpad upstream commit for building with NDK r16; r=ted Apply commit afa9c52715db1e4bfaa4b01c9aec40cc249b689b from the Breakpad upstream to support building with NDK r16. MozReview-Commit-ID: D6xafYkjhjt
0a2bbab838c053f6e1e5d20c799ea25246dd78d1: Bug 1428182 - 5. Update libevent patch for Android builds; r=nfroyd draft
Jim Chen <nchen@mozilla.com> - Mon, 29 Jan 2018 17:38:13 -0500 - rev 748493
Push 97189 by bmo:nchen@mozilla.com at Mon, 29 Jan 2018 22:39:03 +0000
Bug 1428182 - 5. Update libevent patch for Android builds; r=nfroyd Support for accept4 and arc4random_buf depends on which set of NDK headers we're using. accept4 is supported for API >= 21 for unified and non-unified headers. arc4random_buf is supported for API >= 21 if using non-unified headers, and it's always supported if using unified headers (the unified headers provide shims for API < 21). MozReview-Commit-ID: FY8n5jWXB1K
e029eec173f00d2d9afb810f18767beebd485d6d: Bug 1428182 - 4. Fix a gfx warning; r=jchen draft
Jim Chen <nchen@mozilla.com> - Mon, 29 Jan 2018 17:38:13 -0500 - rev 748492
Push 97189 by bmo:nchen@mozilla.com at Mon, 29 Jan 2018 22:39:03 +0000
Bug 1428182 - 4. Fix a gfx warning; r=jchen MozReview-Commit-ID: L5NclHmqCE2
43b3fa15042246d2c3ec37a3ca904822b0f68d0c: Bug 1428182 - 3. Only include <linux/elf.h> for non-unified headers; r=glandium draft
Jim Chen <nchen@mozilla.com> - Mon, 29 Jan 2018 17:38:13 -0500 - rev 748491
Push 97189 by bmo:nchen@mozilla.com at Mon, 29 Jan 2018 22:39:03 +0000
Bug 1428182 - 3. Only include <linux/elf.h> for non-unified headers; r=glandium Unified headers have a complete <elf.h> so we should include that instead of <linux/elf.h>. MozReview-Commit-ID: DkQv2vk1Q62
147e4be9eb98326fd4946b7b3695c573c7108347: Bug 1428182 - 2. Check both quota.h and quotactl(); r=glandium draft
Jim Chen <nchen@mozilla.com> - Mon, 29 Jan 2018 17:38:13 -0500 - rev 748490
Push 97189 by bmo:nchen@mozilla.com at Mon, 29 Jan 2018 22:39:03 +0000
Bug 1428182 - 2. Check both quota.h and quotactl(); r=glandium Android headers can have a <sys/quota.h> header but with its functions ifdef'ed out. Check for that by checking for the presence of quotactl(). MozReview-Commit-ID: 26ILnbP7flO
36c9d4d5625fecbbe2485668811f85f9d94372d5: Bug 1428182 - 1. Support unified headers for Android builds; r=nalexander draft
Jim Chen <nchen@mozilla.com> - Mon, 29 Jan 2018 17:38:11 -0500 - rev 748489
Push 97189 by bmo:nchen@mozilla.com at Mon, 29 Jan 2018 22:39:03 +0000
Bug 1428182 - 1. Support unified headers for Android builds; r=nalexander NDK headers are grouped into a "sysroot" directory, which doesn't contain architecture-specific bits, and a "system" directory, which contains only the architecture-specific bits. Previously, both directories are the same, under platforms/android-*/arch-*/. However, with unified headers in NDK r16, the two are different, so we need to support that in the Android build scripts. Unified headers also rely on the build system defining the __ANDROID_API__ macro, so we add support for that as well. MozReview-Commit-ID: 9zBNQC3BRFl
8b4431c06c622eecc2daa2e044b4c98f8aaf154e: Bug 1433971 Clean up Assertions.h with respect to Unused Attributes r?froydnj draft
Tom Ritter <tom@mozilla.com> - Mon, 29 Jan 2018 11:36:19 -0600 - rev 748488
Push 97188 by bmo:tom@mozilla.com at Mon, 29 Jan 2018 22:38:59 +0000
Bug 1433971 Clean up Assertions.h with respect to Unused Attributes r?froydnj In Bug 1393538 I renamed MOZ_STATIC_ASSERT_UNUSED_ATTRIBUTE to MOZ_UNUSED_ATTRIBUTE, moved it out of it's #define depth, and used it in toolkit. I also orphaned a comment. This was wrong. MOZ_UNUSED_ATTRIBUTE was basically identical to MOZ_MAYBE_UNUSED which exists in Attributes.h (because it is an attribute, not an assertion.) Undo that wrong thing: restore MOZ_STATIC_ASSERT_UNUSED_ATTRIBUTE to the correct place, have toolkit use the correct macro, and remove MOZ_UNUSED_ATTRIBUTE. MozReview-Commit-ID: 5BWWsXgbm9i
99438c556c52dd2f225c6816cc20cef78b84a93f: Bug 1434078 - Devices actions links touch-ups. r?markh draft
Edouard Oger <eoger@fastmail.com> - Mon, 29 Jan 2018 17:11:16 -0500 - rev 748487
Push 97187 by bmo:eoger@fastmail.com at Mon, 29 Jan 2018 22:12:20 +0000
Bug 1434078 - Devices actions links touch-ups. r?markh MozReview-Commit-ID: I0q915ku8o8
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip