37648290cd9cb34c20c57932a3c45c391a553bfd: Bug 1328553 - Part 2: Add a netmonitor.requestsFinished timing to DAMP tests r?jryans
draft
Jarda Snajdr <jsnajdr@gmail.com> - Wed, 04 Jan 2017 11:15:12 +0100 - rev 457116
Push
40672 by bmo:jsnajdr@gmail.com at Fri, 06 Jan 2017 19:06:03 +0000
Bug 1328553 - Part 2: Add a netmonitor.requestsFinished timing to DAMP tests r?jryans
MozReview-Commit-ID: 1v7yIUfEwan
9bf62e95982d5f063af0e285b0bd11ced2200c38: Bug 1325277 - Re-enable leak checking for dom/animation/test/css-animations. r=ahal
draft
Andrew McCreight <continuation@gmail.com> - Fri, 06 Jan 2017 11:04:41 -0800 - rev 457115
Push
40671 by bmo:continuation@gmail.com at Fri, 06 Jan 2017 19:05:13 +0000
Bug 1325277 - Re-enable leak checking for dom/animation/test/css-animations. r=ahal
MozReview-Commit-ID: LSlEw5tCcTx
d484f276e04cde8df95d47b4e15349e052fc32fb: Bug 1326534 - Rename sessionCapabilities variable for brevity; r?whimboo
draft
Andreas Tolfsen <ato@mozilla.com> - Sat, 31 Dec 2016 12:32:14 +0000 - rev 457114
Push
40670 by bmo:ato@mozilla.com at Fri, 06 Jan 2017 18:52:13 +0000
Bug 1326534 - Rename sessionCapabilities variable for brevity; r?whimboo
MozReview-Commit-ID: KGYk2CgwERy
e20cb12a7ac34fd98855ad71eae78d0919a249d6: Bug 1326534 - Use session.Capabilities representation in listener; r?whimboo
draft
Andreas Tolfsen <ato@mozilla.com> - Sat, 31 Dec 2016 12:30:49 +0000 - rev 457113
Push
40670 by bmo:ato@mozilla.com at Fri, 06 Jan 2017 18:52:13 +0000
Bug 1326534 - Use session.Capabilities representation in listener; r?whimboo
Capabilities are sent to the content frame script as a JSON blob.
We can re-parse that in the listener to make use of the same complex
object representation there.
Because the listener is comprised of a set of top-level functions and
not an object prototype, we cannot reuse the same pointer/getter trick
as in testing/marionette/driver.js. However, we can change this later
when we do introduce more robust code organisation to this file.
MozReview-Commit-ID: 7PpholLqtF
6c6c9d713b6bbc60aa7ab498f92a1f88b691f252: Bug 1326534 - Reset session capabilities state on teardown; r?whimboo
draft
Andreas Tolfsen <ato@mozilla.com> - Sat, 31 Dec 2016 12:28:19 +0000 - rev 457112
Push
40670 by bmo:ato@mozilla.com at Fri, 06 Jan 2017 18:52:13 +0000
Bug 1326534 - Reset session capabilities state on teardown; r?whimboo
This change resets the session ID after all other state has been cleared,
and also reinitialises `GeckoDriver#sessionCapabilities`, which was not
done before.
MozReview-Commit-ID: Jb40CXuX8h1
0ab1430892e3fa4fbca53bf5b1cd65e88f481e1a: Bug 1326534 - Deploy WebDriver conforming capabilities in Marionette; r?automatedtester,whimboo,maja_zf
draft
Andreas Tolfsen <ato@mozilla.com> - Sat, 31 Dec 2016 12:27:13 +0000 - rev 457111
Push
40670 by bmo:ato@mozilla.com at Fri, 06 Jan 2017 18:52:13 +0000
Bug 1326534 - Deploy WebDriver conforming capabilities in Marionette; r?automatedtester,whimboo,maja_zf
This change removes session capability processing
from testing/marionette/driver.js and replaces it with
testing/marionette/session.js and `session.Capabilities`.
Session timeout durations used to be stored in properties
exposed directly on the `GeckoDriver` prototype, but these are now
represented by `GeckoDriver#timeouts`, which is a pointer (getter) of
`GeckoDriver#sessionCapabilities#timeouts`. The same is true for other
session-scoped state.
Since capabilities parsing is not unique to starting a new session,
the errors thrown by `session.Capabilities.fromJSON` are re-thrown
in `GeckoDriver#newSession` since it is required that we return a
`SessionNotCreatedError` on parsing them during session creation.
MozReview-Commit-ID: I3Xu2v71n4S
204c99867038c12b6064662c93dc01b4107dff57: Bug 1326534 - Rewrite capabilities parsing in Marionette; r?automatedtester
draft
Andreas Tolfsen <ato@mozilla.com> - Sat, 31 Dec 2016 12:21:34 +0000 - rev 457110
Push
40670 by bmo:ato@mozilla.com at Fri, 06 Jan 2017 18:52:13 +0000
Bug 1326534 - Rewrite capabilities parsing in Marionette; r?automatedtester
This patch provides a (nearly) WebDriver conforming implementation
of capabilities in Marionette. The work remaining is pending further
clarification in the specification.
Capabilities are represented internally as a complex object provided
by `session.Capabilities`. Timeouts and proxy configuration are also
represented by the similar complex objects `session.Timeouts` and
`session.Proxy`, respectively.
The capabilities stored in `GeckoDriver#sessionCapabilities` are the
result of parsing user-provided desired- and required capabilities.
WebDriver now uses `firstMatch` and `alwaysMatch` primitives for
capabilities, but as this is considered a wider breaking change, the
move to these primitives will be done at a later stage. It’s prudent
to point out that the base techniques used with the new primitives
are similar to those implemented for `desiredCapabilities` and
`requiredCapabilities` in this patch, and that the work needed to adapt
them is considered trivial.
When capabilities are presented back to the user (the so called processed
capabilities), we call the `toJSON` implementation on the complex objects.
`session.Capabilities#toJSON` calls the internal function `marshal`
which ensures empty fields are dropped. `marshal` can be considered to
be a specialisation of the standard library `JSON.stringify`, which also
calls `toJSON` on entry values if they provide this function.
The changeset overall also provides a much deeper level of testing of
WebDriver capabilities.
MozReview-Commit-ID: 97xGt3cnMys
b32ee8408ad9a1870964e2ee6447873e9d15ee45: Bug 1326534 - Correct capability wrapping in tests; r?automatedtester
draft
Andreas Tolfsen <ato@mozilla.com> - Fri, 30 Dec 2016 14:12:53 +0000 - rev 457109
Push
40670 by bmo:ato@mozilla.com at Fri, 06 Jan 2017 18:52:13 +0000
Bug 1326534 - Correct capability wrapping in tests; r?automatedtester
Capabilities should be sent in either a `desiredCapabilities` or a
`requiredCapabilities` block inside `capabilities`:
{capabilities: {requiredCapabilities: {acceptInsecureCerts: true}}}
Marionette currently accepts capabilities in the top-level dictionary,
but this is not conforming to the WebDriver.
MozReview-Commit-ID: 9JWjvPKBp6S
f0695008e305a756c83a25156b9c0f25c9341f4e: Bug 1326534 - Propagate stacktraces for WebDriver errors; r?automatedtester
draft
Andreas Tolfsen <ato@mozilla.com> - Fri, 30 Dec 2016 13:07:54 +0000 - rev 457108
Push
40670 by bmo:ato@mozilla.com at Fri, 06 Jan 2017 18:52:13 +0000
Bug 1326534 - Propagate stacktraces for WebDriver errors; r?automatedtester
When we currently create new WebDriver errors we throw away the stacktrace
generated by `WebDriverError`'s prototype, `Error`. This change stores
the stacktrace, which will cause it to be serialised and returned to
the client.
This change is not as valuable as storing the stacktraces of internal
errors, but brings symmetry to our error handling and may be useful if
only to navigate to the source of an error.
MozReview-Commit-ID: LCFMwKxxcTp
a7a82945a3e3e086c884c4499ac7570b50d4a828: Bug 1326534 - Lint a few statements in driver.js; r?automatedtester
draft
Andreas Tolfsen <ato@mozilla.com> - Fri, 30 Dec 2016 12:43:36 +0000 - rev 457107
Push
40670 by bmo:ato@mozilla.com at Fri, 06 Jan 2017 18:52:13 +0000
Bug 1326534 - Lint a few statements in driver.js; r?automatedtester
No functional changes.
MozReview-Commit-ID: FP9p9tPr8Ce
36ea2874be623e6b69a717d636cda327d1f55dd6: Bug 1326534 - Add assert.in for own properties; r?automatedtester
draft
Andreas Tolfsen <ato@mozilla.com> - Fri, 30 Dec 2016 11:39:22 +0000 - rev 457106
Push
40670 by bmo:ato@mozilla.com at Fri, 06 Jan 2017 18:52:13 +0000
Bug 1326534 - Add assert.in for own properties; r?automatedtester
The implementation of the new library function `assert.in` is analogous
to Python's `unittest.TestCase.assertIn`.
MozReview-Commit-ID: 1pjS9ttPXgo
64ac13861b524c0d85a9a384f663df899a8d9548: Bug 1326534 - Add test for assert.array; r?automatedtester
draft
Andreas Tolfsen <ato@mozilla.com> - Fri, 30 Dec 2016 11:30:05 +0000 - rev 457105
Push
40670 by bmo:ato@mozilla.com at Fri, 06 Jan 2017 18:52:13 +0000
Bug 1326534 - Add test for assert.array; r?automatedtester
MozReview-Commit-ID: IWUnhCgPp1R
a2cb1121cf3dbc430d1bc9c83856cc5ac090958a: Bug 1326534 - Preserve stacks when passing error protos to WebDriverError; r?automatedtester
draft
Andreas Tolfsen <ato@mozilla.com> - Fri, 30 Dec 2016 11:26:30 +0000 - rev 457104
Push
40670 by bmo:ato@mozilla.com at Fri, 06 Jan 2017 18:52:13 +0000
Bug 1326534 - Preserve stacks when passing error protos to WebDriverError; r?automatedtester
The `stack` argument to `WebDriverError` has never been in use. Following
the API of the `Error` prototype, this changes its constructor to take
one argument which can either be a string of an `Error`.
When internal errors are thrown in Marionette, they are usually
wrapped in `WebDriverError` but we currently lose track of its stack.
This preserves the wrapped error's stacktrace by setting the `stack`
property. Practice have found that they are very useful to return to
the client, as they are currently only printed to stdout.
MozReview-Commit-ID: 9sTdP4TntIc
7936520f03f7d8c69c352ae40ab04c54001a2957: Bug 1326534 - Exclude array and null from being counted as objects; r?automatedtester
draft
Andreas Tolfsen <ato@mozilla.com> - Fri, 30 Dec 2016 11:21:27 +0000 - rev 457103
Push
40670 by bmo:ato@mozilla.com at Fri, 06 Jan 2017 18:52:13 +0000
Bug 1326534 - Exclude array and null from being counted as objects; r?automatedtester
Calling `typeof` on arrays or null in JavaScript returns `"object"`,
and a safer check is to rely on `Object.prototype.toString`.
MozReview-Commit-ID: 5VxXf2ByoEx
4797e1c50cb55e5ba790d5f5f2c27f850f39920d: Bug 1326534 - Correct tests for mandated and supported capabilities; r?automatedtester
draft
Andreas Tolfsen <ato@mozilla.com> - Tue, 20 Dec 2016 15:01:18 +0000 - rev 457102
Push
40670 by bmo:ato@mozilla.com at Fri, 06 Jan 2017 18:52:13 +0000
Bug 1326534 - Correct tests for mandated and supported capabilities; r?automatedtester
MozReview-Commit-ID: 932AoNlBtwt
03ecac03153826248f24736f9620fc5d8edac29a: Bug 1328553 - Signed DAMP changes
draft
J. Ryan Stinnett <jryans@gmail.com> - Fri, 06 Jan 2017 12:38:08 -0600 - rev 457101
Push
40669 by bmo:jryans@gmail.com at Fri, 06 Jan 2017 18:38:47 +0000
Bug 1328553 - Signed DAMP changes
MozReview-Commit-ID: LADBIPiXlse
e3d96c7a07ebbd63e490c82f89e9697c6040344e: Bug 1294541 - Merged changesets. r?dao
draft
Vlad Traian Zuga <vladzuga@gmail.com> - Thu, 05 Jan 2017 23:08:15 +0200 - rev 457100
Push
40668 by bmo:vladzuga@gmail.com at Fri, 06 Jan 2017 18:05:19 +0000
Bug 1294541 - Merged changesets. r?dao
MozReview-Commit-ID: 7V2Wvb2TPe3
eda304c8b6f830ffc368fbec0225a3a03567689d: Bug 1286948 - onEnterFrame/onLeaveFrame wasm events and callstack. r?shu
draft
Yury Delendik <ydelendik@mozilla.com> - Fri, 06 Jan 2017 11:38:14 -0600 - rev 457099
Push
40667 by ydelendik@mozilla.com at Fri, 06 Jan 2017 17:41:01 +0000
Bug 1286948 - onEnterFrame/onLeaveFrame wasm events and callstack. r?shu
Handles onEnterFrame and onLeaveFrame trap handling. The FrameIter is used in
the DebuggerFrame instead of ScriptFrameIter. The debug wasm frame is created
and can be found on callstack during those event.
MozReview-Commit-ID: 8oyFkrINc0A
24256040660fa8de325cb15d5a37f8c6b23d9749: Bug 1286948 - Adds prolog and epilog debug traps and handlers. r?luke
draft
Yury Delendik <ydelendik@mozilla.com> - Fri, 06 Jan 2017 11:37:49 -0600 - rev 457098
Push
40667 by ydelendik@mozilla.com at Fri, 06 Jan 2017 17:41:01 +0000
Bug 1286948 - Adds prolog and epilog debug traps and handlers. r?luke
Using toggled call/traps to invoke handler to process enter and leave
frame events.
MozReview-Commit-ID: APTt3N6Zt0P
c50fe70405296e626919c8fd8a80933f19d55570: Bug 1286948 - Extends AbstractFramePtr to reference wasm::DebugFrame. r?shu, luke
draft
Yury Delendik <ydelendik@mozilla.com> - Fri, 06 Jan 2017 11:34:56 -0600 - rev 457097
Push
40667 by ydelendik@mozilla.com at Fri, 06 Jan 2017 17:41:01 +0000
Bug 1286948 - Extends AbstractFramePtr to reference wasm::DebugFrame. r?shu, luke
Debugger.cpp use FrameIter to walk the stack. Having extended AbstractFramePtr
helps with simulating wasm callstack as JS one.
MozReview-Commit-ID: 7zGWZp33sme