37410a9eeafc1b26322f3a24c401f5747ca2c3be: Bug 1433958 - Change code that sets nsIURI.scheme to use nsIURIMutator draft
Valentin Gosu <valentin.gosu@gmail.com> - Tue, 30 Jan 2018 00:53:56 +0100 - rev 748553
Push 97203 by valentin.gosu@gmail.com at Mon, 29 Jan 2018 23:59:17 +0000
Bug 1433958 - Change code that sets nsIURI.scheme to use nsIURIMutator MozReview-Commit-ID: 7RNbqE8OJut
2e865430c41ee01dd8ecad8cebc8c8c134915ec8: Bug 1433958 - If setting the host succeeds, SetHostPort should not return an error code draft
Valentin Gosu <valentin.gosu@gmail.com> - Tue, 30 Jan 2018 00:53:52 +0100 - rev 748552
Push 97203 by valentin.gosu@gmail.com at Mon, 29 Jan 2018 23:59:17 +0000
Bug 1433958 - If setting the host succeeds, SetHostPort should not return an error code WebPlatformTests expect that when calling url.host = "host:" // port missing url.host = "host:65536" // port too big url.host = "host:bla" // invalid port that the hostname will be set, but the port will be left unchanged. Since DOM APIs are the only consumers for SetHostPort it means we can change this behaviour to match the WPT expectations. As such, SetHostPort will return NS_OK if setting the host succeded, and will ignore if setting the port failed. MozReview-Commit-ID: LoMw8hCWlCv
02011c9e350d88e78275b19a99f70edd9b5c3403: Bug 1433958 - Change code that sets nsIURI.host to use nsIURIMutator draft
Valentin Gosu <valentin.gosu@gmail.com> - Tue, 30 Jan 2018 00:53:42 +0100 - rev 748551
Push 97203 by valentin.gosu@gmail.com at Mon, 29 Jan 2018 23:59:17 +0000
Bug 1433958 - Change code that sets nsIURI.host to use nsIURIMutator MozReview-Commit-ID: E4oUKt6LLhi
dfbad0067f10813f79948040f2977e09bd1cbe45: Bug 1433958 - Change code that sets nsIURI.port to use nsIURIMutator draft
Valentin Gosu <valentin.gosu@gmail.com> - Tue, 30 Jan 2018 00:51:57 +0100 - rev 748550
Push 97203 by valentin.gosu@gmail.com at Mon, 29 Jan 2018 23:59:17 +0000
Bug 1433958 - Change code that sets nsIURI.port to use nsIURIMutator MozReview-Commit-ID: 7Lu7JJvDUGF
461552e09f321419b2e55055bcf361b487700342: Bug 1433958 - Change code that sets nsIURI.query to use nsIURIMutator draft
Valentin Gosu <valentin.gosu@gmail.com> - Tue, 30 Jan 2018 00:51:54 +0100 - rev 748549
Push 97203 by valentin.gosu@gmail.com at Mon, 29 Jan 2018 23:59:17 +0000
Bug 1433958 - Change code that sets nsIURI.query to use nsIURIMutator MozReview-Commit-ID: JKW8IsaFY10
fef67c6e9ec5350322b85d16f52a158b8ba17862: Bug 1433958 - Change code that sets nsIURI.ref to use nsIURIMutator draft
Valentin Gosu <valentin.gosu@gmail.com> - Tue, 30 Jan 2018 00:51:50 +0100 - rev 748548
Push 97203 by valentin.gosu@gmail.com at Mon, 29 Jan 2018 23:59:17 +0000
Bug 1433958 - Change code that sets nsIURI.ref to use nsIURIMutator MozReview-Commit-ID: 4caicZFBkcQ
2f05088993c5c19bdf58fce505fcb639b305962c: Bug 1433958 - Don't fail when setting an empty password if the username is already empty draft
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 29 Jan 2018 21:41:16 +0100 - rev 748547
Push 97203 by valentin.gosu@gmail.com at Mon, 29 Jan 2018 23:59:17 +0000
Bug 1433958 - Don't fail when setting an empty password if the username is already empty We normally fail in nsStandardURL::SetPassword if the username is empty. But if the password we are trying to set is also empty, we should't really fail. MozReview-Commit-ID: FIDqkPrb1gp
16faede41c05a35859875b41059f257a9c312a55: Bug 1433958 - Change code that sets nsIURI.password to use nsIURIMutator draft
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 29 Jan 2018 21:41:10 +0100 - rev 748546
Push 97203 by valentin.gosu@gmail.com at Mon, 29 Jan 2018 23:59:17 +0000
Bug 1433958 - Change code that sets nsIURI.password to use nsIURIMutator MozReview-Commit-ID: I8igxClMM5L
68d3eccf4409a406a990564c020990ca8268b467: Bug 1433958 - Change code that sets nsIURI.username to use nsIURIMutator draft
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 29 Jan 2018 21:40:10 +0100 - rev 748545
Push 97203 by valentin.gosu@gmail.com at Mon, 29 Jan 2018 23:59:17 +0000
Bug 1433958 - Change code that sets nsIURI.username to use nsIURIMutator MozReview-Commit-ID: 7E63pAIOZCs
bb4ef19e8a51f25c064e5ad4fb9611fa1191a69a: Bug 1433958 - Change URLWorker to use NS_MutateURI draft
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 29 Jan 2018 21:38:48 +0100 - rev 748544
Push 97203 by valentin.gosu@gmail.com at Mon, 29 Jan 2018 23:59:17 +0000
Bug 1433958 - Change URLWorker to use NS_MutateURI * Also makes mStdURL be a nsCOMPtr<nsIURI> in order to avoid static_casts MozReview-Commit-ID: BagXxecHCSK
bfa702ac114199096148133f59c80ea391e86f10: Bug 1433958 - Change code that sets nsIURI.userPass to use nsIURIMutator draft
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 29 Jan 2018 21:37:20 +0100 - rev 748543
Push 97203 by valentin.gosu@gmail.com at Mon, 29 Jan 2018 23:59:17 +0000
Bug 1433958 - Change code that sets nsIURI.userPass to use nsIURIMutator MozReview-Commit-ID: 3cK5HeyzjFE
bd17d39f3f25685f5e0040b9526c4a3e99d24c17: Bug 1433958 - Change code that calls nsIURI.setQueryWithEncoding to use nsIURIMutator draft
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 29 Jan 2018 21:32:16 +0100 - rev 748542
Push 97203 by valentin.gosu@gmail.com at Mon, 29 Jan 2018 23:59:17 +0000
Bug 1433958 - Change code that calls nsIURI.setQueryWithEncoding to use nsIURIMutator MozReview-Commit-ID: crYLGLcsk6
2e4fadc7c5fa3e22608c12cd43542f238f740614: Bug 1433958 - Change code that sets nsIURI.filePath to use nsIURIMutator draft
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 29 Jan 2018 21:32:01 +0100 - rev 748541
Push 97203 by valentin.gosu@gmail.com at Mon, 29 Jan 2018 23:59:17 +0000
Bug 1433958 - Change code that sets nsIURI.filePath to use nsIURIMutator MozReview-Commit-ID: GYHpakKPEbe
2c48abccce99cc6071fe9dc046b12ab02c70288d: Bug 1433958 - Change code that sets nsIURI.pathQueryRef to use nsIURIMutator draft
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 29 Jan 2018 21:31:24 +0100 - rev 748540
Push 97203 by valentin.gosu@gmail.com at Mon, 29 Jan 2018 23:59:17 +0000
Bug 1433958 - Change code that sets nsIURI.pathQueryRef to use nsIURIMutator MozReview-Commit-ID: HVyZ3E1XuLN
f02c208be23c82f00595040ba20bf146e7ddd980: Bug 1433958 - Make NS_MutateURI methods warn immediately after calling method that fails draft
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 29 Jan 2018 21:31:18 +0100 - rev 748539
Push 97203 by valentin.gosu@gmail.com at Mon, 29 Jan 2018 23:59:17 +0000
Bug 1433958 - Make NS_MutateURI methods warn immediately after calling method that fails Calling NS_ENSURE_SUCCESS at the begining of the methods shows the error in the console, but what we really care about is where the error code comes from. So it is best to use if (NS_FAILED(mStatus) {} at the begining of the methods, and NS_ENSURE_SUCCESS right after calling the appropriate method on mMutator. MozReview-Commit-ID: 5vVuHk3N4FU
d80b821b23fb2339857d4e9a63eb79e65e30692f: Bug 1433958 - Change code that uses nsIURI.setHostAndPort() to use nsIURIMutator draft
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 29 Jan 2018 21:31:09 +0100 - rev 748538
Push 97203 by valentin.gosu@gmail.com at Mon, 29 Jan 2018 23:59:17 +0000
Bug 1433958 - Change code that uses nsIURI.setHostAndPort() to use nsIURIMutator * Removes setHostAndPort from nsIURIMutator as it only has one use * Instead, the consumer sets the port to -1 before calling setHostPort() MozReview-Commit-ID: Jx9UMW440hq
980ed80ecc236ca3e9482d0f4b972eb4b7fc67d9: Bug 1433958 - Change code that uses nsIURI.hostPort to use nsIURIMutator draft
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 29 Jan 2018 21:31:02 +0100 - rev 748537
Push 97203 by valentin.gosu@gmail.com at Mon, 29 Jan 2018 23:59:17 +0000
Bug 1433958 - Change code that uses nsIURI.hostPort to use nsIURIMutator MozReview-Commit-ID: IuUurzUP5Rw
80d2e6a5b08a24366dd9ea4813108b6e7e60d1ed: Bug 1432519 - Make nsIURL attributes readonly draft
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 29 Jan 2018 21:23:29 +0100 - rev 748536
Push 97203 by valentin.gosu@gmail.com at Mon, 29 Jan 2018 23:59:17 +0000
Bug 1432519 - Make nsIURL attributes readonly MozReview-Commit-ID: KuPILT7rX6N
0227375b034f80f406b23a416c6733e26499708b: Bug 1432257 - Remove nsIStandardURL setter methods draft
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 29 Jan 2018 21:23:23 +0100 - rev 748535
Push 97203 by valentin.gosu@gmail.com at Mon, 29 Jan 2018 23:59:17 +0000
Bug 1432257 - Remove nsIStandardURL setter methods * Removes nsIStandardURL.{init,setDefaultPort} as these have been migrated to nsIStandardURLMutator MozReview-Commit-ID: 7JPZmyEr65h
afeaf4c4babf4723ee046b07bb47d04424d09166: Bug 1432620 - Make nsIMozIconURI attributes readonly draft
Valentin Gosu <valentin.gosu@gmail.com> - Mon, 29 Jan 2018 21:23:15 +0100 - rev 748534
Push 97203 by valentin.gosu@gmail.com at Mon, 29 Jan 2018 23:59:17 +0000
Bug 1432620 - Make nsIMozIconURI attributes readonly MozReview-Commit-ID: LLSjC2fBa4x
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip