36bf901845b9ac084a5bd9d6de73b727f5bb3a11: testing: don't create pushlog Kafka topic
Gregory Szorc <gps@mozilla.com> - Fri, 08 Jan 2016 14:33:03 -0800 - rev 362079
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
testing: don't create pushlog Kafka topic It isn't used. It just adds overhead.
04fe92f9ec0c4dec280b5bb9cf06c0778bebe000: mozreview: test security of ldap assocations (Bug 1237702). r=gps
Steven MacLeod <smacleod@mozilla.com> - Thu, 07 Jan 2016 14:14:59 -0500 - rev 362078
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: test security of ldap assocations (Bug 1237702). r=gps https://reviewboard.mozilla.org/r/28445 reminded me we don't actually have tests that make sure random users cannot change ldap associations. I've added tests for an unprivileged user changing their own ldap association, an unprivileged user changing another users association, and a test for changing ldap association without authenticating.
96657fb045a9a38fa63342d249c02315d50a0575: mozreview: update model when adding reviewers to trigger draft banner display (bug 1236999); r=smacleod
Gregory Szorc <gps@mozilla.com> - Wed, 06 Jan 2016 13:04:54 -0800 - rev 362077
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: update model when adding reviewers to trigger draft banner display (bug 1236999); r=smacleod Review Board 2.5 added a check in the review request view's showBanner() that this.model.get('hasDraft') is true. For reasons I don't fully understand, the model isn't getting refreshed when we set a draft field on it. This patch sets the hasDraft attribute manually. I think ideally we'd refresh the view's model instance, but I'm not sure how to do that.
fba5aff085482be39febe8f7b851eb2bc1a853e7: firefoxtree: don't track try repos (bug 1237339); r=dminor
Gregory Szorc <gps@mozilla.com> - Wed, 06 Jan 2016 10:48:21 -0800 - rev 362076
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
firefoxtree: don't track try repos (bug 1237339); r=dminor It doesn't make sense to track remote refs for try repos. Filter try repos from the repos list when reading and writing the file and when updating remote refs.
de4852e08d137ebc2a908e993e774a0267ac20c2: firefoxtree: check for attribute presence properly
Gregory Szorc <gps@mozilla.com> - Wed, 06 Jan 2016 10:39:46 -0800 - rev 362075
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
firefoxtree: check for attribute presence properly If the attribute is an empty dict "not" will be True. Derp.
be629f390dcecf7f7f9851564bffdbc4ec3e4a2e: mozreview: only post diffset comment if diffset changes (bug 1229789) r=mcote
Dan Minor <dminor@mozilla.com> - Mon, 04 Jan 2016 11:57:11 -0500 - rev 362074
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: only post diffset comment if diffset changes (bug 1229789) r=mcote Currently we post a comment everytime we update bugzilla. This ends up causing problems such as posting incorrect links to diffsets when reviewers are added manually. Instead, we check if the draft contains a new diffset and only generate a new comment if it does.
01efb008d1f2d3c76c61d654de808348bb6be38f: Bug 1236857 - Fix valid_revision function + release pushlog_client 0.3.2. r=armenzg
MikeLing <sabergeass@gmail.com> - Wed, 06 Jan 2016 08:50:21 -0500 - rev 362073
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
Bug 1236857 - Fix valid_revision function + release pushlog_client 0.3.2. r=armenzg
30dab86c2248f9e9438e0248bb76bc67280b1d39: mozreview: change password of privileged mozreview account
Gregory Szorc <gps@mozilla.com> - Tue, 05 Jan 2016 17:33:23 -0800 - rev 362072
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: change password of privileged mozreview account Let's not use the same password everywhere. This exposes us to bugs around using the wrong accounts in tests.
2f4d7c427eb986bb2c7b015057c626fcd8338f38: mozreview: unauthenticated users can search now (bug 1237105); r=smacleod
Gregory Szorc <gps@mozilla.com> - Tue, 05 Jan 2016 16:08:03 -0800 - rev 362071
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: unauthenticated users can search now (bug 1237105); r=smacleod ReviewBoard 2.5 swallows exceptions in auth backends. This is a change in behavior from 2.0. smacleod says the old behavior may get restored for a future release of 2.5. For now, update the test output so tests pass.
687901fbd7719679c9d5cc9a01cb0d8e0926608e: ansible/hg-reviewboard: block AhrefsBot via User-Agent
Gregory Szorc <gps@mozilla.com> - Tue, 05 Jan 2016 15:51:08 -0800 - rev 362070
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
ansible/hg-reviewboard: block AhrefsBot via User-Agent It has been hammering the server using dozens of IP addresses.
ae826dd424eba5fcd8f6ec26353e96ecc3183166: docs: remove ancient paragraph about replication
Gregory Szorc <gps@mozilla.com> - Tue, 05 Jan 2016 14:32:32 -0800 - rev 362069
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
docs: remove ancient paragraph about replication
3d8fdbfea78aeb70db88a9fe3309908824a063df: vcsreplicator: fixup errant #
Gregory Szorc <gps@mozilla.com> - Tue, 05 Jan 2016 14:21:17 -0800 - rev 362068
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
vcsreplicator: fixup errant #
0aee001565c8e8112898249017e4c8f526d11456: docs: document modern replication mechanisms
Gregory Szorc <gps@mozilla.com> - Tue, 05 Jan 2016 10:59:54 -0800 - rev 362067
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
docs: document modern replication mechanisms
fd5d34a50a45972919e8ace0cbf7e8eae50b6b62: ansible/hg-ssh: merge hgrc-vcsreplicator into hgrc (bug 1126153); r=smacleod
Gregory Szorc <gps@mozilla.com> - Tue, 05 Jan 2016 14:14:58 -0800 - rev 362066
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
ansible/hg-ssh: merge hgrc-vcsreplicator into hgrc (bug 1126153); r=smacleod vcsreplicator is no longer optional. There is no good reason to have the config exist in a separate file. Put everything in the main hgrc file. Blackbox logging output changed slightly due to the order extensions are loaded.
954c87148af9b9b6d612fa73dc11da919beaffc2: ansible/hg-ssh: convert hgrc to a template (bug 1126153); r=smacleod
Gregory Szorc <gps@mozilla.com> - Tue, 05 Jan 2016 14:14:00 -0800 - rev 362065
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
ansible/hg-ssh: convert hgrc to a template (bug 1126153); r=smacleod We'll be merging hgrc-vcsreplicator into hgrc and this requires it being a template.
96a798e859cd171721c02930b725841e11d4d200: hgserver: inline do_repo_push; r=smacleod
Gregory Szorc <gps@mozilla.com> - Tue, 05 Jan 2016 14:13:47 -0800 - rev 362064
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
hgserver: inline do_repo_push; r=smacleod We only have one consumer of this function now. Inline it and drop a note to implement similar functionality in vcsreplicator.
71d2509445b53550bb3f4da3b742d46d0bb2c90b: hgserver: don't explicitly replicate when creating empty user repo (bug 1126153); r=smacleod
Gregory Szorc <gps@mozilla.com> - Tue, 05 Jan 2016 14:13:36 -0800 - rev 362063
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
hgserver: don't explicitly replicate when creating empty user repo (bug 1126153); r=smacleod `hg init` will send a replication message automatically. There is no need to call into the legacy replication system to initiate the replication.
5478db0f544849ca5ea3f268877ca1d3eea7788e: hgserver: replicate cloning via vcsreplicator (bug 1126153); r=smacleod
Gregory Szorc <gps@mozilla.com> - Tue, 05 Jan 2016 14:13:24 -0800 - rev 362062
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
hgserver: replicate cloning via vcsreplicator (bug 1126153); r=smacleod vcsreplicator doesn't currently intercept `hg clone` commands and automatically generate replication events (it arguably should). So, change how repository cloning is performed from `hg clone` to `hg init` + `hg pull` + `hg replicatesync` so replication events are written accordingly. Also add in explicit testing that hgweb machines replicated the clone, which was lacking before. This uncovered a bug in the lack of pash creating per-user WSGI files. (This is done as an hourly CRON on the servers to fill any gaps - but it should be done at repo creation time.)
47cda311bd29550eca5bad017eeadaa0c37790b5: hgserver: replicate hgrc changes via vcsreplicator (bug 1126153); r=smacleod
Gregory Szorc <gps@mozilla.com> - Tue, 05 Jan 2016 14:13:10 -0800 - rev 362061
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
hgserver: replicate hgrc changes via vcsreplicator (bug 1126153); r=smacleod Now that the new replication is enabled, we can integrate pash with it. Start by having pash record hgrc changes via the new replication system. The change adds explicit test coverage for hgrc content replication. Before, it only verified the SSH server had its config updated.
6bbefc64099255fa79fac79031ca25c65addee19: hghooks: remove legacy replication hook (bug 1126153); r=smacleod
Gregory Szorc <gps@mozilla.com> - Tue, 05 Jan 2016 14:12:53 -0800 - rev 362060
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
hghooks: remove legacy replication hook (bug 1126153); r=smacleod vcsreplicator is now handling replication. The legacy hook is no longer needed.
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip