33aaa6f4d275e509a273ce4c6092104f275d6dcc: Bug 1381876 - Allow assert_success to be used without an expected value. r?automatedtester draft
Andreas Tolfsen <ato@sny.no> - Tue, 01 Aug 2017 18:21:59 +0100 - rev 641120
Push 72440 by bmo:ato@sny.no at Sat, 05 Aug 2017 16:47:34 +0000
Bug 1381876 - Allow assert_success to be used without an expected value. r?automatedtester It happens that we receive responses that do not have a body value. We want to be able to use assert_success with these as well. MozReview-Commit-ID: B1f0Hn406Nj
e595943b24788062c938daef66a0c12b97a8f842: Bug 1381876 - Compare window rect, not window size. r?automatedtester draft
Andreas Tolfsen <ato@sny.no> - Tue, 01 Aug 2017 18:21:04 +0100 - rev 641119
Push 72440 by bmo:ato@sny.no at Sat, 05 Aug 2017 16:47:34 +0000
Bug 1381876 - Compare window rect, not window size. r?automatedtester The dictionary from Marionette#window_size is a subset of what is returned from Marionette#window_rect, causing the self.assertEqual to complain that they are not equal. We want to compare the same types. MozReview-Commit-ID: L4XTlgtUYKW
0a29b248a18040afcf375d27572abead12fd93e5: Bug 1381876 - Remove unused import from test_window_maximize.py. r?automatedtester draft
Andreas Tolfsen <ato@sny.no> - Tue, 01 Aug 2017 18:19:58 +0100 - rev 641118
Push 72440 by bmo:ato@sny.no at Sat, 05 Aug 2017 16:47:34 +0000
Bug 1381876 - Remove unused import from test_window_maximize.py. r?automatedtester MozReview-Commit-ID: 5C7ewMqY1iY
80f5c682e43dd854192fab3d494b129f31439c40: Bug 1381876 - Fix window maximised assertions. r?automatedtester draft
Andreas Tolfsen <ato@sny.no> - Tue, 01 Aug 2017 18:19:34 +0100 - rev 641117
Push 72440 by bmo:ato@sny.no at Sat, 05 Aug 2017 16:47:34 +0000
Bug 1381876 - Fix window maximised assertions. r?automatedtester The "delta" in the second assertion was not deducted from the height. The patch also improves the error message. MozReview-Commit-ID: 8u8UhKg3Q62
66db374659c9b940e5d86214206e69cca1b52d43: Bug 1381876 - Include window state in window rect. r?automatedtester draft
Andreas Tolfsen <ato@sny.no> - Tue, 01 Aug 2017 18:18:12 +0100 - rev 641116
Push 72440 by bmo:ato@sny.no at Sat, 05 Aug 2017 16:47:34 +0000
Bug 1381876 - Include window state in window rect. r?automatedtester The window state was included for only some of the commands' responses earlier. MozReview-Commit-ID: DdNyR7vdgtY
47f87dca3d5cea827c7449eb0ecb97442f5610a1: Bug 1381876 - Return window rect from Context#rect consistently. r?automatedtester draft
Andreas Tolfsen <ato@sny.no> - Tue, 01 Aug 2017 18:17:29 +0100 - rev 641115
Push 72440 by bmo:ato@sny.no at Sat, 05 Aug 2017 16:47:34 +0000
Bug 1381876 - Return window rect from Context#rect consistently. r?automatedtester MozReview-Commit-ID: D5pCPK2PEr3
97a530a7dc42ca3886d896d7355b90dcfdf56321: Bug 1381876 - Rename Maximize Window test to match command name. r?automatedtester draft
Andreas Tolfsen <ato@sny.no> - Wed, 26 Jul 2017 17:34:59 +0100 - rev 641114
Push 72440 by bmo:ato@sny.no at Sat, 05 Aug 2017 16:47:34 +0000
Bug 1381876 - Rename Maximize Window test to match command name. r?automatedtester MozReview-Commit-ID: 6g2GgZW846h
693263e24261bd956a362339b103731454a9117f: Bug 1358960 - "united state" string should not be recognized as "address-level1". r=MattN draft
Sean Lee <selee@mozilla.com> - Fri, 04 Aug 2017 16:23:45 +0800 - rev 641113
Push 72439 by bmo:selee@mozilla.com at Sat, 05 Aug 2017 15:55:14 +0000
Bug 1358960 - "united state" string should not be recognized as "address-level1". r=MattN MozReview-Commit-ID: E7pmBkGRBkQ
0d4715ceb84a96070f7951e9ba61c6effb7c94c8: Bug 1387723 - Remove --toolbarbutton-icon-fill and --toolbarbutton-icon-fill-inverted. r?johannh draft
Dão Gottwald <dao@mozilla.com> - Sat, 05 Aug 2017 16:11:12 +0200 - rev 641112
Push 72438 by dgottwald@mozilla.com at Sat, 05 Aug 2017 14:11:42 +0000
Bug 1387723 - Remove --toolbarbutton-icon-fill and --toolbarbutton-icon-fill-inverted. r?johannh --toolbarbutton-icon-fill and --toolbarbutton-icon-fill-inverted are largely unused; only the dark theme uses --toolbarbutton-icon-fill-inverted as intended to change icon colors. The variables are footguns in that people think they should somehow use them when they really shouldn't, see bug 1384898, bug 1384893, bug 1384895, and pocket.css. MozReview-Commit-ID: 8qAZAWJDkrt
3375c27ff20a12b630e5f3c6b85580692e42e25d: Bug 1382579 - Part 3: Tests, r=gijs draft
Fischer Liu<fliu@mozilla.com> - Wed, 02 Aug 2017 13:53:05 +0800 - rev 641111
Push 72437 by fliu@mozilla.com at Sat, 05 Aug 2017 14:06:37 +0000
Bug 1382579 - Part 3: Tests, r=gijs This commit - adds 2 utility functions to the uitour's head.js - adds the browser_UITour4.js - moves the tests in the browser_showMenu_controlCenter.js into the newly added the browser_showMenu.js - deletes the browser_showMenu_urlbar.js because it's test has been modified and moved into the browser_showMenu.js - adds one test case for the page action panel in the browser_showMenu.js - updates the browser_UITour_availableTargets.js test because we have more targets right now. MozReview-Commit-ID: CydEAkqAl3V
7e723533e4a6e296fed98e3243ac134ed7f471aa: Bug 1382579 - Part 2: UITour should support showMenu, showInfo, showHighlight on the Page Action Panel, r=gijs draft
Fischer.json <fischer.json@gmail.com> - Fri, 04 Aug 2017 17:04:55 +0800 - rev 641110
Push 72437 by fliu@mozilla.com at Sat, 05 Aug 2017 14:06:37 +0000
Bug 1382579 - Part 2: UITour should support showMenu, showInfo, showHighlight on the Page Action Panel, r=gijs This commit - makes UITour support showMenu, showInfo, showHighlight on the Page Action Panel - makes UITour support showInfo, showHighlight on the Page Action buttons and on the urlbar's bookmark #star-button button btw - fixes Bug 1382700 - "UITour lacks the `hideMenu` api support for the single search bar (urlbar) dropdown menu" together - fixes Bug 1386201 - "UITour wouldn't close the appMenu if running the tracking-protection's ui tour" together MozReview-Commit-ID: Fou1sD4gAs4
a5986eb9e0fc7273411c382b034b0697256e7b55: Bug 1382579 - Part 1: Update the BrowserPageActions API for the UITour's usage, r=Gijs draft
Fischer.json <fischer.json@gmail.com> - Tue, 01 Aug 2017 12:09:25 +0800 - rev 641109
Push 72437 by fliu@mozilla.com at Sat, 05 Aug 2017 14:06:37 +0000
Bug 1382579 - Part 1: Update the BrowserPageActions API for the UITour's usage, r=Gijs - adds `showPanel` so UITour could call it to open the page action panel - makes clicking page action button on the urlbar would toggle the panel. This is for the case, when UITour opens the page action panel to highlight a button it would set "noautohide" to let the panel persistently opened. But we still need a way to let user able to close the panel so made this change. The PanelUI is doing the same thing [1]. UITour wuold remove "noautohide" on the panelHidden event [2]. [1] https://dxr.mozilla.org/mozilla-central/rev/1b065ffd8a535a0ad4c39a912af18e948e6a42c1/browser/components/customizableui/content/panelUI.js#246 [2] https://dxr.mozilla.org/mozilla-central/rev/1b065ffd8a535a0ad4c39a912af18e948e6a42c1/browser/components/uitour/UITour.jsm#1483 MozReview-Commit-ID: FtJZZ0bfy61
26f3c2cafb79e870a32390b8afbcc4423d7a322b: Bug 1387716 - Remove ancient workaround for bug 341047. r?masayuki draft
Dão Gottwald <dao@mozilla.com> - Sat, 05 Aug 2017 14:43:41 +0200 - rev 641108
Push 72436 by dgottwald@mozilla.com at Sat, 05 Aug 2017 12:44:09 +0000
Bug 1387716 - Remove ancient workaround for bug 341047. r?masayuki _updateScrollButtonsDisabledState doesn't use nsIScrollBoxObject, so this shouldn't be a problem anymore. MozReview-Commit-ID: DP7RD0lA7dQ
f21d21c343362d7f65928604bfa097be1c3e4e58: Bug 1387716 - Remove ancient workaround for bug bug 341047. r?masayuki draft
Dão Gottwald <dao@mozilla.com> - Sat, 05 Aug 2017 14:41:21 +0200 - rev 641107
Push 72435 by dgottwald@mozilla.com at Sat, 05 Aug 2017 12:41:47 +0000
Bug 1387716 - Remove ancient workaround for bug bug 341047. r?masayuki _updateScrollButtonsDisabledState doesn't use nsIScrollBoxObject, so this shouldn't be a problem anymore. MozReview-Commit-ID: GOnH2VDhMMt
9dce791545429b5ca1412af590a241ed4b0571bc: Bug 1385820 - Enable the ESLint no-new-wrappers rule across mozilla-central; r?standard8, markh draft
dagasatvik <dagasatvik10@gmail.com> - Sat, 05 Aug 2017 17:08:36 +0530 - rev 641106
Push 72434 by bmo:dagasatvik10@gmail.com at Sat, 05 Aug 2017 11:39:39 +0000
Bug 1385820 - Enable the ESLint no-new-wrappers rule across mozilla-central; r?standard8, markh All changes to /sync directory reverted along with comment referencing bug 1295510 Changes reverted where objects are required Dropped String and Number wrapper where not needed Removed valueOf from Boolean return in telemetry MozReview-Commit-ID: 1vX0mTF4R5M
ca6ff2d2306e19eb8a21e1898fcc8d05d36c6703: Bug 1387701 - Simplify lineScrollAmount. r?masayuki draft
Dão Gottwald <dao@mozilla.com> - Sat, 05 Aug 2017 12:17:11 +0200 - rev 641105
Push 72433 by dgottwald@mozilla.com at Sat, 05 Aug 2017 10:17:44 +0000
Bug 1387701 - Simplify lineScrollAmount. r?masayuki MozReview-Commit-ID: 401ja5XzBpO
933a04a91ce3bd44b230937083a835cb60637084: merge mozilla-inbound to mozilla-central. r=merge a=merge
Sebastian Hengst <archaeopteryx@coole-files.de> - Sat, 05 Aug 2017 11:55:25 +0200 - rev 641104
Push 72433 by dgottwald@mozilla.com at Sat, 05 Aug 2017 10:17:44 +0000
merge mozilla-inbound to mozilla-central. r=merge a=merge MozReview-Commit-ID: 9IxbB2vCH4S
8163646237aa5bc72f6414c9e73fcb4073d053eb: Bug 1385880: Part 3 - Wait for add-on startup before showing inline options browser. r=aswan
Kris Maglione <maglione.k@gmail.com> - Fri, 04 Aug 2017 13:20:58 -0700 - rev 641103
Push 72433 by dgottwald@mozilla.com at Sat, 05 Aug 2017 10:17:44 +0000
Bug 1385880: Part 3 - Wait for add-on startup before showing inline options browser. r=aswan MozReview-Commit-ID: JPPUjIGPRvs
618f5606f763e87fa64c2eee01f168fe1f34c6bb: Bug 1385880: Part 2 - Store promise returned by bootstrap startup method. r=aswan
Kris Maglione <maglione.k@gmail.com> - Fri, 04 Aug 2017 13:20:36 -0700 - rev 641102
Push 72433 by dgottwald@mozilla.com at Sat, 05 Aug 2017 10:17:44 +0000
Bug 1385880: Part 2 - Store promise returned by bootstrap startup method. r=aswan This is also the first step in moving async startup/shutdown tracking into the add-on manager. MozReview-Commit-ID: Uf4ecSW77S
f7f8579ec94e8a2ff03e5299c13381b4234517a1: Bug 1385880: Part 1 - Remove WebExtensionBootstrap.js. r=aswan
Kris Maglione <maglione.k@gmail.com> - Fri, 04 Aug 2017 23:12:24 -0700 - rev 641101
Push 72433 by dgottwald@mozilla.com at Sat, 05 Aug 2017 10:17:44 +0000
Bug 1385880: Part 1 - Remove WebExtensionBootstrap.js. r=aswan MozReview-Commit-ID: X4JoEC61TF
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip