33305c9f74f64062444234d6201c3d848a9b59f3: Bug 1415448 - Rename setTarget.html to target.html; r?hiro draft
Brian Birtles <birtles@gmail.com> - Wed, 08 Nov 2017 16:20:10 +0900 - rev 696026
Push 88616 by bbirtles@mozilla.com at Fri, 10 Nov 2017 04:12:48 +0000
Bug 1415448 - Rename setTarget.html to target.html; r?hiro This matches better the naming of other test files. MozReview-Commit-ID: 3rzEwBhum3E
72f7428148ac3f210286a09962c7ef10462dc193: Bug 1415448 - Tidy up titles of Web Animations web-platform-tests; r?hiro draft
Brian Birtles <birtles@gmail.com> - Wed, 08 Nov 2017 16:16:14 +0900 - rev 696025
Push 88616 by bbirtles@mozilla.com at Fri, 10 Nov 2017 04:12:48 +0000
Bug 1415448 - Tidy up titles of Web Animations web-platform-tests; r?hiro It's not necessary to say "tests" or "tests for" in the title of these tests. It's obvious from the context that these are test files. This patch: * Remove "Tests for" and "tests" from the titles * Makes the titles match the spec sections they test more closely where practical * Makes the titles more consistent in general (e.g. not putting () after method names) * Updates a few spec links * Drops a few author annotations since we decided to no longer use them There are still some inconsistencies: - The naming of the setTarget.html test file - The location of the effect-value-visibility.html file - The getComputedStyle.html test - etc. These will be fixed in subsequent patches in this series. MozReview-Commit-ID: Ghl0dWalYZE
34dcccb2948d84fd503d58e7dd707b466401f525: Bug 1415448 - Update web-platform-tests manifest; r?hiro draft
Brian Birtles <birtles@gmail.com> - Wed, 08 Nov 2017 16:15:14 +0900 - rev 696024
Push 88616 by bbirtles@mozilla.com at Fri, 10 Nov 2017 04:12:48 +0000
Bug 1415448 - Update web-platform-tests manifest; r?hiro This is simply the result of running: ./mach wpt-manifest-update MozReview-Commit-ID: EKoDVNn7yA2
6781c119176c9b6cdd7283a7a799304c32e4dd6a: Bug 1416067 - Avoid doing a bunch of useless event-regions work for frames with empty border boxes. r?mstange draft
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 09 Nov 2017 19:40:44 -0500 - rev 696023
Push 88615 by kgupta@mozilla.com at Fri, 10 Nov 2017 04:10:48 +0000
Bug 1416067 - Avoid doing a bunch of useless event-regions work for frames with empty border boxes. r?mstange MozReview-Commit-ID: 8gsIJojhQ6t
043e71f0626fc4621872fb46ed244a79fda61fd1: Bug 1413830 - PART 2: introduce root/parent session_id draft
Fred Lin <gasolin@gmail.com> - Fri, 10 Nov 2017 12:06:37 +0800 - rev 696022
Push 88614 by bmo:gasolin@mozilla.com at Fri, 10 Nov 2017 04:09:12 +0000
Bug 1413830 - PART 2: introduce root/parent session_id MozReview-Commit-ID: ATyRNzky8R4
0a531def292f9ffea61f5f4f578d03713abb1538: Bug 1413830 - PART 1: track new events for onboarding telemetry; draft
Fred Lin <gasolin@gmail.com> - Tue, 31 Oct 2017 12:01:30 +0800 - rev 696021
Push 88614 by bmo:gasolin@mozilla.com at Fri, 10 Nov 2017 04:09:12 +0000
Bug 1413830 - PART 1: track new events for onboarding telemetry; MozReview-Commit-ID: 3jNAmOcrvEa
30e52aa95d880eca40c3b94d2dd9b5f6f22cef0b: Bug 1413830 - PART 2: introduce root/parent session_id draft
Fred Lin <gasolin@gmail.com> - Fri, 10 Nov 2017 12:06:37 +0800 - rev 696020
Push 88613 by bmo:gasolin@mozilla.com at Fri, 10 Nov 2017 04:07:24 +0000
Bug 1413830 - PART 2: introduce root/parent session_id MozReview-Commit-ID: ATyRNzky8R4
2fe72741eb9ee31553108effdbec484b57dc8de3: fixup! Bug 1413830 - PART 1: track new events for onboarding telemetry; draft
Fred Lin <gasolin@gmail.com> - Fri, 10 Nov 2017 11:06:22 +0800 - rev 696019
Push 88613 by bmo:gasolin@mozilla.com at Fri, 10 Nov 2017 04:07:24 +0000
fixup! Bug 1413830 - PART 1: track new events for onboarding telemetry;
ae5539a11d9fbe472d545136e5d764822f4efbb3: Bug 1413830 - PART 1: track new events for onboarding telemetry; draft
Fred Lin <gasolin@gmail.com> - Tue, 31 Oct 2017 12:01:30 +0800 - rev 696018
Push 88613 by bmo:gasolin@mozilla.com at Fri, 10 Nov 2017 04:07:24 +0000
Bug 1413830 - PART 1: track new events for onboarding telemetry; MozReview-Commit-ID: 3jNAmOcrvEa
320fd9dfd0aed1e6c0011dd9538fa31ead604bd1: Bug 1412608 - Fix comment selection color in markup view. r=jdescottes draft
Gabriel Luong <gabriel.luong@gmail.com> - Thu, 09 Nov 2017 23:06:37 -0500 - rev 696017
Push 88612 by bmo:gl@mozilla.com at Fri, 10 Nov 2017 04:07:09 +0000
Bug 1412608 - Fix comment selection color in markup view. r=jdescottes MozReview-Commit-ID: 9G5efQSPHCf
3ea6a1a7234311497e090123ea8725c107b47765: Backed out changeset 186ee641ae41 (bug 1415300) for frequent failures in browser_dbg-wasm-sourcemaps.js
Phil Ringnalda <philringnalda@gmail.com> - Thu, 09 Nov 2017 19:58:39 -0800 - rev 696016
Push 88612 by bmo:gl@mozilla.com at Fri, 10 Nov 2017 04:07:09 +0000
Backed out changeset 186ee641ae41 (bug 1415300) for frequent failures in browser_dbg-wasm-sourcemaps.js CLOSED TREE MozReview-Commit-ID: 4gWGPGXMgP6
d89736edd7a95f1f24222ae340a6509b7a7a703b: Backed out changeset 39beeec35ecc (bug 1415554) for failing devtools/client/shared/components/test/mochitest/test_tabs_accessibility.html r=backout on a CLOSED TREE
Andreea Pavel <apavel@mozilla.com> - Fri, 10 Nov 2017 03:11:01 +0200 - rev 696015
Push 88612 by bmo:gl@mozilla.com at Fri, 10 Nov 2017 04:07:09 +0000
Backed out changeset 39beeec35ecc (bug 1415554) for failing devtools/client/shared/components/test/mochitest/test_tabs_accessibility.html r=backout on a CLOSED TREE
5ece2d052e8eecc7cc9ac9c10ade8bc794e3d8ab: merge mozilla-central to mozilla-inbound. r=merge a=merge on a CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 10 Nov 2017 02:47:06 +0200 - rev 696014
Push 88612 by bmo:gl@mozilla.com at Fri, 10 Nov 2017 04:07:09 +0000
merge mozilla-central to mozilla-inbound. r=merge a=merge on a CLOSED TREE
71c35bd93e81532ed990796522785dfb6ec82d7e: Bug 1415401 - Part4 - Have GMPServiceParent::RecvLaunchGMP fill in the error description. draft
James Cheng <jacheng@mozilla.com> - Fri, 10 Nov 2017 12:03:00 +0800 - rev 696013
Push 88611 by bmo:jacheng@mozilla.com at Fri, 10 Nov 2017 04:03:22 +0000
Bug 1415401 - Part4 - Have GMPServiceParent::RecvLaunchGMP fill in the error description. MozReview-Commit-ID: GQoV7g1uQeC
409ae92e480c1414ba4cd406de64a4bd73df59c5: Bug 1415401 - Part3 - Add an out parameter to LaunchGMP interface in ipdl to better know the error detail when failure. draft
James Cheng <jacheng@mozilla.com> - Fri, 10 Nov 2017 11:28:45 +0800 - rev 696012
Push 88611 by bmo:jacheng@mozilla.com at Fri, 10 Nov 2017 04:03:22 +0000
Bug 1415401 - Part3 - Add an out parameter to LaunchGMP interface in ipdl to better know the error detail when failure. MozReview-Commit-ID: BmiTYeQGIrm
25392c965152859b62d4633eb8b9a000d7c3aae0: Bug 1415401 - Part2 - Make GetServiceChildPromise rejection function acceopt MediaResult and propagate the error result to GetContentParent rejection function. draft
James Cheng <jacheng@mozilla.com> - Thu, 09 Nov 2017 18:01:01 +0800 - rev 696011
Push 88611 by bmo:jacheng@mozilla.com at Fri, 10 Nov 2017 04:03:22 +0000
Bug 1415401 - Part2 - Make GetServiceChildPromise rejection function acceopt MediaResult and propagate the error result to GetContentParent rejection function. MozReview-Commit-ID: 4IjV9KGcsvd
c4e632e79fae02066debf282632911730c01b091: Bug 1415401 - Part1 - Make GetGMPContentParentPromise rejection function accept MediaResult. draft
James Cheng <jacheng@mozilla.com> - Thu, 09 Nov 2017 17:21:59 +0800 - rev 696010
Push 88611 by bmo:jacheng@mozilla.com at Fri, 10 Nov 2017 04:03:22 +0000
Bug 1415401 - Part1 - Make GetGMPContentParentPromise rejection function accept MediaResult. MozReview-Commit-ID: CdDFgkDSomW
dcf51aa102e9e596604c5ea1ad5d44a959ed8729: Bug 1415800 - part 5: Redesign HTMLEditRules::FindNearSelectableNode() r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 10 Nov 2017 01:35:10 +0900 - rev 696009
Push 88610 by masayuki@d-toybox.com at Fri, 10 Nov 2017 04:02:33 +0000
Bug 1415800 - part 5: Redesign HTMLEditRules::FindNearSelectableNode() r?m_kato First, the method name is not correct. It tries to find an editable node near the given DOM point. Therefore, it should be FindNearEditableNode(). Next, the implementation did something odd. E.g., in the first |if| block, when |nearNode| is nullptr, it returns nullptr. However, following |if| block does something only when |nearNode| is nullptr. So, we can get rid of the second |if| block. Then, nobody will change aDirection. So, we can make it not a reference now. Similarly, in |while| block, if |nearNode| becomes nullptr, it returns error. However, following block checks if |nearNode| is NOT nullptr. So, we can get rid of this |if| statement and outdent its block. Additionally, |curNode| isn't necessary. It only increments the refcount redundantly. So, we can get rid of it. Finally, FindNearEditableNode() can return found node directly instead of error code because error code doesn't make sense. Not found an editable node is not illegal. And also it can take EditorRawDOMPoint instead of a set of container, child and offset of the child in the container. MozReview-Commit-ID: CTI581PhJMd
4f10b9a1d41a89f6d82edde16faa951e2432b838: Bug 1415800 - part 4: Redesign HTMLEditor::GetNextHTMLNode() same as similar to EditorBase::GetNext*() r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 10 Nov 2017 00:12:22 +0900 - rev 696008
Push 88610 by masayuki@d-toybox.com at Fri, 10 Nov 2017 04:02:33 +0000
Bug 1415800 - part 4: Redesign HTMLEditor::GetNextHTMLNode() same as similar to EditorBase::GetNext*() r?m_kato HTMLEditor::GetNextHTMLNode() should be redesigned as HTMLEditor::GetNextEditableHTMLNode(nsINode&), HTMLEditor::GetNextEditableHTMLNodeInBlock(nsINode&), HTMLEditor::GetNextEditableHTMLNode(const EditorRawDOMPoint&) and HTMLEditor::GetNextEditableHTMLNodeInBlock(const EditorRawDOMPoint&). Same as GetPreviousEditableHTMLNode*(), we don't need the methods to find non-editable nodes too. MozReview-Commit-ID: JjZauCMblp4
5d078405c46b553ed876cb6d78d2e0e65c882f4d: Bug 1415800 - part 3: Redesign HTMLEditor::GetPriorHTMLNode() as similar to EditorBase::GetPrevious*() r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 09 Nov 2017 23:31:59 +0900 - rev 696007
Push 88610 by masayuki@d-toybox.com at Fri, 10 Nov 2017 04:02:33 +0000
Bug 1415800 - part 3: Redesign HTMLEditor::GetPriorHTMLNode() as similar to EditorBase::GetPrevious*() r?m_kato HTMLEditor::GetPriorHTMLNode() methods are similar to EditorBase::GetPriorNode() which was redesigned with the previous patch. So, it should be redesigned as HTMLEditor::GetPreviousEditableHTMLNode(nsINode&), HTMLEditor::GetPreviousEditableHTMLNode(const EditorRawDOMPoint&), HTMLEditor::GetPreviousEditableHTMLNodeInBlock(nsINode&) and HTMLEditor::GetPreviousEditableHTMLNodeInBlock(const EditorRawDOMPoint&). Note that HTMLEditor::GetPriorHTMLNode() are always return editable node. So, we don't need to create non-editable node methods for them. Although, I don't like the word "HTMLNode" because this can return SVG element or something too. The additional feature of those methods is just checking given node is in active editing host. So, they are for HTML editor, but not returning only HTML nodes. However, I have no better idea with shorter name. MozReview-Commit-ID: 3J4IaBOFjzj
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip