32b6b2c4a69eb3f71894ecfb7aa2bed853843b36: Bug 1148504 - Protect Firefox Account state with a critical section. r=rnewman, a=readinglist
Nick Alexander <nalexander@mozilla.com> - Fri, 27 Mar 2015 08:27:28 -0700 - rev 266461
Push 2233 by mozilla@noorenberghe.ca at Fri, 22 May 2015 21:06:00 +0000
Bug 1148504 - Protect Firefox Account state with a critical section. r=rnewman, a=readinglist ======== https://github.com/mozilla-services/android-sync/commit/8b1d353ee8c5f049c65d6ab437d3adee871ae8ec Author: Nick Alexander <nalexander@mozilla.com> Bug 1148504 - Part 2: Make updating Firefox Account state happen in a critical section. It's worth noting that the two consumers of the shared state lock will only race for a very short window -- essentially only when creating or re-connecting an account. That's because Reading List oauth tokens are long-lived and do not expire (yet) in response to remote Account state changes, such as updating the Account password. So Sync and RL will race to initialize the Account state; eventually RL will get an oauth token; and that token will be cached forever until RL produces a 401 for the token or Android expires the token. Since Sync requests a token server token at the start of every sync, the lock will be constantly exercised, but should never block. ======== https://github.com/mozilla-services/android-sync/commit/d7a8611810ebd6872df7ffdcf301e30520fc6ff9 Author: Nick Alexander <nalexander@mozilla.com> Bug 1148504 - Part 1: Reduce scope of section that may set Account state. The only place that might throw a TokenServerException is the token server client code itself. By handling such an exception earlier, we reduce the scope of the section that may update the Firefox Account state. (This comes at the cost of threading AndroidFxAccount into syncWithAssertion, but c'est la vie.) This does not interact with the exist handling of 401s that we might see from the storage endpoint. Those 401s never generated TokenServerExceptions; in fact, they were (essentially) ignored. Since we fetch a fresh token every Sync, what was (and is) expected is that such 401s would be transient and fixed by authenticating with a fresher token. Test plan: manually verify that remotely changing the Firefox Account's password while the device is in the Married state does the following: 1) uses the cached certificate to generate a local assertion; 2) the assertion produces a 401 from the TokenServerException, since the certificate is no longer fresh; 3) the TokenServerException drives the Account state to Cohabiting; 4) the state machine discovers it cannot /sign, driving the Account state to Separated.
0aedf96a7cdc06cc788e47407259cbf008ee344d: Bug 1142596 - Use cached FxA OAuth tokens in Reading List sync. r=rnewman, a=readinglist
Nick Alexander <nalexander@mozilla.com> - Tue, 24 Mar 2015 23:00:34 -0700 - rev 266460
Push 2233 by mozilla@noorenberghe.ca at Fri, 22 May 2015 21:06:00 +0000
Bug 1142596 - Use cached FxA OAuth tokens in Reading List sync. r=rnewman, a=readinglist ======== https://github.com/mozilla-services/android-sync/commit/9b406122ef93dea4be4bff8d84caa3a2fae54d39 Author: Nick Alexander <nalexander@mozilla.com> Bug 1142596 - Post: Use production OAuth and Reading List endpoints. ======== https://github.com/mozilla-services/android-sync/commit/9e5368b4aaf6fca78230d184e901bb78020a771f Author: Nick Alexander <nalexander@mozilla.com> Bug 1142596 - Part 4: Make ReadingListSyncAdapter use oauth tokens produced and cached by the authenticator. ======== https://github.com/mozilla-services/android-sync/commit/fbef93698dac1e060fd6ca71dee54c74f1d14fd8 Author: Nick Alexander <nalexander@mozilla.com> Date: Tue Mar 24 22:49:52 2015 -0700 Bug 1142596 - Part 3: Implement getAuthToken with token types of the form oauth::scope. Be aware that there are two levels of token invalidation relevant here. The first level is when a consumer uses an oauth token and gets a 401; in this case, the consumer *must* call Android's own invalidateAuthToken. The second level is when the oauth client itself gets a 401 trying to fetch an oauth token; in this case, the internal state of the Firefox Account needs to be pushed back. ======== https://github.com/mozilla-services/android-sync/commit/e4e2247b4e6a080b8e76008595a7e75b734a7c64 Author: Nick Alexander <nalexander@mozilla.com> Date: Tue Mar 24 22:43:26 2015 -0700 Bug 1142596 - Part 2: Extract login state machine delegate encapsulating expirations. ======== https://github.com/mozilla-services/android-sync/commit/f1f716cc8831b947078f066cf5ffefbece7f695e Author: Nick Alexander <nalexander@mozilla.com> Date: Tue Mar 24 22:14:47 2015 -0700 Bug 1142596 - Part 1: Surface Reading List authentication errors. ======== https://github.com/mozilla-services/android-sync/commit/5833cbbf711cdc4d2b4d861988a454c8b33241c3 Author: Nick Alexander <nalexander@mozilla.com> Date: Tue Mar 24 22:01:46 2015 -0700 Bug 1142596 - Pre: Add note about deleting cached oauth tokens. Deleting cached oauth tokens is tracked by Bug 1147245. ======== https://github.com/mozilla-services/android-sync/commit/b0165a6c14bf04de9bb2854ba4d0cdf772e58b5b Author: Nick Alexander <nalexander@mozilla.com> Date: Tue Mar 24 23:06:49 2015 -0700 Bug 1142596 - Pre: Trim imports.
ac9b83aca21f3686f7dd95be2ab89d509d653fe5: Bug 1147473 - Expose Firefox Account debug information from Settings activity. r=rnewman, a=readinglist
Nick Alexander <nalexander@mozilla.com> - Tue, 24 Mar 2015 22:10:05 -0700 - rev 266459
Push 2233 by mozilla@noorenberghe.ca at Fri, 22 May 2015 21:06:00 +0000
Bug 1147473 - Expose Firefox Account debug information from Settings activity. r=rnewman, a=readinglist ======== https://github.com/mozilla-services/android-sync/commit/afcbbba32cdf290afc26e89a7db8c739f0216d5e Author: Nick Alexander <nalexander@mozilla.com> Bug 1147473 - Part 2: Make it possible to toggle Firefox Accounts debug / PII logging at runtime. Tap the email address in the Firefox Account settings activity 5 times. Only available when: !defined(MOZILLA_OFFICIAL) || defined(NIGHTLY_BUILD) || defined(MOZ_DEBUG) ======== https://github.com/mozilla-services/android-sync/commit/261f912d1267d52ffb0268d2a83c7870caad8457 Author: Nick Alexander <nalexander@mozilla.com> Bug 1147473 - Part 1: Add additional (dangerous!) debug commands. These make it easier to test oauth token authorization, especially using stage servers. ======== https://github.com/mozilla-services/android-sync/commit/c1509baa7736e95c4bda9ea972dd407ca5966536 Author: Nick Alexander <nalexander@mozilla.com> Date: Tue Mar 24 22:06:43 2015 -0700 Bug 1142596 - Pre: Move constants around. ======== https://github.com/mozilla-services/android-sync/commit/2c676500c32ae11e06fa65fd0aa9c05e13d3fd79 Author: Nick Alexander <nalexander@mozilla.com> Date: Thu Mar 26 11:28:22 2015 -0700 Bug 1142596 - Pre: Make it easier to construct intermediate states.
c27964aaa4c5e71c0bfdeb93fe2080fd5bad34b6: Bug 1148432 - Sync reading list deletions. r=nalexander, a=readinglist
Richard Newman <rnewman@mozilla.com> - Fri, 27 Mar 2015 11:54:16 -0700 - rev 266458
Push 2233 by mozilla@noorenberghe.ca at Fri, 22 May 2015 21:06:00 +0000
Bug 1148432 - Sync reading list deletions. r=nalexander, a=readinglist
f1c7c471c2d81000269ecc76e0717551295d8332: Bug 1140810 - Upload material (non-status) Reading List modifications. r=rnewman, a=readinglist
Nick Alexander <nalexander@mozilla.com> - Wed, 25 Mar 2015 16:35:26 -0700 - rev 266457
Push 2233 by mozilla@noorenberghe.ca at Fri, 22 May 2015 21:06:00 +0000
Bug 1140810 - Upload material (non-status) Reading List modifications. r=rnewman, a=readinglist ======== https://github.com/mozilla-services/android-sync/commit/575d80fddb1afc10123b928a07800bda15c8c087 Author: Nick Alexander <nalexander@mozilla.com> Bug 1140810 - Part 2: Upload material (non-status) modifications. ======== https://github.com/mozilla-services/android-sync/commit/a86e734ef12624267e12898140bf72db8e7b56c2 Author: Nick Alexander <nalexander@mozilla.com> Date: Wed Mar 25 10:56:07 2015 -0700 Bug 1140810 - Part 1: Add storage test for material (non-status) modifications. ======== https://github.com/mozilla-services/android-sync/commit/2259378d084df7c203ea29e4dec8c292d4cdf6fc Author: Nick Alexander <nalexander@mozilla.com> Date: Wed Mar 25 13:33:13 2015 -0700 Bug 1140810 - Part 0: Add and use HTTP PATCH. ======== https://github.com/mozilla-services/android-sync/commit/0222d53d980c87a52c1416f4e683af79a9c79983 Author: Nick Alexander <nalexander@mozilla.com> Date: Wed Mar 25 14:49:19 2015 -0700 Bug 1140810 - Pre: Don't fail in status upload when there are no failures. ======== https://github.com/mozilla-services/android-sync/commit/7f2feede3bf7a9d83c59a3184a58f6b125b21bbd Author: Nick Alexander <nalexander@mozilla.com> Date: Wed Mar 25 14:53:45 2015 -0700 Bug 1140810 - Pre: convert 4 spaces to 2 spaces. ======== https://github.com/mozilla-services/android-sync/commit/49e80d271efcbf5554f10e35591027b5a81cefcc Author: Nick Alexander <nalexander@mozilla.com> Date: Wed Mar 25 10:40:26 2015 -0700 Bug 1140810 - Pre: Fix whitespace.
daf8a9291a9bcdde85dd7ba589c1690c49d2f400: Bug 1148862 - Update pref to the new v3 endpoint [r=adw, a=sylvestre]
Ed Lee <edilee@mozilla.com> - Wed, 01 Apr 2015 01:02:50 -0700 - rev 266456
Push 2233 by mozilla@noorenberghe.ca at Fri, 22 May 2015 21:06:00 +0000
Bug 1148862 - Update pref to the new v3 endpoint [r=adw, a=sylvestre]
98144ed917cb8244da64a7faaa327c1fdd762d36: Bug 1149682: Don't cache (or show) sponsored suggested links. r=adw, a=sylvestre
Marina Samuel <msamuel@mozilla.com> - Wed, 01 Apr 2015 17:34:21 -0400 - rev 266455
Push 2233 by mozilla@noorenberghe.ca at Fri, 22 May 2015 21:06:00 +0000
Bug 1149682: Don't cache (or show) sponsored suggested links. r=adw, a=sylvestre
96e8fba7c4c41cd551845b00591b4d3fc6ab6f9c: Bug 1149680: Send the Firefox channel on fetch. r=adw, a=sylvestre
Marina Samuel <msamuel@mozilla.com> - Wed, 01 Apr 2015 17:30:28 -0400 - rev 266454
Push 2233 by mozilla@noorenberghe.ca at Fri, 22 May 2015 21:06:00 +0000
Bug 1149680: Send the Firefox channel on fetch. r=adw, a=sylvestre
311733df5675219a9192a041fb8230dec5592d3f: Bug 1105360: Only enhance tiles that are under the 'enhanced' key. r=adw, a=sylvestre
Marina Samuel <msamuel@mozilla.com> - Wed, 01 Apr 2015 17:26:46 -0400 - rev 266453
Push 2233 by mozilla@noorenberghe.ca at Fri, 22 May 2015 21:06:00 +0000
Bug 1105360: Only enhance tiles that are under the 'enhanced' key. r=adw, a=sylvestre
da253517277077271eb8d9b53f6a90fc18f373aa: Bug 1149021 - Suggested tile with just an image shows a thumbnail instead [r=adw, a=sylvestre]
Ed Lee <edilee@mozilla.com> - Sun, 29 Mar 2015 23:30:54 -0700 - rev 266452
Push 2233 by mozilla@noorenberghe.ca at Fri, 22 May 2015 21:06:00 +0000
Bug 1149021 - Suggested tile with just an image shows a thumbnail instead [r=adw, a=sylvestre] Use Object.assign to copy over base values into a new link with extra attributes.
1d9b014f0414cb0d9b54bf8b41b8e83128deb2b7: Bug 1136203 - Remove thumbnail/title replacing functionality for history tiles. r=adw, a=sylvestre
Marina Samuel <msamuel@mozilla.com> - Fri, 27 Mar 2015 17:57:11 -0400 - rev 266451
Push 2233 by mozilla@noorenberghe.ca at Fri, 22 May 2015 21:06:00 +0000
Bug 1136203 - Remove thumbnail/title replacing functionality for history tiles. r=adw, a=sylvestre
5fd426f495ff0230bcace86e8d76abb81140f5dc: Bug 1146146 - Maximize the number of rows of tiles by reducing the suggested explanation maximum line count to 2 instead of 3 [r=adw, a=sylvestre]
Marina Samuel <msamuel@mozilla.com> - Sat, 28 Mar 2015 01:08:36 -0700 - rev 266450
Push 2233 by mozilla@noorenberghe.ca at Fri, 22 May 2015 21:06:00 +0000
Bug 1146146 - Maximize the number of rows of tiles by reducing the suggested explanation maximum line count to 2 instead of 3 [r=adw, a=sylvestre]
6892b485a7e005abcc611775cb30707f45f07e61: Bug 1146249 - Tiles on the newtab page don't wrap properly [r=adw, a=sylvestre]
Ed Lee <edilee@mozilla.com> - Mon, 23 Mar 2015 01:16:30 -0700 - rev 266449
Push 2233 by mozilla@noorenberghe.ca at Fri, 22 May 2015 21:06:00 +0000
Bug 1146249 - Tiles on the newtab page don't wrap properly [r=adw, a=sylvestre] Calculate the appropriate cell width for computing the grid width.
4afccec73fb9515f83602e35904bb652fb009d90: Bug 1140496 - Only show a suggested tile url for some number of times or until clicked [r=adw, a=sylvestre]
Ed Lee <edilee@mozilla.com> - Sun, 22 Mar 2015 00:46:26 -0700 - rev 266448
Push 2233 by mozilla@noorenberghe.ca at Fri, 22 May 2015 21:06:00 +0000
Bug 1140496 - Only show a suggested tile url for some number of times or until clicked [r=adw, a=sylvestre] Default to a hardcoded frequency cap that decreases by 1 per view or all for a click.
60f350a6b8b886a46a2827a48e6f8c7fe185a446: Bug 1136208 - Change all references of 'related' to 'suggested' r=adw, a=sylvestre
Marina Samuel <msamuel@mozilla.com> - Thu, 26 Mar 2015 17:23:21 -0400 - rev 266447
Push 2233 by mozilla@noorenberghe.ca at Fri, 22 May 2015 21:06:00 +0000
Bug 1136208 - Change all references of 'related' to 'suggested' r=adw, a=sylvestre
745269d59b33f9df2798f31530e0a4393b294b52: Bug 1143745 - Update the way Firefox reads directoryLinks.json sent from the server for the tiles v3 endpoint. r=adw, a=sylvestre
Marina Samuel <msamuel@mozilla.com> - Thu, 26 Mar 2015 17:17:59 -0400 - rev 266446
Push 2233 by mozilla@noorenberghe.ca at Fri, 22 May 2015 21:06:00 +0000
Bug 1143745 - Update the way Firefox reads directoryLinks.json sent from the server for the tiles v3 endpoint. r=adw, a=sylvestre
65f2aa5f2dd736116ed4b3408417b9f81f7c9248: Bug 1143797 - Allow clicking on suggested explanation text to see overlay explaining the suggested tile. r=adw, a=sylvestre
Marina Samuel <msamuel@mozilla.com> - Thu, 26 Mar 2015 17:05:44 -0400 - rev 266445
Push 2233 by mozilla@noorenberghe.ca at Fri, 22 May 2015 21:06:00 +0000
Bug 1143797 - Allow clicking on suggested explanation text to see overlay explaining the suggested tile. r=adw, a=sylvestre
56763fc69140552ab810342889a122691bd4a328: Bug 1145410: Return valid results when querying the provider cache while it's empty or being populated. r=adw, a=sylvestre
Marina Samuel <msamuel@mozilla.com> - Fri, 20 Mar 2015 17:46:24 -0400 - rev 266444
Push 2233 by mozilla@noorenberghe.ca at Fri, 22 May 2015 21:06:00 +0000
Bug 1145410: Return valid results when querying the provider cache while it's empty or being populated. r=adw, a=sylvestre
db2b585009340185edd1286b6c656483b08cbb9c: Bug 1126186: Allow users to turn off all tiles that aren't history tiles and update newtab cogmenu wording. r=adw, a=sylvestre
Marina Samuel <msamuel@mozilla.com> - Fri, 20 Mar 2015 17:28:15 -0400 - rev 266443
Push 2233 by mozilla@noorenberghe.ca at Fri, 22 May 2015 21:06:00 +0000
Bug 1126186: Allow users to turn off all tiles that aren't history tiles and update newtab cogmenu wording. r=adw, a=sylvestre
e9021ea8d7ca06c0793085a3c8db96fcd1480567: Bug 1126188: Show suggested tile explanation text under a suggested tile. r=adw, a=sylvestre
Marina Samuel <msamuel@mozilla.com> - Fri, 20 Mar 2015 16:39:09 -0400 - rev 266442
Push 2233 by mozilla@noorenberghe.ca at Fri, 22 May 2015 21:06:00 +0000
Bug 1126188: Show suggested tile explanation text under a suggested tile. r=adw, a=sylvestre
(0) -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip