Bug 1344853 - Enable flake8 rule E127: "continuation line over-indented for visual indent". r?dexter MozReview-Commit-ID: GfcBe95NNNm

Bug 1344853 Enable flake8 rule E127 fixed - set correct indentation r=reviewers MozReview-Commit-ID: JeJ1BVpKKij

bug 1313239 - Emit vrdisplayactivate event during document navigation MozReview-Commit-ID: 92AvdabOzq6

Bug 1325988 - Fix ESLint issues in devtools/server/tests/mochitest/ r?tromey MozReview-Commit-ID: BFaOv5i5Tun

Bug 1340842 - Add FX_TAB_CLOSE_PERMIT_UNLOAD_TIME_MS probe to measure how long it takes to run permitUnload on a tab when asked to close. r?Mossop, data-review?liuche MozReview-Commit-ID: 1qvhY6g2p9w

Bug 1340842 - Add FX_TAB_CLOSE_TIME_MS probe to measure how long it takes for tabs to close. r?Mossop, data-review?liuche MozReview-Commit-ID: J4MzsiwaLcT

Bug 1347971 - pass oldVersion to install and startup methods for temporary add-on reloads r?aswan MozReview-Commit-ID: GjEmTt86JaG

Bug 1347971 - pass oldVersion to install and startup methods for temporary add-on reloads r?aswan MozReview-Commit-ID: GjEmTt86JaG

Bug 1331742 - Add support for browserAction.onClicked r?rpl MozReview-Commit-ID: F0xTX0NCcij

Bug 1331742 - Create and register ext-browserAction.js r?mixedpuppy MozReview-Commit-ID: CGR4689b6oo

Bug 1331742 - Create a module for managing browser actions r?gbrown MozReview-Commit-ID: 2epdMD75e84

Bug 1331742 - Create and register browser_action.json r?mixedpuppy MozReview-Commit-ID: AwYuTDU3Ki4

Bug 977177 - Expire old page to icon relations to avoid serving deprecated icons. r=adw Inserting new payloads for a page should expire old ones, otherwise if the page should change favicons, we'd retain old associations forever. At the same time, setting multiple payloads for a page should keep working. MozReview-Commit-ID: 2y1XLUiKAQo

Bug 977177 - Add size ref fragment to icon protocols. r=adw Both page-icon: and moz-anno:favicon: should support a simple #size=NNN ref fragment to allow consumers to request a specific sized icon (if available). The service will do its best to satisfy the request, but it's not guaranteed. If no size hint is found, it will default to the biggest icon payload available. It's currently not possible to test the fragment on moz-anno:favicon: since that requires imagelib support to extract payloads from ico files. Thus a test will be added at a later time. MozReview-Commit-ID: G221MKY7rfs

Bug 977177 - Update favicons API consumers. r=adw Updates consumers to the new behavior. Some consumers are changed to use the "page-icon:" protocol, since it's not trivial to join the icons table and get a single result out of it. In most cases the join would return multiple results since a page can have multiple icon payloads. These consumers for now will return the biggest payload, bug 1347532 will fix some of them to properly pass a #size=NN fragment. Note that, even before, these were just "moz-anno:favicon:" uris, and the payload had to be fetched from the database. Some other consumers for now just fallback to the largest payload, by passing 0 to GetFaviconURLForPage. The favicon optimization still happens on the main-thread, bug 1346139 will handle that problem. Most of the changes involve handling the modified IconData objects, that now retain an array of payloads, rather than just one. But note that .ico files are not yet split into single frames, due to imagelib missing APIs that will be handled in bug 1337402. The other changes involve fixing queries to properly join with the new tables. Finally, note that thanks to the FOREIGN KEYS support, removing from moz_icons or moz_pages_w_icons will also remove relations from moz_icons_to_pages. The system only supports square icons, so icons are resized based on their larger side. This doesn't include new tests, those will be in a following changeset. MozReview-Commit-ID: JUkpquhpS8y

Bug 977177 - Move favicons to a separate store. r=adw This patch moves favicons blobs to a separate database names favicons.sqlite. The dabatase is then ATTACHED to the main Places connection, so that its tables can be used as if they were all part of the same database. The favicons.database contains 3 tables: 1. moz_pages_w_icons This is the way to join with moz_places, through page_url_hash and page_url. We are not using the place id to avoid possible mismatches between places.sqlite and favicons.sqlite. This way the database is "portable" and reusable even if places.sqlite changes. 2. moz_icons Contains icons payloads, each payload can either be an SVG or a PNG. These are the only stored formats, any other format is rescaled and converted to PNG. ICO files are split into single frames and stored as multiple PNGs. SVG are distinguishable through width == UINT16_MAX In future the table will also contain mask-icon color for SVG and average color for PNGs. The fixed_icon_url_hash is "fixed" to allow quickly fetch root icons, that means icons like "domain/favicon.ico" that can also be reused for any page under that domain. 3. moz_icons_to_pages This is the relation table between icons and pages. Each page can have multiple icons, each icon can be used by multiple pages. There is a FOREIGN_KEY constraint between this (child) table and icons or pages (parents), so that it's not possible to insert non-existing ids in this table, and if an entry is removed from a parent table, the relation will be automatically removed from here. Note though that removing from the relation table won't remove from the parent tables. Since the relations are now many-many, it's no more possible to simply join places with the icons table and obtain a single icon, thus it's suggested that consumers go through the "page-icon" protocol. The migration process from the old favicons table is async and interruptible, it will be restarted along with the favicons service until the temp preference places.favicons.convertPayloads is set to true. MozReview-Commit-ID: CUCoL9smRyt

Bug 1336560 - Allow distributions to hide search engines. r?florian MozReview-Commit-ID: 12lSpSPZTqm

Bug 1335907 - Pref Reorg. WORK IN PROGRESS. Patch co-authored by Zachary Herrick. r?jaws MozReview-Commit-ID: 1sx0Wj15yM7

Bug 1345511 - pt 3 - start using IPC call for stun addrs in PCMedia. r=bwc Two new calls are added to NrIceCtx. 1) A static call to allow StunAddrsRequestParent to get stun addrs from the main process. 2) A call to allow StunAddrsRequestChild to pass the new stun addrs back to PeerConnectionMedia on the content process. PeerConnectionMedia, when running in e10s mode, sets up the StunAddrsRequestChild and makes the async request to get the stun addrs. When they are returned, it sets the stun addrs in NrIceCtx avoid the network calls that would otherwise cause a further restricted sandbox to fail. MozReview-Commit-ID: C2hYBzm6WNv

Bug 1345511 - pt 2 - add IPC mechanism for getting stun addrs on main process. r=bwc,jduell PStunAddrsRequest.ipdl defines the new IPC protocol to get stun addrs on the main process. StunAddrsRequestChild requests the stun addrs from the parent. StunAddrsRequestParent uses a static method on NrIceCtx to get the stun addrs from the STS thead and sends the addrs back to the child process. NrIceStunAddr (nricestunaddr.{cpp|h}) wraps nr_local_addr and makes it easier to serialize/deserialize over IPC. NrIceStunAddrMessageUtils follows the pattern used by other Necko IPC classes to define top-level serialization/deserialization calls used by the IPC framework. Modifications under netwerk/ipc are to connect the new IPC protocol to get stun addrs to PNecko since it is a network related IPC protocol. MozReview-Commit-ID: GyEapBe5krl