304e8857922bebc0b06312fcd08c5f2ce17cbe5c: Bug 1402397 - Renamed the files in the \devtools\client\webconsole\new-console-output\components\ directory to use the CamelCase convention. r=patrick brosset
draft
Darren M. OConnell <doconnell@cursived.com> - Fri, 22 Sep 2017 22:01:40 -0700 - rev 669448
Push
81328 by bmo:doconnell@cursived.com at Sat, 23 Sep 2017 05:11:08 +0000
Bug 1402397 - Renamed the files in the \devtools\client\webconsole\new-console-output\components\ directory to use the CamelCase convention. r=patrick brosset
MozReview-Commit-ID: 1e0lWhK4sPp
aa89341fcd0ed260976560b789f7ceb9c0f21aa5: Bug 1401888 - Part 3. Make EMFViaExtDLLHelper inherit from PDFViaEMFPrintHelper.
draft
cku <cku@mozilla.com> - Thu, 21 Sep 2017 15:43:34 +0800 - rev 669447
Push
81327 by cku@mozilla.com at Sat, 23 Sep 2017 05:05:28 +0000
Bug 1401888 - Part 3. Make EMFViaExtDLLHelper inherit from PDFViaEMFPrintHelper.
Reuse the code in PDFViaEMFPrintHelper.
MozReview-Commit-ID: 3NAVxuv2jJH
171b81cfffd1dc2b2cfacac61adaced12866e32e: Bug 1401888 - Part 2. Implement PDFiumEngineShim::GetInstanceOrNull(const nsCString&)
draft
cku <cku@mozilla.com> - Thu, 21 Sep 2017 15:22:18 +0800 - rev 669446
Push
81327 by cku@mozilla.com at Sat, 23 Sep 2017 05:05:28 +0000
Bug 1401888 - Part 2. Implement PDFiumEngineShim::GetInstanceOrNull(const nsCString&)
With this change, we are able to load PDFium engine from different library.
MozReview-Commit-ID: ErAZCPRzRR5
912ced940eb3dca6bcaed53c97c3e672210e409a: Bug 1401888 - Part 1. Move PDFiumEngineShim::Init to private section.
draft
cku <cku@mozilla.com> - Thu, 21 Sep 2017 15:16:40 +0800 - rev 669445
Push
81327 by cku@mozilla.com at Sat, 23 Sep 2017 05:05:28 +0000
Bug 1401888 - Part 1. Move PDFiumEngineShim::Init to private section.
MozReview-Commit-ID: KK1wAv1KoPh
46b43c90f2eaf7a9486dad67ed23dd7aa245cf6f: Bug 1401069 - Part 8. Give a detailed comment to explain how to react when hitting this assertion in OpenDocument().
draft
cku <cku@mozilla.com> - Mon, 18 Sep 2017 23:55:54 +0800 - rev 669444
Push
81327 by cku@mozilla.com at Sat, 23 Sep 2017 05:05:28 +0000
Bug 1401069 - Part 8. Give a detailed comment to explain how to react when hitting this assertion in OpenDocument().
MozReview-Commit-ID: 74UkMV3ZOWm
21e18f967b84a5ae35b09857c028a0481706665e: Bug 1401069 - Part 7. Declare GetPageCount as a const member function.
draft
cku <cku@mozilla.com> - Mon, 18 Sep 2017 23:46:44 +0800 - rev 669443
Push
81327 by cku@mozilla.com at Sat, 23 Sep 2017 05:05:28 +0000
Bug 1401069 - Part 7. Declare GetPageCount as a const member function.
MozReview-Commit-ID: IRM8FikStJi
06e54cceb1f893abc590212aef23afce6c520d0d: Bug 1401069 - Part 6. Fine tune ComputeScaleFactor.
draft
cku <cku@mozilla.com> - Mon, 18 Sep 2017 23:40:05 +0800 - rev 669442
Push
81327 by cku@mozilla.com at Sat, 23 Sep 2017 05:05:28 +0000
Bug 1401069 - Part 6. Fine tune ComputeScaleFactor.
Make the implementation of it moew consice.
MozReview-Commit-ID: J7v98HBLhT
9c438eae915b749857327956ca4c98dca816ee30: Bug 1401069 - Part 5. Remove two local variables since we do not need them.
draft
cku <cku@mozilla.com> - Mon, 18 Sep 2017 23:28:08 +0800 - rev 669441
Push
81327 by cku@mozilla.com at Sat, 23 Sep 2017 05:05:28 +0000
Bug 1401069 - Part 5. Remove two local variables since we do not need them.
dcWidth and dcHieght are used only once, we do not need to define a local
variable for any of them.
MozReview-Commit-ID: Fw5rHqtUPQN
75341af8268cb2fee27ff30b803ede23d2254566: Bug 1401069 - Part 4. Change argument type from 'const RECT *' to reference type in WindowsEMF::Playback.
draft
cku <cku@mozilla.com> - Mon, 18 Sep 2017 23:25:34 +0800 - rev 669440
Push
81327 by cku@mozilla.com at Sat, 23 Sep 2017 05:05:28 +0000
Bug 1401069 - Part 4. Change argument type from 'const RECT *' to reference type in WindowsEMF::Playback.
MozReview-Commit-ID: 4StsIm9sqeC
29881c079ab3c574d64e5d867c8e3f426d032dce: Bug 1401069 - Part 3. Declare WindowsEMF::GetDC as const member function.
draft
cku <cku@mozilla.com> - Mon, 18 Sep 2017 23:19:31 +0800 - rev 669439
Push
81327 by cku@mozilla.com at Sat, 23 Sep 2017 05:05:28 +0000
Bug 1401069 - Part 3. Declare WindowsEMF::GetDC as const member function.
MozReview-Commit-ID: BX7ahnIok2T
d99f7dc005143ae6bae893d4c9990b67e7400552: Bug 1401069 - Part 2. Implement ReleaseAllResource to make WindowsEMF::InitForDrawing reusable.
draft
cku <cku@mozilla.com> - Mon, 18 Sep 2017 23:16:08 +0800 - rev 669438
Push
81327 by cku@mozilla.com at Sat, 23 Sep 2017 05:05:28 +0000
Bug 1401069 - Part 2. Implement ReleaseAllResource to make WindowsEMF::InitForDrawing reusable.
Currently, WindowsEMF::InitForDrawing can be used once. With the change in this
patch, we can call WindowsEMF::InitForDrawing and Playback/SaveToFile in pair
as many times as we want.
MozReview-Commit-ID: 4fbY4Q6i9v5
930f19ed13266eaab1d71f6507eb0ea3f9aa6f95: Bug 1401069 - Part 1. Check the value of mPDFDoc and early return if it's invalid in both RenderPageToDC and DrawPageToFile.
draft
cku <cku@mozilla.com> - Mon, 18 Sep 2017 23:59:29 +0800 - rev 669437
Push
81327 by cku@mozilla.com at Sat, 23 Sep 2017 05:05:28 +0000
Bug 1401069 - Part 1. Check the value of mPDFDoc and early return if it's invalid in both RenderPageToDC and DrawPageToFile.
MozReview-Commit-ID: LQ9LTL8ZRKJ
2e6e0d91d4390f8bc25c214a6fdc6a5b0148ec37: Bug 1395387 - Reconcile WebExtension page actions and Photon page actions.
draft
Drew Willcoxon <adw@mozilla.com> - Fri, 22 Sep 2017 21:41:59 -0700 - rev 669436
Push
81326 by dwillcoxon@mozilla.com at Sat, 23 Sep 2017 04:46:33 +0000
Bug 1395387 - Reconcile WebExtension page actions and Photon page actions.
MozReview-Commit-ID: GLWqHebJNBY
1e613129aa7e062d661bd2d1312b728d14af33f9: Bug 1402221: add Telemetry probe to find out rtcp-mux usage. r?bwc
draft
Nils Ohlmeier [:drno] <drno@ohlmeier.org> - Fri, 22 Sep 2017 00:09:52 -0700 - rev 669435
Push
81325 by drno@ohlmeier.org at Sat, 23 Sep 2017 03:37:35 +0000
Bug 1402221: add Telemetry probe to find out rtcp-mux usage. r?bwc
MozReview-Commit-ID: 1XmPbpSmAb1
66c4b8019ea773657abfdcd6cc642f202a42c8b7: Bug 1396094 - Handle change event of textTracks to update the closed caption UI state. r=jaws
draft
Ray Lin <ralin@mozilla.com> - Sat, 23 Sep 2017 10:51:47 +0800 - rev 669434
Push
81324 by bmo:ralin@mozilla.com at Sat, 23 Sep 2017 03:00:41 +0000
Bug 1396094 - Handle change event of textTracks to update the closed caption UI state. r=jaws
MozReview-Commit-ID: KpjXhxUPDKR
0225897f5fe759577e638935c6230ea32b4e8f01: Bug 1400936: Crashtests. r?bholley
draft
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 23 Sep 2017 00:12:33 +0200 - rev 669433
Push
81323 by bmo:emilio@crisal.io at Sat, 23 Sep 2017 02:54:45 +0000
Bug 1400936: Crashtests. r?bholley
MozReview-Commit-ID: 6Q07StWSog
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
efcc13d22c45dacb4a888d9a8af9c38f9a9de854: Bug 1400936: Clear servo data after children data is cleared, and allow setting the root as the document if the tree is mid-unbind. r?bholley
draft
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 23 Sep 2017 00:05:47 +0200 - rev 669432
Push
81323 by bmo:emilio@crisal.io at Sat, 23 Sep 2017 02:54:45 +0000
Bug 1400936: Clear servo data after children data is cleared, and allow setting the root as the document if the tree is mid-unbind. r?bholley
This is the actual fix, and makes sure that the state is consistent even if we
notify of state changes on a parent during unbind.
We potentially do a bit more work than needed given we set the document as the
root in that case instead of the parent which could potentially be the root
itself, but that's not a huge deal I think, given these cases are rare.
If this happens to be a perf problem, we may want to just drop the root during
UnbindFromTree if aNullParent == true and the root is a descendant of `this`.
MozReview-Commit-ID: A9d2igM0hMr
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
f2186b245fc1119734e708e8ae6df313fd78094b: Bug 1400936: Only tear down the servo data in SetXBLInsertionParent if the parent actually changed. r?bholley
draft
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 23 Sep 2017 00:02:59 +0200 - rev 669431
Push
81323 by bmo:emilio@crisal.io at Sat, 23 Sep 2017 02:54:45 +0000
Bug 1400936: Only tear down the servo data in SetXBLInsertionParent if the parent actually changed. r?bholley
This is the reason similar assertion failures can't be reproduced with elements
and stuff like fieldset and form validity changes.
nsBindingManager::ContentRemoved calls SetXBLInsertionParent, which clears all
the Servo data from the subtree eagerly, which is a waste when the actual
binding parent is the same (null).
MozReview-Commit-ID: A5wLKfD4OTL
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
e2b5747346b787bcc89d75716d300656d057b7b3: Bug 1400936: Remove dumb null check. r?bholley
draft
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 23 Sep 2017 00:02:30 +0200 - rev 669430
Push
81323 by bmo:emilio@crisal.io at Sat, 23 Sep 2017 02:54:45 +0000
Bug 1400936: Remove dumb null check. r?bholley
MozReview-Commit-ID: CLs2UcA8DF9
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
08e7d627c2017392af5ba26086e682a61cbc88dd: Bug 1401706: Crashtest. r=me
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 23 Sep 2017 04:10:22 +0200 - rev 669429
Push
81323 by bmo:emilio@crisal.io at Sat, 23 Sep 2017 02:54:45 +0000
Bug 1401706: Crashtest. r=me
MozReview-Commit-ID: Jf0n4f4kMhl