2c03e85a4d967c97a2c44f782e8d13eab657eb25: Bug 1377003 - [Photon] Update sidebar tree styling on Linux. r=dao draft
Nihanth Subramanya <nhnt11@gmail.com> - Tue, 18 Jul 2017 19:06:10 +0530 - rev 643201
Push 73015 by nhnt11@gmail.com at Wed, 09 Aug 2017 11:02:34 +0000
Bug 1377003 - [Photon] Update sidebar tree styling on Linux. r=dao MozReview-Commit-ID: 3ZUJZsIc7Zq
79dd06fdbf813a89868744314cb8c4918dad31f4: Bug 1388368 - Fix the Console panel in Launchpad; r=? draft
Jan Odvarko <odvarko@gmail.com> - Wed, 09 Aug 2017 12:49:37 +0200 - rev 643200
Push 73014 by jodvarko@mozilla.com at Wed, 09 Aug 2017 10:50:06 +0000
Bug 1388368 - Fix the Console panel in Launchpad; r=? MozReview-Commit-ID: 9tv7xAvPxZI
f73fc533c96a562fe47765df3deb999bc7e64982: Bug 1307931 - Make urls in output clickable; r=bgrins. draft
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 03 Aug 2017 16:25:40 +0200 - rev 643199
Push 73013 by bmo:nchevobbe@mozilla.com at Wed, 09 Aug 2017 10:42:55 +0000
Bug 1307931 - Make urls in output clickable; r=bgrins. This passes an openLink callback to the Reps which handles the output. MozReview-Commit-ID: L6q9wAWmwrp
743006536e340a335a68a07dd0c0fb4c209ac56c: Bug 1377174 - Tweak margin to match the spec r?jaws draft
Ricky Chien <ricky060709@gmail.com> - Wed, 26 Jul 2017 15:00:55 +0800 - rev 643198
Push 73012 by bmo:rchien@mozilla.com at Wed, 09 Aug 2017 10:33:23 +0000
Bug 1377174 - Tweak margin to match the spec r?jaws MozReview-Commit-ID: GKZb427Ahum
212bb1e90d2f41d8781d1b64689a48023c00c0f7: Bug 1388444 - Left hand side tabs are not keyboard accessible r?mconley draft
Ricky Chien <ricky060709@gmail.com> - Wed, 09 Aug 2017 17:52:02 +0800 - rev 643197
Push 73011 by bmo:rchien@mozilla.com at Wed, 09 Aug 2017 10:27:24 +0000
Bug 1388444 - Left hand side tabs are not keyboard accessible r?mconley
c4560b378cfd5565d56eaff9dbfed07ec2a7055e: Bug 1369415 - Share bookmarks toolbar styling to remove cross-platform inconsistencies, add extra bottom padding on Mac. r?johannh draft
Dão Gottwald <dao@mozilla.com> - Wed, 09 Aug 2017 12:26:26 +0200 - rev 643196
Push 73010 by dgottwald@mozilla.com at Wed, 09 Aug 2017 10:26:47 +0000
Bug 1369415 - Share bookmarks toolbar styling to remove cross-platform inconsistencies, add extra bottom padding on Mac. r?johannh MozReview-Commit-ID: JUOZw39WTHE
7f928a8411327cc2f95592438ab0ec7f327f504b: Bug 1387128: Drop all promise = require("promise") and replace promise by Promise. r=tromey draft
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 09 Aug 2017 12:23:33 +0200 - rev 643195
Push 73009 by bmo:poirot.alex@gmail.com at Wed, 09 Aug 2017 10:25:45 +0000
Bug 1387128: Drop all promise = require("promise") and replace promise by Promise. r=tromey Part5: manually get rid of some require("promise") leftovers. MozReview-Commit-ID: G9JiSX7gRBy
ed5bdf9a30d3b05ab608818c01ce4e411bb94240: Bug 1387128: Drop all promise = require("promise") and replace promise by Promise. r=tromey draft
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 09 Aug 2017 12:11:48 +0200 - rev 643194
Push 73009 by bmo:poirot.alex@gmail.com at Wed, 09 Aug 2017 10:25:45 +0000
Bug 1387128: Drop all promise = require("promise") and replace promise by Promise. r=tromey Part4: also remove lazy require for "promise" $ sed -i '/lazyRequireGetter(this, "promise")/d' $(egrep -rl 'lazyRequireGetter\(this, "promise"\)' devtools) MozReview-Commit-ID: 2ikcfUW9lIu
b660322b1bb24deff01f27e5ae0e24381befe1f5: Bug 1387128: Drop all promise = require("promise") and replace promise by Promise. r=tromey draft
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 09 Aug 2017 11:49:59 +0200 - rev 643193
Push 73009 by bmo:poirot.alex@gmail.com at Wed, 09 Aug 2017 10:25:45 +0000
Bug 1387128: Drop all promise = require("promise") and replace promise by Promise. r=tromey Part3: There should be no more usage of `promise` symbol anymore, so drop all `require("promise")`. $ sed -i '/promise = require("promise")/d' $(egrep -rl 'require\("promise"\)' devtools) But ignore debugger, which is going to be handled manually in bug 1388364. $ git checkout devtools/client/debugger/ And client's main, which also still uses deprecated-sync promises: $ git checkout devtools/shared/client/main.js MozReview-Commit-ID: 885OBLVIxep
8b459dd8f744a37463e1d8a0e53388e003018e6e: Bug 1387128: Drop all promise = require("promise") and replace promise by Promise. r=tromey draft
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 09 Aug 2017 11:48:46 +0200 - rev 643192
Push 73009 by bmo:poirot.alex@gmail.com at Wed, 09 Aug 2017 10:25:45 +0000
Bug 1387128: Drop all promise = require("promise") and replace promise by Promise. r=tromey Part2: Replace all other lower case usages: promise.{resolve,reject,all,race} $ sed -i -E "s/promise\.(resolve|reject|all|race)\(/Promise.\1(/" $(egrep -rlE "promise.(resolve|reject|all|race)\(" devtools) But ignore debugger, which is going to be handled manually in bug 1388364. $ git checkout devtools/client/debugger/ And client's main, which also still uses deprecated-sync promises: $ git checkout devtools/shared/client/main.js MozReview-Commit-ID: 7olcOVfRLzW
dad2c8eb424d6eb71b3de85ef1d03a873d4a6003: Bug 1387128: Drop all promise = require("promise") and replace promise by Promise. r=tromey draft
Alexandre Poirot <poirot.alex@gmail.com> - Wed, 09 Aug 2017 11:35:17 +0200 - rev 643191
Push 73009 by bmo:poirot.alex@gmail.com at Wed, 09 Aug 2017 10:25:45 +0000
Bug 1387128: Drop all promise = require("promise") and replace promise by Promise. r=tromey Part1: replace `new promise` by `new Promise` $ sed -i 's/new promise(/new Promise(/' $(egrep -rl 'new promise' devtools) MozReview-Commit-ID: Gffzy33isl0
ea3130c26073fcf7903012f73b48ab948bbd5340: Bug 1387123 - Replace all usages of require(promise).defer by require(devtools/shared/defer).defer. r=tromey draft
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 08 Aug 2017 15:19:56 +0200 - rev 643190
Push 73009 by bmo:poirot.alex@gmail.com at Wed, 09 Aug 2017 10:25:45 +0000
Bug 1387123 - Replace all usages of require(promise).defer by require(devtools/shared/defer).defer. r=tromey In prevision of Promise.jsm removal, use defer helper module instead of Promise.jsm as that's the only one feature that DOM Promise don't support. PART3: Manual fixes - Go manually fix: http://searchfox.org/mozilla-central/source/devtools/client/dom/dom-panel.js which has duplicated import of defer symbol (it already used to import it) - execute eslint, see all the places where we import of 'promise' is no longer use it (there may be leftovers not covered by eslint that will be covered in bug 1387128) devtools/server/tests/mochitest/inspector-helpers.js needs to keep importing promise as it is a shared test script. - fix devtools/client/performance/panel.js and devtools/client/webconsole/console-output.js which use loader.lazyRequireGetter(this, "promise") and miss the defer import - fix devtools/server/worker.js to use 'worker.require(devtools/shared/defer")' MozReview-Commit-ID: HIOB5Et87Wc
24b1c4c65cdd4281486f81259e2ea27b5d97cd92: Bug 1387123 - Replace all usages of require(promise).defer by require(devtools/shared/defer).defer. r=tromey draft
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 08 Aug 2017 15:24:04 +0200 - rev 643189
Push 73009 by bmo:poirot.alex@gmail.com at Wed, 09 Aug 2017 10:25:45 +0000
Bug 1387123 - Replace all usages of require(promise).defer by require(devtools/shared/defer).defer. r=tromey In prevision of Promise.jsm removal, use defer helper module instead of Promise.jsm as that's the only one feature that DOM Promise don't support. PART2: Substitutes promise.defer usages with defer $ sed -i 's/promise.defer/defer/gI' $(egrep -lir "promise.defer\(\)" devtools) Reset modification to the following files as they are using deprecated syncable promises as we don't want to touch them. http://searchfox.org/mozilla-central/search?q=deprecated-sync-thenables&case=true&regexp=false&path= $ git checkout devtools/client/debugger/test/mochitest/ $ git checkout devtools/shared/client/main.js $ git checkout devtools/client/debugger/ $ git checkout devtools/server/main.js MozReview-Commit-ID: DGN5ae68wtn
d0f36dadd36f18081c7a45773887812a16b4ff38: Bug 1387123 - Replace all usages of require(promise).defer by require(devtools/shared/defer).defer. r=tromey draft
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 08 Aug 2017 15:33:56 +0200 - rev 643188
Push 73009 by bmo:poirot.alex@gmail.com at Wed, 09 Aug 2017 10:25:45 +0000
Bug 1387123 - Replace all usages of require(promise).defer by require(devtools/shared/defer).defer. r=tromey In prevision of Promise.jsm removal, use defer helper module instead of Promise.jsm as that's the only one feature that DOM Promise don't support. PART1: Import devtools/shared/defer $ sed -i '/require("promise")/a const defer = require("devtools/shared/defer");' $(egrep -lir "promise.defer\(\)" $(egrep -rl "require\(\"promise\"\)" devtools)) But ignore debugger as it still uses sync promises and would better be handled manually $ git checkout devtools/client/debugger/ MozReview-Commit-ID: 7FvhNxULB2x
ca1940f0a05187ab06b115dac9950a35dfcab3d5: Bug 1387122 - Remove all useless Promise = require("promise"). r=tromey draft
Alexandre Poirot <poirot.alex@gmail.com> - Mon, 07 Aug 2017 17:53:29 +0200 - rev 643187
Push 73009 by bmo:poirot.alex@gmail.com at Wed, 09 Aug 2017 10:25:45 +0000
Bug 1387122 - Remove all useless Promise = require("promise"). r=tromey Promise with a capital 'P' is already available in all DevTools sandboxes. Still a couple of letfovers: * Modules still using `Promise.defer()` (will be handled in bug 1387123) * devtools/shared/defer, which introduces changes in Promise unhandled exception and stacks (bug 1388054) MozReview-Commit-ID: PBaliHFa7u
e484867c43ac75c35509bfee3836e15a6d095e7b: Bug 1388368 - Fix the Console panel in Launchpad; r=? draft
Jan Odvarko <odvarko@gmail.com> - Wed, 09 Aug 2017 12:17:17 +0200 - rev 643186
Push 73008 by jodvarko@mozilla.com at Wed, 09 Aug 2017 10:17:57 +0000
Bug 1388368 - Fix the Console panel in Launchpad; r=? MozReview-Commit-ID: Acs2RT66uhI
8580e0e9724af45663d66c87f7e3ea64bae9ae4a: Bug 1366664 - Update color and layout. Hide splash screen if first seen. r?walkingice draft
Nevin Chen <cnevinchen@gmail.com> - Wed, 09 Aug 2017 18:13:55 +0800 - rev 643185
Push 73007 by bmo:cnevinchen@gmail.com at Wed, 09 Aug 2017 10:14:49 +0000
Bug 1366664 - Update color and layout. Hide splash screen if first seen. r?walkingice MozReview-Commit-ID: EP6hQIGcdyo
956be67de5d78f7022e9a3f3420fd5d42b72e8dc: Bug 1388647 - part2: Make IMEInputHandler of Cocoa widget handle request to commit/cancel composition synchronously r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 09 Aug 2017 18:41:19 +0900 - rev 643184
Push 73006 by masayuki@d-toybox.com at Wed, 09 Aug 2017 10:04:14 +0000
Bug 1388647 - part2: Make IMEInputHandler of Cocoa widget handle request to commit/cancel composition synchronously r?m_kato When Gecko starts to support Cocoa widget, we needed to use NSInputManager. That allowed applications to access only focused IME context. Therefore, commit composition request handler for Cocoa is designed as handling asynchronosly if it's requested when the window is not active or is being inactivated. Additionally, the asynchronous handling isn't perfect. We hit some MOZ_ASSERT() now in some places. E.g., in SelectedRange(), it doesn't assume that it's called during deactive. On the other hand, NSInputManager was alreay obsolete and we already stopped using it (bug 810225). Instead, we're using NSTextInputContext and it allows applications to access IME anytime. Therefore, if we make IMEInputHandler handles commit/cancel composition requests synchronsly, that behaves same as the other platforms. So, we can get rid of macOS specific issue completely. MozReview-Commit-ID: X7aWmGq95x
c06c11634eaebafe4281b035a2e618531b9122e0: Bug 1388647 - part1: IMEStateManager::OnChangeFocusInternal() shouldn't request to commit composition with sFocusedIMETabParent r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 09 Aug 2017 18:04:28 +0900 - rev 643183
Push 73006 by masayuki@d-toybox.com at Wed, 09 Aug 2017 10:04:14 +0000
Bug 1388647 - part1: IMEStateManager::OnChangeFocusInternal() shouldn't request to commit composition with sFocusedIMETabParent r?m_kato When a remote process has focus and it loses focus, IMEStateManager::OnChangeFocusInternal() sends NOTIFY_IME_OF_BLUR via IMEStateManager::NotifyIMEOfBlurForChildProcess(). Therefore, sFocusedIMETabParent and sFocusedIMEWidget are set to nullptr here. So, if a window becomes active, REQUEST_IME_TO_COMMIT_COMPOSITION in IMEStateManager::OnChangeFocusInternal() won't work because IMEStateManager::NotifyIME() ignores the request because of coming from wrong process. Therefore, IMEStateManager::OnChangeFocusInternal() needs to send REQUEST_TO_COMMIT_COMPOSITION with proper process information which is only stored by TextComposition instance. MozReview-Commit-ID: KNEvOoQtK1E
a10feba2200e3c870782e4b24df1d3f5e1c278e1: Bug 1369309 - Part 4: Modify the test case 'test_video_stats_resistfingerprinting.html'. r?cpearce,arthuredelstein draft
Tim Huang <tihuang@mozilla.com> - Mon, 17 Jul 2017 17:30:08 +0800 - rev 643182
Push 73005 by bmo:tihuang@mozilla.com at Wed, 09 Aug 2017 09:59:56 +0000
Bug 1369309 - Part 4: Modify the test case 'test_video_stats_resistfingerprinting.html'. r?cpearce,arthuredelstein This patch modifies the test case 'test_video_stats_resistfingerprinting.html' to check media statistics report spoofed values when fingerprinting resistance is enabled. This test will play a video and test the media statistics when the video is finished. It will make sure all media statistics report correct spoofed values corresponding to the play time of the video. MozReview-Commit-ID: GpYewu7cIbY
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip