2bd880fdd5f212a070fa6da5691b9850cc6cd54c: Bug 1394586: Unconditionally clear the restyle flags on Element::BindToTree. r?bholley draft
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 29 Aug 2017 16:12:58 +0200 - rev 655093
Push 76771 by bmo:emilio@crisal.io at Tue, 29 Aug 2017 17:08:17 +0000
Bug 1394586: Unconditionally clear the restyle flags on Element::BindToTree. r?bholley The failure here is a <script> that document.writes a whole HTML document, which happens to have the Gecko style back-end. Of all the elements written there, there's an <img> element which triggers a load, which finishes and changes the state of the <img>, posting a restyle event to its Gecko-backed restyle manager. At that point, but before the refresh driver ticks, the element is unbound from the tree, keeping the restyle root bits from the Gecko back-end. Afterwards, the element is bound to a Servo-backed document, so ClearRestyleFlagsIfGecko does nothing (since the document pointer is already set, and points to a Servo-backed document). Furthermore, it's inserted on a display: none subtree, so we never reach it during the traversal to remove the flags. Other alternative fixes for this same issue would be: * Clearing the Gecko restyle flags in UnbindFromTree. Gecko doesn't seem to prevent restyle roots from being outside of the document (it just does nothing when finding them on ProcessPendingRestyles), so it doesn't seem a very reliable solution. * Reorder the flag clearing to be before setting the document in BindToTree. Seems somewhat risky, and for no good reason. MozReview-Commit-ID: B6iZKhGHc3A
3a2ec0b55ead78df01d0a37b300590d3c70b78bd: Bug 1384381 - Intermittent failures in browser_privatebrowsing_placestitle.js and browser_privatebrowsing_placesTitleNoUpdate.js. r=standard8 draft
Marco Bonardo <mbonardo@mozilla.com> - Tue, 29 Aug 2017 18:45:36 +0200 - rev 655092
Push 76770 by mak77@bonardo.net at Tue, 29 Aug 2017 17:02:45 +0000
Bug 1384381 - Intermittent failures in browser_privatebrowsing_placestitle.js and browser_privatebrowsing_placesTitleNoUpdate.js. r=standard8 MozReview-Commit-ID: 8nvln9OLx9S
170437e75672f2c4512bbb9983c01a205d4f2233: Bug 1394874 Fix function order and add include to fix MinGW build draft
Tom Ritter <tom@mozilla.com> - Tue, 29 Aug 2017 11:56:53 -0500 - rev 655091
Push 76769 by bmo:tom@mozilla.com at Tue, 29 Aug 2017 17:00:23 +0000
Bug 1394874 Fix function order and add include to fix MinGW build nsPrintfCString.h was not included, so it caused an error GetStringValue was called before it was defined MozReview-Commit-ID: KUA8idDDI1E
1148b8c8a57bf4cd2a822792ca02c7f713762ca6: Bug 1394875 Add an include to resolve missing type error in MinGW build draft
Tom Ritter <tom@mozilla.com> - Tue, 29 Aug 2017 11:59:15 -0500 - rev 655090
Push 76768 by bmo:tom@mozilla.com at Tue, 29 Aug 2017 16:59:44 +0000
Bug 1394875 Add an include to resolve missing type error in MinGW build MozReview-Commit-ID: 88aSJCrDfTX
ea442d8e943e6a46cabe627eda1dce8d1497d4a4: Bug 1394874 Fix function order and add include to fix MinGW build draft
Tom Ritter <tom@mozilla.com> - Tue, 29 Aug 2017 11:56:53 -0500 - rev 655089
Push 76768 by bmo:tom@mozilla.com at Tue, 29 Aug 2017 16:59:44 +0000
Bug 1394874 Fix function order and add include to fix MinGW build nsPrintfCString.h was not included, so it caused an error GetStringValue was called before it was defined
984a0bde36705194240eb655a6e3951934149a8b: bug 1394871 - add key4.db to password-related file list in Firefox profile migration code r?mossop draft
David Keeler <dkeeler@mozilla.com> - Mon, 28 Aug 2017 12:18:37 -0700 - rev 655088
Push 76767 by bmo:dkeeler@mozilla.com at Tue, 29 Aug 2017 16:59:07 +0000
bug 1394871 - add key4.db to password-related file list in Firefox profile migration code r?mossop NSS stores the password encrypting key in key3.db. When Firefox uses the sqlite-backed NSS databases by default (bug 783994), this file will be called key4.db. The Firefox profile migration code needs to know this. MozReview-Commit-ID: 2KgJdZtCXju
2dbe97873880e9ee93cef7a3bdbac55b16eabc3e: Bug 1383880: add only-if-dependencies-run optimization for follow-ons; r?ahal draft
Dustin J. Mitchell <dustin@mozilla.com> - Fri, 25 Aug 2017 21:18:13 +0000 - rev 655087
Push 76766 by dmitchell@mozilla.com at Tue, 29 Aug 2017 16:56:09 +0000
Bug 1383880: add only-if-dependencies-run optimization for follow-ons; r?ahal MozReview-Commit-ID: JuhwyQIx3Mh
eef59ff75a31cc50837bbe81352fdd869206b648: Bug 1383880: annotate source files with what they SCHEDULE; r?ahal draft
Dustin J. Mitchell <dustin@mozilla.com> - Fri, 25 Aug 2017 19:31:54 +0000 - rev 655086
Push 76766 by dmitchell@mozilla.com at Tue, 29 Aug 2017 16:56:09 +0000
Bug 1383880: annotate source files with what they SCHEDULE; r?ahal MozReview-Commit-ID: CR70dSg5R79
9d38e62cdb7307077aae58ce7c7cfb76397b79e3: Bug 1383880: Annotate builds and tests with SCHEDULES-related optimizations; r?ahal draft
Dustin J. Mitchell <dustin@mozilla.com> - Fri, 25 Aug 2017 19:15:12 +0000 - rev 655085
Push 76766 by dmitchell@mozilla.com at Tue, 29 Aug 2017 16:56:09 +0000
Bug 1383880: Annotate builds and tests with SCHEDULES-related optimizations; r?ahal This means that a push to try affecting only Android will only run android builds and tests, for example. MozReview-Commit-ID: HVUvIg0EUZn
efa00cf59766c57ca1cedd06ccea92e7117eda4b: Bug 1383880: add support for optimizing tasks based on SCHEDULES; r?ahal draft
Dustin J. Mitchell <dustin@mozilla.com> - Wed, 23 Aug 2017 16:21:06 +0000 - rev 655084
Push 76766 by dmitchell@mozilla.com at Tue, 29 Aug 2017 16:56:09 +0000
Bug 1383880: add support for optimizing tasks based on SCHEDULES; r?ahal This adds some new optimization strategies. For tests, we use Either(SETA, SkipUnlessSchedules), thereby giving both mechanisms a chance to skip tasks. On try, SETA is omitted. MozReview-Commit-ID: GL4tlwyeBa6
b87687ff1e7d83d01840478c6cf9f780953f2a28: Bug 1383880: add support for SCHEDULES in moz.build; r?gps draft
Dustin J. Mitchell <dustin@mozilla.com> - Mon, 31 Jul 2017 20:44:56 +0000 - rev 655083
Push 76766 by dmitchell@mozilla.com at Tue, 29 Aug 2017 16:56:09 +0000
Bug 1383880: add support for SCHEDULES in moz.build; r?gps MozReview-Commit-ID: 2pfLr0VTy2J
89580a21565889143db5f778b3b0bca52ca62796: Bug 1383880: parse try config during the decision task; r?ahal draft
Dustin J. Mitchell <dustin@mozilla.com> - Mon, 21 Aug 2017 23:14:14 +0000 - rev 655082
Push 76766 by dmitchell@mozilla.com at Tue, 29 Aug 2017 16:56:09 +0000
Bug 1383880: parse try config during the decision task; r?ahal This sets the try_mode property, and parses the try message (if given), early in the decision task and puts the results into the parameters. The proximate need is to set optimze_target_tasks for some try modes and not others. This also replaces the existing logic for parsing messages for certain kinds, and makes the distinction between the different try modes a little clearer. MozReview-Commit-ID: AXJEGLh6pEV
ac0d4f8d8af2ae0358f1b20528812eac482b1740: Bug 1383880: optimize in three phases; r?ahal draft
Dustin J. Mitchell <dustin@mozilla.com> - Sun, 20 Aug 2017 20:00:17 +0000 - rev 655081
Push 76766 by dmitchell@mozilla.com at Tue, 29 Aug 2017 16:56:09 +0000
Bug 1383880: optimize in three phases; r?ahal In preparation for much more thorough optimization of task-graphs, this makes a few changes: * optimization is split into thre phases, with task removal in one phase (following dependency links) and task replacement in the next (in the reverse order). * optimization uses class instances instead of functions for optimizations; this allows different functions for different phases, and also leaves open the possibility of composing optimizations. * the replacement phase can also support removal; this is when utility tasks like symbol uploads can be optimized away iff their parent task is optimized. MozReview-Commit-ID: C5QznNpwqXn
3cc2ca1a6811d376be4c24f2c875b9542a037cf2: Bug 1383880: add Graph.visit_preorder; r?ahal draft
Dustin J. Mitchell <dustin@mozilla.com> - Sun, 20 Aug 2017 16:29:12 +0000 - rev 655080
Push 76766 by dmitchell@mozilla.com at Tue, 29 Aug 2017 16:56:09 +0000
Bug 1383880: add Graph.visit_preorder; r?ahal MozReview-Commit-ID: BWGqLUuWlN9
0589d9257c7afd3282a9827ce130d7da7d2fae39: bug 1394871 - add key4.db to password-related file list in Firefox profile migration code r?mossop draft
David Keeler <dkeeler@mozilla.com> - Mon, 28 Aug 2017 12:18:37 -0700 - rev 655079
Push 76765 by bmo:dkeeler@mozilla.com at Tue, 29 Aug 2017 16:55:46 +0000
bug 1394871 - add key4.db to password-related file list in Firefox profile migration code r?mossop NSS stores the password encrypting key in key3.db. When Firefox uses the sqlite-backed NSS databases by default (bug 783994), this file will be called key4.db. The Firefox profile migration code needs to know this. MozReview-Commit-ID: 2KgJdZtCXju
b413ef73108b6088b289966ce7d6d432328f49c3: bug 1394532 - fix up modeline in FirefoxProfileMigrator.js r?mossop draft
David Keeler <dkeeler@mozilla.com> - Mon, 28 Aug 2017 12:08:09 -0700 - rev 655078
Push 76765 by bmo:dkeeler@mozilla.com at Tue, 29 Aug 2017 16:55:46 +0000
bug 1394532 - fix up modeline in FirefoxProfileMigrator.js r?mossop MozReview-Commit-ID: ChPuFDYrbDt
0ae86aaab7ead389d9ec87b6501ae3753d6fd6cf: Bug 1390093 - Add whydidyouupdate mixin to React components r?jlast draft
Michael Ratcliffe <mratcliffe@mozilla.com> - Tue, 29 Aug 2017 11:50:36 +0100 - rev 655077
Push 76764 by bmo:mratcliffe@mozilla.com at Tue, 29 Aug 2017 16:42:27 +0000
Bug 1390093 - Add whydidyouupdate mixin to React components r?jlast @Jason: You only really need to review devtools/shared/mixinService.js because you already r+ssed the rest of the changes. This patch just provides a simple way for us to add plugins to **all** our React components. As for the whydidyouupdate mixin: I am sure you need no introduction. This mixin outputs to the browser console. It is great for understanding why a particular React render was called. I am in the process of creating another mixin that outputs shouldComponentUpdate methods... hopefully. MozReview-Commit-ID: D7adUCMpvOA
d4977c821a14d418a154f3daf8a20bd21c79168e: Bug 1394849 - Add error.stack to create stacktraces. r?automatedtester draft
Andreas Tolfsen <ato@sny.no> - Tue, 29 Aug 2017 17:34:37 +0100 - rev 655076
Push 76763 by bmo:ato@sny.no at Tue, 29 Aug 2017 16:36:34 +0000
Bug 1394849 - Add error.stack to create stacktraces. r?automatedtester This patch introduces a new error.stack function as a shorthand for creating stacktraces. It is equivalent to calling new Error().stack and removing the first line of the stack. Removing the first line is needed to make it appear as if the error originated from the caller's position in the program. MozReview-Commit-ID: DpSSWU5vPDm
d357b67492a5a842f3dcbc96bf9e3e06a782102e: Bug 1394849 - Export pprint separately. r?automatedtester draft
Andreas Tolfsen <ato@sny.no> - Tue, 29 Aug 2017 17:33:38 +0100 - rev 655075
Push 76763 by bmo:ato@sny.no at Tue, 29 Aug 2017 16:36:34 +0000
Bug 1394849 - Export pprint separately. r?automatedtester pprint is currently exposed twice: once on the error namespace and once separately. We only want to expose it once, and since there are only a handful "error.pprint" usages left, we can go ahead and make this change. When we move transition to use "require" in the future, like devtools does, it will be possible to use both "error.pprint" and "pprint" styles without export duplication. MozReview-Commit-ID: CAnPDWn9Vr7
81bb99509815770c0ce10689108b2cca91ecc44f: Bug 1394868 Fix include casing in VTableBuilder.h to fix MinGW build draft
Tom Ritter <tom@mozilla.com> - Tue, 29 Aug 2017 11:34:58 -0500 - rev 655074
Push 76762 by bmo:tom@mozilla.com at Tue, 29 Aug 2017 16:35:10 +0000
Bug 1394868 Fix include casing in VTableBuilder.h to fix MinGW build MozReview-Commit-ID: 8YHKyOOd7S5
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip