2790be26fe1665a79b37887ebd6123a7939beaaa: Bug 1460509 - part 75: Make HTMLEditRules::DeleteNonTableElements() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 17 May 2018 23:46:00 +0900 - rev 798793
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 75: Make HTMLEditRules::DeleteNonTableElements() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: 9SIBECF8s1R
1aacc148d12799d83bc74b115da1e2377f063c69: Bug 1460509 - part 74: Make HTMLEditRules::DidDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 17 May 2018 23:21:52 +0900 - rev 798792
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 74: Make HTMLEditRules::DidDeleteSelection() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: E3LGBAbaw7N
e98e1f80a80fdfcfd57d56579a8589285c9a5df1: Bug 1460509 - part 73: Make HTMLEditRules::WillMakeList() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 17 May 2018 20:51:56 +0900 - rev 798791
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 73: Make HTMLEditRules::WillMakeList() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: 6qTXENBW8tV
84c52ed3b7c0c73944a053dcbe72e89fca525c6b: Bug 1460509 - part 72: Mark HTMLEditRules::WillRemoveList() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 17 May 2018 20:27:53 +0900 - rev 798790
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 72: Mark HTMLEditRules::WillRemoveList() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED r?m_kato Additionally, it creates AutoSelectionRestorer. So, this patch adds CanHandleEditAction() check after its caller since even if it returns NS_OK, the editor might have been gone. MozReview-Commit-ID: BgIbpHFFPE1
bb20a0b9d5f005293116c9cb99277637c2127482: Bug 1460509 - part 71: Mark HTMLEditRules::WillMakeDefListItem() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 17 May 2018 20:18:49 +0900 - rev 798789
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 71: Mark HTMLEditRules::WillMakeDefListItem() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED r?m_kato MozReview-Commit-ID: LrLmebLbwWm
5a402d861d0ed429a59a136231ed7d24518d79e5: Bug 1460509 - part 70: Mark HTMLEditRules::WillMakeBasicBlock() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 17 May 2018 20:01:19 +0900 - rev 798788
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 70: Mark HTMLEditRules::WillMakeBasicBlock() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED r?m_kato MozReview-Commit-ID: 6mfoqUWync8
1adc8c22446a3b9bd313193f8bacc5e5681d22ae: Bug 1460509 - part 69: Make HTMLEditRules::MakeBasicBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 17 May 2018 19:56:41 +0900 - rev 798787
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 69: Make HTMLEditRules::MakeBasicBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: Gfnai2runLs
ba48afee92855afc89673bdc0305af73f619cc7b: Bug 1460509 - part 68: Mark HTMLEditRules::DidMakeBasicBlock() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 17 May 2018 19:05:26 +0900 - rev 798786
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 68: Mark HTMLEditRules::DidMakeBasicBlock() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED r?m_kato MozReview-Commit-ID: 5ZxF0ArbnLU
e3cac1b7ff6fee7af79e288a9e5cfa82f2eeb0b8: Bug 1460509 - part 67: Mark HTMLEditRules::WillIndent() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 17 May 2018 18:34:00 +0900 - rev 798785
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 67: Mark HTMLEditRules::WillIndent() as MOZ_MUST_USE since it may return NS_ERROR_EDITOR_DESTROYED r?m_kato MozReview-Commit-ID: 3lP4jp2nOQy
2179a856265febf7b51b8cd6c56ba1731003ea33: Bug 1460509 - part 66: Make HTMLEditRules::WillCSSIndent() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 17 May 2018 18:27:35 +0900 - rev 798784
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 66: Make HTMLEditRules::WillCSSIndent() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: nnnC5VDpk8
5fd52aa507ec628eddc0e1cb53ee2d3e42dbedaf: Bug 1460509 - part 65: Make HTMLEditRules::WillHTMLIndent() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 17 May 2018 18:14:01 +0900 - rev 798783
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 65: Make HTMLEditRules::WillHTMLIndent() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: 2jZh8GtC7BA
fd141fa5b3cb8ef9c821b0daac382a3770278797: Bug 1460509 - part 64: Make HTMLEditRules::WillOutdent() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 17 May 2018 17:57:09 +0900 - rev 798782
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 64: Make HTMLEditRules::WillOutdent() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato And this patch creates a new method, OutdentAroundSelection(), to check if restoring Selection with AutoSelectionRestorer causes destroying the editor. However, this does NOT change any logic in the new method except changing some else-if blocks to if blocks with early-return style. MozReview-Commit-ID: JMIo4kUOkwx
841f2930f0e48f38bd89989306314e943f653b51: Bug 1460509 - part 63: Make HTMLEditRules::RemovePartOfBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 17 May 2018 17:13:04 +0900 - rev 798781
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 63: Make HTMLEditRules::RemovePartOfBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato And this patch renames it to SplitRangeOffFromBlockAndRemoveMiddleContainer() for making the name explain what it does. MozReview-Commit-ID: 546dnCeoGOV
2e022b1173c768f4d7c1378793e8cbdb72f63f17: Bug 1460509 - part 62: Make HTMLEditRules::OutdentPartOfBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 17 May 2018 16:53:18 +0900 - rev 798780
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 62: Make HTMLEditRules::OutdentPartOfBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: 7IkBuQ6Tr3P
628d6f26bd9f2054da351592bf1dcf1e0d69e17e: Bug 1460509 - part 61: Make HTMLEditRules::SplitBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 17 May 2018 16:28:52 +0900 - rev 798779
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 61: Make HTMLEditRules::SplitBlock() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato And this patch renames it to SplitRangeOffFromBlock() for making the name explain what it does since "split" is used as splitting to two nodes widely in editor. MozReview-Commit-ID: GrRu5sI4yrP
df2b6285101f7ad3bb5c17055c0e41891d5187fa: Bug 1460509 - part 60: Make HTMLEditRules::ConvertListType() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 17 May 2018 14:28:47 +0900 - rev 798778
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 60: Make HTMLEditRules::ConvertListType() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: 1xbR3f73NR1
7b93bc7c22082f29e55b05864ee5ed6a85e8aa91: Bug 1460509 - part 59: Make HTMLEditRules::CreateStyleForInsertText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 16 May 2018 15:36:20 +0900 - rev 798777
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 59: Make HTMLEditRules::CreateStyleForInsertText() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: GsBcGxfJhbb
f61b6a2b5cf0b76912b41c18dbad8cadb7e03893: Bug 1460509 - part 58: Make HTMLEditRules::WillAlign() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 16 May 2018 15:23:52 +0900 - rev 798776
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 58: Make HTMLEditRules::WillAlign() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: L6rjqZABqsI
4511e5964295d84fad6b73f9085132e2bf5763b6: Bug 1460509 - part 57: Mark HTMLEditRules::AlignInnerBlocks() as MOZ_MUST_USE since it may cause destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 16 May 2018 14:54:33 +0900 - rev 798775
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 57: Mark HTMLEditRules::AlignInnerBlocks() as MOZ_MUST_USE since it may cause destroying the editor r?m_kato MozReview-Commit-ID: 8hBJPn1shZu
4abbd928c523da899bd2a47ecb780041de3acb4b: Bug 1460509 - part 56: Make HTMLEditRules::AlignBlockContents() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 16 May 2018 14:45:34 +0900 - rev 798774
Push 110840 by masayuki@d-toybox.com at Wed, 23 May 2018 13:41:58 +0000
Bug 1460509 - part 56: Make HTMLEditRules::AlignBlockContents() return NS_ERROR_EDITOR_DESTROYED if it causes destroying the editor r?m_kato MozReview-Commit-ID: Jn4m4uTdLtW
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip