2607c50a69854e349b2ad4916a6294e0bb195a38: Bug 1424798 - stylo: Add reftest; r=hiro
Manish Goregaokar <manishearth@gmail.com> - Mon, 18 Dec 2017 18:17:03 -0800 - rev 713069
Push 93528 by kgupta@mozilla.com at Tue, 19 Dec 2017 14:18:06 +0000
Bug 1424798 - stylo: Add reftest; r=hiro MozReview-Commit-ID: FsALAIEmHql
32eb8bbad8cbdbbdd0bec756409064a3f331b7b9: Bug 1404454 - use about:blank as the inital page of the testing iframe. r=dragana
Shih-Chiang Chien <schien@mozilla.com> - Sat, 09 Dec 2017 20:31:29 -0600 - rev 713068
Push 93528 by kgupta@mozilla.com at Tue, 19 Dec 2017 14:18:06 +0000
Bug 1404454 - use about:blank as the inital page of the testing iframe. r=dragana In our test script we set the unload handler on the inner iframe earlier than the page is loaded, therefore it pass the origin check since the contentWindow object is for about:blank. Security error will raise if the OnStartRequest for that iframe is received beforehand. Use about:blank can guarantee to have same-origin window on the inner iframe. MozReview-Commit-ID: 8AiwGIfoF4
2166b03540e9f4973c3f0de347c8a9ef4e555e27: Bug 1425318 - Add MOZ_MUST_USE to methods in nsIURIMutator.idl r=mayhemer
Valentin Gosu <valentin.gosu@gmail.com> - Tue, 19 Dec 2017 02:16:36 +0100 - rev 713067
Push 93528 by kgupta@mozilla.com at Tue, 19 Dec 2017 14:18:06 +0000
Bug 1425318 - Add MOZ_MUST_USE to methods in nsIURIMutator.idl r=mayhemer * adds MOZ_MUST_USE to C++ methods and [must_use] to idl interfaces * Rearranges the code so it's more readable, and it fits within 80 chars * Fixes indentation in BaseURIMutator MozReview-Commit-ID: 3vG5eVaOC9U
b0f9fe04079c20ff7fbcb2bf131ff4b1e77241f2: Bug 1425318 - The second call to NS_MutateURI.Finalize should fail r=mayhemer
Valentin Gosu <valentin.gosu@gmail.com> - Tue, 19 Dec 2017 02:06:45 +0100 - rev 713066
Push 93528 by kgupta@mozilla.com at Tue, 19 Dec 2017 14:18:06 +0000
Bug 1425318 - The second call to NS_MutateURI.Finalize should fail r=mayhemer MozReview-Commit-ID: 4U2XsftU2sy
bf4b28e3e513fd29caf81d3bfdfe694008ef8877: Bug 1425318 - Allow calling NS_MutateURI.Finalize(nsIURI**) r=mayhemer
Valentin Gosu <valentin.gosu@gmail.com> - Tue, 19 Dec 2017 02:04:40 +0100 - rev 713065
Push 93528 by kgupta@mozilla.com at Tue, 19 Dec 2017 14:18:06 +0000
Bug 1425318 - Allow calling NS_MutateURI.Finalize(nsIURI**) r=mayhemer MozReview-Commit-ID: Hz4CfDDS1FI
ba242fe9760e1744c2bdb463bbc679a741254cd5: servo: Merge #19604 - stylo: Correctly handle interpolation where optional second argument for translate(), skew(), scale() exists in one but not the other (from Manishearth:animate-second); r=emilio
Manish Goregaokar <manishearth@gmail.com> - Mon, 18 Dec 2017 20:46:31 -0600 - rev 713064
Push 93528 by kgupta@mozilla.com at Tue, 19 Dec 2017 14:18:06 +0000
servo: Merge #19604 - stylo: Correctly handle interpolation where optional second argument for translate(), skew(), scale() exists in one but not the other (from Manishearth:animate-second); r=emilio r=emilio https://bugzilla.mozilla.org/show_bug.cgi?id=1424798 Source-Repo: https://github.com/servo/servo Source-Revision: 861ceb10eadcd8e73c54a85336d081432813b2b1
251fb7b394132abe8947b526def1318a59fd65e3: Bug 1425771 - Add a branch in only_one_restyling_after_finish_is_called for the conformant Promise handling. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 18 Dec 2017 14:19:39 +0900 - rev 713063
Push 93528 by kgupta@mozilla.com at Tue, 19 Dec 2017 14:18:06 +0000
Bug 1425771 - Add a branch in only_one_restyling_after_finish_is_called for the conformant Promise handling. r=birtles Animation.finish() in a micro task for Animation.ready leads to a restyle and a redundant restyle due to bug 1415457. The redundant restyle has been observed in a single frame without the conformant Promise handling. But once we have the conformant Promise handling we can tell it in a later frame. (see https://bugzilla.mozilla.org/show_bug.cgi?id=1415457#c1 to know what's going on there) MozReview-Commit-ID: FoojunfYZ6k
4f15412de9e861ebca0cd7f63a99ffff7a204a59: Bug 1425771 - Tweak expected restyle count for the case where the animation begins at the current time. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 18 Dec 2017 14:19:26 +0900 - rev 713062
Push 93528 by kgupta@mozilla.com at Tue, 19 Dec 2017 14:18:06 +0000
Bug 1425771 - Tweak expected restyle count for the case where the animation begins at the current time. r=birtles The expected restyle count depends both on animation state and micro task handling. If we have the conformant Promise handling and if the animation begins at the current time, we will observe 1 less restyles than observed frames since we skip the first restyle in the initial frame. This represents correctly what we do and what we *should* do. If we don't have the conformant Promise handling and if the animation doesn't begin at the current time, we will observe 1 more restyles than obsered frames since the Promise in observeStyling (precisely the Promise is inside the callback for requestAnimationFrame) is fulfilled once after a restyling process followed by the requestAnimationFrame. MozReview-Commit-ID: FLhSRx4y1V7
defd32520915be804c88754236b856656e180f03: Bug 1425771 - Add a another variant of restyling_transform_animations_in_scrolled_out_element for the conformant Promise handling. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 18 Dec 2017 14:18:17 +0900 - rev 713061
Push 93528 by kgupta@mozilla.com at Tue, 19 Dec 2017 14:18:06 +0000
Bug 1425771 - Add a another variant of restyling_transform_animations_in_scrolled_out_element for the conformant Promise handling. r=birtles The test case checks document timeline's currentTime to make sure that we are in the first frame which happened after 200ms since the animation started. It is unfortunate for us from the point of view of restyling that the first frame includes the restyling process in the frame without the conformant Promise handling, doesn't include the process with the Promise handling. So we need to tweak there depends on the Promise handling. I did intentionally add the forked version of the function with the same name since branching depending on the conformant flag inside the original function will be hard to understand and also we can easily remove the original version once we have the conformant Promise handling. FWIW, here is the diff between them: @@ -365,6 +365,9 @@ waitForAllPaints(() => { await SpecialPowers.pushPrefEnv({ set: [["ui.showHideScrollbars", 1]] }); + // Make sure we start from the state right after requestAnimationFrame. + await waitForFrame(); + var parentElement = addDiv(null, { style: 'overflow-y: scroll; height: 20px;' }); var div = addDiv(null, @@ -379,13 +382,17 @@ waitForAllPaints(() => { var markers; var now; while (true) { - markers = await observeStyling(1); - // Check restyle markers until 200ms is elapsed. now = document.timeline.currentTime; if ((now - timeAtStart) >= 200) { + // If the current time has elapsed over 200ms since the animation was + // created, it means that the animation should have already + // unthrottled in this tick, let's see what observes in this tick's + // restyling process. + markers = await observeStyling(1); break; } + markers = await observeStyling(1); is(markers.length, 0, 'Transform animation running on the element which is scrolled out ' + 'should be throttled until 200ms is elapsed'); MozReview-Commit-ID: 3WfY6aVnsXk
23541a04b9240654bf2c21c68159a16fe1bd74e1: Bug 1425771 - Add a function to check detect whether have conformant Promise handling and set the flag to represent it. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Mon, 18 Dec 2017 14:17:44 +0900 - rev 713060
Push 93528 by kgupta@mozilla.com at Tue, 19 Dec 2017 14:18:06 +0000
Bug 1425771 - Add a function to check detect whether have conformant Promise handling and set the flag to represent it. r=birtles MozReview-Commit-ID: FbzaUBKQ47F
917b5ee4fe132f6bbc6f6baa8e1f6f07cf04b2d8: Backed out changeset fc0b6106be47 (bug 1425807) for static build bustage
Phil Ringnalda <philringnalda@gmail.com> - Mon, 18 Dec 2017 18:31:20 -0800 - rev 713059
Push 93528 by kgupta@mozilla.com at Tue, 19 Dec 2017 14:18:06 +0000
Backed out changeset fc0b6106be47 (bug 1425807) for static build bustage CLOSED TREE
fc0b6106be4772915e148d7829e6d61aded06310: Bug 1425807 - Convert nsHostKey members to nsCString. r=valentin
Jeff Hemphill <jthemphill@gmail.com> - Mon, 18 Dec 2017 11:27:38 -0800 - rev 713058
Push 93528 by kgupta@mozilla.com at Tue, 19 Dec 2017 14:18:06 +0000
Bug 1425807 - Convert nsHostKey members to nsCString. r=valentin MozReview-Commit-ID: 8tZUukA8Rrk
4309d6abe27f88b9dcc90b59a69b469df6da959e: Bug 1425878 - Don't expose raw pointers to refcounted vsync dispatcher object. r=sotaro
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 18 Dec 2017 13:33:56 -0500 - rev 713057
Push 93528 by kgupta@mozilla.com at Tue, 19 Dec 2017 14:18:06 +0000
Bug 1425878 - Don't expose raw pointers to refcounted vsync dispatcher object. r=sotaro MozReview-Commit-ID: 5ywkZqfY8uZ
31c635f8f249de38c1378ac0b88ea091c13134f5: servo: Merge #19601 - style: Don't adjust :visited styles (from emilio:adjust-visited); r=upsuper
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 18 Dec 2017 18:00:27 -0600 - rev 713056
Push 93528 by kgupta@mozilla.com at Tue, 19 Dec 2017 14:18:06 +0000
servo: Merge #19601 - style: Don't adjust :visited styles (from emilio:adjust-visited); r=upsuper As the comment says those are not interesting, and it matches what we do for text and placeholders in Servo_ComputedValues_Inherit. This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1425893 Source-Repo: https://github.com/servo/servo Source-Revision: d6797db10054dd42a7e96ce2ca8198838b068c81
ce813e8a46832f31a3c696880a8554e63b923fb8: Backed out changeset 966836866e8a (bug 1425807) for Build Bustage. r=backout on a CLOSED TREE
Csoregi Natalia <ncsoregi@mozilla.com> - Tue, 19 Dec 2017 03:09:04 +0200 - rev 713055
Push 93528 by kgupta@mozilla.com at Tue, 19 Dec 2017 14:18:06 +0000
Backed out changeset 966836866e8a (bug 1425807) for Build Bustage. r=backout on a CLOSED TREE
095928b49caa8918ac6354044100ed3be6c0b9f6: Backed out changeset 8a71f6e05783 (bug 1393287) for Hazard Build Bustage. r=backout on a CLOSED TREE
Csoregi Natalia <ncsoregi@mozilla.com> - Tue, 19 Dec 2017 02:49:50 +0200 - rev 713054
Push 93528 by kgupta@mozilla.com at Tue, 19 Dec 2017 14:18:06 +0000
Backed out changeset 8a71f6e05783 (bug 1393287) for Hazard Build Bustage. r=backout on a CLOSED TREE
440c32f8f0a9b5d663e8cc634262634e3f249f81: Bug 1424721 - Allow long strings and invisible-to-debugger objects to be stored as global variables. r=nchevobbe
Oriol Brufau <oriol-bugzilla@hotmail.com> - Mon, 18 Dec 2017 12:52:31 +0100 - rev 713053
Push 93528 by kgupta@mozilla.com at Tue, 19 Dec 2017 14:18:06 +0000
Bug 1424721 - Allow long strings and invisible-to-debugger objects to be stored as global variables. r=nchevobbe MozReview-Commit-ID: IZFKgror7F6
966836866e8afe423a01a9926834a26cb3d3e2b0: Bug 1425807 - Convert nsHostKey members to nsCString r=valentin
Jeff Hemphill <jthemphill@gmail.com> - Mon, 18 Dec 2017 11:27:38 -0800 - rev 713052
Push 93528 by kgupta@mozilla.com at Tue, 19 Dec 2017 14:18:06 +0000
Bug 1425807 - Convert nsHostKey members to nsCString r=valentin MozReview-Commit-ID: 8tZUukA8Rrk
00e1d58aedfe4d25a8a5f27a3db579a60dab5bba: Bug 1424834 - LinkedList::sizeOfExcludingThis should use ConstRawType instead of T* r=njn
Valentin Gosu <valentin.gosu@gmail.com> - Fri, 15 Dec 2017 15:46:31 -0600 - rev 713051
Push 93528 by kgupta@mozilla.com at Tue, 19 Dec 2017 14:18:06 +0000
Bug 1424834 - LinkedList::sizeOfExcludingThis should use ConstRawType instead of T* r=njn MozReview-Commit-ID: 2EM9cEOAkIl
9b69f2b7d37346a5ac8aff8aeec2fe23673fe566: Bug 1424834 - Replace nsHostRecord.callbacks with LinkedList<RefPtr<nsResolveHostCallback>> r=mayhemer
Valentin Gosu <valentin.gosu@gmail.com> - Fri, 15 Dec 2017 15:46:24 -0600 - rev 713050
Push 93528 by kgupta@mozilla.com at Tue, 19 Dec 2017 14:18:06 +0000
Bug 1424834 - Replace nsHostRecord.callbacks with LinkedList<RefPtr<nsResolveHostCallback>> r=mayhemer * nsResolveHostCallback extends nsISupports (for addref-ing and because nsDNSAsyncRequest implements nsICancelable) * nsResolveHostCallback extends LinkedListElement<RefPtr<nsResolveHostCallback>> so the list can properly manage references * nsDNSAsyncRequest and nsDNSSyncRequest properly implement nsISupports and use RefPtr to manage lifetimes MozReview-Commit-ID: 5NvBcWZzfyN
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip