Bug 1321408 - Move ENABLE_MARIONETTE to python configure. r=chmanchester This patch tries to do three things: 1) Replace the ENABLE_MARIONETTE entrypoint with --enable-marionette. 2) Fold the default value -- forced on unless building for target OS Android or building with toolkit gonk -- into the flag, rather than embedding that condition in the tree. 3) Stop using AC_DEFINE and instead use only AC_SUBST, so that no compiled code needs to be rebuilt if the flag is flipped locally. n.b., each installer/Makefile.in knows that ENABLE_MARIONETTE is set (in order to set -DENABLE_MARIONETTE=1 for */installer/package-manifest.in) due to it being an AC_SUBST. MozReview-Commit-ID: AkkmybyP1uI

Bug 1321408 - Pre: Remove all references to Marionette from b2g. r=ato Per https://bugzilla.mozilla.org/show_bug.cgi?id=1321408#c20, Marionette no longer supports b2g. MozReview-Commit-ID: 5N23aZgmzz3

Bug 1308697 - Implement UI for performance statistics. r=Honza, rickychien MozReview-Commit-ID: IwnLPNlKIup

Bug 1317089 - Pre: Make MOZ_ANDROID_SHARED_ID mandatory. r=sebastian It already is mandatory; the build system will set the ID (based on the package name) if it's not given. MozReview-Commit-ID: 4OLnzLwsHJe

Bug 1317089 - Pre: Pass --debug-mode to aapt. r=sebastian,gps Gradle always sets android:debuggable from build.gradle switches (and warns about having it in AndroidManifest.xml). Future patches in this series unify how we produce the Android manifest, and this makes it easier to compare the resulting productions. MozReview-Commit-ID: 47g4AZX8Z6a

Bug 1291366 - Part 3: Generate o.m.geckoview.BuildConfig using Gradle. r=sebastian There's still work to be done here to unify these two processes, but that can be follow-up. In any case, geckoview.BuildConfig should change very infrequently, and we're hoping to transition to Gradle eventually. MozReview-Commit-ID: D2c6XTYqubj

Bug 1291366 - Part 2: Add o.m.geckoview.BuildConfig. r=sebastian This is the first, mostly mechanical, introduction of a GeckoView specific BuildConfig. We have a few "debug logging" like checks. I introduced a MOZILLA_OFFICIAL abstraction and removed some of the checks as I saw fit. Subsequent patches will remove more of these checks. With this change applied, Gradle is broken, because there will be duplicate BuildConfig files included in the build. That will be fixed in subsequent patches. MozReview-Commit-ID: KHhV32o5j5A

Bug 1291366 - Part 1: Use GENERATED_FILES to produce AppConstants.java. r=gps This patch lays the groundwork for two things. First, it paves the way for splitting AppConstants.java into two parts, a GeckoView part and a Fennec part. This is necessary because the Makefile.in preprocessing is not flexible enough to write two separate GeckoView and Fennec constants files into different directories. Second, this allows us to more flexibly generate the file contents. Gradle has a way to get compile-time constants into Java code, which we want to migrate to. The details don't matter right here, but this paves the way to move from preprocessing to generating the Gradle-style BuildConfig files while we continue to support both build systems. MozReview-Commit-ID: 2o8X99uLoaM

Bug 1291366 - Pre: don't force generated/ in Java generated_sources. r=gps This was a mistake from the beginning. I'm removing it now so that I can easily generate across objdirs. While we transition from moz.build to Gradle, I want all the build logic to be in mobile/android/base but the outputs to be split across Gradle project locations. That's hard to do when generated/ is automatically prepended to generated_sources paths. MozReview-Commit-ID: L07ZZBTsNw5

Bug 1291366 - Pre: Don't check against {MIN,MAX}_SDK_VERSION. r=sebastian This had some value for Fennec when we shipped split APKs. Since we don't, there's little value left; and there's definitely no value for GeckoView, which will only ever ship a single library AAR for all consumers. (That library AAR will have a minimum SDK, but it'll be enforced by the Gradle build system, not by runtime checks.) MozReview-Commit-ID: 3l0jUKdCepS

Bug 1291366 - Pre: Inline AppConstants.Versions in GeckoView. r=sebastian This patch inlines most uses of Versions in GeckoView. The Android linter can check that symbols only defined in particular versions of Android are only accessed behind safe guards. However, our Versions symbolic constants defeat the Android linter's simplistic code analysis. The value of the linter is (much!) greater than the explanatory value of our symbolic constants, especially for GeckoView, which will only ever ship a single library AAR suitable for all consumers. I manually tried to squash a few linter errors; subsequent tickets will track enabling the linter for GeckoView specifically, and burning down the remaining linter version errors. MozReview-Commit-ID: cZmNehx8tR

Bug 1321408 - Move ENABLE_MARIONETTE to python configure. r=chmanchester This patch tries to do three things: 1) Replace the ad-hoc ENABLE_MARIONETTE entrypoint with --enable-marionette. 2) Fold the default value -- on unless building for Android or building with toolkit gonk -- into the flag, rather than repeating the condition throughout the tree. 3) Stop using AC_DEFINE and instead use only AC_SUBST, so that no compiled code needs to be rebuilt if the flag is flipped locally. I can't recall how */installer/Makefile.in knows that ENABLE_MARIONETTE is set (in order to set -DENABLE_MARIONETTE=1 for */installer/package-manifest.in), but I see no additional special handling of flags used this way and it works locally. MozReview-Commit-ID: AkkmybyP1uI

No bug - Update readability from github repo, includes fix for Bug 1142312 and Bug 1285543, r=Gijs MozReview-Commit-ID: 5hi1iuDO3XE

Bug 1308697 - Part 2: Address Ricky's comments and fix failed tests, r=Honza, rickychien MozReview-Commit-ID: HbJEfHJO9fv

Bug 1308697 - Implement UI for performance statistics. r=Honza, rickychien MozReview-Commit-ID: IwnLPNlKIup

Bug 1142312 - Update readability from github repo, includes fix for Bug 1142312 and Bug 1285543, r=Gijs MozReview-Commit-ID: 5hi1iuDO3XE

Bug 1323628 - disable test_TelemetrySend.js for sudden apparently time-based failure across all trunk trees, a=surprise

Bug 1323390 - Support audio profile in mp4 rust parser. r=kinetik MozReview-Commit-ID: DfWuEk10koO

Bug 1323566 - Fix incorrect index usage in MediaKeySystemAccessManager::Observe(). r?cpearce MozReview-Commit-ID: 1D6Yes6ofdj

Bug 1315874 part 2 - Skip creating CSS-Transition when SMIL restyling. r?dbaron Currently RestyleManager will skip creating transition when restyling of animation only update. However SMIL will update style with eRestyle_StyleAttribute and eRestyle_StyleAttribute_Animations.[1] [1] https://dxr.mozilla.org/mozilla-central/rev/8103c612b79c2587ea4ca1b0a9f9f82db4b185b8/dom/base/Element.cpp#1987 In this patch, RestyleManager will skip creating transition when including eRestyle_StyleAttribute_Animations hint. MozReview-Commit-ID: 1sUnr2j8Jyu