23080ad39e3051ab76f181e7e3cb32875e87bd17: Bug 1275434 - Refactor `PushNotifier` to clarify remoting logic. r=dragana
Kit Cambridge <kcambridge@mozilla.com> - Thu, 19 May 2016 19:01:34 -0700 - rev 374189
Push 19947 by bmo:mh+mozilla@glandium.org at Wed, 01 Jun 2016 23:56:41 +0000
Bug 1275434 - Refactor `PushNotifier` to clarify remoting logic. r=dragana Previously, all `PushNotifier` methods checked the process type, and either called `Notify*{Workers, Observers}` or sent an IPDL message. The message handlers then called back in to `PushNotifier` from the remote process. This was clearer when we only sent worker event notifications to the content process, and fired all observer notifications in the parent. It became more complicated once we started notifying observers for all subscriptions in both processes (bug 1266433). This makes it harder to see omissions; for example, "push-subscription-modified" isn't currently forwarded to the child, but "push-subscription-change" and "push-message" are. This patch moves the remoting code into `PushNotifier::Dispatch`, and adds a base `PushDispatcher` class. Each notification type subclasses this class and implements logic for sending messages and firing observers and worker events. It's more code, but a bit easier to see which methods are called where. MozReview-Commit-ID: 7Q0eD7qXOrW
5885ad0c0a1d9fd25143692d3200a8ec2dcd80f0: Bug 1275707, part 3 - Rename MESSAGE_MANAGER_MESSAGE_SIZE. r=baku
Andrew McCreight <continuation@gmail.com> - Wed, 01 Jun 2016 15:11:06 -0700 - rev 374188
Push 19947 by bmo:mh+mozilla@glandium.org at Wed, 01 Jun 2016 23:56:41 +0000
Bug 1275707, part 3 - Rename MESSAGE_MANAGER_MESSAGE_SIZE. r=baku Now that digits have been filtered out of the message manager message names to avoid creating thousands of similar keys, we can reenable the telemetry by renaming it. Also, update the description to address bsmedberg's comments, and add me to the list of alert emails.
ef70956cd95cf49221eb9055f783dbd7fa7bfdb6: Bug 1275707, part 2 - Remove numbers from the message manager message names. r=billm
Andrew McCreight <continuation@gmail.com> - Wed, 01 Jun 2016 15:11:06 -0700 - rev 374187
Push 19947 by bmo:mh+mozilla@glandium.org at Wed, 01 Jun 2016 23:56:41 +0000
Bug 1275707, part 2 - Remove numbers from the message manager message names. r=billm There are a huge number of different message manager messages with names of the form "ublock0:sb:{N}", where {N} is some number from 1 to over 1000. Having so many different keys seems to cause problems for telemetry and makes it harder to tell how many messages of each type there really are, so this patch combines them by eliminating any digits. It will also help for the webdev tools that use channels with names like "debug:server1.conn5.child1:packet". This will create some ambiguity (eg there are some messages of the form "ublock:sb:{N}"), but that should be a minor issue.
6115c96a870103809d586830da707155b0679df8: Bug 1275707, part 1 - Factor out a common method for message manager size telemetry. r=billm
Andrew McCreight <continuation@gmail.com> - Wed, 01 Jun 2016 15:11:06 -0700 - rev 374186
Push 19947 by bmo:mh+mozilla@glandium.org at Wed, 01 Jun 2016 23:56:41 +0000
Bug 1275707, part 1 - Factor out a common method for message manager size telemetry. r=billm
8908cc624380f5a1790dc89ae5079c6f09611603: Bug 1277052 - Remove the unused xpcomThreadsShutdown. r=Yoric
Andrew McCreight <continuation@gmail.com> - Wed, 01 Jun 2016 15:05:54 -0700 - rev 374185
Push 19947 by bmo:mh+mozilla@glandium.org at Wed, 01 Jun 2016 23:56:41 +0000
Bug 1277052 - Remove the unused xpcomThreadsShutdown. r=Yoric This should be xpcom-shutdown-threads, not xpcom-threads-shutdown, but it is unused so I just removed it.
efcca7d36ad40386c137366b8f3161e13695e67f: Bug 1277067 - Remove nsIAsyncShutdown.contentChildShutdown. r=Yoric
Andrew McCreight <continuation@gmail.com> - Wed, 01 Jun 2016 15:05:54 -0700 - rev 374184
Push 19947 by bmo:mh+mozilla@glandium.org at Wed, 01 Jun 2016 23:56:41 +0000
Bug 1277067 - Remove nsIAsyncShutdown.contentChildShutdown. r=Yoric
cb803c900f834f44a483a46cf2998f2fbf0e2863: Bug 1270308 - Remove content-child-shutdown observer for OS.file. r=Yoric
Andrew McCreight <continuation@gmail.com> - Wed, 01 Jun 2016 15:05:54 -0700 - rev 374183
Push 19947 by bmo:mh+mozilla@glandium.org at Wed, 01 Jun 2016 23:56:41 +0000
Bug 1270308 - Remove content-child-shutdown observer for OS.file. r=Yoric
25e2bc431fa991d0ecb7efa2f38768449134838b: Bug 1276383 - Add nsIAsyncShutdown.xpcomWillShutdown and use it in WebRTC. r=Yoric,jib
Andrew McCreight <continuation@gmail.com> - Wed, 01 Jun 2016 15:05:53 -0700 - rev 374182
Push 19947 by bmo:mh+mozilla@glandium.org at Wed, 01 Jun 2016 23:56:41 +0000
Bug 1276383 - Add nsIAsyncShutdown.xpcomWillShutdown and use it in WebRTC. r=Yoric,jib
14e071360b24812c8a9107ae7adbba47e75f28b4: Bug 1276738 - Test that newly opened dialogs can receive arguments. r=Gijs
Mike Conley <mconley@mozilla.com> - Tue, 03 May 2016 14:14:09 -0400 - rev 374181
Push 19947 by bmo:mh+mozilla@glandium.org at Wed, 01 Jun 2016 23:56:41 +0000
Bug 1276738 - Test that newly opened dialogs can receive arguments. r=Gijs MozReview-Commit-ID: jF3Port57I
c60082ec436a31a40cc03cb99191e0f715592eef: Bug 1276738 - Test that modal windows can be opened from the parent process. r=Gijs
Mike Conley <mconley@mozilla.com> - Tue, 03 May 2016 11:42:34 -0400 - rev 374180
Push 19947 by bmo:mh+mozilla@glandium.org at Wed, 01 Jun 2016 23:56:41 +0000
Bug 1276738 - Test that modal windows can be opened from the parent process. r=Gijs MozReview-Commit-ID: 8PWxf9E6ZMv
0ac161595496d7605cf4aae0282c1451484fea91: Bug 1276738 - Add a test to ensure that we clone sessionStorage when opening new windows. r=gabor
Mike Conley <mconley@mozilla.com> - Mon, 02 May 2016 17:36:41 -0400 - rev 374179
Push 19947 by bmo:mh+mozilla@glandium.org at Wed, 01 Jun 2016 23:56:41 +0000
Bug 1276738 - Add a test to ensure that we clone sessionStorage when opening new windows. r=gabor MozReview-Commit-ID: B2rLxdpWKOu
ea2da46bde0a4a3039d69e198ad40afefc92a5ec: Bug 1276738 - Ensure that .open() on web content called with chrome privileges results in a new window with the appropriate principal. r=Gijs
Mike Conley <mconley@mozilla.com> - Mon, 02 May 2016 17:36:12 -0400 - rev 374178
Push 19947 by bmo:mh+mozilla@glandium.org at Wed, 01 Jun 2016 23:56:41 +0000
Bug 1276738 - Ensure that .open() on web content called with chrome privileges results in a new window with the appropriate principal. r=Gijs MozReview-Commit-ID: IG9ioQLTI78
1a7d17e9e15d84f22d56a056cb48c28b3ba23c7b: Bug 1276738 - Add a test for the size of newly opened window from content. r=gabor
Mike Conley <mconley@mozilla.com> - Mon, 30 May 2016 15:23:01 -0400 - rev 374177
Push 19947 by bmo:mh+mozilla@glandium.org at Wed, 01 Jun 2016 23:56:41 +0000
Bug 1276738 - Add a test for the size of newly opened window from content. r=gabor This notably fails for me on Windows, for which I've filed bug 1276802. Until that's figured out, this test is disabled on Windows. MozReview-Commit-ID: Hx24driJ80w
73f7e5190b38c89efc0e8c68c84770097e9f95e4: Bug 1276738 - Test _blank name usage in new windows. r=Gijs
Mike Conley <mconley@mozilla.com> - Fri, 29 Apr 2016 17:39:18 -0400 - rev 374176
Push 19947 by bmo:mh+mozilla@glandium.org at Wed, 01 Jun 2016 23:56:41 +0000
Bug 1276738 - Test _blank name usage in new windows. r=Gijs MozReview-Commit-ID: Gqh04VTzOuC
9d23fffa886b0b78a2d6f9584f05e4af9a019c63: Bug 1276738 - Test that named windows work properly. r=gabor
Mike Conley <mconley@mozilla.com> - Mon, 30 May 2016 17:26:52 -0400 - rev 374175
Push 19947 by bmo:mh+mozilla@glandium.org at Wed, 01 Jun 2016 23:56:41 +0000
Bug 1276738 - Test that named windows work properly. r=gabor MozReview-Commit-ID: 80uzqBvPmOA
88f049f304465bb2aaee131d775d6ea95bfa7502: Bug 1276738 - Test that new windows opened from remote content get the right flags. r=gabor
Mike Conley <mconley@mozilla.com> - Fri, 29 Apr 2016 15:28:29 -0400 - rev 374174
Push 19947 by bmo:mh+mozilla@glandium.org at Wed, 01 Jun 2016 23:56:41 +0000
Bug 1276738 - Test that new windows opened from remote content get the right flags. r=gabor MozReview-Commit-ID: 3zgJrU0LeUV
9d903a6a12aa7182252ec3e220c89b569c14e11b: Bug 1276738 - Tag a bunch of tests that exercise opening windows with openwindow. r=me
Mike Conley <mconley@mozilla.com> - Fri, 29 Apr 2016 14:29:03 -0400 - rev 374173
Push 19947 by bmo:mh+mozilla@glandium.org at Wed, 01 Jun 2016 23:56:41 +0000
Bug 1276738 - Tag a bunch of tests that exercise opening windows with openwindow. r=me There are a series of tests strewn about the tree that seem to exercise window opening in one form or another, so I thought I'd put them under a tag. MozReview-Commit-ID: 74JwLUTzaMU
f9f96ca7f0432a51b7ef3932c7fb8711a4362f35: Bug 1101628 - Follow-up to fix crash in some gtest scenarios. r=me
Kartikaya Gupta <kgupta@mozilla.com> - Wed, 01 Jun 2016 17:17:06 -0400 - rev 374172
Push 19947 by bmo:mh+mozilla@glandium.org at Wed, 01 Jun 2016 23:56:41 +0000
Bug 1101628 - Follow-up to fix crash in some gtest scenarios. r=me MozReview-Commit-ID: 9qRNiaMnLd
81bfec47b65d25b4c2303f345d174e475d45e380: Bug 1088763 - Preload yosemite tab images. r=mconley
Markus Stange <mstange@themasta.com> - Wed, 01 Jun 2016 16:57:27 -0400 - rev 374171
Push 19947 by bmo:mh+mozilla@glandium.org at Wed, 01 Jun 2016 23:56:41 +0000
Bug 1088763 - Preload yosemite tab images. r=mconley We need to preload both the inactive and the active images. All our image loads need to be kicked off before the window document's load event fires. While the window is hidden, it is inactive. So we need the preloading hack to kick off the loads for the active images. MozReview-Commit-ID: 2dPdJNORwhw
33544460e0b963a1278a6553e0f9da9b403d9b4d: Bug 1088763 - Fix yosemite inactive window style, r=mconley, ui-r=shorlander
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 01 Jun 2016 16:46:24 -0400 - rev 374170
Push 19947 by bmo:mh+mozilla@glandium.org at Wed, 01 Jun 2016 23:56:41 +0000
Bug 1088763 - Fix yosemite inactive window style, r=mconley, ui-r=shorlander MozReview-Commit-ID: GjEN1nQmpz4
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip