22555ccbbad5aa84aa7a1d8ed2630097a662d3e8: Disable the installer
draft
Tom Ritter <tom@mozilla.com> - Thu, 24 Aug 2017 16:21:17 -0500 - rev 653109
Push
76238 by bmo:tom@mozilla.com at Fri, 25 Aug 2017 15:17:03 +0000
Disable the installer
MozReview-Commit-ID: 86MIOp87Di8
cdc8347a975aede84b6b61282d9f3aef0f69a81e: Suppress style warnings for gcc
draft
Tom Ritter <tom@mozilla.com> - Thu, 24 Aug 2017 10:18:36 -0500 - rev 653108
Push
76238 by bmo:tom@mozilla.com at Fri, 25 Aug 2017 15:17:03 +0000
Suppress style warnings for gcc
MozReview-Commit-ID: JZLAAIFaXc4
933244fb24804d327bfe314d2450166518dcf97b: Suppress warnings in third party cairo and libpixman code
draft
Tom Ritter <tom@mozilla.com> - Thu, 24 Aug 2017 12:26:10 -0500 - rev 653107
Push
76238 by bmo:tom@mozilla.com at Fri, 25 Aug 2017 15:17:03 +0000
Suppress warnings in third party cairo and libpixman code
MozReview-Commit-ID: Any1Vr7teiy
43802a453410aa868899fe6bdd6f2a24cd60f2f7: Fix a signedness comparison warning in WindowsDllBlocklist.cpp
draft
Tom Ritter <tom@mozilla.com> - Tue, 22 Aug 2017 23:21:22 -0500 - rev 653106
Push
76238 by bmo:tom@mozilla.com at Fri, 25 Aug 2017 15:17:03 +0000
Fix a signedness comparison warning in WindowsDllBlocklist.cpp
MozReview-Commit-ID: 3qH0PU2gBur
85150f52737dc16cb5ec65e3895ffe2a7e835923: Cast to HRESULT
draft
Tom Ritter <tom@mozilla.com> - Tue, 22 Aug 2017 22:56:17 -0500 - rev 653105
Push
76238 by bmo:tom@mozilla.com at Fri, 25 Aug 2017 15:17:03 +0000
Cast to HRESULT
MozReview-Commit-ID: Fc01RHPqCbg
75dbdf4e89aca11f5dc90d577e223a89cbb270db: Silence several types of warnings in gfx/
draft
Tom Ritter <tom@mozilla.com> - Wed, 23 Aug 2017 15:07:19 -0500 - rev 653104
Push
76238 by bmo:tom@mozilla.com at Fri, 25 Aug 2017 15:17:03 +0000
Silence several types of warnings in gfx/
MozReview-Commit-ID: GoSg3nrVmsk
8b360bc49fc88eb4f296879f845e551f8e3ae1ca: Fix forbidden string constant assignment
draft
Tom Ritter <tom@mozilla.com> - Tue, 22 Aug 2017 16:58:06 -0500 - rev 653103
Push
76238 by bmo:tom@mozilla.com at Fri, 25 Aug 2017 15:17:03 +0000
Fix forbidden string constant assignment
ISO C++ forbids converting a string constant to 'wchar_t*' [-Werror=write-strings]
Either change it to a nullptr (which has same intent) or pass through a static
MozReview-Commit-ID: CSunOCyO9PN
be8bba0e9d5737b96464cc3667568061bb8af264: Bug 1393454 Do not compile rust tests if --disable-tests is set
draft
Tom Ritter <tom@mozilla.com> - Thu, 24 Aug 2017 13:04:12 -0500 - rev 653102
Push
76238 by bmo:tom@mozilla.com at Fri, 25 Aug 2017 15:17:03 +0000
Bug 1393454 Do not compile rust tests if --disable-tests is set
MozReview-Commit-ID: 1HgK0D1kGNu
6cfc691b9726960544482f7fdabe0eca80e28d22: Bug 1393528 Add parentheses to a confusing if statement r?jimm
draft
Tom Ritter <tom@mozilla.com> - Thu, 24 Aug 2017 12:34:09 -0500 - rev 653101
Push
76238 by bmo:tom@mozilla.com at Fri, 25 Aug 2017 15:17:03 +0000
Bug 1393528 Add parentheses to a confusing if statement r?jimm
MozReview-Commit-ID: rKnimtw55c
fdf6d376b92a161915201680bc1bf33650374e9e: Bug 1393538 Clean up unused variables in toolkit/
draft
Tom Ritter <tom@mozilla.com> - Thu, 24 Aug 2017 15:07:59 -0500 - rev 653100
Push
76238 by bmo:tom@mozilla.com at Fri, 25 Aug 2017 15:17:03 +0000
Bug 1393538 Clean up unused variables in toolkit/
MozReview-Commit-ID: I6r50dqJJHJ
450e8653a7d4289f9408b77633527a2ecc8137fd: Bug 1393536 Clean up unused variables in widget/
draft
Tom Ritter <tom@mozilla.com> - Thu, 24 Aug 2017 13:11:18 -0500 - rev 653099
Push
76238 by bmo:tom@mozilla.com at Fri, 25 Aug 2017 15:17:03 +0000
Bug 1393536 Clean up unused variables in widget/
MozReview-Commit-ID: 9NBzIriF8NU
352429cdae4b37f3a0c63d9e74d6b2ec200a3365: Bug 1393535 Fix unused variable wanrings in dom/
draft
Tom Ritter <tom@mozilla.com> - Thu, 24 Aug 2017 11:52:36 -0500 - rev 653098
Push
76238 by bmo:tom@mozilla.com at Fri, 25 Aug 2017 15:17:03 +0000
Bug 1393535 Fix unused variable wanrings in dom/
MozReview-Commit-ID: 1Ql20AHx1Jz
01aec9ceda722fa2c82fe092d052c7e9a7d1240d: Bug 1393487 Silence unused variable warning because we do it on purpose with CALLING_CONVENTION_HACK in PluginPRLibrary.cpp
draft
Tom Ritter <tom@mozilla.com> - Thu, 24 Aug 2017 10:26:25 -0500 - rev 653097
Push
76238 by bmo:tom@mozilla.com at Fri, 25 Aug 2017 15:17:03 +0000
Bug 1393487 Silence unused variable warning because we do it on purpose with CALLING_CONVENTION_HACK in PluginPRLibrary.cpp
MozReview-Commit-ID: 5AcehJFnFho
c89626ad83fb08f3bd26a978f063043c7e34ba30: Bug 1393498 Mark the stub_BaseThreadInitThunk as MOZ_NORETURN to silence a warning about a noreturn function not returning r?dmajor
draft
Tom Ritter <tom@mozilla.com> - Thu, 24 Aug 2017 22:49:09 -0500 - rev 653096
Push
76238 by bmo:tom@mozilla.com at Fri, 25 Aug 2017 15:17:03 +0000
Bug 1393498 Mark the stub_BaseThreadInitThunk as MOZ_NORETURN to silence a warning about a noreturn function not returning r?dmajor
/home/worker/workspace/build/src/mozglue/build/WindowsDllBlocklist.cpp:816:1: error: 'noreturn' function does return [-Werror]
MozReview-Commit-ID: SYgPDW0sMV
c7f2994a3ac08305970e4d930f3f9b542244b49c: Bug 1393222 Disable the unused-function warning when compiling with gcc for Windows r?froydnj
draft
Tom Ritter <tom@mozilla.com> - Wed, 23 Aug 2017 16:08:30 -0500 - rev 653095
Push
76238 by bmo:tom@mozilla.com at Fri, 25 Aug 2017 15:17:03 +0000
Bug 1393222 Disable the unused-function warning when compiling with gcc for Windows r?froydnj
In some cases, they are false positives. In other cases, the callsite is #ifdef-ed
out, so it's a true positive, but not one we would correct.
MozReview-Commit-ID: 6ThZH3wEXTp
e0cdd73fa5374006be14e983c7b626005f809350: Bug 1393216 Disable unknown pragma warnings when compiling for Windows with gcc r?froydnj
draft
Tom Ritter <tom@mozilla.com> - Wed, 23 Aug 2017 16:18:28 -0500 - rev 653094
Push
76238 by bmo:tom@mozilla.com at Fri, 25 Aug 2017 15:17:03 +0000
Bug 1393216 Disable unknown pragma warnings when compiling for Windows with gcc r?froydnj
MozReview-Commit-ID: 6cZ96xe4h8C
a26482829b21d49c990ba1fae36bca39d427da89: Bug 1393196 Some illustrative examples of gfx/ signed/unsigned comparisons
draft
Tom Ritter <tom@mozilla.com> - Wed, 23 Aug 2017 15:07:32 -0500 - rev 653093
Push
76238 by bmo:tom@mozilla.com at Fri, 25 Aug 2017 15:17:03 +0000
Bug 1393196 Some illustrative examples of gfx/ signed/unsigned comparisons
MozReview-Commit-ID: 3JAolFMhZ9N
d37adc7b57cc0aad70296b12b6b7a6d288ec99e8: Bug 1393201 Signed/Unsigned comparison warning in nsMIMEInfoWin.cpp - Find returns an int, not a unit
draft
Tom Ritter <tom@mozilla.com> - Tue, 22 Aug 2017 16:59:31 -0500 - rev 653092
Push
76238 by bmo:tom@mozilla.com at Fri, 25 Aug 2017 15:17:03 +0000
Bug 1393201 Signed/Unsigned comparison warning in nsMIMEInfoWin.cpp - Find returns an int, not a unit
MozReview-Commit-ID: 3qxIGFPkPXW
8d24ad429442f65f8219e05c09382a4347a4b633: Bug 1392688 Make variable DebugOnly to silence warning about it being unused
draft
Tom Ritter <tom@mozilla.com> - Tue, 22 Aug 2017 12:41:24 -0500 - rev 653091
Push
76238 by bmo:tom@mozilla.com at Fri, 25 Aug 2017 15:17:03 +0000
Bug 1392688 Make variable DebugOnly to silence warning about it being unused
MozReview-Commit-ID: 7wSkP2Lcd0W
046b92690aa1bfe21e2c7cd2de22db45480a0837: Bug 1392684 Remove const qualifier that gets discarded after function return in mscom::AgileReference
draft
Tom Ritter <tom@mozilla.com> - Tue, 22 Aug 2017 17:25:27 -0500 - rev 653090
Push
76238 by bmo:tom@mozilla.com at Fri, 25 Aug 2017 15:17:03 +0000
Bug 1392684 Remove const qualifier that gets discarded after function return in mscom::AgileReference
gcc throws a warning-as-error saying that the const qualifier will be ignored by function callers.
Remove the const qualifier to remove the warning.
MozReview-Commit-ID: JRQMz6Zdcdz
