21c79896aaf7b27eab2e6e42ce7b897256a8d357: Bug 1427726 - remove nsIJARChannel::isUnsafe and nsIDocShell::channelIsUnsafe, r?bz draft
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 07 Feb 2018 14:25:33 +0000 - rev 780416
Push 105989 by bmo:gijskruitbosch+bugs@gmail.com at Wed, 11 Apr 2018 11:22:19 +0000
Bug 1427726 - remove nsIJARChannel::isUnsafe and nsIDocShell::channelIsUnsafe, r?bz MozReview-Commit-ID: 7XyRqzKDbsq
482b3eb780f22d1c2913f2e2ee050e5960851d7e: Bug 1427726 - remove support for remote JAR files, r?michal draft
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 07 Feb 2018 13:54:39 +0000 - rev 780415
Push 105989 by bmo:gijskruitbosch+bugs@gmail.com at Wed, 11 Apr 2018 11:22:19 +0000
Bug 1427726 - remove support for remote JAR files, r?michal MozReview-Commit-ID: H7aaTmj3FI1
28a1468b3b08d74ab0d70ed2ffc8dee1a33917d5: Bug 1427726 - remove postMessage tests for jars, r?bz draft
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 09 Apr 2018 10:09:58 +0100 - rev 780414
Push 105989 by bmo:gijskruitbosch+bugs@gmail.com at Wed, 11 Apr 2018 11:22:19 +0000
Bug 1427726 - remove postMessage tests for jars, r?bz postMessage doesn't really have different origins for file: URIs; to send to them you need "*", and `location.origin` is null. So testing jar:file separately doesn't seem to make much sense, so let's just remove the test now that jar: will only really be usable with a local/file inner URI. MozReview-Commit-ID: 7vvlrugi3xv
29b7ce0ce1a697092a4057c182c3649e133b0c6a: Bug 1427726 - move test for bug 1063538 away from jar URIs, r?baku draft
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 09 Apr 2018 10:08:33 +0100 - rev 780413
Push 105989 by bmo:gijskruitbosch+bugs@gmail.com at Wed, 11 Apr 2018 11:22:19 +0000
Bug 1427726 - move test for bug 1063538 away from jar URIs, r?baku Bug 1063538 was reported with a testcase that accesses a .jsp, which in turn sleeps "forever". The testcase seems to be simulating this by using a jar:http: URI for a really big file contained in some other directory. Instead, we can just use a .sjs file that does a similar thing to the original jsp file in the reporter's testcase, which conveniently also allows us to remove dependencies on support files in other directories. MozReview-Commit-ID: 2JCOS9VLgVv
b2547ff2664f615108cd507eb03a11a4549c7067: Bug 1034036 - Part 7: Test that we stored window z-indices correctly and in order of creation. Ensure that we restore windows in reverse z-index order. r?dao draft
Mike de Boer <mdeboer@mozilla.com> - Wed, 11 Apr 2018 12:06:16 +0200 - rev 780412
Push 105988 by mdeboer@mozilla.com at Wed, 11 Apr 2018 11:21:02 +0000
Bug 1034036 - Part 7: Test that we stored window z-indices correctly and in order of creation. Ensure that we restore windows in reverse z-index order. r?dao MozReview-Commit-ID: 6z1zHUKDf9
7b77d08c958c04127075054e620ab29fbace944e: Bug 1034036 - Part 6: Tests that use ss.setBrowserState() or ss.setWindowState() should wait until the window is restored to continue. r?dao draft
Mike de Boer <mdeboer@mozilla.com> - Wed, 11 Apr 2018 12:06:12 +0200 - rev 780411
Push 105988 by mdeboer@mozilla.com at Wed, 11 Apr 2018 11:21:02 +0000
Bug 1034036 - Part 6: Tests that use ss.setBrowserState() or ss.setWindowState() should wait until the window is restored to continue. r?dao MozReview-Commit-ID: 5d1E5TjKnIR
529f81474ee77f8782f1456d35e362e994ec2576: Bug 1034036 - Part 5: restore windows in reverse z-order, so that the last focused window is restored first and stays in front. r?dao draft
Mike de Boer <mdeboer@mozilla.com> - Wed, 11 Apr 2018 12:06:09 +0200 - rev 780410
Push 105988 by mdeboer@mozilla.com at Wed, 11 Apr 2018 11:21:02 +0000
Bug 1034036 - Part 5: restore windows in reverse z-order, so that the last focused window is restored first and stays in front. r?dao MozReview-Commit-ID: 22OIFutLgmx
af635a3f20e2b234e973b7dcaf6f82c7e53e4c35: Bug 1034036 - Part 4: move away from keeping state on the living objects, like windows, tabs and browsers, but keep it truly privately stored in WeakMaps. r?dao draft
Mike de Boer <mdeboer@mozilla.com> - Wed, 11 Apr 2018 12:06:06 +0200 - rev 780409
Push 105988 by mdeboer@mozilla.com at Wed, 11 Apr 2018 11:21:02 +0000
Bug 1034036 - Part 4: move away from keeping state on the living objects, like windows, tabs and browsers, but keep it truly privately stored in WeakMaps. r?dao NOTE: The '__SSi' and '__SS_lastSessionWindowID' properties on windows are kept, because they are expected to stick around longer during application shutdown. The benefits is are: 1. Cleaner code - Sessionstore implementation details are not leaked outside its module. 2. Observing the lifetime of objects becomes unnecessary, because the WeakMaps are cleaned up when objects are GC'd, making leakage of their references impossible and Sessionstore can't hold objects hostage anymore. 3. Simplification - all state is now maintained in SessionStore.jsm, which allows for additional refactoring later on to simplify the implementation further. MozReview-Commit-ID: C1II8qHkQ6F
a0767609c5043ce67afd40f22bc4f742811df868: Bug 1034036 - Part 3: start tracking windows activations to always be aware of their respective order. This allows consumers to iterate over a set of windows in order of appearance (e.g. z-order). r?dao draft
Mike de Boer <mdeboer@mozilla.com> - Wed, 11 Apr 2018 12:06:03 +0200 - rev 780408
Push 105988 by mdeboer@mozilla.com at Wed, 11 Apr 2018 11:21:02 +0000
Bug 1034036 - Part 3: start tracking windows activations to always be aware of their respective order. This allows consumers to iterate over a set of windows in order of appearance (e.g. z-order). r?dao Tests are also added here for the legacy `getTopWindow` method to guard against basic regressions. We now start tracking browser windows right after the DOMContentLoaded event, which is earlier than before. We now also assume that any newly tracked window has the focus initially, which is closer to the nsIWindowMediator semantics. MozReview-Commit-ID: 6QYJqA1tMPC
3a6a43101580391f4a2a6c33bada7ae418ce769b: Bug 1034036 - Part 2: Rename and shorten `getMostRecentBrowserWindow` to `getTopWindow` and modernize the style used in BrowserWindowTracker.jsm. r?dao draft
Mike de Boer <mdeboer@mozilla.com> - Wed, 11 Apr 2018 12:05:59 +0200 - rev 780407
Push 105988 by mdeboer@mozilla.com at Wed, 11 Apr 2018 11:21:02 +0000
Bug 1034036 - Part 2: Rename and shorten `getMostRecentBrowserWindow` to `getTopWindow` and modernize the style used in BrowserWindowTracker.jsm. r?dao MozReview-Commit-ID: EvgAhq4uR3a
1b49fbf866c175a05c8bc5c6c44c09d5077a6ff5: Bug 1034036 - Part 1: Merge RecentWindow.jsm and UpdateTopLevelContentWindowIDHelper.jsm into one module called 'BrowserWindowTracker.jsm'. r?dao draft
Mike de Boer <mdeboer@mozilla.com> - Wed, 11 Apr 2018 12:05:56 +0200 - rev 780406
Push 105988 by mdeboer@mozilla.com at Wed, 11 Apr 2018 11:21:02 +0000
Bug 1034036 - Part 1: Merge RecentWindow.jsm and UpdateTopLevelContentWindowIDHelper.jsm into one module called 'BrowserWindowTracker.jsm'. r?dao MozReview-Commit-ID: 9qzq1aGvjDu
4c71e2db23024f02fac5d8ba4c0d3bce367ce402: Bug 1432410 - Add tests in tree to make sure we don't regress with clang-tidy. draft
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Wed, 11 Apr 2018 14:16:32 +0300 - rev 780405
Push 105987 by bmo:bpostelnicu@mozilla.com at Wed, 11 Apr 2018 11:19:27 +0000
Bug 1432410 - Add tests in tree to make sure we don't regress with clang-tidy. MozReview-Commit-ID: 38q8wvxuheO
afcfaed50b0fc158fa2cc18be261411e4d9555d4: Bug 1453280 - Clear and destroy tabbrowser tab's listener when adopting the last tab of a window. draft
Luca Greco <lgreco@mozilla.com> - Tue, 10 Apr 2018 23:09:28 +0200 - rev 780404
Push 105986 by luca.greco@alcacoop.it at Wed, 11 Apr 2018 11:17:19 +0000
Bug 1453280 - Clear and destroy tabbrowser tab's listener when adopting the last tab of a window. MozReview-Commit-ID: 4XA866P0HJl
5e34e15c56bc8c94fb310cc237354a3a22dc4b35: Bug 1453280 - Clear and destroy tabbrowser tab's listener when adopting the last tab of a window. draft
Luca Greco <lgreco@mozilla.com> - Tue, 10 Apr 2018 23:09:28 +0200 - rev 780403
Push 105985 by luca.greco@alcacoop.it at Wed, 11 Apr 2018 11:13:45 +0000
Bug 1453280 - Clear and destroy tabbrowser tab's listener when adopting the last tab of a window. MozReview-Commit-ID: 4XA866P0HJl
5051ba980ab12c9bb04e43707c3876d6f871ef27: Bug 1448945 - Only update expiration if not a builtin event. r?dexter draft
Jan-Erik Rediger <jrediger@mozilla.com> - Tue, 10 Apr 2018 17:03:00 +0200 - rev 780402
Push 105984 by bmo:jrediger@mozilla.com at Wed, 11 Apr 2018 10:59:45 +0000
Bug 1448945 - Only update expiration if not a builtin event. r?dexter The check was erroneously placed in the first if-check. This made already statically loaded events not be skipped and then be overwritten with the dynamic builtin ones. MozReview-Commit-ID: BGw997mbwwS
761bd7f6cd79b19eb4195cbc9e598447391daf97: Bug 1448945 - Check for expired event first. r?dexter draft
Jan-Erik Rediger <jrediger@mozilla.com> - Tue, 10 Apr 2018 16:01:49 +0200 - rev 780401
Push 105984 by bmo:jrediger@mozilla.com at Wed, 11 Apr 2018 10:59:45 +0000
Bug 1448945 - Check for expired event first. r?dexter Expired event keys have an ID of uint32::max, which should never be a valid index into the gDynamicEventInfo array. We can return early without handling those expired events at all, not even fixing up the process type. MozReview-Commit-ID: 83oWogs06Cl
ad7fb43f3b67b5232e9f314aebbacf5e2a9e6947: Bug 1448945 - Document support for adding events in artifact builds. r?dexter draft
Jan-Erik Rediger <jrediger@mozilla.com> - Tue, 10 Apr 2018 13:55:48 +0200 - rev 780400
Push 105984 by bmo:jrediger@mozilla.com at Wed, 11 Apr 2018 10:59:45 +0000
Bug 1448945 - Document support for adding events in artifact builds. r?dexter MozReview-Commit-ID: 1e8hF3DyfDj
986ba07d135356bcbb2417f8857ce1b5c8e1cafc: Bug 1448945 - Add test coverage for loading dynamic inbuilt events on startup. r?dexter draft
Jan-Erik Rediger <jrediger@mozilla.com> - Tue, 10 Apr 2018 13:39:10 +0200 - rev 780399
Push 105984 by bmo:jrediger@mozilla.com at Wed, 11 Apr 2018 10:59:45 +0000
Bug 1448945 - Add test coverage for loading dynamic inbuilt events on startup. r?dexter MozReview-Commit-ID: Dpl4GUSZePf
433b24aca9a898ffdb345ae7574ea95e714fc39e: Bug 1448945 - Allow underscore in category, method and extra keys of event. r?dexter draft
Jan-Erik Rediger <jrediger@mozilla.com> - Tue, 10 Apr 2018 13:05:39 +0200 - rev 780398
Push 105984 by bmo:jrediger@mozilla.com at Wed, 11 Apr 2018 10:59:45 +0000
Bug 1448945 - Allow underscore in category, method and extra keys of event. r?dexter According to the documnetation[1] category and method are identifiers, thus an underscore is allowed. It's less clear for extra keys, but underscores are already used there. [1]: https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/collection/events.html#limits MozReview-Commit-ID: 9pUsDNXCY8m
2970fb8d37f19cfcb4556c98bf9af30f032cfa58: Bug 1448945 - Load dynamic inbuilt event probes on startup. r?dexter draft
Jan-Erik Rediger <jrediger@mozilla.com> - Mon, 09 Apr 2018 15:26:09 +0200 - rev 780397
Push 105984 by bmo:jrediger@mozilla.com at Wed, 11 Apr 2018 10:59:45 +0000
Bug 1448945 - Load dynamic inbuilt event probes on startup. r?dexter MozReview-Commit-ID: 3eyqkcV6LWM
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip