218f86b40078e5412ace98f15b3f6e6ba60ae446: Bug 1429386 Added missing functionalities from a newer LP SDK version draft
Vlad Baicu <vlad.baicu@softvision.ro> - Thu, 05 Apr 2018 19:09:45 +0300 - rev 777948
Push 105346 by vbaicu@mozilla.com at Thu, 05 Apr 2018 16:12:37 +0000
Bug 1429386 Added missing functionalities from a newer LP SDK version MozReview-Commit-ID: EWGABsN3Diu
840ee7a43b65f0b48d208a9515ccb655f84d7a87: Bug 1328236: Add a web-platform test that shows shape-outside: border-box float areas are correctly clipped to margin rects. draft
Brad Werth <bwerth@mozilla.com> - Wed, 04 Apr 2018 17:22:36 -0700 - rev 777947
Push 105345 by bwerth@mozilla.com at Thu, 05 Apr 2018 16:10:26 +0000
Bug 1328236: Add a web-platform test that shows shape-outside: border-box float areas are correctly clipped to margin rects. MozReview-Commit-ID: JkIQqRhLNrs
e2f59e695f038804d22046162c12e0070a475052: Bug 1363168 - Add support for OSX Share feature. r=gijs, r=mstange draft
Dale Harvey <dale@arandomurl.com> - Mon, 12 Mar 2018 09:16:51 +0000 - rev 777946
Push 105344 by bmo:dharvey@mozilla.com at Thu, 05 Apr 2018 15:28:45 +0000
Bug 1363168 - Add support for OSX Share feature. r=gijs, r=mstange MozReview-Commit-ID: sJXl2If9Ou
bac9058392c1059763dd69fc365c250e7340d3dc: Bug 1352598 - Add WebExtension API for access to search. r?aswan draft
Michael Kaply <mozilla@kaply.com> - Thu, 05 Apr 2018 10:25:36 -0500 - rev 777945
Push 105343 by mozilla@kaply.com at Thu, 05 Apr 2018 15:26:04 +0000
Bug 1352598 - Add WebExtension API for access to search. r?aswan MozReview-Commit-ID: I0NaRf4ap3u
03e51a42c7f09460998088ca05ea8e5dc9cef912: bug 1440673 - Test Event Summary's key limit pref r?Dexter draft
Chris H-C <chutten@mozilla.com> - Tue, 03 Apr 2018 18:32:53 -0400 - rev 777944
Push 105342 by bmo:chutten@mozilla.com at Thu, 05 Apr 2018 15:24:31 +0000
bug 1440673 - Test Event Summary's key limit pref r?Dexter As requested, a test for the key limit pref. This sets it to a value lower than the limit of events we can currently send without truncation (100), but higher than is likely to be hit by tests (since the first time we record an event, we read the pref, so we can't unsend it). MozReview-Commit-ID: 7pGftCa1rz3
9dcff1194a2a4a03a40f9427c2a9bc50a77aa088: bug 1440673 - Test Event Summarization in xpcshell r?Dexter draft
Chris H-C <chutten@mozilla.com> - Tue, 03 Apr 2018 14:38:51 -0400 - rev 777943
Push 105342 by bmo:chutten@mozilla.com at Thu, 05 Apr 2018 15:24:31 +0000
bug 1440673 - Test Event Summarization in xpcshell r?Dexter To test the TelemetryEvents portion of the code we need TelemetryEvents tests. (The gtests only cover portions deeper than the TelemetryScalar API). MozReview-Commit-ID: ExaiW0OiwFI
565e65d8e6a241d747e63b67662b146e0f4167c3: bug 1440673 - Test that dynamic events are summarized to a dynamic scalar r?Dexter draft
Chris H-C <chutten@mozilla.com> - Thu, 29 Mar 2018 15:41:47 -0400 - rev 777942
Push 105342 by bmo:chutten@mozilla.com at Thu, 05 Apr 2018 15:24:31 +0000
bug 1440673 - Test that dynamic events are summarized to a dynamic scalar r?Dexter MozReview-Commit-ID: 6n1MFFIes5j
e94da89ff57371392ec90210be0b3b114eb9df64: bug 1440673 - Summarize dynamic events to a dynamic scalar r?Dexter draft
Chris H-C <chutten@mozilla.com> - Thu, 29 Mar 2018 14:28:50 -0400 - rev 777941
Push 105342 by bmo:chutten@mozilla.com at Thu, 05 Apr 2018 15:24:31 +0000
bug 1440673 - Summarize dynamic events to a dynamic scalar r?Dexter MozReview-Commit-ID: KD9ADGJZZCM
1c01089410d506e1fff77a0be6c9086e82c0e0d6: bug 1440673 - Permit snapshotting non-parent-process scalars r?Dexter draft
Chris H-C <chutten@mozilla.com> - Thu, 29 Mar 2018 14:28:21 -0400 - rev 777940
Push 105342 by bmo:chutten@mozilla.com at Thu, 05 Apr 2018 15:24:31 +0000
bug 1440673 - Permit snapshotting non-parent-process scalars r?Dexter MozReview-Commit-ID: CBjLy7uDEeb
f8cfb4f52094d25b47ba3ff1ed0f75a9962f65d0: bug 1440673 - Test event summary scalar collection r?Dexter draft
Chris H-C <chutten@mozilla.com> - Wed, 28 Mar 2018 11:36:51 -0400 - rev 777939
Push 105342 by bmo:chutten@mozilla.com at Thu, 05 Apr 2018 15:24:31 +0000
bug 1440673 - Test event summary scalar collection r?Dexter MozReview-Commit-ID: 6wiiX8pCoHT
e353baca44dac321d259427195f9dcfda0977755: bug 1440673 - Set the max number of event summary keys by pref r?Dexter draft
Chris H-C <chutten@mozilla.com> - Wed, 28 Mar 2018 13:58:33 -0400 - rev 777938
Push 105342 by bmo:chutten@mozilla.com at Thu, 05 Apr 2018 15:24:31 +0000
bug 1440673 - Set the max number of event summary keys by pref r?Dexter Introducing the pref toolkit.telemetry.maxEventSummaryKeys which we should hopefully never have to think about because (and yes, I risk being quoted in future for this): 500 unique event names per process ought to be enough. We check the preference just once but have to set it each time as the KeyedScalar object may have been recreated while we weren't looking. MozReview-Commit-ID: 8IE9dcfuynh
89f2380e61404b32ed61e0ee35796ebcff29369a: bug 1440673 - Allow changing the max number of keys per-keyed-scalar r?Dexter draft
Chris H-C <chutten@mozilla.com> - Wed, 28 Mar 2018 13:45:07 -0400 - rev 777937
Push 105342 by bmo:chutten@mozilla.com at Thu, 05 Apr 2018 15:24:31 +0000
bug 1440673 - Allow changing the max number of keys per-keyed-scalar r?Dexter I considered a few different ways to do this, but storing the limit inside the KeyedScalar itself was the cleanest. The limit check is too deep to pass it as an argument, and making it conditional on the keyed scalar being called "telemetry.event_counts" was too fragile. MozReview-Commit-ID: AyfEKB40Abb
e5c8da2185ff21dab4e946d739d73efd3bdc6961: bug 1440673 - Summarize events to a keyed scalar r?Dexter draft
Chris H-C <chutten@mozilla.com> - Fri, 16 Mar 2018 15:56:16 -0400 - rev 777936
Push 105342 by bmo:chutten@mozilla.com at Thu, 05 Apr 2018 15:24:31 +0000
bug 1440673 - Summarize events to a keyed scalar r?Dexter Telemetry Events will now be counted in the keyed scalar "telemetry.event_counts" even if their category is not enabled for recording. The keys will be category#method#object and a follow-up commit will expand the process limit of the number of these from 100 to 500, configurable by pref. Unfortunately Event Telemetry needs a special API so that an event recorded in multiple processes will be summarized to those processes separately. MozReview-Commit-ID: 7dKcM3SXO6r
53e79ffd8aa5abbd6c7f00a69111359ac833d9e3: bug 1440673 - Allow TelemetryScalar.h to be included in tests r?Dexter draft
Chris H-C <chutten@mozilla.com> - Tue, 27 Mar 2018 17:01:28 -0400 - rev 777935
Push 105342 by bmo:chutten@mozilla.com at Thu, 05 Apr 2018 15:24:31 +0000
bug 1440673 - Allow TelemetryScalar.h to be included in tests r?Dexter TelemetryComms includes some ipc headers we don't have in the gtest build. MozReview-Commit-ID: 9gK6KPHeUIa
ff68bf2d34edbcdcdeb3e77b02bf0580017eb498: bug 1440673 - Allow scalar keys to be an extra 2 chars long r?Dexter draft
Chris H-C <chutten@mozilla.com> - Tue, 27 Mar 2018 16:15:27 -0400 - rev 777934
Push 105342 by bmo:chutten@mozilla.com at Thu, 05 Apr 2018 15:24:31 +0000
bug 1440673 - Allow scalar keys to be an extra 2 chars long r?Dexter This allows us to store Telemetry Event category (30), method (20), object (20), and two delimiters (2) in a single key, like so: oohwowlookthiscategoryissolong#thismethodislongtooo#thisobjectisnoslouch MozReview-Commit-ID: BkoU1VAXFF9
54668f4982a9100a4108c5d6a20f56800ea593e2: bug 1440673 - Fix off-by-one errors in keyed scalars r?Dexter draft
Chris H-C <chutten@mozilla.com> - Tue, 27 Mar 2018 16:59:15 -0400 - rev 777933
Push 105342 by bmo:chutten@mozilla.com at Thu, 05 Apr 2018 15:24:31 +0000
bug 1440673 - Fix off-by-one errors in keyed scalars r?Dexter The maximum key length constraint should be strict greater-than, and the maximum number of keys constraint should only be checked if we are creating a new key. MozReview-Commit-ID: 5fhfV8BbmRH
eab1b959731a4b4aad0632a5d2afa9fbb5ac042a: Bug 1451767 - Add missing type in events API schema examples from the WebExtensions docs. draft
Luca Greco <lgreco@mozilla.com> - Thu, 05 Apr 2018 16:31:00 +0200 - rev 777932
Push 105341 by luca.greco@alcacoop.it at Thu, 05 Apr 2018 15:22:31 +0000
Bug 1451767 - Add missing type in events API schema examples from the WebExtensions docs. MozReview-Commit-ID: Job5tZbiwWm
896de6c613e50e7bf761a6c2606f2a23a1ac9fda: Bug 1449564 - part 3: Make absolute position editor listen to mouse events at the system event group r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 05 Apr 2018 00:32:32 +0900 - rev 777931
Push 105340 by masayuki@d-toybox.com at Thu, 05 Apr 2018 15:14:45 +0000
Bug 1449564 - part 3: Make absolute position editor listen to mouse events at the system event group r?m_kato Currently, absolute position editor listens to mouse events at the default event group to handle dragging of positioner. However, this is blocked by a call of Event.stopPropagation() in web apps unexpectedly. Therefore, we should make it listen to the events at the system event group instead. MozReview-Commit-ID: Hoa8c9QvMuG
1e18914f62a73e688f5d97670cf44fc4079744ca: Bug 1449564 - part 2: Make absolute positioned element editor disabled in default and make it possible to enable it with new command r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 04 Apr 2018 22:27:49 +0900 - rev 777930
Push 105340 by masayuki@d-toybox.com at Thu, 05 Apr 2018 15:14:45 +0000
Bug 1449564 - part 2: Make absolute positioned element editor disabled in default and make it possible to enable it with new command r?m_kato We have another built-in UI of editor which is not implemented by any other browsers. That is a draggable handler to move absolute positioned elements. So, we should disable it in default for compatibility with the other browsers. However, different from resizers and inline table editor, we don't have command to enable/disable this feature but for backward compatibility, we should have it. Therefore, this patch adds new command "enableAbsolutePositionEditor". Note that whether resizing UI is available only with enableObjectResizing state is different from enableInlineTableEditing command. Resizers for absolute positioned elements are NOT available both enableObjectResizing and enableAbsolutePositionEditor are enabled. Additionally, this adds automated tests to check basic functions of absolute positioned editor. MozReview-Commit-ID: 9ZSGB8tLpFw
045c33454fdf7d2e646f5f71a7096cebdb8525c7: Bug 1449564 - part 1: Disable object resizer and inline table editor in default r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 02 Apr 2018 17:26:46 +0900 - rev 777929
Push 105340 by masayuki@d-toybox.com at Thu, 05 Apr 2018 15:14:45 +0000
Bug 1449564 - part 1: Disable object resizer and inline table editor in default r?m_kato Gecko supports resizers of <img> elements and <table>, <td>, <th> elements and has UI to remove existing table row or column in default. However, the other browsers don't have such UI and web apps need to disable this feature with calling both: document.execCommand("enableObjectResizing", false, false); document.execCommand("enableInlineTableEditing", false, false); for avoiding conflicting with their own features to edit such elements. Therefore, it doesn't make sense to keep enabling them in default only on Gecko. If web apps want to keep using these features, they should call: document.execCommand("enableObjectResizing", false, true); document.execCommand("enableInlineTableEditing", false, true); at initializing the editor. And also this patch fixes bugs of document.queryCommandState("enableObjectResizing") and document.queryCommandState("enableInlineTableEditing"). They always return false even after calling document.execCommand(..., false, true) since nsSetDocumentStateCommand::GetCommandStateParams() sets bool value as STATE_ATTRIBUTE. However, nsHTMLDocument::QueryCommandValue() which is the caller referring STATE_ATTRIBUTE doesn't treat it as bool value. And also those commands are related to state of document. Therefore, they should be return as bool value of STATE_ALL instead. Then, nsHTMLDocument::QueryCommandState() returns the state as expected. Note that those commands are supported only by Gecko. So, we don't need to worry about the compatibility. Finally, this patch rewrites 2 existing tests to check basic behavior of resizers and appearance of resizers. Note that this patch does not add new tests to test inline table editor since it's difficult to test the behavior with current API. Perhaps, we should add an API to nsIHTMLEditor to retrieve each anonymous elements in another bug since it requires to add wrapping API of SpecialPowers. MozReview-Commit-ID: 1FhYo5vcV60
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip