2091c74ecd29d90d96e4302ae0467eb3bed7973c: Bug 1466715 - Remove unimplemented -moz-appearance:window from XUL document elements on Windows and align on 'dialog' elsewhere. r=dao,emilio
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Sun, 10 Jun 2018 14:54:06 -0700 - rev 806723
Push 112919 by jdescottes@mozilla.com at Mon, 11 Jun 2018 10:52:00 +0000
Bug 1466715 - Remove unimplemented -moz-appearance:window from XUL document elements on Windows and align on 'dialog' elsewhere. r=dao,emilio Before this commit, we use `-moz-appearance: dialog;`[1] (mapping to NS_THEME_DIALOG) in global.css on macOS for XUL root elements while on Windows[2] and Linux[3] we use `-moz-appearance: window;` (mapping to NS_THEME_WINDOW). From what I can tell NS_THEME_WINDOW behaves the same as NS_THEME_DIALOG on Linux[4], NS_THEME_WINDOW doesn't do anything useful on macOS[5], and neither are implemented on Windows (bug 119737). [1] https://dxr.mozilla.org/mozilla-central/rev/0ee6b755ab2ee6d2ab79b17cc97bd4e83424cbfc/toolkit/themes/osx/global/global.css#35 [2] https://dxr.mozilla.org/mozilla-central/rev/0ee6b755ab2ee6d2ab79b17cc97bd4e83424cbfc/toolkit/themes/windows/global/global.css#41 [3] https://dxr.mozilla.org/mozilla-central/rev/0ee6b755ab2ee6d2ab79b17cc97bd4e83424cbfc/toolkit/themes/linux/global/global.css#45 [4] All references to NS_THEME_WINDOW and NS_THEME_DIALOG seem to handle the other in the same way. [5] https://dxr.mozilla.org/mozilla-central/search?q=regexp%3ANS_THEME_WINDOW%5Cb+path%3Acocoa&redirect=false MozReview-Commit-ID: 6TGzDnMEY2y
09d892dcaca7f8700a08f14b3b075b769bd82c5d: Bug 1467403 - Remove the source notes handling for prologue bytecode. r=jandem
Tooru Fujisawa <arai_a@mac.com> - Mon, 11 Jun 2018 15:09:28 +0900 - rev 806722
Push 112919 by jdescottes@mozilla.com at Mon, 11 Jun 2018 10:52:00 +0000
Bug 1467403 - Remove the source notes handling for prologue bytecode. r=jandem
0fa742aea983a6e0caa437428d8196d58092d216: Bug 1392274 - Update Web Platform Tests manifests and meta data r?whimboo draft
David Burns <dburns@mozilla.com> - Mon, 11 Dec 2017 21:38:30 +0000 - rev 806721
Push 112918 by bmo:dburns@mozilla.com at Mon, 11 Jun 2018 10:37:10 +0000
Bug 1392274 - Update Web Platform Tests manifests and meta data r?whimboo MozReview-Commit-ID: 3dfANiYwa05
6785e38dfeaa59a5ff5cd567d0a70e821ecd8db1: Bug 1392274 - Add Navigate Back wdspec tests r?whimboo draft
David Burns <dburns@mozilla.com> - Tue, 12 Dec 2017 22:20:47 +0000 - rev 806720
Push 112918 by bmo:dburns@mozilla.com at Mon, 11 Jun 2018 10:37:10 +0000
Bug 1392274 - Add Navigate Back wdspec tests r?whimboo These are the wdspec tests for testing the back command in https://w3c.github.io/webdriver/webdriver-spec.html#back MozReview-Commit-ID: Hhz2ocpvxbS
ac62ef3795b395bc55c9ea8e01e71b8850deaf49: Bug 1392274 - Add Refresh wdspec tests r?whimboo draft
David Burns <dburns@mozilla.com> - Mon, 11 Dec 2017 21:38:18 +0000 - rev 806719
Push 112918 by bmo:dburns@mozilla.com at Mon, 11 Jun 2018 10:37:10 +0000
Bug 1392274 - Add Refresh wdspec tests r?whimboo These are the wdspec tests for testing the refresh command in https://w3c.github.io/webdriver/webdriver-spec.html#refresh MozReview-Commit-ID: HHd6sU7P8hp
95daf9af66f62f5b3304a2c50f7d186f3b209d18: Bug 1392274 - Add Navigate Forward wdspec tests r?whimboo draft
David Burns <dburns@mozilla.com> - Mon, 11 Dec 2017 21:36:53 +0000 - rev 806718
Push 112918 by bmo:dburns@mozilla.com at Mon, 11 Jun 2018 10:37:10 +0000
Bug 1392274 - Add Navigate Forward wdspec tests r?whimboo These are the wdspec tests for testing the forward command in https://w3c.github.io/webdriver/webdriver-spec.html#forward MozReview-Commit-ID: BA8HOLRy1EC
50a554666ccb6dbb7a7f3205c4e6846f4ddec6ad: Bug 1466720 - Make PR shipping options use inline amounts followed by labels. r=sfoster draft
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 04 Jun 2018 18:16:49 -0700 - rev 806717
Push 112917 by mozilla@noorenberghe.ca at Mon, 11 Jun 2018 07:53:04 +0000
Bug 1466720 - Make PR shipping options use inline amounts followed by labels. r=sfoster MozReview-Commit-ID: GqDNdAch4yv
2e3327d9a9b2a31954d146011b9cdc48a01737eb: Bug 1466720 - Default PaymentRequest dialog styles for background, <a>, and debugging.html. r=jaws draft
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 11 Jun 2018 00:18:54 -0700 - rev 806716
Push 112917 by mozilla@noorenberghe.ca at Mon, 11 Jun 2018 07:53:04 +0000
Bug 1466720 - Default PaymentRequest dialog styles for background, <a>, and debugging.html. r=jaws MozReview-Commit-ID: EwH6sPo8yRV
6e544dd61798ebe3865ca108e59392a1319d7eeb: Bug 1466720 - Don't reload l10n.js in the PaymentRequest scope on a refresh. r=sfoster draft
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Mon, 11 Jun 2018 00:03:47 -0700 - rev 806715
Push 112917 by mozilla@noorenberghe.ca at Mon, 11 Jun 2018 07:53:04 +0000
Bug 1466720 - Don't reload l10n.js in the PaymentRequest scope on a refresh. r=sfoster There was an error trying to redefine variables from l10n.js via loadSubScript. We really only need it loaded once like a frame script but I had to fix the l10n.js code to handle this properly. MozReview-Commit-ID: EbNrEaRQJbs
dbe385e09d54b7fd96a35dbaf90e11d7aa2f8e23: Bug 1467572 - Part 5: Implement the new style for the global toolbar. r=jryans draft
Gabriel Luong <gabriel.luong@gmail.com> - Mon, 11 Jun 2018 02:51:29 -0400 - rev 806714
Push 112916 by bmo:gl@mozilla.com at Mon, 11 Jun 2018 07:03:24 +0000
Bug 1467572 - Part 5: Implement the new style for the global toolbar. r=jryans MozReview-Commit-ID: HuZntrqBMDe
d4d5a307bab9cbe2b0dc6f385f394f1f44b3f59f: Bug 1467572 - Part 4: Move the device selector into the global toolbar. r=jryans draft
Gabriel Luong <gabriel.luong@gmail.com> - Mon, 11 Jun 2018 02:04:59 -0400 - rev 806713
Push 112915 by bmo:gl@mozilla.com at Mon, 11 Jun 2018 06:06:00 +0000
Bug 1467572 - Part 4: Move the device selector into the global toolbar. r=jryans MozReview-Commit-ID: CNcgJzgAMzj
d324c376be18618c978a1490b40a260abbc1f23f: Bug 1467572 - Part 3: Remove the viewport dimension. r=jryans draft
Gabriel Luong <gabriel.luong@gmail.com> - Mon, 11 Jun 2018 01:53:37 -0400 - rev 806712
Push 112915 by bmo:gl@mozilla.com at Mon, 11 Jun 2018 06:06:00 +0000
Bug 1467572 - Part 3: Remove the viewport dimension. r=jryans MozReview-Commit-ID: 85AaCrnXnAZ
c82bd09ba86ec6697d6c680924854f9eb9d190ea: Bug 1467572 - Part 2: Remove the viewport toolbar. r=jryans draft
Gabriel Luong <gabriel.luong@gmail.com> - Mon, 11 Jun 2018 01:49:01 -0400 - rev 806711
Push 112915 by bmo:gl@mozilla.com at Mon, 11 Jun 2018 06:06:00 +0000
Bug 1467572 - Part 2: Remove the viewport toolbar. r=jryans MozReview-Commit-ID: GKphJlfrkBG
e48ce235eeab37e2f19a540f9af32dc1e564aafa: Bug 1468133: Remove the optimization to lazily load non-SVG styles since it's not relevant anymore. r?heycam draft
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 11 Jun 2018 06:38:42 +0200 - rev 806710
Push 112914 by bmo:emilio@crisal.io at Mon, 11 Jun 2018 05:46:14 +0000
Bug 1468133: Remove the optimization to lazily load non-SVG styles since it's not relevant anymore. r?heycam This was a memory-saving optimization introduced as part of dependencies for bug 686875, but a more general system landed in bug 77999 for Gecko and https://github.com/servo/servo/pull/18509 for Servo. So now it's probably even a bit of a pessimization (though probably not huge), and given this causes bugs like bug 1462742, bug 1157592, and bug 1468145, and fishiness like the one pointed out in this bug, we may as well remove it. The performance impact of having to lookup through more rules should be minimal given the bloom filter and the rule hash optimizations. This makes me wonder whether we could remove the whole concept of on-demand UA sheets, since they've caused pain, for example, when the frontend people try loading <svg>s from NAC (since that triggers sheet loading from frame construction, which is not good). I'm not concerned about loading mathml.css and svg.css everywhere, though xul.css may not be as doable since it adds a bunch of attribute-dependent selectors. Though on the other hand I asserted in the xul.css code and we don't load it in content with <video> / <input type="date/time/etc"> and such, afaict, so maybe now that legacy addons are gone we can remove that sheet from content processes altogether. Maybe worth at least filing a followup? MozReview-Commit-ID: 9JCWNZj6BkT
f5b937936fb84b3ae414d6cf0250add4078a9d53: Bug 1467873 - Fix FrameMetrics::CalculateCompositedRectInCssPixels(). r=kats draft
Botond Ballo <botond@mozilla.com> - Sat, 09 Jun 2018 16:33:26 -0400 - rev 806709
Push 112913 by bballo@mozilla.com at Mon, 11 Jun 2018 05:27:21 +0000
Bug 1467873 - Fix FrameMetrics::CalculateCompositedRectInCssPixels(). r=kats - Fix the implementation to return a numerically correct result - Change call sites that should have instead been using CalculateCompositedSizeInCssPixels(), to do so - Rename and document to emphasize that the returned rect is in the CSS pixels of the content surrounding the scroll frame MozReview-Commit-ID: GCPbA1k88rz
103d6204d56b5132113db9a62d5ef9a1e9886651: Bug 1467572 - Part 1: Move the App component into the component folder. r=jryans draft
Gabriel Luong <gabriel.luong@gmail.com> - Mon, 11 Jun 2018 00:51:58 -0400 - rev 806708
Push 112912 by bmo:gl@mozilla.com at Mon, 11 Jun 2018 04:52:57 +0000
Bug 1467572 - Part 1: Move the App component into the component folder. r=jryans MozReview-Commit-ID: Eja1zgEvdMH
39e53f0ddcddaa3f95646f2d5705965ec8516263: Bug 1467340 - Ctrl+w and Ctrl+f4 shortcuts close all selected tabs in multi-select context. r?jaws draft multiselect_close_keybinding_ctrl_w
layely <ablayelyfondou@gmail.com> - Thu, 07 Jun 2018 13:36:17 +0000 - rev 806707
Push 112911 by bmo:ablayelyfondou@gmail.com at Mon, 11 Jun 2018 04:04:33 +0000
Bug 1467340 - Ctrl+w and Ctrl+f4 shortcuts close all selected tabs in multi-select context. r?jaws MozReview-Commit-ID: AfrpuOKBfas
af2b3e0e1d02f4cc1521e285d774a98dedc0d960: Bug 1157592: Make InsertAnonymousContent load all the relevant stylesheets in SVG documents. r?bz draft
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 11 Jun 2018 04:45:10 +0200 - rev 806706
Push 112910 by bmo:emilio@crisal.io at Mon, 11 Jun 2018 03:12:55 +0000
Bug 1157592: Make InsertAnonymousContent load all the relevant stylesheets in SVG documents. r?bz The underlying issue here is that the rule that makes the custom content container abspos is in ua.css, and we don't load that for SVG documents. Similarly, this fixes all the markers and such, that would be inline because of the lack of html.css etc. This fixes the root cause of bug 1462742, as well, so I added a few assertions that should replace the wallpaper there. The reason we're guaranteed to be oof is because top-layer implies that via StyleAdjuster::adjust_for_top_layer. As an aside, the fact that AccessibleCaret calls into InsertAnonymousContent from frame construction makes me extremely nervous, but it already does all sort of other pretty nasty stuff... I'll file and fix. MozReview-Commit-ID: 7ofKNGR8E20
5a6110885a9a86e2237b1291ea4fe27a1ce6499b: Bug 1468127: Move slot UA rule to html.css. r?heycam draft
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 11 Jun 2018 03:26:57 +0200 - rev 806705
Push 112910 by bmo:emilio@crisal.io at Mon, 11 Jun 2018 03:12:55 +0000
Bug 1468127: Move slot UA rule to html.css. r?heycam MozReview-Commit-ID: FRBioGS4Gbe
0e84b7df59d06ed83c61e9abf27ff0b3dc0430e8: Bug 1427961 - Basic shipping address validation for state/province and zip/postal code. draft
Jared Wein <jwein@mozilla.com> - Thu, 07 Jun 2018 17:02:42 -0400 - rev 806704
Push 112909 by bmo:jaws@mozilla.com at Mon, 11 Jun 2018 03:07:44 +0000
Bug 1427961 - Basic shipping address validation for state/province and zip/postal code. todo: need to clear validation messages when changing which page is shown MozReview-Commit-ID: DCjr13QxP5Z
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip