1ea285ab81ac52ccffc4d765b7f495b76faebf77: Bug 1329319 - gtest for issue with NewRunnableMethod on a non-refcounted base class method - r?froydnj draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 09 Jan 2017 11:09:59 +1100 - rev 457800
Push 40901 by gsquelart@mozilla.com at Mon, 09 Jan 2017 23:50:28 +0000
Bug 1329319 - gtest for issue with NewRunnableMethod on a non-refcounted base class method - r?froydnj This test alone would fail to even build without the previous patch, demonstrating the issue at hand, where the method-pointer from the base class forces NewRunnableMethod to store a pointer to that base class in a RefPtr, which is not possible when that base class is not ref-counted. MozReview-Commit-ID: 9XaQ8SwMqVo
aa2cac47036d0d1d7a36c8c0137fe21f21b4961b: Bug 1329319 - Allow NewRunnableMethod to method of a non-refcounted base class - r?froydnj draft
Gerald Squelart <gsquelart@mozilla.com> - Tue, 10 Jan 2017 10:49:08 +1100 - rev 457799
Push 40901 by gsquelart@mozilla.com at Mon, 09 Jan 2017 23:50:28 +0000
Bug 1329319 - Allow NewRunnableMethod to method of a non-refcounted base class - r?froydnj This is done by storing the object pointer based on the exact pointee type, instead of as hinted by the method-pointer, which could be a non-refcounted base class. The stored pointer type is statically-checked to be derived from (or the same as) the class type from the method-pointer, to prevent misuses. One change had to be done in TrackBuffersManager, as it was passing another type and relying on implicit pointer conversions. A simple `.get()` to pass the raw pointer type (to be stored in a RefPtr) fixed that one issue. MozReview-Commit-ID: 4kH0XdjB5Rk
70bd5c8ffd5a5ce89bb892d38ad82c0041c742cf: Bug 1329220 - use a fourth browser to deal with print previewing simplified mode, r?jwatt,mconley draft
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 09 Jan 2017 23:44:15 +0000 - rev 457798
Push 40900 by bmo:gijskruitbosch+bugs@gmail.com at Mon, 09 Jan 2017 23:44:44 +0000
Bug 1329220 - use a fourth browser to deal with print previewing simplified mode, r?jwatt,mconley MozReview-Commit-ID: JxMA3Kk6wnO
e5853c043cce75ba89e3d800a181ba1d259e1f70: Bug 1329220 - fix print preview source browser confusion, r?jwatt,mconley draft
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 09 Jan 2017 22:04:05 +0000 - rev 457797
Push 40900 by bmo:gijskruitbosch+bugs@gmail.com at Mon, 09 Jan 2017 23:44:44 +0000
Bug 1329220 - fix print preview source browser confusion, r?jwatt,mconley Restore overwriting of this._sourceBrowser as it was before bug 1308621 to ensure we continue to use the same DOM to do print previewing (and eventually printing). Bug 1308621 already changed the enterPrintPreview code to rely on the member _sourceBrowser variable, which will be updated to point to the print preview browser if/when print preview is being reinitialized for the same page (because one of the print settings changes). We need to do this to avoid re-initializing off the original browser, which may now have navigated or be displaying something else entirely. This also updates the 'simplified' mode code to rely on the extant _originalURL member to avoid displaying the page URL as about:blank after a settings change. MozReview-Commit-ID: DZ1kT7Mb0mS
6494eff7e0dd17b61c5cd03d768f794e9772e7b4: Bug 1313155 - Remove dom/settings and related code. r?ehsan draft
Michelangelo De Simone <mdesimone@mozilla.com> - Thu, 29 Dec 2016 11:26:49 -0800 - rev 457796
Push 40899 by bmo:mdesimone@mozilla.com at Mon, 09 Jan 2017 23:41:27 +0000
Bug 1313155 - Remove dom/settings and related code. r?ehsan MozReview-Commit-ID: Gi7frPFQ6yW
701429d2e3c71a4b7c0eb934407422b163c23413: Bug 1329319 - gtest for issue with NewRunnableMethod on a non-refcounted base class method - r?froydnj draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 09 Jan 2017 11:09:59 +1100 - rev 457795
Push 40898 by gsquelart@mozilla.com at Mon, 09 Jan 2017 23:33:56 +0000
Bug 1329319 - gtest for issue with NewRunnableMethod on a non-refcounted base class method - r?froydnj This test alone would fail to even build without the previous patch, demonstrating the issue at hand, where the method-pointer from the base class forces NewRunnableMethod to store a pointer to that base class in a RefPtr, which is not possible when that base class is not ref-counted. MozReview-Commit-ID: 9XaQ8SwMqVo
1516d9dd5a4724cf452bc11e771b2a6ca01d8c47: Bug 1329319 - Allow NewRunnableMethod to method of a non-refcounted base class - r?froydnj draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 09 Jan 2017 11:11:16 +1100 - rev 457794
Push 40898 by gsquelart@mozilla.com at Mon, 09 Jan 2017 23:33:56 +0000
Bug 1329319 - Allow NewRunnableMethod to method of a non-refcounted base class - r?froydnj This is done by storing the object pointer based on the exact pointee type, instead of as hinted by the method-pointer, which could be a non-refcounted base class. The stored pointer type is statically-checked to be derived from (or the same as) the class type from the method-pointer, to prevent misuses. One change had to be done in TrackBuffersManager, as it was passing another type and relying on implicit pointer conversions. A simple `.get()` to pass the raw pointer type (to be stored in a RefPtr) fixed that one issue. MozReview-Commit-ID: 4kH0XdjB5Rk
4db25092c64d87f34e9691f1e80617c9a0bf3662: Bug 1329513 - RemoveRawOrSmartPointerHelper to extract T from T*, RefPtr<T>, and nsCOMPtr<T> - r?froydnj draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 09 Jan 2017 09:32:36 +1100 - rev 457793
Push 40897 by gsquelart@mozilla.com at Mon, 09 Jan 2017 23:32:39 +0000
Bug 1329513 - RemoveRawOrSmartPointerHelper to extract T from T*, RefPtr<T>, and nsCOMPtr<T> - r?froydnj Implemented in the same style as RemovePointer and RemoveSmartPointer, for consistency. It could have been done by invoking the latter two, but I didn't want to add an unnecessary extra layer of templates; the cost of the code duplication should be negligible. MozReview-Commit-ID: IH4lZkbRYGZ
4068c9ce12eb6995027a2039a17957c21bf4608a: Bug 1329512 - Make IsRefcountedSmartPointer and RemoveSmartPointer const&volatile-resistant - r?froydnj draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 09 Jan 2017 08:28:49 +1100 - rev 457792
Push 40896 by gsquelart@mozilla.com at Mon, 09 Jan 2017 23:31:25 +0000
Bug 1329512 - Make IsRefcountedSmartPointer and RemoveSmartPointer const&volatile-resistant - r?froydnj MozReview-Commit-ID: HayfiFH0f9E
6e643229023edb1a286df8dfb02e59ba8dcf1da7: Bug 1329512 - Move *SmartPointer classes higher in the file - r?froydnj draft
Gerald Squelart <gsquelart@mozilla.com> - Mon, 09 Jan 2017 08:21:44 +1100 - rev 457791
Push 40896 by gsquelart@mozilla.com at Mon, 09 Jan 2017 23:31:25 +0000
Bug 1329512 - Move *SmartPointer classes higher in the file - r?froydnj Just a straight move, no code changes. This will be needed in bug 1329319, as some new code higher in the file will rely on RemoveSmartPointer. Since the next patch will pretty much rewrite RemoveSmartPointer anyway, I thought I might as well make the big move right now, to keep better history/blame of the upcoming changes. MozReview-Commit-ID: A2lMUFHFWg4
3075b2c4da4454adb518fd5fc686a92622633d30: Bug 1326018 - Process telemetry for highlight click before url open action r=sebastian draft
Grigory Kruglov <gkruglov@mozilla.com> - Mon, 09 Jan 2017 15:04:58 -0800 - rev 457790
Push 40895 by gkruglov@mozilla.com at Mon, 09 Jan 2017 23:05:47 +0000
Bug 1326018 - Process telemetry for highlight click before url open action r=sebastian MozReview-Commit-ID: 8Tlth9GvqOb
431251ee911f1d4aa92039b542a25787b907b235: Bug 1329467 - Drop non-SPS version of AutoProfilerRegister. r?mstange draft
Jan Beich <jbeich@FreeBSD.org> - Mon, 09 Jan 2017 23:03:22 +0000 - rev 457789
Push 40894 by bmo:jbeich@FreeBSD.org at Mon, 09 Jan 2017 23:05:30 +0000
Bug 1329467 - Drop non-SPS version of AutoProfilerRegister. r?mstange MozReview-Commit-ID: 9lZLPAi5ZZT
79e9d56a9608129fbcba9d89c19a96b325a5d6fe: Bug 1329467 - Move remaining *RAII classes from GeckoProfiler under mozilla namespace. r?mstange draft
Jan Beich <jbeich@FreeBSD.org> - Mon, 09 Jan 2017 22:11:58 +0000 - rev 457788
Push 40893 by bmo:jbeich@FreeBSD.org at Mon, 09 Jan 2017 22:25:06 +0000
Bug 1329467 - Move remaining *RAII classes from GeckoProfiler under mozilla namespace. r?mstange MozReview-Commit-ID: I8qqGDLJkgo
73f445510dfe4e6fb58f0f9ee61a970bba837216: Bug 1329467 - Adjust *RAII classes to be under mozilla namespace. r?mstange draft
Jan Beich <jbeich@FreeBSD.org> - Mon, 09 Jan 2017 22:11:58 +0000 - rev 457787
Push 40892 by bmo:jbeich@FreeBSD.org at Mon, 09 Jan 2017 22:19:37 +0000
Bug 1329467 - Adjust *RAII classes to be under mozilla namespace. r?mstange MozReview-Commit-ID: I8qqGDLJkgo
5c01f85c4a3beda9aee1006be9a3ce35d833c7b8: Bug 1329467 - Revert bug 1151829 to unbreak non-SPS build after bug 1322553. r?mstange draft
Jan Beich <jbeich@FreeBSD.org> - Mon, 09 Jan 2017 21:46:56 +0000 - rev 457786
Push 40892 by bmo:jbeich@FreeBSD.org at Mon, 09 Jan 2017 22:19:37 +0000
Bug 1329467 - Revert bug 1151829 to unbreak non-SPS build after bug 1322553. r?mstange MozReview-Commit-ID: 14QL0Unr84G
8255f8b17af426d3332151d7e8b5237e8bc564a6: Bug 1329634 - actually call profiler_tracing in GeckoProfilerTracingRAII constructor; r=mstange draft
Nathan Froyd <froydnj@gmail.com> - Mon, 09 Jan 2017 21:45:07 +0000 - rev 457785
Push 40892 by bmo:jbeich@FreeBSD.org at Mon, 09 Jan 2017 22:19:37 +0000
Bug 1329634 - actually call profiler_tracing in GeckoProfilerTracingRAII constructor; r=mstange
6c8a1c1d25e379eb895a693aeda613bf1871f86c: Bug 1325275 - Re-enable leak testing on OSX in the prompts directory. r=ahal draft
Andrew McCreight <continuation@gmail.com> - Mon, 09 Jan 2017 10:27:28 -0800 - rev 457784
Push 40891 by bmo:continuation@gmail.com at Mon, 09 Jan 2017 22:17:40 +0000
Bug 1325275 - Re-enable leak testing on OSX in the prompts directory. r=ahal MozReview-Commit-ID: FWoPApp6BRw
72cd4970c78254ec43612f1c1ffbbbcb6116c39b: Bug 1309284 - WebAuthn JS API [part 4]: Add Unit Tests r=keeler draft
J.C. Jones <jjones@mozilla.com> - Mon, 09 Jan 2017 13:28:02 -0700 - rev 457783
Push 40890 by jjones@mozilla.com at Mon, 09 Jan 2017 22:16:19 +0000
Bug 1309284 - WebAuthn JS API [part 4]: Add Unit Tests r=keeler This uses the new mochitest "scheme" option from Bug 1286312. This cannot land until after Bug 1286312 does. For now, you can test locally by adding --setpref dom.securecontext.whitelist=mochi.test to your command line, such as: ~/hg/mozilla-central/mach mochitest \ --setpref dom.securecontext.whitelist=mochi.test ./dom/u2f/tests/ Updated: Review fixes (thanks keeler!) MozReview-Commit-ID: 7jTxF3Mrtcg
1d1cbdabfa79097be5ad14a5e4ecb887883453e4: Bug 1309284 - WebAuthn JS API [part 3]: Support origin relax algorithm r=keeler draft
J.C. Jones <jjones@mozilla.com> - Mon, 09 Jan 2017 13:55:59 -0700 - rev 457782
Push 40890 by jjones@mozilla.com at Mon, 09 Jan 2017 22:16:19 +0000
Bug 1309284 - WebAuthn JS API [part 3]: Support origin relax algorithm r=keeler The WebAuthn specification calls for running the HTML5.1 algorithm that occurs when you modify document.domain from JS, and use that algorithm's output for the "Relying Party ID" through the rest of the WebAuthn algorithm. This code paves the way for that to be added in Bug 1329764, once the spec issues upstream are resolved. MozReview-Commit-ID: DNNcr3Gh1Be
52151480b4b2b600a598c06678b28f6be581e5e6: Bug 1309284 - WebAuthn JS API [part 2]: Bugfixes from testing r=keeler draft
J.C. Jones <jjones@mozilla.com> - Fri, 16 Dec 2016 10:44:56 -0700 - rev 457781
Push 40890 by jjones@mozilla.com at Mon, 09 Jan 2017 22:16:19 +0000
Bug 1309284 - WebAuthn JS API [part 2]: Bugfixes from testing r=keeler Add more debugging information to signing operations for the NSS Soft Token. Bugfixes in WebAuthentication.cpp: - Calculate ArrayBuffer/View before using. - Fix an instance where we should return NotSupportedError. - Fix several instances where we should return Out Of Memory. - Fix a MozPromise assertion that occurs in GetAssertion if you coerce an early return. - Mark all constructors explicit. MozReview-Commit-ID: DQWHqZIlau9
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip