1b0742e4dc15ca3530311a264a1417400c4f7d9e: Bug 1256565 - Part 1. Implement GetEventTimeStamp(). r=jchen r?karlt draft
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 20 Feb 2017 12:34:44 +0900 - rev 486842
Push 46075 by m_kato@ga2.so-net.ne.jp at Mon, 20 Feb 2017 03:38:04 +0000
Bug 1256565 - Part 1. Implement GetEventTimeStamp(). r=jchen r?karlt Android uses android.os.SystemClock.uptimeMilles for event time and SystemClock.uptimeMilles uses SYSTEM_TIME_MONOTONIC. So since TimeStamp posix impelemetation uses SYSTEM_TIME_MONOTONIC too, so we can use event time on FromSystemTime. MozReview-Commit-ID: 5Qb5kmnHHCI
39f16b4e50267f36c7bd19f11d5226242d7445cd: Bug 1338961 - A mozinputrangeignorepreventdefault hack for input[type=range], r=smaug, sr=smaug draft
Timothy Guan-tin Chien <timdream@gmail.com> - Fri, 17 Feb 2017 17:05:27 +0800 - rev 486841
Push 46074 by bmo:timdream@gmail.com at Mon, 20 Feb 2017 03:28:58 +0000
Bug 1338961 - A mozinputrangeignorepreventdefault hack for input[type=range], r=smaug, sr=smaug This is a terrible hack, asking input[type=range] in our video control xbl binding content continue to handle mouse/touch event, even if the event is being defaultPrevented by the content. MozReview-Commit-ID: G1huxbS7oeq
4475558321d30c08eec181479a0ed11b11df4227: Bug 1340942. Part 4 - pass Data& to DoInitDecoder(). draft
JW Wang <jwwang@mozilla.com> - Fri, 17 Feb 2017 15:21:46 +0800 - rev 486840
Push 46073 by jwwang@mozilla.com at Mon, 20 Feb 2017 03:04:34 +0000
Bug 1340942. Part 4 - pass Data& to DoInitDecoder(). MozReview-Commit-ID: IwlpxR2MuRE
d76613e0c3d4792b416175a72c1e7d94432dd29d: Bug 1340942. Part 3 - pass Data& to DoCreateDecoder. draft
JW Wang <jwwang@mozilla.com> - Fri, 17 Feb 2017 15:17:22 +0800 - rev 486839
Push 46073 by jwwang@mozilla.com at Mon, 20 Feb 2017 03:04:34 +0000
Bug 1340942. Part 3 - pass Data& to DoCreateDecoder. MozReview-Commit-ID: ABHu0tp57AM
54d8ffc3d28b2762e86e6f73f36e90e790f0b4eb: Bug 1340942. Part 2 - pass Data& to RunStage(). draft
JW Wang <jwwang@mozilla.com> - Fri, 17 Feb 2017 15:14:53 +0800 - rev 486838
Push 46073 by jwwang@mozilla.com at Mon, 20 Feb 2017 03:04:34 +0000
Bug 1340942. Part 2 - pass Data& to RunStage(). MozReview-Commit-ID: DAALmMBhoep
32edcdf089f2ebe6f543355cf67db259ebab1e94: Bug 1340942. Part 1 - add some members so we don't have to pass the track type around. draft
JW Wang <jwwang@mozilla.com> - Fri, 17 Feb 2017 14:48:42 +0800 - rev 486837
Push 46073 by jwwang@mozilla.com at Mon, 20 Feb 2017 03:04:34 +0000
Bug 1340942. Part 1 - add some members so we don't have to pass the track type around. MozReview-Commit-ID: Ewipsg8FFqb
f606545c5fafc439fe4dad363607de36ca45e8f7: debug MediaCache. draft
JW Wang <jwwang@mozilla.com> - Fri, 20 Jan 2017 15:20:18 +0800 - rev 486836
Push 46073 by jwwang@mozilla.com at Mon, 20 Feb 2017 03:04:34 +0000
debug MediaCache. MozReview-Commit-ID: 3uGC1nCUKi0
66d4a7f54fd7b2b08ceaf5ef2672fc8a06c3bcc1: Bug 1314921 - merge events.js into constants.js;r=rickychien draft
Fred Lin <gasolin@mozilla.com> - Fri, 17 Feb 2017 11:11:18 +0800 - rev 486835
Push 46072 by bmo:gasolin@mozilla.com at Mon, 20 Feb 2017 02:39:47 +0000
Bug 1314921 - merge events.js into constants.js;r=rickychien MozReview-Commit-ID: 3tstH8uxv0B
f9915d624efc13dab96c3a6c8d75ad24c5f85c6f: Bug 1314921 - move top-level files into utils;r=honza draft
Fred Lin <gasolin@mozilla.com> - Thu, 16 Feb 2017 15:24:26 +0800 - rev 486834
Push 46072 by bmo:gasolin@mozilla.com at Mon, 20 Feb 2017 02:39:47 +0000
Bug 1314921 - move top-level files into utils;r=honza MozReview-Commit-ID: GtAe9ggiCeA
b745fe73f51c15de9b4efbc38f41926db292360b: Bug 1338082 - Add telemetry probes to track the positive and negative cache durations in V4. r?francois draft
dimi <dlee@mozilla.com> - Mon, 20 Feb 2017 10:25:18 +0800 - rev 486833
Push 46071 by dlee@mozilla.com at Mon, 20 Feb 2017 02:25:55 +0000
Bug 1338082 - Add telemetry probes to track the positive and negative cache durations in V4. r?francois MozReview-Commit-ID: 43Nf5bS2Uo
5d7f3330d5aef618c1b7f13de3bfb805b11416c2: Bug 1340885 - Null check frame's content when searching for NAC ancestors in GetCorrectedParent. r?xidorn draft
Cameron McCormack <cam@mcc.id.au> - Mon, 20 Feb 2017 10:22:13 +0800 - rev 486832
Push 46070 by bmo:cam@mcc.id.au at Mon, 20 Feb 2017 02:22:38 +0000
Bug 1340885 - Null check frame's content when searching for NAC ancestors in GetCorrectedParent. r?xidorn MozReview-Commit-ID: 7u2yKe8ir1V
f2189a78081ad535efb59ba387ef424fe7b94d2d: Bug 1337694 - Add Language negotiation to LocaleService API draft
Zibi Braniecki <gandalf@mozilla.com> - Sun, 19 Feb 2017 18:15:27 -0800 - rev 486831
Push 46069 by zbraniecki@mozilla.com at Mon, 20 Feb 2017 02:17:11 +0000
Bug 1337694 - Add Language negotiation to LocaleService API MozReview-Commit-ID: 59zOYC8Y219
3dd2473efa260b2efcf89c399e40910f0c9c0260: Bug 1337694 - Add language negotiation heuristics to LocaleService. draft
Zibi Braniecki <gandalf@mozilla.com> - Mon, 13 Feb 2017 15:49:37 -0800 - rev 486830
Push 46069 by zbraniecki@mozilla.com at Mon, 20 Feb 2017 02:17:11 +0000
Bug 1337694 - Add language negotiation heuristics to LocaleService. MozReview-Commit-ID: Ka6ESWYqyTQ
0794c2aa6348f9df1442f261015d05acb9220f88: Bug 1323366 - Create new IconRequest to prevent ConcurrentModificationException, r?sebastian draft
Jing-wei Wu <topwu.tw@gmail.com> - Mon, 20 Feb 2017 09:45:16 +0800 - rev 486829
Push 46068 by bmo:topwu.tw@gmail.com at Mon, 20 Feb 2017 02:09:07 +0000
Bug 1323366 - Create new IconRequest to prevent ConcurrentModificationException, r?sebastian
9e5d57c24027277f6305830cde4d2d374a976dc6: Bug 1317223 (part 6) - integration tests for the bookmark repair requestor and responder. r?tcsc draft
Mark Hammond <mhammond@skippinet.com.au> - Mon, 06 Feb 2017 10:54:08 -0800 - rev 486828
Push 46067 by mhammond@skippinet.com.au at Mon, 20 Feb 2017 02:02:46 +0000
Bug 1317223 (part 6) - integration tests for the bookmark repair requestor and responder. r?tcsc This is an attempt at a true integration tests without the use of mocks. It's tricky and hacky to do such tests - I suspect this patch is probably misguided and that TPS might be a better environment for these kinds of tests - I'm flagging Thom for review here primarily to see what he things about using TPS instead of this. MozReview-Commit-ID: 8us4v6Y21oM
cfe0ab4baea54219059a0f05fcc23164f794039e: Bug 1317223 (part 5) - a bookmark repair responder. r?kitcambridge draft
Mark Hammond <mhammond@skippinet.com.au> - Mon, 20 Feb 2017 12:53:07 +1100 - rev 486827
Push 46067 by mhammond@skippinet.com.au at Mon, 20 Feb 2017 02:02:46 +0000
Bug 1317223 (part 5) - a bookmark repair responder. r?kitcambridge This is the "repair responder" - it handles a "repairRequest" command sent by another client and attempts to take the list of IDs that client lists as missing and upload whatever records are necessary such that the requesting client would then be likely to find a complete and valid tree on the server. In the simple case, the responder would just upload the listed items if they exist locally, but this isn't smart enough - we will also need to (a) walk to the root from a requested item and ensure all subsequent parents also exist (b) if the missing item is a folder ensure the entire subtree under the item exists correctly and (c) see if the item should never have been uploaded in the first place (eg, if it is a local left-pane root) and if so, issue a delete of that ID and all subsequent parents up to the root. Currently (a) is done - (b) and (c) are not. The main TODOs here are: * (b) and (c) above, including tests for those. * Any other edge cases we can think about. * See if the "tree walking" code in the patch should be moved to PlacesSyncUtils. * Formalize the concept of "track weakly" used in the patch - we don't touch the syncChangeCounter field when tracking items as the entire repair process will automatically restart when the browser does. * More tests for other edge-cases - there are some XXX comments in the test file. MozReview-Commit-ID: 4xw19nH6EfL
b3ffee0fc9f0f3fd64dfca68cb550a0732f35cf7: Bug 1317223 (part 4) -Formalize weak tracking in `BookmarksChangeset`. r=markh draft
Kit Cambridge <kit@yakshaving.ninja> - Mon, 06 Feb 2017 10:19:27 -0800 - rev 486826
Push 46067 by mhammond@skippinet.com.au at Mon, 20 Feb 2017 02:02:46 +0000
Bug 1317223 (part 4) -Formalize weak tracking in `BookmarksChangeset`. r=markh MozReview-Commit-ID: C6otrtSuhZH
92ccfc8be356153b78675e1ac156ce09f00f038d: Bug 1317223 (part 3) - A bookmark repair requestor. r=markh,tcsc draft
Mark Hammond <mhammond@skippinet.com.au> - Mon, 20 Feb 2017 12:36:08 +1100 - rev 486825
Push 46067 by mhammond@skippinet.com.au at Mon, 20 Feb 2017 02:02:46 +0000
Bug 1317223 (part 3) - A bookmark repair requestor. r=markh,tcsc This is where the fun actually starts :) The bookmark repair requestor takes the validation results, and if those results include missing children records (when the parent exists but a child doesn't) and orphans (when the child exists but the parent doesn't) it kicks off a repair request by sending a "repairRequest" command to other clients in a controlled manner (effectivly a round-robin of all suitable other devices, waiting for a period of time before giving up on that client and moving on to another) until either all requested IDs have been found or no other clients are suitable. The main TODOs in this patch are: * See if there are other obvious validation results which mean a simple "record is missing from the server". * Decide if we really do need to attempt each client twice given that part 1 changes the engine implementation such that the repairRequest command is not actually removed from the client record until a repairResponse has been written. (See XXX comment in _continueRepairs) * Possibly more tests of edge and error cases. MozReview-Commit-ID: 7rRNbBx8Vo3
2c5a78995d0dc65cad8afb82b43c89c3f079ccc6: Bug 1317223 (part 2) - add 'doctor' concept and move bookmark validation logic to it. r?tcsc draft
Mark Hammond <mhammond@skippinet.com.au> - Mon, 20 Feb 2017 12:35:28 +1100 - rev 486824
Push 46067 by mhammond@skippinet.com.au at Mon, 20 Feb 2017 02:02:46 +0000
Bug 1317223 (part 2) - add 'doctor' concept and move bookmark validation logic to it. r?tcsc This patch defines the concept of a "doctor" for collections. The doctor is responsible for running all validators and deciding whether or not to initiate a repair request based on the validation results. The bulk of this patch is moving _tryValidateEngines from enginesync.js into the new doctor, plus changes so that after running a validator it uses the collection_repair interface introduced in part 1 to possibly initiate a repair request. This patch also changes the preference names used for the validators to include the collection names. For example, the pref "services.sync.validation.enabled" has been changed to "services.sync.engine.bookmarks.validation.enabled" - there's no real reason I did this other than I felt it seemed sensible - we might decide there's no good reason for that - nothing in the patch actually relies on it. TODO: The main TODO in this patch is to work out how we should handle the last-modified time on the server. To be safe, we *might* decide that we should keep the last-modified time of the collection we used to perform the validation and use if-unmodified-since when posting any items we find. However, I'm not sure that this buys us any safety in practice, especially while we are only uploading items known to not exist on the server. MozReview-Commit-ID: 6NLRE6L0OpA
49682807294ba9d3f546f3ea91a8e1fcf04e2297: Bug 1317223 (part 1) - a collection_repair module (without any repairers) and integration with the clients engine. r?rnewman,eoger draft
Mark Hammond <mhammond@skippinet.com.au> - Mon, 20 Feb 2017 12:37:01 +1100 - rev 486823
Push 46067 by mhammond@skippinet.com.au at Mon, 20 Feb 2017 02:02:46 +0000
Bug 1317223 (part 1) - a collection_repair module (without any repairers) and integration with the clients engine. r?rnewman,eoger This creates a collection_repair module, somewhat analogous to the existing collection_validator module. This defines the public interface to request a new repair and respond to a remote repair request, and also includes changes to clients.js to call this public interface. collection_validator also defines abstract base classes for the implementation of the requestors/responders, but does not define either a requestor nor a responder - in other words, the interface exists but no concrete requestors or repairers will be found. There are also a couple of changes to client.js used by later patches, namely a way to query the command queued for a client and to get the client record itself. The main TODO here is to consider how safe the new "don't remove the repair request from the client engine until the repair is done" change and consider if there is anything else we should do to make it less likely some obscure error will cause a the command to remain pending forever (although I believe the telemetry we record here should be enough to tell us if this is actually happening) Another thing we should consider is not allowing multiple repair requests to be pending at once. MozReview-Commit-ID: 9JPpRrLgFoR
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip