1a3de277a1fc3591acff3012c0981c2e98278add: Bug 1329045 part 2: Convert some global variables to local variables, in test_use_with_hsts.html. r=xidorn
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 06 Jan 2017 13:03:22 -0800 - rev 457337
Push 40734 by ydelendik@mozilla.com at Sat, 07 Jan 2017 16:43:50 +0000
Bug 1329045 part 2: Convert some global variables to local variables, in test_use_with_hsts.html. r=xidorn (Before we introduced async/await in this test, some of these needed to be global, because they were used in several callbacks.) MozReview-Commit-ID: 7mDzmUx1jQ
aa001860e4ab1e23ea28dbdaeca7f6a5723e2c52: Bug 1329045 part 1: Use async/await to simplify callbacks in mochitest test_use_with_hsts.html. r=xidorn
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 06 Jan 2017 13:03:21 -0800 - rev 457336
Push 40734 by ydelendik@mozilla.com at Sat, 07 Jan 2017 16:43:50 +0000
Bug 1329045 part 1: Use async/await to simplify callbacks in mochitest test_use_with_hsts.html. r=xidorn MozReview-Commit-ID: 3qMTOl3fQzg
88f2a76d67dd618d58b43117bd50721c5da01dea: Bug 1316749: use taskcluster-proxy to hit index for docker image optimization; r=jonasfj
Dustin J. Mitchell <dust in@mozilla.com> - Fri, 06 Jan 2017 22:04:56 +0100 - rev 457335
Push 40734 by ydelendik@mozilla.com at Sat, 07 Jan 2017 16:43:50 +0000
Bug 1316749: use taskcluster-proxy to hit index for docker image optimization; r=jonasfj
e3d4bca8197cd818e9bc550da16ca9fc5850b8d4: Backed out changeset 1f38938f4e9b (bug 1316749) for flake8 lint error. r=backout
Sebastian Hengst <archaeopteryx@coole-files.de> - Fri, 06 Jan 2017 22:04:15 +0100 - rev 457334
Push 40734 by ydelendik@mozilla.com at Sat, 07 Jan 2017 16:43:50 +0000
Backed out changeset 1f38938f4e9b (bug 1316749) for flake8 lint error. r=backout
8f982926c7e5e7285c95fcade680fdfc9b458d42: Bug 1329013 - Enable no-lone-blocks rule for eslint and remove the seven unnecessary blocks that it found. r=mossop
Jared Wein <jwein@mozilla.com> - Thu, 05 Jan 2017 13:30:25 -0500 - rev 457333
Push 40734 by ydelendik@mozilla.com at Sat, 07 Jan 2017 16:43:50 +0000
Bug 1329013 - Enable no-lone-blocks rule for eslint and remove the seven unnecessary blocks that it found. r=mossop MozReview-Commit-ID: 9DJGO4en378
9eb227438c64a8e2f1c8e010c924f1c11e470527: Bug 1329012 - Enable the no-useless-call rule for eslint and fix the nine errors that it caught. r=mossop
Jared Wein <jwein@mozilla.com> - Thu, 05 Jan 2017 12:56:53 -0500 - rev 457332
Push 40734 by ydelendik@mozilla.com at Sat, 07 Jan 2017 16:43:50 +0000
Bug 1329012 - Enable the no-useless-call rule for eslint and fix the nine errors that it caught. r=mossop MozReview-Commit-ID: 57vvfJlyvfW
272ffe5b217ee34ecfc54ac09e471c53b845ee54: Bug 1329047 - Make sure arm-sim jobs are assigned the correct platform r=dustin
Wes Kocher <wkocher@mozilla.com> - Thu, 05 Jan 2017 16:42:26 -0800 - rev 457331
Push 40734 by ydelendik@mozilla.com at Sat, 07 Jan 2017 16:43:50 +0000
Bug 1329047 - Make sure arm-sim jobs are assigned the correct platform r=dustin MozReview-Commit-ID: KmREmRtFHDQ
1f38938f4e9bf10b08fab35c05eb16c5ec3349a6: Bug 1316749: use taskcluster-proxy to hit index for docker image optimization; r=jonasfj
Dustin J. Mitchell <dustin@mozilla.com> - Sat, 31 Dec 2016 09:40:50 -0500 - rev 457330
Push 40734 by ydelendik@mozilla.com at Sat, 07 Jan 2017 16:43:50 +0000
Bug 1316749: use taskcluster-proxy to hit index for docker image optimization; r=jonasfj MozReview-Commit-ID: 9AL7HhBdjE1
6e3472323a0cdb10f0371bfd8181420712633ccf: Bug 1328553 - Part 2: Add a netmonitor.requestsFinished timing to DAMP tests r=jryans
Jarda Snajdr <jsnajdr@gmail.com> - Wed, 04 Jan 2017 11:15:12 +0100 - rev 457329
Push 40734 by ydelendik@mozilla.com at Sat, 07 Jan 2017 16:43:50 +0000
Bug 1328553 - Part 2: Add a netmonitor.requestsFinished timing to DAMP tests r=jryans MozReview-Commit-ID: 1v7yIUfEwan
d68deea3f449808972de989c84dcda590231b253: Bug 1328553 - Part 1: Add a method to NetmonitorController that waits for requests to finish r=jryans
Jarda Snajdr <jsnajdr@gmail.com> - Wed, 04 Jan 2017 11:14:22 +0100 - rev 457328
Push 40734 by ydelendik@mozilla.com at Sat, 07 Jan 2017 16:43:50 +0000
Bug 1328553 - Part 1: Add a method to NetmonitorController that waits for requests to finish r=jryans MozReview-Commit-ID: IP18VjUaYCk
73f5e38d40a2e1c89481a40996ead654881e20c1: Bug 1326534 - Rename sessionCapabilities variable for brevity; r=whimboo
Andreas Tolfsen <ato@mozilla.com> - Sat, 31 Dec 2016 12:32:14 +0000 - rev 457327
Push 40734 by ydelendik@mozilla.com at Sat, 07 Jan 2017 16:43:50 +0000
Bug 1326534 - Rename sessionCapabilities variable for brevity; r=whimboo MozReview-Commit-ID: KGYk2CgwERy
d960a2d9e2084797cd57697b13e9c059610d6b38: Bug 1326534 - Use session.Capabilities representation in listener; r=automatedtester
Andreas Tolfsen <ato@mozilla.com> - Sat, 31 Dec 2016 12:30:49 +0000 - rev 457326
Push 40734 by ydelendik@mozilla.com at Sat, 07 Jan 2017 16:43:50 +0000
Bug 1326534 - Use session.Capabilities representation in listener; r=automatedtester Capabilities are sent to the content frame script as a JSON blob. We can re-parse that in the listener to make use of the same complex object representation there. Because the listener is comprised of a set of top-level functions and not an object prototype, we cannot reuse the same pointer/getter trick as in testing/marionette/driver.js. However, we can change this later when we do introduce more robust code organisation to this file. MozReview-Commit-ID: 7PpholLqtF
e28fc7e5b9844cba2d0ae81d3ac2afb290de3b18: Bug 1326534 - Reset session capabilities state on teardown; r=whimboo
Andreas Tolfsen <ato@mozilla.com> - Sat, 31 Dec 2016 12:28:19 +0000 - rev 457325
Push 40734 by ydelendik@mozilla.com at Sat, 07 Jan 2017 16:43:50 +0000
Bug 1326534 - Reset session capabilities state on teardown; r=whimboo This change resets the session ID after all other state has been cleared, and also reinitialises `GeckoDriver#sessionCapabilities`, which was not done before. MozReview-Commit-ID: Jb40CXuX8h1
638234f7abd95a1fa1b127776fd78a6d6953eec5: Bug 1326534 - Deploy WebDriver conforming capabilities in Marionette; r=automatedtester,maja_zf,whimboo
Andreas Tolfsen <ato@mozilla.com> - Sat, 31 Dec 2016 12:27:13 +0000 - rev 457324
Push 40734 by ydelendik@mozilla.com at Sat, 07 Jan 2017 16:43:50 +0000
Bug 1326534 - Deploy WebDriver conforming capabilities in Marionette; r=automatedtester,maja_zf,whimboo This change removes session capability processing from testing/marionette/driver.js and replaces it with testing/marionette/session.js and `session.Capabilities`. Session timeout durations used to be stored in properties exposed directly on the `GeckoDriver` prototype, but these are now represented by `GeckoDriver#timeouts`, which is a pointer (getter) of `GeckoDriver#sessionCapabilities#timeouts`. The same is true for other session-scoped state. Since capabilities parsing is not unique to starting a new session, the errors thrown by `session.Capabilities.fromJSON` are re-thrown in `GeckoDriver#newSession` since it is required that we return a `SessionNotCreatedError` on parsing them during session creation. MozReview-Commit-ID: I3Xu2v71n4S
252175a9c2a61399718b7ae091d74489507c5ba4: Bug 1326534 - Rewrite capabilities parsing in Marionette; r=automatedtester
Andreas Tolfsen <ato@mozilla.com> - Sat, 31 Dec 2016 12:21:34 +0000 - rev 457323
Push 40734 by ydelendik@mozilla.com at Sat, 07 Jan 2017 16:43:50 +0000
Bug 1326534 - Rewrite capabilities parsing in Marionette; r=automatedtester This patch provides a (nearly) WebDriver conforming implementation of capabilities in Marionette. The work remaining is pending further clarification in the specification. Capabilities are represented internally as a complex object provided by `session.Capabilities`. Timeouts and proxy configuration are also represented by the similar complex objects `session.Timeouts` and `session.Proxy`, respectively. The capabilities stored in `GeckoDriver#sessionCapabilities` are the result of parsing user-provided desired- and required capabilities. WebDriver now uses `firstMatch` and `alwaysMatch` primitives for capabilities, but as this is considered a wider breaking change, the move to these primitives will be done at a later stage. It’s prudent to point out that the base techniques used with the new primitives are similar to those implemented for `desiredCapabilities` and `requiredCapabilities` in this patch, and that the work needed to adapt them is considered trivial. When capabilities are presented back to the user (the so called processed capabilities), we call the `toJSON` implementation on the complex objects. `session.Capabilities#toJSON` calls the internal function `marshal` which ensures empty fields are dropped. `marshal` can be considered to be a specialisation of the standard library `JSON.stringify`, which also calls `toJSON` on entry values if they provide this function. The changeset overall also provides a much deeper level of testing of WebDriver capabilities. MozReview-Commit-ID: 97xGt3cnMys
602a6650ba466bac7517415ab7ac475bd2a12631: Bug 1326534 - Correct capability wrapping in tests; r=automatedtester
Andreas Tolfsen <ato@mozilla.com> - Fri, 30 Dec 2016 14:12:53 +0000 - rev 457322
Push 40734 by ydelendik@mozilla.com at Sat, 07 Jan 2017 16:43:50 +0000
Bug 1326534 - Correct capability wrapping in tests; r=automatedtester Capabilities should be sent in either a `desiredCapabilities` or a `requiredCapabilities` block inside `capabilities`: {capabilities: {requiredCapabilities: {acceptInsecureCerts: true}}} Marionette currently accepts capabilities in the top-level dictionary, but this is not conforming to the WebDriver. MozReview-Commit-ID: 9JWjvPKBp6S
cc4431a2998ab010e0cc15570a3e49cdfab1b5fd: Bug 1326534 - Propagate stacktraces for WebDriver errors; r=automatedtester
Andreas Tolfsen <ato@mozilla.com> - Fri, 30 Dec 2016 13:07:54 +0000 - rev 457321
Push 40734 by ydelendik@mozilla.com at Sat, 07 Jan 2017 16:43:50 +0000
Bug 1326534 - Propagate stacktraces for WebDriver errors; r=automatedtester When we currently create new WebDriver errors we throw away the stacktrace generated by `WebDriverError`'s prototype, `Error`. This change stores the stacktrace, which will cause it to be serialised and returned to the client. This change is not as valuable as storing the stacktraces of internal errors, but brings symmetry to our error handling and may be useful if only to navigate to the source of an error. MozReview-Commit-ID: LCFMwKxxcTp
29d37d4274e76872ef6c378cd62cc1e25d20f4d4: Bug 1326534 - Lint a few statements in driver.js; r=automatedtester
Andreas Tolfsen <ato@mozilla.com> - Fri, 30 Dec 2016 12:43:36 +0000 - rev 457320
Push 40734 by ydelendik@mozilla.com at Sat, 07 Jan 2017 16:43:50 +0000
Bug 1326534 - Lint a few statements in driver.js; r=automatedtester No functional changes. MozReview-Commit-ID: FP9p9tPr8Ce
3c65e5b16928497942e641402dbf8e54095870dd: Bug 1326534 - Add assert.in for own properties; r=automatedtester
Andreas Tolfsen <ato@mozilla.com> - Fri, 30 Dec 2016 11:39:22 +0000 - rev 457319
Push 40734 by ydelendik@mozilla.com at Sat, 07 Jan 2017 16:43:50 +0000
Bug 1326534 - Add assert.in for own properties; r=automatedtester The implementation of the new library function `assert.in` is analogous to Python's `unittest.TestCase.assertIn`. MozReview-Commit-ID: 1pjS9ttPXgo
0ea5e8c0beefddbe259351cd2e68cbf39b988f96: Bug 1326534 - Add test for assert.array; r=automatedtester
Andreas Tolfsen <ato@mozilla.com> - Fri, 30 Dec 2016 11:30:05 +0000 - rev 457318
Push 40734 by ydelendik@mozilla.com at Sat, 07 Jan 2017 16:43:50 +0000
Bug 1326534 - Add test for assert.array; r=automatedtester MozReview-Commit-ID: IWUnhCgPp1R
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip