15663d3f8728823e6e48eca1d785b84d1de1edcd: Backed out changeset c2bdce9b76f2 (bug 1411458) for Mac Windows and Android build bustage
Phil Ringnalda <philringnalda@gmail.com> - Wed, 25 Oct 2017 19:22:36 -0700 - rev 686628
Push 86226 by maglione.k@gmail.com at Thu, 26 Oct 2017 03:22:13 +0000
Backed out changeset c2bdce9b76f2 (bug 1411458) for Mac Windows and Android build bustage MozReview-Commit-ID: 20DOPFcmRFH
1bfaea0c03ec2b00ece8f769720ff816d6832ca9: Backed out changeset 2c36f41ed77c (bug 1410123) for causing frequent Windows mochitest-gl leaks.
Ryan VanderMeulen <ryanvm@gmail.com> - Wed, 25 Oct 2017 22:10:11 -0400 - rev 686627
Push 86226 by maglione.k@gmail.com at Thu, 26 Oct 2017 03:22:13 +0000
Backed out changeset 2c36f41ed77c (bug 1410123) for causing frequent Windows mochitest-gl leaks.
0f266ffacf0d46f9f82198a23eae3eca7177cf4d: Bug 1411480 - Make CallbackNode::mDomain const. r=glandium.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 26 Oct 2017 12:29:41 +1100 - rev 686626
Push 86226 by maglione.k@gmail.com at Thu, 26 Oct 2017 03:22:13 +0000
Bug 1411480 - Make CallbackNode::mDomain const. r=glandium. MozReview-Commit-ID: EvLC5FrMyKy
75212b4a8c0a73bf2d49bc78af6dda9c12f29c8e: Bug 1411480 - Make PrefValue::mStringVal const. r=glandium.
Nicholas Nethercote <nnethercote@mozilla.com> - Thu, 26 Oct 2017 12:29:34 +1100 - rev 686625
Push 86226 by maglione.k@gmail.com at Thu, 26 Oct 2017 03:22:13 +0000
Bug 1411480 - Make PrefValue::mStringVal const. r=glandium. This makes it clear that the stored string values are never modified. It requires some const_casts to free the strings, but that feels like an ok trade-off. MozReview-Commit-ID: JikBT3uwpfq
0c807a8e8b295e655cc27bc58373dd49c3662b17: Bug 1411480 - Change PrefSaveData's element type. r=glandium.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 25 Oct 2017 10:22:39 +1100 - rev 686624
Push 86226 by maglione.k@gmail.com at Thu, 26 Oct 2017 03:22:13 +0000
Bug 1411480 - Change PrefSaveData's element type. r=glandium. Because nsCString is nicer than UniqueFreePtr<char>. The patch also streamlines pref_savePrefs(). And also changes StrEscape() to always put quotations around the result, because that's needed in both call sites. MozReview-Commit-ID: HT7HZz4QiSN
21324f73db0c6ef7b4c484208e8d6fbd73fbc816: Bug 1411480 - Use |private| instead of |protected| in nsPrefBranch. r=glandium.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 25 Oct 2017 10:22:39 +1100 - rev 686623
Push 86226 by maglione.k@gmail.com at Thu, 26 Oct 2017 03:22:13 +0000
Bug 1411480 - Use |private| instead of |protected| in nsPrefBranch. r=glandium. There's not much use using |protected| in a |final| class. MozReview-Commit-ID: IECyfNGZsL5
f7de6fa0ef2c5593f83a9e9968da0aee3a8b9934: Bug 1411480 - Remove pref_savePrefs()'s argument. r=glandium.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 25 Oct 2017 10:22:39 +1100 - rev 686622
Push 86226 by maglione.k@gmail.com at Thu, 26 Oct 2017 03:22:13 +0000
Bug 1411480 - Remove pref_savePrefs()'s argument. r=glandium. It's always gHashTable, and all the other functions in this file work directly on gHashTable rather than taking a parameter. MozReview-Commit-ID: BDCEvcMlo8P
b7cdbe5153fa2a796a660c8a57f9410ea55e1722: Bug 1411480 - Simplify pref_HashPref()'s workings. r=glandium.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 25 Oct 2017 10:22:39 +1100 - rev 686621
Push 86226 by maglione.k@gmail.com at Thu, 26 Oct 2017 03:22:13 +0000
Bug 1411480 - Simplify pref_HashPref()'s workings. r=glandium. First, the patch removes the return values from PrefTypeFlags::Set*(). They allow chained calls, but they're barely used and they just make the code harder to read. Second, the patch changes pref_SetValue() to not modify and return the pref flags. It's clearer if the flags changing is done separately. This requires passing pref_SetValue() the old type instead of the flags. MozReview-Commit-ID: HZVS2TIlBIY
8a66ec3e83386cacc89bed3356ff0e24fefeafea: Bug 1411480 - Remove the machinery for choosing the dirty callback. r=glandium.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 25 Oct 2017 10:22:38 +1100 - rev 686620
Push 86226 by maglione.k@gmail.com at Thu, 26 Oct 2017 03:22:13 +0000
Bug 1411480 - Remove the machinery for choosing the dirty callback. r=glandium. It's unnecessarily general, because we only ever use Preferences::DirtyCallback() as the callback. And because it's no longer a callback, the patch renames DirtyCallback() as HandleDirty(). MozReview-Commit-ID: Hl50dcxfVQq
3fdf2ac7762d9656bad80e593d8b3389038109a9: Bug 1411480 - Inline and remove PREF_GetPrefType(). r=glandium.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 25 Oct 2017 10:22:38 +1100 - rev 686619
Push 86226 by maglione.k@gmail.com at Thu, 26 Oct 2017 03:22:13 +0000
Bug 1411480 - Inline and remove PREF_GetPrefType(). r=glandium. It has a single call site. MozReview-Commit-ID: o5CwR8Od7o
eaa177ef5f60991f3a2ed06b50c49d3d67ea516b: Bug 1411480 - Inline and remove pref_[SG]etInitPhase(). r=glandium.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 25 Oct 2017 10:22:38 +1100 - rev 686618
Push 86226 by maglione.k@gmail.com at Thu, 26 Oct 2017 03:22:13 +0000
Bug 1411480 - Inline and remove pref_[SG]etInitPhase(). r=glandium. They both have a single use. MozReview-Commit-ID: 4Jj64B6NV0o
e87ba9542cf8bac95d16545dfd129f5a39d56a22: Bug 1411480 - Inline and remove pref_SetWatchingPref(). r=glandium.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 25 Oct 2017 10:22:38 +1100 - rev 686617
Push 86226 by maglione.k@gmail.com at Thu, 26 Oct 2017 03:22:13 +0000
Bug 1411480 - Inline and remove pref_SetWatchingPref(). r=glandium. It's simple enough that having a separate function isn't helpful. MozReview-Commit-ID: Ke9BIfp9yHU
f1cf84a50ebc368ad4e2088957cbda008a74520d: Bug 1411480 - Inline and remove the parser's pref_DoCallback() function. r=glandium.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 25 Oct 2017 10:22:38 +1100 - rev 686616
Push 86226 by maglione.k@gmail.com at Thu, 26 Oct 2017 03:22:13 +0000
Bug 1411480 - Inline and remove the parser's pref_DoCallback() function. r=glandium. Preferences.cpp has two functions named pref_DoCallback(). One of them has a single use in the parser. This patch inlines that single use to remove the name duplication. MozReview-Commit-ID: HnyteQ0N5M1
c2bdce9b76f2135fd100f073b6ccaf8bb9a69fed: Bug 1411458 - Confirm we actually have a PKCS#7 signedData content info. r=jcj
David Keeler <dkeeler@mozilla.com> - Wed, 25 Oct 2017 09:54:13 -0700 - rev 686615
Push 86226 by maglione.k@gmail.com at Thu, 26 Oct 2017 03:22:13 +0000
Bug 1411458 - Confirm we actually have a PKCS#7 signedData content info. r=jcj MozReview-Commit-ID: GKfL1C0EPWt
c2cecb6d6f9bb85f258a66cf8e94c1860adde7e5: Bug 1406398 - Avoid rooting the object twice in EnumerableOwnProperties. r=jandem
André Bargull <andre.bargull@gmail.com> - Thu, 12 Oct 2017 09:20:07 -0700 - rev 686614
Push 86226 by maglione.k@gmail.com at Thu, 26 Oct 2017 03:22:13 +0000
Bug 1406398 - Avoid rooting the object twice in EnumerableOwnProperties. r=jandem
a3785ec9a48c8c76dd98b5c5140283f8ac44c851: Bug 1410276 - Add a canary field to nsStringBuffer. r=bz
Paul Bone <pbone@mozilla.com> - Wed, 25 Oct 2017 23:21:47 +1100 - rev 686613
Push 86226 by maglione.k@gmail.com at Thu, 26 Oct 2017 03:22:13 +0000
Bug 1410276 - Add a canary field to nsStringBuffer. r=bz
d376cac28778edfaf3ba95f12bda3df7a9cecefe: Bug 818634 - Remove support for Date.prototype.toLocaleFormat. r=gandalf, r=anba
Rofael Aleezada <me@rofael.com> - Wed, 18 Oct 2017 21:51:32 -0500 - rev 686612
Push 86226 by maglione.k@gmail.com at Thu, 26 Oct 2017 03:22:13 +0000
Bug 818634 - Remove support for Date.prototype.toLocaleFormat. r=gandalf, r=anba
186606ff9e5e6d6da877d488109e5d9f2acd3e95: Bug 1248222 - Add crashtest. r=me
Jesse Ruderman <jruderman@gmail.com> - Wed, 25 Oct 2017 21:03:17 -0400 - rev 686611
Push 86226 by maglione.k@gmail.com at Thu, 26 Oct 2017 03:22:13 +0000
Bug 1248222 - Add crashtest. r=me
06b41b154ad7038d5ce69ed464037e730034016c: Bug 1242822 - Add crashtest. r=me
Jesse Ruderman <jruderman@gmail.com> - Wed, 25 Oct 2017 21:03:17 -0400 - rev 686610
Push 86226 by maglione.k@gmail.com at Thu, 26 Oct 2017 03:22:13 +0000
Bug 1242822 - Add crashtest. r=me
fbad23d9e737b46514687ca09a9c2d433cba6df6: Bug 1242811 - Add crashtest. r=me
Jesse Ruderman <jruderman@gmail.com> - Wed, 25 Oct 2017 21:03:16 -0400 - rev 686609
Push 86226 by maglione.k@gmail.com at Thu, 26 Oct 2017 03:22:13 +0000
Bug 1242811 - Add crashtest. r=me
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip