15567714f6fade0200fb4f4d79e246979dc9d27b: Bug 1373525 - layout: Remove unused classes nsAutoScannerChanger and nsAutoCSSParserInputStateRestorer. r=dholbert draft
Chris Peterson <cpeterson@mozilla.com> - Wed, 07 Jun 2017 00:03:03 -0700 - rev 596120
Push 64519 by cpeterson@mozilla.com at Sun, 18 Jun 2017 06:41:45 +0000
Bug 1373525 - layout: Remove unused classes nsAutoScannerChanger and nsAutoCSSParserInputStateRestorer. r=dholbert layout/style/nsCSSParser.cpp:524:12 [-Wunused-member-function] unused member function 'DoNotRestore' layout/style/nsCSSParser.cpp:563:7 [-Wunused-member-function] unused member function 'nsAutoScannerChanger' layout/style/nsCSSParser.cpp:587:7 [-Wunused-member-function] unused member function '~nsAutoScannerChanger' layout/style/nsCSSParser.cpp:1236:8 [-Wunused-member-function] unused member function 'ParseSingleTokenVariantWithRestrictions' MozReview-Commit-ID: JRTBxrNcZzT
bb6926b14dcbd32b0661c4ff17ce5d27eb25d83f: Bug 1373525 - libfuzzer: Remove unused member function ScopedXPCOM::failed(). r=decoder draft
Chris Peterson <cpeterson@mozilla.com> - Tue, 13 Jun 2017 00:42:23 -0700 - rev 596119
Push 64519 by cpeterson@mozilla.com at Sun, 18 Jun 2017 06:41:45 +0000
Bug 1373525 - libfuzzer: Remove unused member function ScopedXPCOM::failed(). r=decoder tools/fuzzing/libfuzzer/harness/LibFuzzerTestHarness.h:118:10: warning: unused member function 'failed' [-Wunused-member-function] MozReview-Commit-ID: 7hsvvnnolcl
72ab8f2f0d3c62f9565f4156a5412fd0d951e3b5: Bug 1373525 - lul: Remove unused member functions in FDWrapper and MmapWrapper. r=jseward draft
Chris Peterson <cpeterson@mozilla.com> - Tue, 13 Jun 2017 00:46:55 -0700 - rev 596118
Push 64519 by cpeterson@mozilla.com at Sun, 18 Jun 2017 06:41:45 +0000
Bug 1373525 - lul: Remove unused member functions in FDWrapper and MmapWrapper. r=jseward tools/profiler/lul/LulElf.cpp:105:7: warning: unused member function 'get' [-Wunused-member-function] tools/profiler/lul/LulElf.cpp:108:7: warning: unused member function 'release' [-Wunused-member-function] tools/profiler/lul/LulElf.cpp:136:8: warning: unused member function 'release' [-Wunused-member-function] MozReview-Commit-ID: L16RVC1QDrk
52a0f0041276a36e297fca0874b76f08284d322f: Bug 1373525 - media/mtransport: Remove unused member functions and unused member variable trickled_. r?drno draft
Chris Peterson <cpeterson@mozilla.com> - Sun, 11 Jun 2017 00:09:42 -0700 - rev 596117
Push 64519 by cpeterson@mozilla.com at Sun, 18 Jun 2017 06:41:45 +0000
Bug 1373525 - media/mtransport: Remove unused member functions and unused member variable trickled_. r?drno media/mtransport/test/ice_unittest.cpp:349:24 [-Wunused-member-function] unused member function 'Candidate' media/mtransport/test/ice_unittest.cpp:353:12 [-Wunused-member-function] unused member function 'Stream' media/mtransport/test/ice_unittest.cpp:1131:8 [-Wunused-member-function] unused member function 'DumpCandidatePairs_s' media/mtransport/test/ice_unittest.cpp:1394:7 [-Wunused-member-function] unused member function 'trickled' media/mtransport/test/ice_unittest.cpp:1867:8 [-Wunused-member-function] unused member function 'SetExpectedTypes' media/mtransport/test/transport_unittests.cpp:917:8 [-Wunused-member-function] unused member function 'InitIce' MozReview-Commit-ID: 70PNtdc92mg
4cdb0ca771d47a149fa6f56717a6786c6db1e9fb: Bug 1373525 - mfbt: Use unused GetPrev() member function in DoublyLinkedList test. r=froydnj draft
Chris Peterson <cpeterson@mozilla.com> - Sun, 11 Jun 2017 14:39:42 -0700 - rev 596116
Push 64519 by cpeterson@mozilla.com at Sun, 18 Jun 2017 06:41:45 +0000
Bug 1373525 - mfbt: Use unused GetPrev() member function in DoublyLinkedList test. r=froydnj mfbt/tests/TestDoublyLinkedList.cpp:138:24 [-Wunused-member-function] unused member function 'GetPrev' MozReview-Commit-ID: HQuTw0vXRKV
7294a31687cb06b005213205772f778eb8c3176b: Bug 1373525 - sandbox: Suppress -Wunused-member-function warnings in third-party chromium/base code. r?gcp draft
Chris Peterson <cpeterson@mozilla.com> - Tue, 13 Jun 2017 00:50:03 -0700 - rev 596115
Push 64519 by cpeterson@mozilla.com at Sun, 18 Jun 2017 06:41:45 +0000
Bug 1373525 - sandbox: Suppress -Wunused-member-function warnings in third-party chromium/base code. r?gcp security/sandbox/chromium/base/strings/string_util.cc:83:28: warning: unused member function 'value' [-Wunused-member-function] security/sandbox/chromium/base/strings/string_util.cc:86:28: warning: unused member function 'value' [-Wunused-member-function] security/sandbox/chromium/base/strings/string_util.cc:96:28: warning: unused member function 'value' [-Wunused-member-function] MozReview-Commit-ID: 4kthSl21sN5
193e4bb0826d8a7685b8bc94fa247d11859f5dcb: Bug 1373525 - testing/gtest: Suppress -Wunused-member-function warnings in third-party code. r=ted draft
Chris Peterson <cpeterson@mozilla.com> - Sun, 11 Jun 2017 00:33:36 -0700 - rev 596114
Push 64519 by cpeterson@mozilla.com at Sun, 18 Jun 2017 06:41:45 +0000
Bug 1373525 - testing/gtest: Suppress -Wunused-member-function warnings in third-party code. r=ted testing/gtest/gtest/src/gtest.cc:2598:12 [-Wunused-member-function] unused member function 'TestNameIs' testing/gtest/gtest/src/gtest.cc:2602:8 [-Wunused-member-function] unused member function 'operator()' MozReview-Commit-ID: 9XTVwEZ3vPL
659536224f2d70dfdfbc49577f380de8bfa1a31e: Bug 1373525 - toolkit/osfile: Remove unused constructor of ScopedArrayBufferContents. r=dteller draft
Chris Peterson <cpeterson@mozilla.com> - Sat, 10 Jun 2017 16:40:56 -0700 - rev 596113
Push 64519 by cpeterson@mozilla.com at Sun, 18 Jun 2017 06:41:45 +0000
Bug 1373525 - toolkit/osfile: Remove unused constructor of ScopedArrayBufferContents. r=dteller toolkit/components/osfile/NativeOSFileInternals.cpp:98:12 [-Wunused-member-function] unused member function 'ScopedArrayBufferContents' MozReview-Commit-ID: 7OQH2RyX6xa
0ced0f1ecf1f9c62418c483945a925d4ea235e9b: Bug 1373525 - toolkit/protobuf: Suppress warnings in third-party code. r=Mossop draft
Chris Peterson <cpeterson@mozilla.com> - Mon, 12 Jun 2017 22:18:42 -0700 - rev 596112
Push 64519 by cpeterson@mozilla.com at Sun, 18 Jun 2017 06:41:45 +0000
Bug 1373525 - toolkit/protobuf: Suppress warnings in third-party code. r=Mossop toolkit/components/protobuf/src/google/protobuf/descriptor.cc:193:15 [-Wunused-member-function] unused member function 'operator()' toolkit/components/protobuf/src/google/protobuf/descriptor.cc:222:10 [-Wunused-member-function] unused member function 'operator()' toolkit/components/protobuf/src/google/protobuf/stubs/map_util.h:356:43 [-Wunused-local-typedef] unused typedef 'value_type' toolkit/components/protobuf/src/google/protobuf/stubs/map_util.h:367:43 [-Wunused-local-typedef] unused typedef 'value_type' toolkit/components/protobuf/src/google/protobuf/stubs/strutil.cc:313:8 [-Wcomma] possible misuse of comma operator here toolkit/components/protobuf/src/google/protobuf/wire_format.cc:60:12 [-Wunused-function] unused function 'GetEnumNumber' MozReview-Commit-ID: GFXHI2LveE3
61200f6aa81bf3f96c14ab0cf902f73d36896052: Bug 1373525 - webrtc: Remove unused member function in WrappableJSErrorResult. r=bwc draft
Chris Peterson <cpeterson@mozilla.com> - Mon, 12 Jun 2017 21:43:29 -0700 - rev 596111
Push 64519 by cpeterson@mozilla.com at Sun, 18 Jun 2017 06:41:45 +0000
Bug 1373525 - webrtc: Remove unused member function in WrappableJSErrorResult. r=bwc media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:181:3 [-Wunused-member-function] unused member function 'operator (anonymous namespace)::JSErrorResult &' And suppress -Wcomma and -Wunused-member-function warnings in upstream webrtc code: media/webrtc/trunk/webrtc/modules/audio_coding/neteq/background_noise.h:98:22: warning: possible misuse of comma operator here [-Wcomma] media/webrtc/trunk/webrtc/modules/desktop_capture/differ_unittest.cc:187:22: warning: possible misuse of comma operator here [-Wcomma] media/webrtc/trunk/webrtc/voice_engine/voe_codec_unittest.cc:26:3: warning: unused member function 'VoECodecTest' [-Wunused-member-function] media/webrtc/trunk/webrtc/audio/audio_receive_stream_unittest.cc:120:20: warning: unused member function 'voice_engine' [-Wunused-member-function] media/webrtc/trunk/webrtc/modules/audio_processing/utility/delay_estimator_unittest.cc:126:26: warning: unused member function 'InitBinary' [-Wunused-member-function] media/webrtc/trunk/webrtc/system_wrappers/source/scoped_vector_unittest.cc:265:8: warning: unused member function 'VoidMethod0' [-Wunused-member-function] media/webrtc/trunk/webrtc/system_wrappers/source/stl_util_unittest.cc:26:8: warning: unused member function 'operator==' [-Wunused-member-function] MozReview-Commit-ID: FVecnczsWk7
a0e22c4e8ff1bf907de1d3ebcdd606d41c8ffca7: Bug 1373232 - Use floating point division when dividing nscoord values with a twipsPerPixel factor. r?mats draft
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Sun, 18 Jun 2017 09:33:25 +0300 - rev 596110
Push 64518 by bmo:bpostelnicu@mozilla.com at Sun, 18 Jun 2017 06:34:15 +0000
Bug 1373232 - Use floating point division when dividing nscoord values with a twipsPerPixel factor. r?mats MozReview-Commit-ID: JR3EDkDuwVA
1df177ea09f290cb35b67bcf192169ca06e20852: Bug 1373525 - build: Enable clang's -Wunused-member-function warnings. r?glandium draft
Chris Peterson <cpeterson@mozilla.com> - Sun, 11 Jun 2017 00:20:41 -0700 - rev 596109
Push 64517 by cpeterson@mozilla.com at Sun, 18 Jun 2017 06:22:14 +0000
Bug 1373525 - build: Enable clang's -Wunused-member-function warnings. r?glandium But ignore clang's -Wunneeded-member-function warnings because they report some false positives for `= default` constructors and destructors. MozReview-Commit-ID: EP1D3LYEDgK
9137cf2061e6b323baf9fb26118e388fe68eddef: Bug 1373525 - a11y: Remove unused member function Revoke() in Accessible::DoCommand Runnable. r?tbsaunde draft
Chris Peterson <cpeterson@mozilla.com> - Wed, 07 Jun 2017 00:19:47 -0700 - rev 596108
Push 64517 by cpeterson@mozilla.com at Sun, 18 Jun 2017 06:22:14 +0000
Bug 1373525 - a11y: Remove unused member function Revoke() in Accessible::DoCommand Runnable. r?tbsaunde accessible/generic/Accessible.cpp:1813:10 [-Wunused-member-function] unused member function 'Revoke' MozReview-Commit-ID: J5oyZt2rjkh
26eaf68a720d9717d53cb6c3c41b419a96252000: Bug 1373525 - dom: Remove some unused member functions. r?billm draft
Chris Peterson <cpeterson@mozilla.com> - Sun, 11 Jun 2017 15:34:21 -0700 - rev 596107
Push 64517 by cpeterson@mozilla.com at Sun, 18 Jun 2017 06:22:14 +0000
Bug 1373525 - dom: Remove some unused member functions. r?billm dom/asmjscache/AsmJSCache.cpp:371:3 [-Wunused-member-function] unused member function 'IsOnOwningThread' dom/cache/DBSchema.cpp:303:3 [-Wunused-member-function] unused member function 'IdCount' dom/filesystem/GetFilesHelper.cpp:26:3 [-Wunused-member-function] unused member function 'ReleaseRunnable' dom/webbrowserpersist/WebBrowserPersistLocalDocument.cpp:298:10 [-Wunused-member-function] unused member function 'IsFlagSet' MozReview-Commit-ID: 2A11iqF7u9X
725ceb02de3a87a17ac1a05fcb5da5466bd814fb: Bug 1373525 - dom/html: Remove unused member function Revoke() of HTMLCanvasElement Runnables. r?baku draft
Chris Peterson <cpeterson@mozilla.com> - Thu, 15 Jun 2017 00:56:18 -0700 - rev 596106
Push 64517 by cpeterson@mozilla.com at Sun, 18 Jun 2017 06:22:14 +0000
Bug 1373525 - dom/html: Remove unused member function Revoke() of HTMLCanvasElement Runnables. r?baku dom/html/HTMLCanvasElement.cpp:1369:12 [-Wunused-member-function] unused member function 'Revoke' dom/html/HTMLCanvasElement.cpp:1411:12 [-Wunused-member-function] unused member function 'Revoke' MozReview-Commit-ID: 1fmfUIO8VR6
4046c165e9b811a1a3e95444d20f979dab63bcd9: Bug 1373525 - dom/indexedDB: Remove unused classes and member functions. r?bevis draft
Chris Peterson <cpeterson@mozilla.com> - Thu, 15 Jun 2017 00:59:17 -0700 - rev 596105
Push 64517 by cpeterson@mozilla.com at Sun, 18 Jun 2017 06:22:14 +0000
Bug 1373525 - dom/indexedDB: Remove unused classes and member functions. r?bevis The UpgradeSchemaFrom17_0To18_0Helper class is never instantiated, so its constructor and destructor don't need to be define. dom/base/nsContentUtils.cpp:529:21 [-Wunused-member-function] unused member function 'GetResult' dom/indexedDB/ActorsParent.cpp:2715:3 [-Wunused-member-function] unused member function 'UpgradeSchemaFrom17_0To18_0Helper' dom/indexedDB/ActorsParent.cpp:2720:3 [-Wunused-member-function] unused member function '~UpgradeSchemaFrom17_0To18_0Helper' dom/indexedDB/ActorsParent.cpp:6464:3 [-Wunused-member-function] unused member function 'GetPrincipalInfo' dom/indexedDB/ActorsParent.cpp:6545:3 [-Wunused-member-function] unused member function 'ReleaseTransactionThreadObjects' dom/indexedDB/ActorsParent.cpp:6548:3 [-Wunused-member-function] unused member function 'ReleaseBackgroundThreadObjects' dom/indexedDB/ActorsParent.cpp:7710:3 [-Wunused-member-function] unused member function 'operator<' dom/indexedDB/ActorsParent.cpp:7753:3 [-Wunused-member-function] unused member function 'IsOtherProcessActor' dom/quota/ActorsParent.cpp:809:3 [-Wunused-member-function] unused member function 'GetState' dom/quota/StorageManager.cpp:76:3 [-Wunused-member-function] unused member function 'GetType' MozReview-Commit-ID: FbfMj2YJ4Fx
263f924faca8ba0bc65afeea180fbfd9f0082fb8: Bug 1373525 - dom/plugins: Remove unused member function PluginModuleMapping::IsLoadModuleOnStack(). r?jimm draft
Chris Peterson <cpeterson@mozilla.com> - Thu, 15 Jun 2017 00:49:28 -0700 - rev 596104
Push 64517 by cpeterson@mozilla.com at Sun, 18 Jun 2017 06:22:14 +0000
Bug 1373525 - dom/plugins: Remove unused member function PluginModuleMapping::IsLoadModuleOnStack(). r?jimm The static variable PluginModuleMapping::sIsLoadModuleOnStack is only accessed within the class PluginModuleMapping and the unused getter IsLoadModuleOnStack() can be removed. dom/plugins/ipc/PluginModuleParent.cpp:313:5 [-Wunused-member-function] unused member function 'IsLoadModuleOnStack' MozReview-Commit-ID: 5UCxHZUQCNQ
0cd2baf9d289e06db52f298230709bc8294dfa32: Bug 1373525 - dom/workers: Remove unused classes and member functions. r?baku draft
Chris Peterson <cpeterson@mozilla.com> - Thu, 15 Jun 2017 00:40:59 -0700 - rev 596103
Push 64517 by cpeterson@mozilla.com at Sun, 18 Jun 2017 06:22:14 +0000
Bug 1373525 - dom/workers: Remove unused classes and member functions. r?baku dom/workers/ScriptLoader.cpp:246:3 [-Wunused-member-function] unused member function 'ReadyToExecute' dom/workers/ServiceWorkerScriptCache.cpp:200:19 [-Wunused-member-function] unused member function 'URL' dom/workers/WorkerPrivate.cpp:1553:3 [-Wunused-member-function] unused member function 'DummyRunnable' MozReview-Commit-ID: DLjD10iZJJV
ef4812ee944168642b1535c18ae958778b085c43: Bug 1373525 - gfx/angle: Suppress warnings in third-party code. r?jgilbert draft
Chris Peterson <cpeterson@mozilla.com> - Wed, 07 Jun 2017 00:52:43 -0700 - rev 596102
Push 64517 by cpeterson@mozilla.com at Sun, 18 Jun 2017 06:22:14 +0000
Bug 1373525 - gfx/angle: Suppress warnings in third-party code. r?jgilbert Should I update https://github.com/mozilla/angle/blob/mozilla/generate_mozbuild.py? That script looks like it has fallen behind the changes in gfx/angle/moz.build. gfx/angle/src/common/debug.cpp:47:12 [-Wunused-member-function] unused member function 'length' gfx/angle/src/compiler/translator/ASTMetadataHLSL.cpp:93:15 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/angle/src/compiler/translator/ParseContext.cpp:1123:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/angle/src/compiler/translator/ParseContext.cpp:3640:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/angle/src/compiler/translator/ParseContext.cpp:3808:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/angle/src/compiler/translator/util.cpp:216:15 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/angle/src/compiler/translator/util.cpp:225:15 [-Wimplicit-fallthrough] unannotated fall-through between switch labels gfx/angle/src/compiler/translator/util.cpp:234:15 [-Wimplicit-fallthrough] unannotated fall-through between switch labels MozReview-Commit-ID: EExTKYUzXB
17d436b3405a55584857b8094281f4a390d2f5b4: Bug 1373525 - gfx/layers: Remove unused member functions Revoke() of AsyncCanvasRenderer Runnables. r?bas draft
Chris Peterson <cpeterson@mozilla.com> - Wed, 07 Jun 2017 00:54:35 -0700 - rev 596101
Push 64517 by cpeterson@mozilla.com at Sun, 18 Jun 2017 06:22:14 +0000
Bug 1373525 - gfx/layers: Remove unused member functions Revoke() of AsyncCanvasRenderer Runnables. r?bas gfx/layers/AsyncCanvasRenderer.cpp:62:10 [-Wunused-member-function] unused member function 'Revoke' gfx/layers/AsyncCanvasRenderer.cpp:97:10 [-Wunused-member-function] unused member function 'Revoke' MozReview-Commit-ID: 11CjGtiXIqv
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip