143dcd21c6f0e94eb4c7cb7242061c7ef411b210: Bug 1367576 - Make IsWidgetStateSafe not truncate the bits that it needs to test. r=karlt
L. David Baron <dbaron@dbaron.org> - Tue, 06 Jun 2017 22:27:18 -0700 - rev 590099
Push 62591 by lochang@mozilla.com at Wed, 07 Jun 2017 06:17:02 +0000
Bug 1367576 - Make IsWidgetStateSafe not truncate the bits that it needs to test. r=karlt This fix a mistake that goes back to the original code from bug 174585 (gecko-dev 9611b23530704402a714fa39cb433a01dca0bb6e, 2005-08-20). (This makes me wonder how important the code is in the first place if it didn't work correctly.) MozReview-Commit-ID: B6q0o5n5hDw
33997d929fda5555b857ce1aa0f523c99bfc0434: Bug 1367576 - Shrink existing caches to the size that's actually needed. r=karlt
L. David Baron <dbaron@dbaron.org> - Tue, 06 Jun 2017 22:27:18 -0700 - rev 590098
Push 62591 by lochang@mozilla.com at Wed, 07 Jun 2017 06:17:02 +0000
Bug 1367576 - Shrink existing caches to the size that's actually needed. r=karlt Now that, thanks to bug 1367577, we have the theme constants in an enum, we can make these arrays smaller rather than assuming that the constants might use any valid uint8_t value. MozReview-Commit-ID: A6GjTarVurc
b8e44a1cb4505c51d398db387c4c1d5c8afc462c: Bug 1367576 - Cache results of getting GTK widget borders. r=karlt
L. David Baron <dbaron@dbaron.org> - Tue, 06 Jun 2017 22:27:18 -0700 - rev 590097
Push 62591 by lochang@mozilla.com at Wed, 07 Jun 2017 06:17:02 +0000
Bug 1367576 - Cache results of getting GTK widget borders. r=karlt See comments in the header file. This also clears out mSafeWidgetStates in ThemeChanged since that seems like a good thing to do, and marks nsNativeThemeGTK as final. MozReview-Commit-ID: 5Zne4eGbGlh
db68e1963b3974821cc065440f1b693a82721619: Bug 1367576 - Refactor to allow for caching of some gtk widget padding/border results. r=karlt
L. David Baron <dbaron@dbaron.org> - Tue, 06 Jun 2017 22:27:17 -0700 - rev 590096
Push 62591 by lochang@mozilla.com at Wed, 07 Jun 2017 06:17:02 +0000
Bug 1367576 - Refactor to allow for caching of some gtk widget padding/border results. r=karlt This refactors the two nearly-identical callsites into a method so that I can do caching in that method in the next patch. Note that there was a slight difference between them in that the aWidgetFlags parameter to GetGtkWidgetAndState was only passed from one callsite. However, given that the aState parameter is null, this doesn't cause any behavior differences. (Some controls in GetGtkWidgetAndState null-check aWidgetFlags and some don't!) Note also that this makes it always assign a result (often zero). This is fine for both callsites; GetWidgetPadding previously assigned zero right before the call, and GetWidgetBorder did so at the start of the function (and wasn't modified in between, since it was immediately before the switch that the modified code is a case in). MozReview-Commit-ID: IKurwry3UTi
05cb421de1c392e23da293e03dd2d28a3d65457d: Bug 1367576 - Remove unused ishtml parameter to moz_gtk_get_widget_border. r=karlt
L. David Baron <dbaron@dbaron.org> - Tue, 06 Jun 2017 22:27:17 -0700 - rev 590095
Push 62591 by lochang@mozilla.com at Wed, 07 Jun 2017 06:17:02 +0000
Bug 1367576 - Remove unused ishtml parameter to moz_gtk_get_widget_border. r=karlt This was needed for the (now-unused) GTK2 version of the code. MozReview-Commit-ID: GocgC4OZ76p
3853c5543f6e4e8ef24cc1ac47be5a65e4b672e0: Bug 1369260 - Remove use of MOZ_ASSERT_IF in layout. r=heycam
L. David Baron <dbaron@dbaron.org> - Tue, 06 Jun 2017 22:27:17 -0700 - rev 590094
Push 62591 by lochang@mozilla.com at Wed, 07 Jun 2017 06:17:02 +0000
Bug 1369260 - Remove use of MOZ_ASSERT_IF in layout. r=heycam As I've said before, as module owner I prefer that MOZ_ASSERT_IF not be used in the module because I consider it to be unreadable. However, a few uses have crept in, and this patch removes them. I consider it to be unreadable because the name looks like a name that uses smalltalk-ish naming conventions, i.e., with a part of the name corresponding to each parameter, in order. However, the parameters are in the order opposite the name. This was written primarily with the vim commands: :%s/MOZ_ASSERT_IF(\([^,]*\),/MOZ_ASSERT(!\1 ||/ :wn followed by manual cleanup for indentation and removal of !!. MozReview-Commit-ID: G6rLbOn7k8d
0145ab10f5cc62bdf5cee9453be305809e5f7840: Bug 1368915 (part 5) - Introduce MAX_JS_FRAMES. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 02 Jun 2017 09:41:58 +1000 - rev 590093
Push 62591 by lochang@mozilla.com at Wed, 07 Jun 2017 06:17:02 +0000
Bug 1368915 (part 5) - Introduce MAX_JS_FRAMES. r=mstange.
2f636eeb949d07746a412fbf327ce4e4015f2aad: Bug 1368915 (part 4) - Clean up NativeStack. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 02 Jun 2017 09:41:55 +1000 - rev 590092
Push 62591 by lochang@mozilla.com at Wed, 07 Jun 2017 06:17:02 +0000
Bug 1368915 (part 4) - Clean up NativeStack. r=mstange. This patch puts the arrays inside NativeStack, gives NativeStack a constructor, and renames its fields using "mFoo" form. The patch also moves MAX_NATIVE_FRAMES from the LUL-only code and applies it globally. This increases the max native frame count from 256 to 1024 on the LUL platforms, which makes things consistent with other platforms.
e7d5a07cede0aa1d2de6fdf13b7f522aa4a1cc22: Bug 1368915 (part 3) - Rename aStartTime parameters as aProcessStartTime where appropriate. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 02 Jun 2017 09:41:51 +1000 - rev 590091
Push 62591 by lochang@mozilla.com at Wed, 07 Jun 2017 06:17:02 +0000
Bug 1368915 (part 3) - Rename aStartTime parameters as aProcessStartTime where appropriate. r=mstange. This increases naming consistency. The remaining aStartTime parameters within the profiler refer to a different start time than the process start time.
2019c06e297c20de7afcd05716b6298ee2ea36f2: Bug 1368915 (part 2) - Remove unnecessary mozilla:: qualifiers in plaform.cpp. r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 02 Jun 2017 09:41:48 +1000 - rev 590090
Push 62591 by lochang@mozilla.com at Wed, 07 Jun 2017 06:17:02 +0000
Bug 1368915 (part 2) - Remove unnecessary mozilla:: qualifiers in plaform.cpp. r=mstange.
827b05e1b8f77ff34829b7002a582363b41c9f92: Bug 1368915 (part 1) - Rename a parameter of locked_register_thread(). r=mstange.
Nicholas Nethercote <nnethercote@mozilla.com> - Wed, 31 May 2017 15:14:50 +1000 - rev 590089
Push 62591 by lochang@mozilla.com at Wed, 07 Jun 2017 06:17:02 +0000
Bug 1368915 (part 1) - Rename a parameter of locked_register_thread(). r=mstange.
f79cc01cb73f6beba75b92bb0719438d5f6accc1: Bug 1320186: Don't sanitize storage values more than once. r=aswan
Kris Maglione <maglione.k@gmail.com> - Tue, 06 Jun 2017 18:59:06 -0700 - rev 590088
Push 62591 by lochang@mozilla.com at Wed, 07 Jun 2017 06:17:02 +0000
Bug 1320186: Don't sanitize storage values more than once. r=aswan MozReview-Commit-ID: y6S5LqS7fL
3ccce72b9da08d67bdc520985bc78f2a40853a55: Bug 1370634 - Make the time to wait the callback application (e.g. firefox.exe) to exit in the updater to be greater than the application's watchdog timer. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Tue, 06 Jun 2017 20:27:21 -0700 - rev 590087
Push 62591 by lochang@mozilla.com at Wed, 07 Jun 2017 06:17:02 +0000
Bug 1370634 - Make the time to wait the callback application (e.g. firefox.exe) to exit in the updater to be greater than the application's watchdog timer. r=mhowell
9948661fdb33b7d10bffc815d05332dae3e1423a: Bug 1365845 - Reset app.update.cancelations after a successful update. r=mhowell
Robert Strong <robert.bugzilla@gmail.com> - Tue, 06 Jun 2017 20:26:14 -0700 - rev 590086
Push 62591 by lochang@mozilla.com at Wed, 07 Jun 2017 06:17:02 +0000
Bug 1365845 - Reset app.update.cancelations after a successful update. r=mhowell
48e28c61a9dc74c40c512ce4072d708880d39d31: Backed out changeset 4524bfde8583 (bug 1361970) for failures in transform-3d/backface-visibility-3.html and transform-3d/opacity-preserve3d-1.html
Phil Ringnalda <philringnalda@gmail.com> - Tue, 06 Jun 2017 19:54:40 -0700 - rev 590085
Push 62591 by lochang@mozilla.com at Wed, 07 Jun 2017 06:17:02 +0000
Backed out changeset 4524bfde8583 (bug 1361970) for failures in transform-3d/backface-visibility-3.html and transform-3d/opacity-preserve3d-1.html CLOSED TREE MozReview-Commit-ID: GmEmiedJYeX
268ba7085b28b6de2924ef1c7ae604b235a0955a: Bug 1369282 - Update the close button style in the onboarding overlay to fit the spec;r=mossop;rexboy draft
gasolin <gasolin@gmail.com> - Wed, 07 Jun 2017 13:51:46 +0800 - rev 590084
Push 62590 by bmo:gasolin@mozilla.com at Wed, 07 Jun 2017 06:06:09 +0000
Bug 1369282 - Update the close button style in the onboarding overlay to fit the spec;r=mossop;rexboy MozReview-Commit-ID: 97cwIccQZs2
a7ab59f38557d24f33fc364db2811a04c9b99870: Bug 1351783 part 16 - Do less work when apz.keyboard.enabled is false r?kats draft
Ryan Hunt <rhunt@eqrion.net> - Tue, 06 Jun 2017 11:08:45 -0500 - rev 590083
Push 62589 by bmo:rhunt@eqrion.net at Wed, 07 Jun 2017 06:04:26 +0000
Bug 1351783 part 16 - Do less work when apz.keyboard.enabled is false r?kats When keyboard apz is disabled, we don't need to calculate focus targets and we don't need to update focus state. It should be harmless even if it's done, but I think it's good to not add something on this critical path that doesn't do anything. This commit also disable keyboard map generation in this case too for similar reasoning. This has the side effect that you can't turn on keyboard apz without doing a restart. MozReview-Commit-ID: LxmofT2g7qs
c8e820fe434479e64f9f750e206c8ee858c4bc5f: Bug 1351783 part 15 - Don't invalidate the FocusTarget if mousemove events happen without listeners r?kats draft
Ryan Hunt <rhunt@eqrion.net> - Mon, 05 Jun 2017 19:46:39 -0500 - rev 590082
Push 62589 by bmo:rhunt@eqrion.net at Wed, 07 Jun 2017 06:04:26 +0000
Bug 1351783 part 15 - Don't invalidate the FocusTarget if mousemove events happen without listeners r?kats Invalidating the focus state on every mousemove event can cause situations where we sync scroll because the user has moved their mouse recently and a repaint hasn't come soon enough. As an optimization, we can track when we have mousemove event listeners and not invalidate our focus state if we see that there are none. MozReview-Commit-ID: 9foGlGHVnVy
5c40a1f9c7a3aeb92d24f9c5c43f90363924e9d5: Bug 1351783 part 14 - Perform async scrolling for keyboard events when possible r?kats draft
Ryan Hunt <rhunt@eqrion.net> - Mon, 05 Jun 2017 19:46:06 -0500 - rev 590081
Push 62589 by bmo:rhunt@eqrion.net at Wed, 07 Jun 2017 06:04:26 +0000
Bug 1351783 part 14 - Perform async scrolling for keyboard events when possible r?kats This commit ties it all together by dispatching keyboard actions to scroll targets in response to keyboard inputs when we have current and valid focus state. MozReview-Commit-ID: G7rZiS3FH5e
7f9a3e0b6e87ccd381bf7d2b784b0a1dc464cf6a: Bug 1351783 part 13 - Hook up APZC for scrolling based on a KeyboardAction r?kats draft
Ryan Hunt <rhunt@eqrion.net> - Tue, 06 Jun 2017 04:47:10 -0500 - rev 590080
Push 62589 by bmo:rhunt@eqrion.net at Wed, 07 Jun 2017 06:04:26 +0000
Bug 1351783 part 13 - Hook up APZC for scrolling based on a KeyboardAction r?kats This commit adds code for keyboard scroll animations and computing the delta needed for a keyboard action. Keyboard scrolling also doesn't work well with scroll snapping for some reason, so we ignore any scrolls when we have scroll snap points. MozReview-Commit-ID: 97CpprCBp2A
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip