137282e8aeb8e22e4ee0fdca8bceaa2b6bcdeb8b: Bug 1304180 - Set taskcluster artifact expiration to 28 days on try draft
Brian Stack <bstack@mozilla.com> - Tue, 25 Oct 2016 11:47:50 -0700 - rev 429345
Push 33548 by bstack@mozilla.com at Tue, 25 Oct 2016 18:48:46 +0000
Bug 1304180 - Set taskcluster artifact expiration to 28 days on try MozReview-Commit-ID: ECXCs9EkOYI
d3351816685931b97168c0c810320661af72f5b7: Bug 1307816 - 16. Fix charset for robocop_input.html; r=me
Jim Chen <nchen@mozilla.com> - Tue, 25 Oct 2016 12:28:54 -0400 - rev 429344
Push 33548 by bstack@mozilla.com at Tue, 25 Oct 2016 18:48:46 +0000
Bug 1307816 - 16. Fix charset for robocop_input.html; r=me Trivial patch to include a meta charset line in robocop_input.html.
fb50e86c0ad54262cb5fde0847ec72baf02d794a: Bug 1307816 - 15. Use eContentCommandDelete for deleting text; r=esawin
Jim Chen <nchen@mozilla.com> - Tue, 25 Oct 2016 12:28:54 -0400 - rev 429343
Push 33548 by bstack@mozilla.com at Tue, 25 Oct 2016 18:48:46 +0000
Bug 1307816 - 15. Use eContentCommandDelete for deleting text; r=esawin Use a separate delete command for deleting text, because using regular composition events for deleting text doesn't seem to work well in Facebook comment boxes.
6319555e8a495d168f0341bc5d7c3bfa1c422f67: Bug 1307816 - 14. Save composition update for later; r=esawin
Jim Chen <nchen@mozilla.com> - Tue, 25 Oct 2016 12:28:54 -0400 - rev 429342
Push 33548 by bstack@mozilla.com at Tue, 25 Oct 2016 18:48:46 +0000
Bug 1307816 - 14. Save composition update for later; r=esawin Turns out the Facebook comment box doesn't work well if we send compositions alongside set/remove span events. This patch adds back the update composition flag, but only sends composition when necessary, which is only right before we send key events. Because onImeUpdateComposition is no longer associated with a separate action, it no longer sends back a reply using AutoIMESynchronize.
9740602ca9d274b00be9b81f23381efb4fd27dcd: Bug 1307816 - 13. Expand RemoveIMEComposition to allow canceling; r=esawin
Jim Chen <nchen@mozilla.com> - Tue, 25 Oct 2016 12:28:54 -0400 - rev 429341
Push 33548 by bstack@mozilla.com at Tue, 25 Oct 2016 18:48:46 +0000
Bug 1307816 - 13. Expand RemoveIMEComposition to allow canceling; r=esawin Expand RemoveIMEComposition with a flag to allow canceling the composition. Also, remove the "ideographic space" hack from before because it's no longer applicable (the test remains so we can catch any regressions).
67eeff0d462ae902c882adc0bc41012243a75b71: Bug 1307816 - 12. Fix up selection and composition when replacing text from Gecko; r=esawin
Jim Chen <nchen@mozilla.com> - Tue, 25 Oct 2016 12:28:54 -0400 - rev 429340
Push 33548 by bstack@mozilla.com at Tue, 25 Oct 2016 18:48:46 +0000
Bug 1307816 - 12. Fix up selection and composition when replacing text from Gecko; r=esawin When a Gecko text change spans larger than our original request, we have to do the replacement in parts in order to preserve any spans from the original request. There was a bug where the selection is moved to the wrong offset after the three replacements. This patch switches the order of the two replacements and manually fixes up the selection. For any text changes that originated on the Gecko side, this patch also splits the replacement into two parts (delete + insert), so that old composing spans are properly cleared first. This new behavior changes the expected result for the test added by bug 1051556, so the test is changed as well.. I think this new behavior is more correct, but if it results in regressions, we can reevaluate.
a96c35419566daaa7436ef4fc53dcbca6d9c4af0: Bug 1307816 - 11. Use GeckoThread for waiting on Gecko; r=esawin
Jim Chen <nchen@mozilla.com> - Tue, 25 Oct 2016 12:28:54 -0400 - rev 429339
Push 33548 by bstack@mozilla.com at Tue, 25 Oct 2016 18:48:46 +0000
Bug 1307816 - 11. Use GeckoThread for waiting on Gecko; r=esawin Right now we send a "process-gecko-events" message to GeckoInputConnection in order to wait on Gecko during testing. However, now we have GeckoThread.waitOnGecko() to do that, so we can just use that directly.
fdc8c569252fa1fb7992ba8c49722be8e105dd1a: Bug 1307816 - 10. Move text/selection assert methods to InputConnectionTest; r=esawin
Jim Chen <nchen@mozilla.com> - Tue, 25 Oct 2016 12:28:53 -0400 - rev 429338
Push 33548 by bstack@mozilla.com at Tue, 25 Oct 2016 18:48:46 +0000
Bug 1307816 - 10. Move text/selection assert methods to InputConnectionTest; r=esawin Under asynchronous IME, when we check text/selection for correctness, we have to wait for the IC thread to sync the shadow text first. In order to do that inside the assert methods, we have to move them to inside InputConnectionTest, so that they can call processGeckoEvents() and processInputConnectionEvents(). Also, ignore a single newline character, if present, at the end of the actual text, because it's a side effect of some editing operations in Gecko (e.g. clearing all text in an HTML editor).
72519ac4115b99f0f904ac6fbf163d04edc7ad3d: Bug 1307816 - 9. Fix IC thread switching after async refactoring; r=esawin
Jim Chen <nchen@mozilla.com> - Tue, 25 Oct 2016 12:28:53 -0400 - rev 429337
Push 33548 by bstack@mozilla.com at Tue, 25 Oct 2016 18:48:46 +0000
Bug 1307816 - 9. Fix IC thread switching after async refactoring; r=esawin When switching the IC thread from one thread to another, we can no longer block on the old IC thread waiting for the Gecko thread. However, we still block on the new IC thread, waiting for the old IC thread to finish processing any old events.
7ab2291527e5232ee901fb522a3ad272809947e9: Bug 1307816 - 8. Sync shadow text to current text; r=esawin
Jim Chen <nchen@mozilla.com> - Tue, 25 Oct 2016 12:28:53 -0400 - rev 429336
Push 33548 by bstack@mozilla.com at Tue, 25 Oct 2016 18:48:46 +0000
Bug 1307816 - 8. Sync shadow text to current text; r=esawin Sync the shadow text to the current text when the selection or text changes on the Gecko side, provided we are not in batch mode and if we don't have pending actions. Otherwise, remember the skipped sync and re-sync when we exit batch mode and/or finish all pending actions.
f250f52b697a3e73aa801a3b05e3d2cc2f858b7a: Bug 1307816 - 7. Flush text before sending focus event; r=esawin
Jim Chen <nchen@mozilla.com> - Tue, 25 Oct 2016 12:28:53 -0400 - rev 429335
Push 33548 by bstack@mozilla.com at Tue, 25 Oct 2016 18:48:46 +0000
Bug 1307816 - 7. Flush text before sending focus event; r=esawin We used to flush the Java side text upon receiving the acknowledge-focus event, at which point the Java side is waiting on the Gecko side. Because of the async IME refactoring, we can no longer wait on the Java side, so we have to flush the text early, before sending the first focus notification. Also, the acknowledge-focus event is no longer needed as a result. Our call to InputMethodManager to restart input also has to changed due to the change in calling sequence between notifyIME and notifyIMEContext.
05de8736810048be8ec61d7e0576fadf410ef06e: Bug 1307816 - 6. Remove ActionQueue and switch to AsyncText; r=esawin
Jim Chen <nchen@mozilla.com> - Tue, 25 Oct 2016 12:28:53 -0400 - rev 429334
Push 33548 by bstack@mozilla.com at Tue, 25 Oct 2016 18:48:46 +0000
Bug 1307816 - 6. Remove ActionQueue and switch to AsyncText; r=esawin Due to async IME refactoring, we no longer need the blocking mechanism in ActionQueue. As a result of the simplified code, we can remove ActionQueue entirely and move its code to under GeckoEditable. ActionQueue.offer() is now icOfferAction(). This patch also makes mText an instance of AsyncText, and change all accesses to mText to reflect the new async interface, i.e. accesses on the Gecko thread go through getCurrentText() and the current*** methods, and accesses on the IC thread go through getShadowText() and the shadow*** methods.
bc892befd1352205a8bfe5353d5c58cdfab7930d: Bug 1307816 - 5. Add AsyncText class for handling asynchronous text editing; r=esawin
Jim Chen <nchen@mozilla.com> - Tue, 25 Oct 2016 12:28:53 -0400 - rev 429333
Push 33548 by bstack@mozilla.com at Tue, 25 Oct 2016 18:48:46 +0000
Bug 1307816 - 5. Add AsyncText class for handling asynchronous text editing; r=esawin AsyncText keeps two copies of the text - the current copy on the Gecko thread that is the authoritative version of the text, and the shadow copy on the IC thread that reflects what we think the current text is. When editing the text on the IC thread, the shadow copy is modified directly, and then the modification is sent to the Gecko thread, which modifies the current copy concurrently. Depending on what Gecko does to the text, the current copy may diverge from the shadow copy, but periodically, the shadow copy is synced to the current copy through AsyncText.syncShadowText() to make the two copies identical again.
1d0a76e70bb663d441fa437d6198f0091f46ef13: Bug 1307816 - 4. Stop sending separate composition updates; r=esawin
Jim Chen <nchen@mozilla.com> - Tue, 25 Oct 2016 12:28:53 -0400 - rev 429332
Push 33548 by bstack@mozilla.com at Tue, 25 Oct 2016 18:48:46 +0000
Bug 1307816 - 4. Stop sending separate composition updates; r=esawin As part of async IME refactoring, we will no longer send composition updates separately. Instead, composition updates will be integrated into the set-span and remove-span events, similar to what we already do for replace-text events.
f6fa7ff4145dccd20f59ede30798b26db8f62d3a: Bug 1307816 - 3. Don't implement GeckoEditableListener in GeckoEditable; r=esawin
Jim Chen <nchen@mozilla.com> - Tue, 25 Oct 2016 12:28:53 -0400 - rev 429331
Push 33548 by bstack@mozilla.com at Tue, 25 Oct 2016 18:48:46 +0000
Bug 1307816 - 3. Don't implement GeckoEditableListener in GeckoEditable; r=esawin GeckoEditable implemented GeckoEditableListener because GeckoAppShell called its methods through GeckoEditableListener, but now we use JNI to call GeckoEditable methods directly, so GeckoEditable no longer has to implement GeckoEditableListener. This change also lets us simplify GeckoEditableListener by making onTextChange and onSelectionChange no longer have any parameters.
f007c6a5a0a8ee5663b560dd8a42307f7d14371c: Bug 1307816 - 2. Make clearSpans call go through Gekco; r=esawin
Jim Chen <nchen@mozilla.com> - Tue, 25 Oct 2016 12:28:53 -0400 - rev 429330
Push 33548 by bstack@mozilla.com at Tue, 25 Oct 2016 18:48:46 +0000
Bug 1307816 - 2. Make clearSpans call go through Gekco; r=esawin Currently, clearSpans calls are carried out immediately, but that makes it out of order in relation to other calls, which have to go through Gecko. This patch fixes this issue.
309cb93a58c55ad01273da23b0a1256353267c78: Bug 1307816 - 1. Remove legacy IME code; r=esawin
Jim Chen <nchen@mozilla.com> - Tue, 25 Oct 2016 12:28:52 -0400 - rev 429329
Push 33548 by bstack@mozilla.com at Tue, 25 Oct 2016 18:48:46 +0000
Bug 1307816 - 1. Remove legacy IME code; r=esawin Remove the event listener in GeckoEditable that was used for old text selection code. It's no longer relevant for the new accessible carets code.
f1deb434e0c789b436d64c46bc64fc5208c7df3f: Bug 1312705 - Update ExtendableMessageEvent to the latest version of the spec, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 25 Oct 2016 18:23:06 +0200 - rev 429328
Push 33548 by bstack@mozilla.com at Tue, 25 Oct 2016 18:48:46 +0000
Bug 1312705 - Update ExtendableMessageEvent to the latest version of the spec, r=smaug
12bd9aa9f2c7ee3999acc58fa41783d863cc8308: Bug 1312705 - Update ServiceWorkerMessageEvent to the latest version of the spec, r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 25 Oct 2016 18:22:46 +0200 - rev 429327
Push 33548 by bstack@mozilla.com at Tue, 25 Oct 2016 18:48:46 +0000
Bug 1312705 - Update ServiceWorkerMessageEvent to the latest version of the spec, r=smaug
25e1e4d63f116039124613519b0b516e154f236d: Bug 1307566 - Timeout increased for test_subworkers_suspended.html, r=bkelly
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 25 Oct 2016 18:21:34 +0200 - rev 429326
Push 33548 by bstack@mozilla.com at Tue, 25 Oct 2016 18:48:46 +0000
Bug 1307566 - Timeout increased for test_subworkers_suspended.html, r=bkelly
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip