128e071a026ee2acdd706bb11893986cfb55d5b5: Bug 1451359 - 1. Add support for external selection actions; r?snorp draft
Jim Chen <nchen@mozilla.com> - Fri, 06 Apr 2018 22:12:41 -0400 - rev 778896
Push 105607 by bmo:nchen@mozilla.com at Sat, 07 Apr 2018 02:13:22 +0000
Bug 1451359 - 1. Add support for external selection actions; r?snorp Add support for external selection actions (e.g. "Translate" action offered by the Google Translate app) in the default selection actions toolbar. MozReview-Commit-ID: AAlWIS1ZfMX
6698a5038fcbd26ef1642f685e52be9ec800a4b7: Bug 1303605: Make LazyFC assertions actually hold. r?bz draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 29 Mar 2018 14:04:40 +0200 - rev 778895
Push 105606 by bmo:emilio@crisal.io at Sat, 07 Apr 2018 01:54:08 +0000
Bug 1303605: Make LazyFC assertions actually hold. r?bz The code was trying to assert that we had frames constructed for all the nodes in the parent chain, but we don't bail out in the !GetContentInsertionFrameFor(aContainer) in the case that it's a children element, because they actually have no insertion frame, though their children do. Move the LazyFC check after the insertion point check. That makes the previous check work on the insertion point of the child, which makes it sound. This also fixes bug 1410020, and with it a Shadow DOM test-case that was failing because we had two sibling assigned to two different <slot>s, and the second one wasn't getting properly flagged, and thus the second sibling never got a frame. The other two test failures in this test are an event dispatch failure, where the position of the target is not what the test expects (we don't account for margin and padding). Filed that as bug 1450027. Also, added a test for which we have wrong layout without these patches, and that crashes with "Called Servo_Element_IsDisplayNone" with the first patch of this bug applied but not this one, due to the bogus check mentioned above. MozReview-Commit-ID: 6OeaVrZhTDv
235fcd09034a4f6672fda9acf776bdeed83f17e4: Bug 1303605: Make LazyFC assertions actually hold. r?bz draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 29 Mar 2018 14:04:40 +0200 - rev 778894
Push 105605 by bmo:emilio@crisal.io at Sat, 07 Apr 2018 01:38:39 +0000
Bug 1303605: Make LazyFC assertions actually hold. r?bz The code was trying to assert that we had frames constructed for all the nodes in the parent chain, but we don't bail out in the !GetContentInsertionFrameFor(aContainer) in the case that it's a children element, because they actually have no insertion frame, though their children do. Move the LazyFC check after the insertion point check. That makes the previous check work on the insertion point of the child, which makes it sound. This also fixes bug 1410020, and with it a Shadow DOM test-case that was failing because we had two sibling assigned to two different <slot>s, and the second one wasn't getting properly flagged, and thus the second sibling never got a frame. The other two test failures in this test are an event dispatch failure, where the position of the target is not what the test expects (we don't account for margin and padding). Filed that as bug 1450027. Also, added a test for which we have wrong layout without these patches, and that crashes with "Called Servo_Element_IsDisplayNone" with the first patch of this bug applied but not this one, due to the bogus check mentioned above. MozReview-Commit-ID: 6OeaVrZhTDv
4fa0e995be0b25cafe6992b103ea501cad197852: Bug 1303605: Remove the undisplayed maps. r?bz,mats draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 29 Mar 2018 03:49:26 +0200 - rev 778893
Push 105605 by bmo:emilio@crisal.io at Sat, 07 Apr 2018 01:38:39 +0000
Bug 1303605: Remove the undisplayed maps. r?bz,mats This is mostly code removal, changing GetDisplayContentsStyle(..) checks by an FFI call to Servo. The tricky parts are: * MaybeCreateLazily, which I fixed to avoid setting bits under display: none stuff. This was a pre-existing problem, which was wallpapered by the sc->IsInDisplayNoneSubtree() check, which effectively made the whole assertion useless (see bug 1381017 for the only crashtest that hit this though). * ContentRemoved, where we can no longer know for sure whether the element is actually display: contents if we're removing it as a response to a style change. See the comment there. That kinda sucks, but that case is relatively weird, and it's better than adding tons of complexity to handle that. * GetParentComputedStyle, which also has a comment there. Also, this function has only one caller now, so we should maybe try to remove it. The different assertions after DestroyFramesForAndRestyle are changed for a single assertion in the function itself, and the node bit used as an optimization to avoid hashtable lookups is taken back. MozReview-Commit-ID: AZm822QnhF9
980aadb45ba81d63bd38c0b4b7c646c8c422477c: Bug 1303605: Make LazyFC assertions actually hold. r?bz draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 29 Mar 2018 14:04:40 +0200 - rev 778892
Push 105604 by bmo:emilio@crisal.io at Sat, 07 Apr 2018 01:30:21 +0000
Bug 1303605: Make LazyFC assertions actually hold. r?bz The code was trying to assert that we had frames constructed for all the nodes in the parent chain, but we don't bail out in the !GetContentInsertionFrameFor(aContainer) in the case that it's a children element, because they actually have no insertion frame, though their children do. Move the LazyFC check after the insertion point check. That makes the previous check work on the insertion point of the child, which makes it sound. This also fixes bug 1410020, and with it a Shadow DOM test-case that was failing because the content other slot wasn't getting properly flagged, and thus the slotted content never got a frame. The other two test failures in this test are an event dispatch failure, where the position of the target is not what the test expects (we don't account for margin and padding). Filed that as bug 1450027. Also, added a test for which we have wrong layout without these patches, and that crashes with "Called Servo_Element_IsDisplayNone" with the first applied but not this one, due to the bogus check mentioned above. MozReview-Commit-ID: 6OeaVrZhTDv
bfc4e1bcc1f867ff4253d36db7fb401385d4bc6f: Bug 1303605: Remove the undisplayed maps. r?bz,mats draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 29 Mar 2018 03:49:26 +0200 - rev 778891
Push 105604 by bmo:emilio@crisal.io at Sat, 07 Apr 2018 01:30:21 +0000
Bug 1303605: Remove the undisplayed maps. r?bz,mats This is mostly code removal, changing GetDisplayContentsStyle(..) checks by an FFI call to Servo. The tricky parts are: * MaybeCreateLazily, which I fixed to avoid setting bits under display: none stuff. This was a pre-existing problem, which was wallpapered by the sc->IsInDisplayNoneSubtree() check, which effectively made the whole assertion useless. * ContentRemoved, where we can no longer know for sure whether the element is actually display: contents if we're removing it as a response to a style change. See the comment there. That kinda sucks, but that case is relatively weird, and it's better than adding tons of complexity to handle that. * GetParentComputedStyle, which also has a comment there. Also, this function has only one caller now, so we should maybe try to remove it. The different assertions after DestroyFramesForAndRestyle are changed for a single assertion in the function itself, and the node bit used as an optimization to avoid hashtable lookups is taken back. MozReview-Commit-ID: AZm822QnhF9
fe7fb527479dc18ced1a487d2fe40fea63a03f5a: Bug 1452307: Remove support for old-style experiment API extensions. r?aswan draft
Kris Maglione <maglione.k@gmail.com> - Fri, 06 Apr 2018 18:14:59 -0700 - rev 778890
Push 105603 by maglione.k@gmail.com at Sat, 07 Apr 2018 01:15:17 +0000
Bug 1452307: Remove support for old-style experiment API extensions. r?aswan MozReview-Commit-ID: 5y48pMRQ5XW
8328babe66a3304e19d62b4833844667c2015efb: Bug 1449933 - Webextension popups that don't define a background-color can be hard to read. r?mixedpuppy draft
Jared Wein <jwein@mozilla.com> - Fri, 30 Mar 2018 15:29:31 -0700 - rev 778889
Push 105602 by bmo:jaws@mozilla.com at Sat, 07 Apr 2018 00:55:17 +0000
Bug 1449933 - Webextension popups that don't define a background-color can be hard to read. r?mixedpuppy MozReview-Commit-ID: CVXySkhYaem
28d06ac08311a6f9102b0012bfe6e239190434d7: Bug 1451947 - Tweak dark theme popup styles. r=jaws draft
Tim Nguyen <ntim.bugs@gmail.com> - Sat, 07 Apr 2018 02:45:56 +0200 - rev 778888
Push 105601 by bmo:ntim.bugs@gmail.com at Sat, 07 Apr 2018 00:46:51 +0000
Bug 1451947 - Tweak dark theme popup styles. r=jaws MozReview-Commit-ID: 8ntjWOaMKvl
969a1232af2a2a0de416d0e06d6914df04f84e26: Bug 1441336 - Test addon permissions for PerformanceTiming properties draft
Tomislav Jovanovic <tomica@gmail.com> - Sat, 07 Apr 2018 02:38:51 +0200 - rev 778887
Push 105600 by bmo:tomica@gmail.com at Sat, 07 Apr 2018 00:39:36 +0000
Bug 1441336 - Test addon permissions for PerformanceTiming properties MozReview-Commit-ID: LlySv9AinVC
ad75cd6da33aec3c363969ee58ad27bc1d7693f3: Bug 1441336 - Use addon permissions for PerformanceTiming properties draft
Tomislav Jovanovic <tomica@gmail.com> - Wed, 04 Apr 2018 16:54:26 +0200 - rev 778886
Push 105600 by bmo:tomica@gmail.com at Sat, 07 Apr 2018 00:39:36 +0000
Bug 1441336 - Use addon permissions for PerformanceTiming properties We need to side-step existing cross-origin checks in Performance Timing code when the caller is a web extension content script that otherwise has permission to access the cross-origin resource. MozReview-Commit-ID: 8IgtqZgPWgY
385a49b0ec5a6e7ac47844428e287f1b4ef2abac: Bug 1451947 - Tweak dark theme popup styles. r=jaws draft
Tim Nguyen <ntim.bugs@gmail.com> - Sat, 07 Apr 2018 02:36:04 +0200 - rev 778885
Push 105599 by bmo:ntim.bugs@gmail.com at Sat, 07 Apr 2018 00:38:14 +0000
Bug 1451947 - Tweak dark theme popup styles. r=jaws MozReview-Commit-ID: HH5rw6mJ1BC
2fce968f46582ccb40145a5c0d6e9f58f34ada41: Bug 1452299: Make browser_ext_settings_overrides_search a less-dodgy xpcshell test. r?mkaply draft
Kris Maglione <maglione.k@gmail.com> - Fri, 06 Apr 2018 17:34:23 -0700 - rev 778884
Push 105598 by maglione.k@gmail.com at Sat, 07 Apr 2018 00:36:06 +0000
Bug 1452299: Make browser_ext_settings_overrides_search a less-dodgy xpcshell test. r?mkaply MozReview-Commit-ID: CffGpvV9vck
834489268b1ebf0ce3ded0862c710f16afc93f15: Bug 1451058: Follow-up: Fix some errors that show up during tests. r=me
Kris Maglione <maglione.k@gmail.com> - Fri, 06 Apr 2018 16:34:15 -0700 - rev 778883
Push 105598 by maglione.k@gmail.com at Sat, 07 Apr 2018 00:36:06 +0000
Bug 1451058: Follow-up: Fix some errors that show up during tests. r=me MozReview-Commit-ID: K410z6VdHov
4899cdabbf2535c430a041442bc9eb4aa37f38ab: Bug 1451058: Save temporary popup pre-load panel for remote popups. r=mixedpuppy
Kris Maglione <maglione.k@gmail.com> - Tue, 03 Apr 2018 11:14:49 -0700 - rev 778882
Push 105598 by maglione.k@gmail.com at Sat, 07 Apr 2018 00:36:06 +0000
Bug 1451058: Save temporary popup pre-load panel for remote popups. r=mixedpuppy Creating the temporary panel for a pre-load popup can be expensive, especially for OOP popups, where we need to create a compositor. Since we currently need to create a pre-load popup every time we hover over a browser action with a popup, it's probably worth saving and re-using them, rather than always creating a new one. MozReview-Commit-ID: GwG7qJNdk8f
96e1fe15043878f30293461d89391dfcad747323: Bug 1451947 - Tweak dark theme popup styles. r=dao draft
Tim Nguyen <ntim.bugs@gmail.com> - Sat, 07 Apr 2018 02:20:53 +0200 - rev 778881
Push 105597 by bmo:ntim.bugs@gmail.com at Sat, 07 Apr 2018 00:21:31 +0000
Bug 1451947 - Tweak dark theme popup styles. r=dao MozReview-Commit-ID: 1WJixnFQf0D
c4b19afa06ea11c16ff3983a69e6c3aa1fdad8de: Backed out changeset 1a7f56d4af25 (bug 1451314) for g2 failures in debugger/custom.js: Test timed out on a CLOSED TREE
shindli <shindli@mozilla.com> - Sat, 07 Apr 2018 03:02:39 +0300 - rev 778880
Push 105597 by bmo:ntim.bugs@gmail.com at Sat, 07 Apr 2018 00:21:31 +0000
Backed out changeset 1a7f56d4af25 (bug 1451314) for g2 failures in debugger/custom.js: Test timed out on a CLOSED TREE
199800118427f31cb39876ddf50ef38cd8d352f4: Bug 1452169 - Remove nsNthIndexCache.h. r=dholbert
Jonathan Watt <jwatt@jwatt.org> - Fri, 06 Apr 2018 19:10:43 +0100 - rev 778879
Push 105597 by bmo:ntim.bugs@gmail.com at Sat, 07 Apr 2018 00:21:31 +0000
Bug 1452169 - Remove nsNthIndexCache.h. r=dholbert
deafa2891c61a4570bcadb80b90adac0930b1d10: Bug 1452040 - Get rid of NS_STYLE_FONT_WEIGHT_NORMAL and NS_STYLE_FONT_WEIGHT_BOLD. r=emilio
Jonathan Watt <jwatt@jwatt.org> - Fri, 06 Apr 2018 14:53:25 +0100 - rev 778878
Push 105597 by bmo:ntim.bugs@gmail.com at Sat, 07 Apr 2018 00:21:31 +0000
Bug 1452040 - Get rid of NS_STYLE_FONT_WEIGHT_NORMAL and NS_STYLE_FONT_WEIGHT_BOLD. r=emilio
1a7f56d4af25927c756f94f333068ba5499b2895: Bug 1451314 - Update Debugger Frontend v32. r=jdescottes
Jason Laster <jason.laster.11@gmail.com> - Wed, 04 Apr 2018 13:16:03 -0400 - rev 778877
Push 105597 by bmo:ntim.bugs@gmail.com at Sat, 07 Apr 2018 00:21:31 +0000
Bug 1451314 - Update Debugger Frontend v32. r=jdescottes MozReview-Commit-ID: KK0CLqSzuVx
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip