112b58c156548f957a0aebbceb8600839423cf49: Bug 1251362 - Part 11 - Add telemetry for restoring tabs. r=liuche draft
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 18 May 2016 19:04:49 +0200 - rev 369329
Push 18832 by mozilla@buttercookie.de at Sun, 22 May 2016 13:11:25 +0000
Bug 1251362 - Part 11 - Add telemetry for restoring tabs. r=liuche This adds telemetry for clicking on a closed tab or one of the "Open all" buttons. Methods and extras strings are the same as those used for the old Recent Tabs panel. MozReview-Commit-ID: 1Kc8fACkmIc
8e921e4986920df43ac0980df4e8d5de04727ea4: Bug 1251362 - Part 10 - Only enable swipe to refresh within the Synced devices smart folder. r=liuche draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 14 May 2016 23:38:29 +0200 - rev 369328
Push 18832 by mozilla@buttercookie.de at Sun, 22 May 2016 13:11:25 +0000
Bug 1251362 - Part 10 - Only enable swipe to refresh within the Synced devices smart folder. r=liuche Recently closed tabs aren't synced, therefore being able to swipe to refresh within the Recent tabs folder isn't necessary. To avoid triggering a refresh by accident, we restrict swipe to refresh to the Synced devices folder itself. MozReview-Commit-ID: YwekSwQr2q
12e09918672087e519c1e30c6495cd70e2c3c89a: Bug 1251362 - Part 9 - Hide Recent Tabs smart folder if there aren't any closed tabs to be shown. r=liuche draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 14 May 2016 21:55:57 +0200 - rev 369327
Push 18832 by mozilla@buttercookie.de at Sun, 22 May 2016 13:11:25 +0000
Bug 1251362 - Part 9 - Hide Recent Tabs smart folder if there aren't any closed tabs to be shown. r=liuche This involves making the number of visible smart folders dynamic, so the history adapter can properly display its contents. MozReview-Commit-ID: 6b4V6IHB7BE
09fc625dd2848a514672969da89a5c7db570ee78: Bug 1251362 - Part 8 - Directly notify the RecentTabsAdapter when clearing history. r=liuche draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 14 May 2016 21:27:23 +0200 - rev 369326
Push 18832 by mozilla@buttercookie.de at Sun, 22 May 2016 13:11:25 +0000
Bug 1251362 - Part 8 - Directly notify the RecentTabsAdapter when clearing history. r=liuche Sessionstore.bak is only read when we are initialising the home panels, so after clearing all history from the button in the Combined History panel, the "Tabs from last time" section would still linger around until the home panels have been closed and reopened. To prevent this, we now directly notify the RecentTabsAdapter when all history has been deleted, so it can immediately clear its own copy of last session's tabs. MozReview-Commit-ID: 3EFY2WbWqzh
5453effa5820e55ea00ee137b6165019f2429458: Bug 1251362 - Part 7 - Display a context menu for closed tab entries. r=liuche draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 14 May 2016 19:42:00 +0200 - rev 369325
Push 18832 by mozilla@buttercookie.de at Sun, 22 May 2016 13:11:25 +0000
Bug 1251362 - Part 7 - Display a context menu for closed tab entries. r=liuche MozReview-Commit-ID: Gv2tJoNRldX
883f0b566d2c23d38092a1b58a06be00ace2077f: Bug 1251362 - Part 6 - Handle Recent Tabs in onItemClicked(). r=liuche draft
Jan Henning <jh+bugzilla@buttercookie.de> - Wed, 18 May 2016 18:55:32 +0200 - rev 369324
Push 18832 by mozilla@buttercookie.de at Sun, 22 May 2016 13:11:25 +0000
Bug 1251362 - Part 6 - Handle Recent Tabs in onItemClicked(). r=liuche Clicking a tab in the list of recently closed tabs now sends the appropriate message back to the session store. Likewise, clicking on the "Open all" button collects and sends all tabs of the respective type ("Recently closed" or "Tabs from last time") to Gecko for restoring. MozReview-Commit-ID: KF3UJjq5zQK
1bb5d502c3f21390ae2ba5241a6c4f4d2bea1b54: Bug 1251362 - Part 5 - Update closed tabs count in the History panel main view. r=liuche draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 14 May 2016 20:35:07 +0200 - rev 369323
Push 18832 by mozilla@buttercookie.de at Sun, 22 May 2016 13:11:25 +0000
Bug 1251362 - Part 5 - Update closed tabs count in the History panel main view. r=liuche We need to update the recent tabs count displayed by the smart folder as necessary. To do this, we copy the approach used for updating the synced devices count. MozReview-Commit-ID: BFwv5bY1DWk
c2777c641321f5106b32d3ac2cae3bb57762ee85: Bug 1251362 - Part 4 - Update empty panel state when recent tabs count changes. r=liuche draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 15 May 2016 01:41:45 +0200 - rev 369322
Push 18832 by mozilla@buttercookie.de at Sun, 22 May 2016 13:11:25 +0000
Bug 1251362 - Part 4 - Update empty panel state when recent tabs count changes. r=liuche The recent tabs count might change while the Recent Tabs folder is open, e.g. immediately after startup, once we receive the first "ClosedTabs:Data" from the session store. Therefore, we need to hide/unhide the empty view as necessary, which is normally handled by the Combined History panel's updateEmptyView() function. Since we aren't using a cursor, we can't hinge calling that on the CursorLoader's onLoadFinished() callback, so instead, we include our own callback to the Combined History panel, modelled after the DeviceUpdateHandler used for updating the count of synced devices. MozReview-Commit-ID: GLHM9LoWk2h
a814f49d45a25392a1ed1ce8de2d6499fee251f8: Bug 1251362 - Part 3 - Actually show recently closed tabs when opening the smart folder. r=liuche draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 14 May 2016 20:38:45 +0200 - rev 369321
Push 18832 by mozilla@buttercookie.de at Sun, 22 May 2016 13:11:25 +0000
Bug 1251362 - Part 3 - Actually show recently closed tabs when opening the smart folder. r=liuche This fills the new smart folder we've previously added with life and displays the recently closed tabs as we receive them from the session store. If we can find a sessionstore.bak file, we also add a section for "Tabs from last time". Most of the code for communicating with the session store and reading sessionstore.bak is adapted from the original Recent Tabs panel, however unlike the previous implementation, I've opted for a cursor-less approach of storing and retrieving the recent tabs data, since the recent tabs data isn't actually powered by a database anyway. Instead, the RecentTabsAdapter maintains two arrays for storing "recently closed tabs" (as received through messages from the Gecko session store) and "tabs from last time" (as read from sessionstore.bak during panel initialisation). For unknown reasons, home_open_all_row.xml's background now has to be explicitly set to "@drawable/action_bar_button" in order for highlighting on click to work. TODO: Once the patch to move startup session processing to a background thread (Bug 905223) has landed, we need to update readPreviousSessionData() to explicitly check (by attempting to wait) that the startup code had a chance to move the previous session file to sessionstore.bak if necessary. MozReview-Commit-ID: IpoUr9f0JBP
f194982d7bf43726f434042e6abfcde683bb8f95: Bug 1251362 - Part 2 - Add a Recent Tabs folder to the Combined History panel. r=liuche draft
Jan Henning <jh+bugzilla@buttercookie.de> - Fri, 13 May 2016 23:52:24 +0200 - rev 369320
Push 18832 by mozilla@buttercookie.de at Sun, 22 May 2016 13:11:25 +0000
Bug 1251362 - Part 2 - Add a Recent Tabs folder to the Combined History panel. r=liuche This folder can be opened and closed to get back to the history view, however it doesn't contain any actual content (closed tabs) yet. Its empty view is based on the original empty view of the Recent Tabs panel. For displaying the recently closed tabs count within the smart folder similarly to how we display the number of synced devices, two new strings need to be added. MozReview-Commit-ID: IAL0yDrc2Ld
0bae05cdac7df5107bf2e03c91a0f4214ec7f61e: Bug 1251362 - Part 1 - Increase SwipeRefreshLayout weight. r=liuche draft
Jan Henning <jh+bugzilla@buttercookie.de> - Mon, 16 May 2016 17:53:01 +0200 - rev 369319
Push 18832 by mozilla@buttercookie.de at Sun, 22 May 2016 13:11:25 +0000
Bug 1251362 - Part 1 - Increase SwipeRefreshLayout weight. r=liuche Otherwise, depending on the device's display dimensions, a second smart folder would be overlapped by the empty view message that is displayed when no history is present for the history panel to display. MozReview-Commit-ID: 1xBCeiST9n4
99086ed787b153bc274478ae501b572cb346e44e: Turn off LeakCanary draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 17 Apr 2016 17:06:56 +0200 - rev 369318
Push 18832 by mozilla@buttercookie.de at Sun, 22 May 2016 13:11:25 +0000
Turn off LeakCanary MozReview-Commit-ID: DeWJolAsk9P
16663eb3dcfa759f25b5e27b101bc79270c156f2: No bug, Automated blocklist update from host bld-linux64-spot-425 - a=blocklist-update
ffxbld - Sat, 21 May 2016 05:05:23 -0700 - rev 369317
Push 18832 by mozilla@buttercookie.de at Sun, 22 May 2016 13:11:25 +0000
No bug, Automated blocklist update from host bld-linux64-spot-425 - a=blocklist-update
ce953704de51095d64487c6796ed53dc67cfc2a8: No bug, Automated HPKP preload list update from host bld-linux64-spot-425 - a=hpkp-update
ffxbld - Sat, 21 May 2016 05:05:21 -0700 - rev 369316
Push 18832 by mozilla@buttercookie.de at Sun, 22 May 2016 13:11:25 +0000
No bug, Automated HPKP preload list update from host bld-linux64-spot-425 - a=hpkp-update
ff787bd4fbfa8ebad2570ba0908957f130b527c2: No bug, Automated HSTS preload list update from host bld-linux64-spot-425 - a=hsts-update
ffxbld - Sat, 21 May 2016 05:05:19 -0700 - rev 369315
Push 18832 by mozilla@buttercookie.de at Sun, 22 May 2016 13:11:25 +0000
No bug, Automated HSTS preload list update from host bld-linux64-spot-425 - a=hsts-update
f1f2644d34440fe38c098e323bf570e09197e51a: Backed out 3 changesets (bug 1267910) for reports of it breaking session restore a=backout
Wes Kocher <wkocher@mozilla.com> - Fri, 20 May 2016 21:15:17 -0700 - rev 369314
Push 18832 by mozilla@buttercookie.de at Sun, 22 May 2016 13:11:25 +0000
Backed out 3 changesets (bug 1267910) for reports of it breaking session restore a=backout Backed out changeset 5962f8e6d030 (bug 1267910) Backed out changeset f8afc5cf9e0e (bug 1267910) Backed out changeset cc202e0ac0dd (bug 1267910)
45709b7b6466abcd984d5736c0e64eb12b0044cc: Bug 1274717: use a level-appropriate scope; r=garndt a=KWierso
Dustin J. Mitchell <dustin@mozilla.com> - Fri, 20 May 2016 23:00:15 +0000 - rev 369313
Push 18832 by mozilla@buttercookie.de at Sun, 22 May 2016 13:11:25 +0000
Bug 1274717: use a level-appropriate scope; r=garndt a=KWierso MozReview-Commit-ID: KU7D06KauBK
d2e4b96814aec34e3fb137e9326e2bcc7a6dd45f: Bug 1251362 - DON'T LAND - Debug temp: If the startup tab restore setting is set to "Never", always try switching to the recent tabs panel on startup, so we can test the code path for redirecting this to the combined history panel. draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sun, 15 May 2016 01:42:16 +0200 - rev 369312
Push 18831 by mozilla@buttercookie.de at Sat, 21 May 2016 18:52:21 +0000
Bug 1251362 - DON'T LAND - Debug temp: If the startup tab restore setting is set to "Never", always try switching to the recent tabs panel on startup, so we can test the code path for redirecting this to the combined history panel. Normally, this is only used by the crash loop protection (see bug 1263110). MozReview-Commit-ID: BxTlsfi1HUt
769a7c6cc02127ba8dcc5d796bd739f6916d1ed9: Bug 1251362 - Part 17 - Remove old Recent Tabs Panel code draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 21 May 2016 14:52:41 +0200 - rev 369311
Push 18831 by mozilla@buttercookie.de at Sat, 21 May 2016 18:52:21 +0000
Bug 1251362 - Part 17 - Remove old Recent Tabs Panel code MozReview-Commit-ID: FQJ7j8YlV6E
e554e84181c999086a63bd1700d059a2d34821f9: Bug 1251362 - Part 16 - Migrate (customised) home panel configurations draft
Jan Henning <jh+bugzilla@buttercookie.de> - Sat, 21 May 2016 14:39:15 +0200 - rev 369310
Push 18831 by mozilla@buttercookie.de at Sat, 21 May 2016 18:52:21 +0000
Bug 1251362 - Part 16 - Migrate (customised) home panel configurations MozReview-Commit-ID: 5CSJUTRysQU
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip