112098d624c00470eb65e6c1f3314182530e8fe2: Bug 1439875: Update browser_windowopen_flicker.js. r?florian
draft
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 26 Feb 2018 14:10:22 +0100 - rev 759698
Push
100434 by bmo:emilio@crisal.io at Mon, 26 Feb 2018 13:12:59 +0000
Bug 1439875: Update browser_windowopen_flicker.js. r?florian
To avoid hacking around the empty window, and handle the activation issue seen
on OSX / Windows.
Also add exceptions for the loading of icons in the tab strip and the titlebar.
MozReview-Commit-ID: oK3T8FKd5n
40f7a3780fa3edb076bc69d514a96e150d580884: Bug 1439875: Update browser_windowopen_reflows.js to not wait for a resize that no longer exists. r?florian
draft
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 26 Feb 2018 14:09:20 +0100 - rev 759697
Push
100434 by bmo:emilio@crisal.io at Mon, 26 Feb 2018 13:12:59 +0000
Bug 1439875: Update browser_windowopen_reflows.js to not wait for a resize that no longer exists. r?florian
MozReview-Commit-ID: Jln9ejZh2b6
fa6795753393fc7ba3cf255a224810b16c129e8a: Bug 1439875: Fire MozBeforeInitialXULLayout before sizing the window. r?florian,smaug
draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 22 Feb 2018 16:27:46 +0100 - rev 759696
Push
100434 by bmo:emilio@crisal.io at Mon, 26 Feb 2018 13:12:59 +0000
Bug 1439875: Fire MozBeforeInitialXULLayout before sizing the window. r?florian,smaug
This gives the chance to code that relies on setting the XUL window attributes
to run before we actually size the window.
This should prevent the resizing on OSX and fix some other untested stuff that
the first commit probably broke...
MozReview-Commit-ID: DhCWgmCppek
6471127e9c141dfadaf16d0dceccd475da3a6a51: Bug 1439875: Fix extension windows. r?kmag
draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 22 Feb 2018 10:39:04 +0100 - rev 759695
Push
100434 by bmo:emilio@crisal.io at Mon, 26 Feb 2018 13:12:59 +0000
Bug 1439875: Fix extension windows. r?kmag
Now we're loading the sizemode attribute earlier, doing this on load stops
working.
MozReview-Commit-ID: ToiJiYrvFw
547b8f3a4f1fb94833a8dcb9c7b92d135141808d: Bug 1439875: Size the XUL window before doing layout. r?smaug
draft
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 21 Feb 2018 12:47:05 +0100 - rev 759694
Push
100434 by bmo:emilio@crisal.io at Mon, 26 Feb 2018 13:12:59 +0000
Bug 1439875: Size the XUL window before doing layout. r?smaug
The only subtle thing is the mCenterAfterLoad stuff, which is gated after a
mChromeLoaded.
Other than that it follows the same pattern as
bug 345560.
MozReview-Commit-ID: 8qDiA2yn9DB
5d019ada09d9dd29298f50e25143e69955049c38: Bug 1439398: Upstream a few more ib-split tests. r?dbaron
draft
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Feb 2018 13:23:49 +0100 - rev 759693
Push
100434 by bmo:emilio@crisal.io at Mon, 26 Feb 2018 13:12:59 +0000
Bug 1439398: Upstream a few more ib-split tests. r?dbaron
MozReview-Commit-ID: 3Ah1bb8dmwq
9e8c013a3b65abe5513e99c9c2e4dd6f06d8016e: Bug 1439398: Tidy a few more tests in preparation to upstreaming. r?dbaron
draft
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 19 Feb 2018 13:22:14 +0100 - rev 759692
Push
100434 by bmo:emilio@crisal.io at Mon, 26 Feb 2018 13:12:59 +0000
Bug 1439398: Tidy a few more tests in preparation to upstreaming. r?dbaron
MozReview-Commit-ID: 2QLhO7iu01e
a84c507b49680ec457c424a69c799b002aad6cf5: Bug 1439055: Export the ib-split remove-* reftests. r?bz
draft
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 17 Feb 2018 03:00:43 +0100 - rev 759691
Push
100434 by bmo:emilio@crisal.io at Mon, 26 Feb 2018 13:12:59 +0000
Bug 1439055: Export the ib-split remove-* reftests. r?bz
MozReview-Commit-ID: Ey94P8sPyhp
998810a1a11309f45827f98cfd19ff729a39ce78: But 1439055: Use window.onload instead of <body onload>, so that tests map more easily visually to the ref. r?bz
draft
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 17 Feb 2018 02:54:19 +0100 - rev 759690
Push
100434 by bmo:emilio@crisal.io at Mon, 26 Feb 2018 13:12:59 +0000
But 1439055: Use window.onload instead of <body onload>, so that tests map more easily visually to the ref. r?bz
MozReview-Commit-ID: 1xVzkxmEEhO
c601e742bcc4b5c84aeeaa8200f95d63a7c2b2bc: Bug 1439055: Tidy the ib-split remove-* tests. r?bz
draft
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 17 Feb 2018 02:47:04 +0100 - rev 759689
Push
100434 by bmo:emilio@crisal.io at Mon, 26 Feb 2018 13:12:59 +0000
Bug 1439055: Tidy the ib-split remove-* tests. r?bz
Mostly removing some unneeded tags (<meta name=flags> is no longer needed, and
tagging it "dom" didn't seem appropriate to me). Also adding some tags that
match the WPT test template (charset / titles mostly). Also using consistent
indentation.
Finally, adding the needed
<link rel="match">
tags so that the exported tests work correctly upstream.
MozReview-Commit-ID: Lt83JmJE4pO
678f52801d100a980f529fc565d1009c38320ae4: Bug 1431027 - Update disk space warning to reflect the latest preferences. r=nhnt11
draft
Johann Hofmann <jhofmann@mozilla.com> - Thu, 22 Feb 2018 00:31:16 +0100 - rev 759688
Push
100433 by jhofmann@mozilla.com at Mon, 26 Feb 2018 12:57:38 +0000
Bug 1431027 - Update disk space warning to reflect the latest preferences. r=nhnt11
This changes the disk space notification to show the correct preferences path
and to use the correct openPreferences arguments.
MozReview-Commit-ID: BuKAUvDjp9T
2e530d013e0183726e447a6bbde49cb3578c612b: Bug 1440379 - Tidy up ESlint no-unused-vars definitions wrt Ci/Cu/Cr/Cc usage for varsIgnorePattern. r?florian
draft
Mark Banner <standard8@mozilla.com> - Thu, 22 Feb 2018 16:55:36 +0000 - rev 759687
Push
100432 by bmo:standard8@mozilla.com at Mon, 26 Feb 2018 12:51:08 +0000
Bug 1440379 - Tidy up ESlint no-unused-vars definitions wrt Ci/Cu/Cr/Cc usage for varsIgnorePattern. r?florian
MozReview-Commit-ID: HmliR8iNRDq
4d4e9e636476d1051e0e1951b1c3f9b288c77bf4: Bug 1438679 - [mozrunner] DeviceRunner has to override returncode and wait() to check for remote process status.
draft
Henrik Skupin <mail@hskupin.info> - Thu, 22 Feb 2018 23:08:49 +0100 - rev 759686
Push
100431 by bmo:hskupin@gmail.com at Mon, 26 Feb 2018 12:24:55 +0000
Bug 1438679 - [mozrunner] DeviceRunner has to override returncode and wait() to check for remote process status.
Without returncode and wait() being overridden the default
implementation of the Runner class takes precedence and will
run the check for the adb command but not the remote process.
This always returns 0 because adb runs or forks itself as daemon.
Instead the remote process has to be checked for existence.
MozReview-Commit-ID: GvuAaMSxBT2
3ab3530b3d7e512c7f305702a978b75e5f002c7b: Bug 1438679 - [mozdevice] processExist() has to return a boolean and not remote process id.
draft
Henrik Skupin <mail@hskupin.info> - Mon, 26 Feb 2018 12:09:48 +0100 - rev 759685
Push
100431 by bmo:hskupin@gmail.com at Mon, 26 Feb 2018 12:24:55 +0000
Bug 1438679 - [mozdevice] processExist() has to return a boolean and not remote process id.
MozReview-Commit-ID: I1Z4TLZq9uS
a249c1d3216955b43cb106b3ed323d3a3232b3b5: Bug 1439673 - Fix React 16 warnings r?nchevobbe
draft
Michael Ratcliffe <mratcliffe@mozilla.com> - Wed, 21 Feb 2018 20:34:19 +0000 - rev 759684
Push
100430 by bmo:mratcliffe@mozilla.com at Mon, 26 Feb 2018 12:19:54 +0000
Bug 1439673 - Fix React 16 warnings r?nchevobbe
I believe this fixes all warnings except for one. This warning appears the first time the memory panel is selected:
"Warning: Failed prop type: Calling PropTypes validators directly is not supported by the `prop-types` package. Use `PropTypes.checkPropTypes()` to call them. Read more at http://fb.me/use-check-prop-types
in MemoryApp (created by Connect(MemoryApp))
in Connect(MemoryApp) (created by bound createElementWithValidation)
in bound createElementWithValidation
in Provider"
This appears to be an issue with `devtools/client/memory/app.js` but I will log a new bug for this.
MozReview-Commit-ID: 341zdQyfgrN
ed3ac671499323c4186ca5e0ffc68113a3bcb2e6: Bug 1410456 - Update cubeb from upstream to b1ee1ce. r?padenot
draft
Alex Chronopoulos <achronop@gmail.com> - Mon, 26 Feb 2018 14:03:36 +0200 - rev 759683
Push
100429 by achronop@gmail.com at Mon, 26 Feb 2018 12:13:21 +0000
Bug 1410456 - Update cubeb from upstream to b1ee1ce. r?padenot
MozReview-Commit-ID: 5PmGUcxB6jv
15b4bad08653365f348ce0c57253202101ed4ac9: Bug 1410456 - Add new files in update.sh script. r?padenot
draft
Alex Chronopoulos <achronop@gmail.com> - Mon, 26 Feb 2018 13:52:36 +0200 - rev 759682
Push
100429 by achronop@gmail.com at Mon, 26 Feb 2018 12:13:21 +0000
Bug 1410456 - Add new files in update.sh script. r?padenot
MozReview-Commit-ID: GD8CHTM1pV8
0dbf1f45a6adf863c677de5218d6f8ed1d2cd7e7: Bug 1410456 - Keep the old mechanism for the older versions that jni method is not available. r?padenot
draft
Alex Chronopoulos <achronop@gmail.com> - Mon, 26 Feb 2018 13:46:13 +0200 - rev 759681
Push
100429 by achronop@gmail.com at Mon, 26 Feb 2018 12:13:21 +0000
Bug 1410456 - Keep the old mechanism for the older versions that jni method is not available. r?padenot
MozReview-Commit-ID: IsAOhDkNjHp
2f8d737e9613f80f7b913cf94dac2918ea39ff18: Bug 1432425 - Remove synchronous Bookmarks::RemoveFolderChildren. r=standard8,kitcambridge
draft
Marco Bonardo <mbonardo@mozilla.com> - Sun, 25 Feb 2018 21:44:41 +0100 - rev 759680
Push
100428 by mak77@bonardo.net at Mon, 26 Feb 2018 12:05:56 +0000
Bug 1432425 - Remove synchronous Bookmarks::RemoveFolderChildren. r=standard8,kitcambridge
MozReview-Commit-ID: GPrNcmEIgpZ
e74a3120c47f890790a8427cb39894bbffa9a98b: Bug 1441113 - Can only update a mounted or mounting component when closing Memory Tool r?nchevobbe
draft
Michael Ratcliffe <mratcliffe@mozilla.com> - Mon, 26 Feb 2018 11:59:23 +0000 - rev 759679
Push
100427 by bmo:mratcliffe@mozilla.com at Mon, 26 Feb 2018 12:00:02 +0000
Bug 1441113 - Can only update a mounted or mounting component when closing Memory Tool r?nchevobbe
The onclick handler of the toolbox close button looked like this... spot the deliberate mistake:
```
onClick: () => {
closeToolbox();
focusButton(closeButtonId);
},
```
So we were closing the toolbox and then trying to focus the toolbox's close button.
There is also an obvious race condition with setState inside the toolbox controller not using a callback even though the next line calls a function that uses this.state, which could cause intermittent issues.
MozReview-Commit-ID: 9VRcZw4RvE5