0d7a157692c2e52d068cf600b6c1f2844c30c152: Bug 1322570 Part 4 - Use GetParentAllowServo() in KeyframeEffectReadOnly::UpdateProperties. draft
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 Mar 2017 14:13:01 +0800 - rev 504312
Push 50776 by bmo:tlin@mozilla.com at Fri, 24 Mar 2017 06:09:16 +0000
Bug 1322570 Part 4 - Use GetParentAllowServo() in KeyframeEffectReadOnly::UpdateProperties. Per bug 1322570 Comment 7, we could drop the GetParentAllowServo() when we invoke UpdateProperties() from a SquentialTask, so allow it for now. MozReview-Commit-ID: 52NauGaz4Zv
1fab92884b75b658a707f34d7b75eaf3967f5507: Bug 1322570 Part 3 - Get StyleContext from parent frame in nsFlexContainerFrame::Init(). draft
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 Mar 2017 14:12:28 +0800 - rev 504311
Push 50776 by bmo:tlin@mozilla.com at Fri, 24 Mar 2017 06:09:16 +0000
Bug 1322570 Part 3 - Get StyleContext from parent frame in nsFlexContainerFrame::Init(). In stylo, nsStyleContext::GetParent() is not valid. MozReview-Commit-ID: 5FbgUwobG3U
a4ed86633048f5691eeb3ab4ba67e5de846340df: Bug 1322570 Part 2 - Resolve {align,justify}-self using StyleContext from alignment container frame in ReflowInput::InitConstraints(). draft
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 Mar 2017 14:12:08 +0800 - rev 504310
Push 50776 by bmo:tlin@mozilla.com at Fri, 24 Mar 2017 06:09:16 +0000
Bug 1322570 Part 2 - Resolve {align,justify}-self using StyleContext from alignment container frame in ReflowInput::InitConstraints(). Per bug 1322570 comment 46, it's not easy to replace ComputedJustifyItems() and UsedJustifySelf()'s internal nsStyleContext::GetParent() without correctness penalty, so we use GetParentAllowServo() for now. Also, fix the reftest.list added in bug 1334403 which incorrectly wrote test page as reference page. MozReview-Commit-ID: 6kAAWSFojd5
337820e72d9e2285e956bf216f4c564b6ae842a6: Bug 1322570 Part 1 - Add MOZ_ASSERT in nsStyleContext::GetParent() to disallow usage by stylo. draft
Ting-Yu Lin <tlin@mozilla.com> - Mon, 20 Mar 2017 14:11:06 +0800 - rev 504309
Push 50776 by bmo:tlin@mozilla.com at Fri, 24 Mar 2017 06:09:16 +0000
Bug 1322570 Part 1 - Add MOZ_ASSERT in nsStyleContext::GetParent() to disallow usage by stylo. Also, add GetParentAllowServo() to whitelist the usage in servo-backed style system in subsequent parts so that we could revisit them later. MozReview-Commit-ID: JthU18Ftx02
dc1fdf122af1273904d68b41ee1f8cd0460a1932: Bug 1347336 - Display grid line name and numbers in Grid Highlighter. r?gl draft
Micah Tigley <tigleym@gmail.com> - Fri, 24 Mar 2017 00:06:46 -0600 - rev 504308
Push 50775 by bmo:tigleym@gmail.com at Fri, 24 Mar 2017 06:08:56 +0000
Bug 1347336 - Display grid line name and numbers in Grid Highlighter. r?gl MozReview-Commit-ID: Eh7GEYYZyqc
b21ed2430172c000fc7258a96577f8c8bb63c294: Aspect ratio patch draft
Micah Tigley <tigleym@gmail.com> - Thu, 23 Mar 2017 23:56:22 -0600 - rev 504307
Push 50775 by bmo:tigleym@gmail.com at Fri, 24 Mar 2017 06:08:56 +0000
Aspect ratio patch MozReview-Commit-ID: BRljeUNHg98
8bb524f55e3e80fbd4b6166c2d753fc173ab7a6f: Throttle grid highlight event draft
Micah Tigley <tigleym@gmail.com> - Thu, 23 Mar 2017 22:58:26 -0600 - rev 504306
Push 50775 by bmo:tigleym@gmail.com at Fri, 24 Mar 2017 06:08:56 +0000
Throttle grid highlight event MozReview-Commit-ID: EGzJXFdnLzH
1e2938a5f78d06c9a93f91e75357d4f940cd177b: Bug 1339004 - Do DocGroup labeling in dom/security draft
Thomas Nguyen <tnguyen@mozilla.com> - Wed, 22 Mar 2017 10:56:35 +0800 - rev 504305
Push 50774 by bmo:tnguyen@mozilla.com at Fri, 24 Mar 2017 06:03:32 +0000
Bug 1339004 - Do DocGroup labeling in dom/security MozReview-Commit-ID: 92LLqMOeTmF
da343a4f912a1af31963c6e43a554a326bc7dcf2: Bug 1343754 - Label PLayerTransaction. r?bevistseng, kats draft
Kevin Chen <kechen@mozilla.com> - Tue, 21 Mar 2017 03:57:56 +0000 - rev 504304
Push 50773 by bmo:kechen@mozilla.com at Fri, 24 Mar 2017 05:56:02 +0000
Bug 1343754 - Label PLayerTransaction. r?bevistseng, kats MozReview-Commit-ID: 7hgt9dqzbyq
14a242081204d081dac15e57c7011f395e1b9498: Bug 1343754 - Label PTexture. r?bevistseng, kats draft
Kevin Chen <kechen@mozilla.com> - Tue, 21 Mar 2017 03:57:56 +0000 - rev 504303
Push 50773 by bmo:kechen@mozilla.com at Fri, 24 Mar 2017 05:56:02 +0000
Bug 1343754 - Label PTexture. r?bevistseng, kats MozReview-Commit-ID: 1PnDEQvz9FK
8845613f92c427957ae268a71ebeaacfb71b92d3: Bug 1349989: Correctly handle errors for OMT-compiled scripts. r?shu draft
Kris Maglione <maglione.k@gmail.com> - Thu, 23 Mar 2017 22:13:07 -0700 - rev 504302
Push 50772 by maglione.k@gmail.com at Fri, 24 Mar 2017 05:32:31 +0000
Bug 1349989: Correctly handle errors for OMT-compiled scripts. r?shu MozReview-Commit-ID: 3FpoUmu9ijI
f2eebe34cd1aa205570f0ff30734c3f0a8cab705: Bug 1346607: Follow-up: Fix intermittent failure on Windows. r=me
Kris Maglione <maglione.k@gmail.com> - Thu, 23 Mar 2017 21:18:42 -0700 - rev 504301
Push 50772 by maglione.k@gmail.com at Fri, 24 Mar 2017 05:32:31 +0000
Bug 1346607: Follow-up: Fix intermittent failure on Windows. r=me MozReview-Commit-ID: 9tfJ4ekq7BR
dda3d09783a5b5fe61c6591aa53d77105147b123: Bug 1348442: Part 4 - Remove support for synchronously loading localized extension CSS. r=jdm
Kris Maglione <maglione.k@gmail.com> - Fri, 17 Mar 2017 16:46:59 -0700 - rev 504300
Push 50772 by maglione.k@gmail.com at Fri, 24 Mar 2017 05:32:31 +0000
Bug 1348442: Part 4 - Remove support for synchronously loading localized extension CSS. r=jdm After switching to loading content stylesheets asynchronously, there are no longer any consumers that require a synchronous channel to load localized CSS, so these workarounds are no longer necessary. MozReview-Commit-ID: AwLSmYf9qL3
9b0898770b8f174f9edeca40267348801fa23a02: Bug 1348442: Part 3 - Do not evict cached stylesheets while they're still being used by extant documents. r=aswan
Kris Maglione <maglione.k@gmail.com> - Sat, 18 Mar 2017 16:07:58 -0700 - rev 504299
Push 50772 by maglione.k@gmail.com at Fri, 24 Mar 2017 05:32:31 +0000
Bug 1348442: Part 3 - Do not evict cached stylesheets while they're still being used by extant documents. r=aswan There are some optimizations, both existing and under way, that allow us to share some stylesheet data between documents that they're loaded into. Keeping cached sheets around as long as they're still in use should be a net memory savings. MozReview-Commit-ID: HUZzs6HhuFM
02ffd84b3a0bc6f250eae27af8ec3e67b92113b5: Bug 1348442: Part 2c - Refactor Script class into ES6 class. r=aswan
Kris Maglione <maglione.k@gmail.com> - Sat, 18 Mar 2017 15:19:29 -0700 - rev 504298
Push 50772 by maglione.k@gmail.com at Fri, 24 Mar 2017 05:32:31 +0000
Bug 1348442: Part 2c - Refactor Script class into ES6 class. r=aswan MozReview-Commit-ID: Dtci1mfQts0
963bf8bab6e76ac7993af424088d8d7315475fa6: Bug 1348442: Part 2b - Add getWinUtils helper. r=aswan
Kris Maglione <maglione.k@gmail.com> - Sat, 18 Mar 2017 15:16:16 -0700 - rev 504297
Push 50772 by maglione.k@gmail.com at Fri, 24 Mar 2017 05:32:31 +0000
Bug 1348442: Part 2b - Add getWinUtils helper. r=aswan MozReview-Commit-ID: 9vvCbYovyoN
0b89dcab1adaaf2fdd7a4d1d3a83c0ca58620e5e: Bug 1348442: Part 2a - Asynchronously load and cache content script CSS. r=aswan
Kris Maglione <maglione.k@gmail.com> - Thu, 23 Mar 2017 18:51:38 -0700 - rev 504296
Push 50772 by maglione.k@gmail.com at Fri, 24 Mar 2017 05:32:31 +0000
Bug 1348442: Part 2a - Asynchronously load and cache content script CSS. r=aswan MozReview-Commit-ID: 1BzLNbdXMfU
d5b7156ec45f277a225608c1e719cbb946850527: Bug 1348442: Part 1 - Allow loading preloaded stylesheets asynchronously. r=heycam
Kris Maglione <maglione.k@gmail.com> - Sun, 19 Mar 2017 19:33:49 -0700 - rev 504295
Push 50772 by maglione.k@gmail.com at Fri, 24 Mar 2017 05:32:31 +0000
Bug 1348442: Part 1 - Allow loading preloaded stylesheets asynchronously. r=heycam These changes allow us to asynchronously load pre-loaded stylesheets, in a way that's similar to ChromeUtils.compileScript. The new method returns a Promise which resolves to the preloaded sheet once it's finished loading. This will allow us to remove the last remaining use of synchronous channels in moz-extension: URLs. MozReview-Commit-ID: 7J52ff93YKT
596faf466bbc07412cfa2277ef4d233c748fc233: Bug 1349138 Edit transactions should store their editor instance with strong reference r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Tue, 21 Mar 2017 19:00:36 +0900 - rev 504294
Push 50772 by maglione.k@gmail.com at Fri, 24 Mar 2017 05:32:31 +0000
Bug 1349138 Edit transactions should store their editor instance with strong reference r=smaug Edit transactions should store their editor instance with strong reference and they should be released at destroying the editor. MozReview-Commit-ID: D67KU8WFxyo
b5c478da01df453d8e8630f98558f5500548298e: Bug 1315850 - Ask the GMPService for the GMP thread in GMPParent::ChildTerminated. r=gerald
Chris Pearce <cpearce@mozilla.com> - Fri, 24 Mar 2017 13:38:00 +1300 - rev 504293
Push 50772 by maglione.k@gmail.com at Fri, 24 Mar 2017 05:32:31 +0000
Bug 1315850 - Ask the GMPService for the GMP thread in GMPParent::ChildTerminated. r=gerald When we shutdown the browser while the GMPService is active we can end up leaking a GMPParent, GeckoMediaPluginServiceParent, and a Runnable. I tracked this down to the runnable dispatched to the GMP thread in GMPParent::ChildTerminated(). The dispatch of this runnable is failing as we are dispatching the runnable to a reference of the GMP thread which we have previously acquired, but that thread is now shutdown. So the dispatch fails, and if you look in nsThread::DispatchInternal() you'll see that we deliberately leak the runnable if dispatch fails! The runnable leaking means that the references it holds to the GMPParent and the GMP service parent leak. The solution in this patch is to not cache a reference to the GMP thread on the GMPParent; instead we re-request the GMP thread from the GMPService when we want it. This means that in the case where the browser is shutting down, GMPParent::GMPThread() will return null, and we'll not leak the runnable. We'll then follow the (hacky) shutdown path added in bug 1163239. We also need to change GMPParent::GMPThread() and GMPContentParent::GMPThread() to return a reference to the GMP thread with a refcount held on it, in order to ensure we don't race with the GMP service shutting down the GMP thread while we're trying to dispatch to in on shutdown. MozReview-Commit-ID: CXv9VZqTRzY
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip