0c3a8cce555ecbe06db471c86b7a2775dc283d0c: Bug 1373650. Unteach CustomizableUI about the Report Site Issue button. r=gijs draft
Mike Taylor <miket@mozilla.com> - Thu, 03 Aug 2017 16:17:16 -0500 - rev 620763
Push 72142 by bmo:miket@mozilla.com at Thu, 03 Aug 2017 21:26:11 +0000
Bug 1373650. Unteach CustomizableUI about the Report Site Issue button. r=gijs MozReview-Commit-ID: BGDIpD32sUi
aa59366e04285861ca92df7245748afd7cd6364c: Bug 1373650. Update Report Site Issue button tests. r=gijs draft
Mike Taylor <miket@mozilla.com> - Thu, 03 Aug 2017 15:35:21 -0500 - rev 620762
Push 72142 by bmo:miket@mozilla.com at Thu, 03 Aug 2017 21:26:11 +0000
Bug 1373650. Update Report Site Issue button tests. r=gijs MozReview-Commit-ID: IFNvarOrYtc
5fa6caeaedc83b79eb95add7837503c53f1b4b4c: Bug 1373650. Remove TabListener.jsm from browser_startup.js. r=gijs draft
Mike Taylor <miket@mozilla.com> - Thu, 03 Aug 2017 15:17:41 -0500 - rev 620761
Push 72142 by bmo:miket@mozilla.com at Thu, 03 Aug 2017 21:26:11 +0000
Bug 1373650. Remove TabListener.jsm from browser_startup.js. r=gijs It no longer exists after moving the Report Site Issue button to the PageAction API. MozReview-Commit-ID: 83z6pqwR4z
d2bca055a043cf3039b695d48913c5f606817c1b: Bug 1373650. Move Report Site Issue button from CUI to PageActions API. r=gijs draft
Mike Taylor <miket@mozilla.com> - Thu, 03 Aug 2017 15:15:40 -0500 - rev 620760
Push 72142 by bmo:miket@mozilla.com at Thu, 03 Aug 2017 21:26:11 +0000
Bug 1373650. Move Report Site Issue button from CUI to PageActions API. r=gijs MozReview-Commit-ID: ImBDGZDSXuH
6a821c00c87b46891352ab9291ee457a614f68e4: Bug 1373650. Dont throw if optional Action.onPlacedInPanel is undefined. r=gijs draft
Mike Taylor <miket@mozilla.com> - Thu, 03 Aug 2017 14:01:45 -0500 - rev 620759
Push 72142 by bmo:miket@mozilla.com at Thu, 03 Aug 2017 21:26:11 +0000
Bug 1373650. Dont throw if optional Action.onPlacedInPanel is undefined. r=gijs MozReview-Commit-ID: JregcgjzxaR
33ca8807bddee0b3a17e285c8ed6d2331e6540b1: Bug 1386920 - Use a versioned dependency on GCC to build clang. r=gps
Mike Hommey <mh+mozilla@glandium.org> - Thu, 03 Aug 2017 12:24:41 +0900 - rev 620758
Push 72142 by bmo:miket@mozilla.com at Thu, 03 Aug 2017 21:26:11 +0000
Bug 1386920 - Use a versioned dependency on GCC to build clang. r=gps The lesson learned from bug 1356926 and bug 1386588 is that the version of gcc used to build clang matters, and that we can't bind the version we use to build clang to the version we use to build Firefox.
aabe4d6900bc84a94e8b0120cfa490d2af86e5dd: Bug 1386589 - Remove the linux64 tooltool manifests that look the same as releng.manifest. r=gps
Mike Hommey <mh+mozilla@glandium.org> - Wed, 02 Aug 2017 20:06:10 +0900 - rev 620757
Push 72142 by bmo:miket@mozilla.com at Thu, 03 Aug 2017 21:26:11 +0000
Bug 1386589 - Remove the linux64 tooltool manifests that look the same as releng.manifest. r=gps
24041731b278c34c0b76c1223cb79958cb849d18: Bug 1356926 - Enable stylo on static analysis builds. r=gps
Mike Hommey <mh+mozilla@glandium.org> - Wed, 02 Aug 2017 19:58:59 +0900 - rev 620756
Push 72142 by bmo:miket@mozilla.com at Thu, 03 Aug 2017 21:26:11 +0000
Bug 1356926 - Enable stylo on static analysis builds. r=gps
2a497555fda7695733f438131674ab72e985b89f: Bug 1356926 - Use the same clang as normal builds for static analysis. r=gps
Mike Hommey <mh+mozilla@glandium.org> - Wed, 02 Aug 2017 19:57:24 +0900 - rev 620755
Push 72142 by bmo:miket@mozilla.com at Thu, 03 Aug 2017 21:26:11 +0000
Bug 1356926 - Use the same clang as normal builds for static analysis. r=gps In practice, this upgrades from clang 3.8 to 3.9.
721b953ccc76287a94a1b787025127c5c0644eae: Bug 1356926 - Make all stdc++compat symbols weak. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Thu, 03 Aug 2017 11:52:24 +0900 - rev 620754
Push 72142 by bmo:miket@mozilla.com at Thu, 03 Aug 2017 21:26:11 +0000
Bug 1356926 - Make all stdc++compat symbols weak. r=froydnj In some cases, we can end up linking some things with --static-libstdc++. The notable (only?) example of that is for the clang-plugin, and that happens because it gets some of its flags from llvm-config, which contains --static-libstdc++ because clang itself is built that way. When that happens, the combination of --static-libstdc++ and stdc++compat breaks the build because they have conflicting symbols, which is very much by design. There are two ways out of this: - avoiding either -static-libstdc++ or stdc++compat - work around the symbol conflicts The former is not totally reliable ; we'd have to accurately determine if we're in a potentially conflicting case, and remove one of the two in that case, and while we can do that for the cases we explicitly know about, that's not future-proof, and might fail just as much in the future. So we go with the latter. The way we do this is by defining all the std++compat symbols weak, such that at link time, they're overridden by any symbol with the same name. When building with -static-libstdc++, libstdc++.a provides those symbols so the linker eliminates the weak ones. When not building with -static-libstdc++, the linker keeps the symbols from stdc++compat. That last assertion is validated by the long-standing CHECK_STDCXX test that we run when linking shared libraries and programs. That still leaves the symbols weak in the final shared libraries/programs, which is a change from the current setup, but shouldn't cause problems because when using versions of libstdc++.so that do provide those symbols, it's fine to use the libstdc++.so version anyways.
7290c51efe988249a66137d81ede29ae6c62e695: Bug 1386411 - Part 7: Inline EditorBase::GetSelection(); r=masayuki
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 01 Aug 2017 19:51:25 -0400 - rev 620753
Push 72142 by bmo:miket@mozilla.com at Thu, 03 Aug 2017 21:26:11 +0000
Bug 1386411 - Part 7: Inline EditorBase::GetSelection(); r=masayuki
17155d1c2ca71ef2e3a21254f4dbeae52a0b99e8: Bug 1386411 - Part 6: Add a more efficient nsISelectionController::GetSelection() API for retrieving native Selection objects; r=bzbarsky
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 01 Aug 2017 19:50:50 -0400 - rev 620752
Push 72142 by bmo:miket@mozilla.com at Thu, 03 Aug 2017 21:26:11 +0000
Bug 1386411 - Part 6: Add a more efficient nsISelectionController::GetSelection() API for retrieving native Selection objects; r=bzbarsky This API avoids needless refcounting and QueryInterface overhead.
f570c6739e48f9c519cf011fb730b717192e13f9: Bug 1386411 - Part 5: Make BaseEditor::GetSelectionController() return nsISelectionController*, and inline it; r=masayuki
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 01 Aug 2017 18:56:02 -0400 - rev 620751
Push 72142 by bmo:miket@mozilla.com at Thu, 03 Aug 2017 21:26:11 +0000
Bug 1386411 - Part 5: Make BaseEditor::GetSelectionController() return nsISelectionController*, and inline it; r=masayuki This method can be extremely hot, so we need to remove all sources of XPCOM overhead from it. This includes the usages of weak pointers (thanks to the previous parts), refcounting, and QueryInterface. I kept the callers hold the selection controller alive by assigning the return value to an nsCOMPtr in places where the methods called on it could have a remote chance of messing with the lifetime of objects.
cb876b926c3221a3ce0b8e617b1442fb355cbf0a: Bug 1386411 - Part 4: Don't store the document as a weak reference on EditorBase; r=masayuki
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 01 Aug 2017 18:30:49 -0400 - rev 620750
Push 72142 by bmo:miket@mozilla.com at Thu, 03 Aug 2017 21:26:11 +0000
Bug 1386411 - Part 4: Don't store the document as a weak reference on EditorBase; r=masayuki This one also doesn't need to be a weak reference, and can be a strong reference that the cycle collector knows about instead.
99684f0b3ed66b52681016e77a585d90165ed332: Bug 1386411 - Part 3: Inline some helper functions in Selection.cpp; r=bzbarsky
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 01 Aug 2017 17:19:19 -0400 - rev 620749
Push 72142 by bmo:miket@mozilla.com at Thu, 03 Aug 2017 21:26:11 +0000
Bug 1386411 - Part 3: Inline some helper functions in Selection.cpp; r=bzbarsky
61b7d37ac269656ffc7ba33380c0b0ecb897c7e3: Bug 1386411 - Part 2: Devirtualize and inline nsISelection::AsSelection(); r=bzbarsky
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 01 Aug 2017 17:12:57 -0400 - rev 620748
Push 72142 by bmo:miket@mozilla.com at Thu, 03 Aug 2017 21:26:11 +0000
Bug 1386411 - Part 2: Devirtualize and inline nsISelection::AsSelection(); r=bzbarsky nsISelection is builtinclass, so this method doesn't need to be virtual.
8e16aa741451f0298f93028a20823430a3b9aa7f: Bug 1386411 - Part 1: Don't store the selection controller as a weak reference on EditorBase; r=masayuki
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 01 Aug 2017 17:00:50 -0400 - rev 620747
Push 72142 by bmo:miket@mozilla.com at Thu, 03 Aug 2017 21:26:11 +0000
Bug 1386411 - Part 1: Don't store the selection controller as a weak reference on EditorBase; r=masayuki This doesn't need to be a weak reference, and can instead be a simple strong reference that we introduce to the cycle collector.
ff89a15be29818c44e9d73946e472018ee5093fa: Bug 1386468 - Only register SelectionChangeListener for plaintext controls when dom.select_events.textcontrols.enabled is turned on; r=mystor
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 01 Aug 2017 20:27:24 -0400 - rev 620746
Push 72142 by bmo:miket@mozilla.com at Thu, 03 Aug 2017 21:26:11 +0000
Bug 1386468 - Only register SelectionChangeListener for plaintext controls when dom.select_events.textcontrols.enabled is turned on; r=mystor
fc1d502dc1eafd53d5aecec1feac663e25104c74: Bug 1383916 Prep a DrawTarget to be drawn to on the paint thread. r=dvander
Mason Chang <mchang@mozilla.com> - Thu, 03 Aug 2017 08:50:32 -0700 - rev 620745
Push 72142 by bmo:miket@mozilla.com at Thu, 03 Aug 2017 21:26:11 +0000
Bug 1383916 Prep a DrawTarget to be drawn to on the paint thread. r=dvander
2b92f175ff7a4583d4d00190d6f64e466bf04889: Bug 1386997 - Log both URL and source file when we can't find a mapped file. r=chmanchester
Marco Castelluccio <mcastelluccio@mozilla.com> - Thu, 03 Aug 2017 11:44:14 +0200 - rev 620744
Push 72142 by bmo:miket@mozilla.com at Thu, 03 Aug 2017 21:26:11 +0000
Bug 1386997 - Log both URL and source file when we can't find a mapped file. r=chmanchester
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip