0c03c2ddda3a4e58295c9f3e1670237cd8b75fb9: Bug 1317588 Part 5 - Change Side's operator++ from postfix to prefix. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Wed, 23 Nov 2016 16:55:04 +0800 - rev 443538
Push 37019 by bmo:jsnajdr@gmail.com at Thu, 24 Nov 2016 16:10:05 +0000
Bug 1317588 Part 5 - Change Side's operator++ from postfix to prefix. r=mats The postfix operator++ was actually incorrectly implemented as a prefix version. Since it's only used in NS_FOR_CSS_SIDES, let's changed it to prefix version. MozReview-Commit-ID: GbdB2ZC9KyW
88f2c7f0a24a5d7e1f82769ae24aed5c0cf9bed7: Bug 1317588 Part 4 - Remove side bits defined in BorderConsts.h r=mats
Ting-Yu Lin <tlin@mozilla.com> - Mon, 21 Nov 2016 11:56:35 +0800 - rev 443537
Push 37019 by bmo:jsnajdr@gmail.com at Thu, 24 Nov 2016 16:10:05 +0000
Bug 1317588 Part 4 - Remove side bits defined in BorderConsts.h r=mats Those bits are already defined as enum in gfx/2d/Types.h. MozReview-Commit-ID: 8E81lW9WnAg
1710e2f930dbd5b32aa5f126ab031c8353a73523: Bug 1317588 Part 3 - Remove #define NS_SIDE_TOP/RIGHT/BOTTOM/LEFT. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Fri, 18 Nov 2016 18:12:25 +0800 - rev 443536
Push 37019 by bmo:jsnajdr@gmail.com at Thu, 24 Nov 2016 16:10:05 +0000
Bug 1317588 Part 3 - Remove #define NS_SIDE_TOP/RIGHT/BOTTOM/LEFT. r=mats This patch was written with the help of the following script. Also, manually add mozilla qualifier to the enum values in nsStyleCoord.h, gfxRect.h, and Types.h to make it build. function rename() { find .\ -type f\ ! -path "./obj*"\ ! -path "./.git"\ ! -path "./.hg"\ \( -name "*.cpp" -or\ -name "*.h" \)\ -exec sed -i -e "s/$1/$2/g" "{}" \; } rename "NS_SIDE_TOP" "eSideTop" rename "NS_SIDE_RIGHT" "eSideRight" rename "NS_SIDE_BOTTOM" "eSideBottom" rename "NS_SIDE_LEFT" "eSideLeft" MozReview-Commit-ID: 9T0ORsqM6nP
60506dc6f798fde3715897564930ce5b2dcf5ed8: Bug 1317588 Part 2 - Remove mozilla::css::Side typedef. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Fri, 18 Nov 2016 16:28:38 +0800 - rev 443535
Push 37019 by bmo:jsnajdr@gmail.com at Thu, 24 Nov 2016 16:10:05 +0000
Bug 1317588 Part 2 - Remove mozilla::css::Side typedef. r=mats This patch is written with the help of the following script. function rename() { find .\ -type f\ ! -path "./obj*"\ ! -path "./.git"\ ! -path "./.hg"\ \( -name "*.cpp" -or\ -name "*.h" \)\ -exec sed -i -e "s/$1/$2/g" "{}" \; } rename "css::Side" "Side" MozReview-Commit-ID: DPV6vivpPUp
aceab4673889e2575c25bb5910a9784b2a8e1d1d: Bug 1317588 Part 1 - Move NS_FOR_CSS_SIDES and operator++ to gfx/2d/Types.h. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Fri, 18 Nov 2016 15:25:33 +0800 - rev 443534
Push 37019 by bmo:jsnajdr@gmail.com at Thu, 24 Nov 2016 16:10:05 +0000
Bug 1317588 Part 1 - Move NS_FOR_CSS_SIDES and operator++ to gfx/2d/Types.h. r=mats Make them live with the definition of enum Side. MozReview-Commit-ID: 5uJPxFPOj79
d9b26b438895944ea6764976577436383de9e23d: Bug 1319667 - Part 3. Test case for mask longhands on svg element. r=mstange
cku <cku@mozilla.com> - Wed, 23 Nov 2016 14:02:07 +0800 - rev 443533
Push 37019 by bmo:jsnajdr@gmail.com at Thu, 24 Nov 2016 16:10:05 +0000
Bug 1319667 - Part 3. Test case for mask longhands on svg element. r=mstange MozReview-Commit-ID: HF1NiNPfzQs
3ab240e653d884b2e4df2263a78bf3adf81db317: Bug 1319667 - Part 2. Move DrawResult from function parameter of PaintClipMask to the return value. r=mstange
cku <cku@mozilla.com> - Thu, 24 Nov 2016 00:08:13 +0800 - rev 443532
Push 37019 by bmo:jsnajdr@gmail.com at Thu, 24 Nov 2016 16:10:05 +0000
Bug 1319667 - Part 2. Move DrawResult from function parameter of PaintClipMask to the return value. r=mstange Enlight by "Bug 1314536 - Part 1" MozReview-Commit-ID: Iogdh7LWsWa
464230532ba3c56157be845ac68f4c79b686cd60: Bug 1319667 - Part 1. Allow mask longhands apply to SVG elements. r=mstange
cku <cku@mozilla.com> - Wed, 23 Nov 2016 13:51:36 +0800 - rev 443531
Push 37019 by bmo:jsnajdr@gmail.com at Thu, 24 Nov 2016 16:10:05 +0000
Bug 1319667 - Part 1. Allow mask longhands apply to SVG elements. r=mstange Originally, we use the follwoing statement to determine whether generate mask for an SVG element: aUsage.shouldGenerateMaskLayer = maskFrames.Length() == 1 && maskFrames[0]; maskFrames[0] is not null only if that mask resource is an SVG-mask. That means we will not generate mask for image mask to any SVG one. MozReview-Commit-ID: 4QiifC6J0UR
ac16df8810f60d0bd4514b5d4975e63e7004e3ce: Bug 1319686 - Remove the use of AutoNoJSAPI from HTMLMediaElement::NotifyAudioChannelAgent r=jwwang
Kilik Kuo <kikuo@mozilla.com> - Wed, 23 Nov 2016 18:16:31 +0800 - rev 443530
Push 37019 by bmo:jsnajdr@gmail.com at Thu, 24 Nov 2016 16:10:05 +0000
Bug 1319686 - Remove the use of AutoNoJSAPI from HTMLMediaElement::NotifyAudioChannelAgent r=jwwang MozReview-Commit-ID: FMKloJPpT93
809655f44e1988e72f4efb0f7ccb22b64a8f8a4d: Bug 1318586 - Adjust OpenVR controller button mapping to be consistency; r=kip
Daosheng Mu <daoshengmu@gmail.com> - Fri, 18 Nov 2016 16:36:51 +0800 - rev 443529
Push 37019 by bmo:jsnajdr@gmail.com at Thu, 24 Nov 2016 16:10:05 +0000
Bug 1318586 - Adjust OpenVR controller button mapping to be consistency; r=kip MozReview-Commit-ID: 6ODcMjqYQNP
36a118cbe8155070604735f80e81088ce1df7828: Bug 1301708 - nsWindow::DealWithPopup() should do nothing at receiving WM_ACTIVATE for a popup window and its wParam includes WA_CLICKACTIVATE. r=masayuki
Stone Shih <sshih@mozilla.com> - Thu, 10 Nov 2016 16:09:25 +0800 - rev 443528
Push 37019 by bmo:jsnajdr@gmail.com at Thu, 24 Nov 2016 16:10:05 +0000
Bug 1301708 - nsWindow::DealWithPopup() should do nothing at receiving WM_ACTIVATE for a popup window and its wParam includes WA_CLICKACTIVATE. r=masayuki When the first time user clicks download panel popup to hide the drop marker popup, Windows fires WA_ACTIVATE with wParam includes WA_CLICKACTIVATE to the download panel. In that case the popupWindow is the drop marker. We shouldn't roll up popups by handling WA_ACTIVATE since we'll handle the rollup behavior with WM_LBUTTONDOWN message. MozReview-Commit-ID: 43jCgdBjjUN
120c84ca53629202c22cce565053fee7973eea72: Bug 1319302 - RTL support for Firefox for Android, r=sebastian
maliu <max@mxli.us> - Fri, 11 Nov 2016 16:10:21 +0800 - rev 443527
Push 37019 by bmo:jsnajdr@gmail.com at Thu, 24 Nov 2016 16:10:05 +0000
Bug 1319302 - RTL support for Firefox for Android, r=sebastian MozReview-Commit-ID: bKzW07YBDy
085baebf9e4aebb4e57d5088df9152c490232806: Bug 1317178 - Pass the property name to Servo_DeclarationBlock_SerializeOneValue. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Tue, 22 Nov 2016 19:18:18 +0800 - rev 443526
Push 37019 by bmo:jsnajdr@gmail.com at Thu, 24 Nov 2016 16:10:05 +0000
Bug 1317178 - Pass the property name to Servo_DeclarationBlock_SerializeOneValue. r=birtles In order to use single_value_to_css() in Servo_DeclarationBlock_SerializeOneValue(), we need to pass the property name and a flag for custom properties. MozReview-Commit-ID: 5HfI2qOmPwP
65643222e76c6dfa3560d3d4165d603495ea25e7: Bug 1319790 - add assertions to detect if MediaDecoder is deleted without Shutdown() being called. r=kaku
JW Wang <jwwang@mozilla.com> - Thu, 24 Nov 2016 11:59:18 +0800 - rev 443525
Push 37019 by bmo:jsnajdr@gmail.com at Thu, 24 Nov 2016 16:10:05 +0000
Bug 1319790 - add assertions to detect if MediaDecoder is deleted without Shutdown() being called. r=kaku Also call mResourceCallback->Disconnect() in the destructor in case Shutdown() is not called to avoid dangling pointer. MozReview-Commit-ID: 1qV4m8nWlGq
5d0c5c2ee7625c745269a8f9cccf00e562afcfba: Bug 1319357 - clean up media elements when media tests are done. r=jya
JW Wang <jwwang@mozilla.com> - Tue, 22 Nov 2016 17:02:08 +0800 - rev 443524
Push 37019 by bmo:jsnajdr@gmail.com at Thu, 24 Nov 2016 16:10:05 +0000
Bug 1319357 - clean up media elements when media tests are done. r=jya MozReview-Commit-ID: GHJAwxR50AG
e00b256c87a539e9f9ede45904b9043a9cc6b8f3: Bug 1319698 - Remove MediaDecoderReader::SetIdle(). r=jya
JW Wang <jwwang@mozilla.com> - Wed, 23 Nov 2016 17:30:31 +0800 - rev 443523
Push 37019 by bmo:jsnajdr@gmail.com at Thu, 24 Nov 2016 16:10:05 +0000
Bug 1319698 - Remove MediaDecoderReader::SetIdle(). r=jya MozReview-Commit-ID: ArGqum1MSIO
0390e208038169bbdfa832155bef6359af4775fa: Bug 1316215 - Merge SelectGMP and LaunchGMP into one synchronous IPC operation. r=gerald
Chris Pearce <cpearce@mozilla.com> - Tue, 22 Nov 2016 14:17:59 +1300 - rev 443522
Push 37019 by bmo:jsnajdr@gmail.com at Thu, 24 Nov 2016 16:10:05 +0000
Bug 1316215 - Merge SelectGMP and LaunchGMP into one synchronous IPC operation. r=gerald We were seeing almost permaorange failures in the WebRTC H.264/GMP tests due to the GMP being shutdown in the parent process in between the content process performing an OOP select operation and then performing an OOP launch operation. That is, in GeckoMediaPluginServiceChild::GetContentParent() in between the SendSelectGMP completing and the SendLaunchGMP completing, the GMP would shutdown and so when the launch operation ran in the main process it would fail. The select and launch are seperate operations so that the crash handler can be reported to the content process and an association can be made in the content process between the plugin ID and the crash helper before we try to launch the GMP. This is so that if the GMP crashes on startup, we're ready to handle the crash. However it turns out that if the GMP crashes on startup, the crash report message comes in after another round of the event/IPC message loop. So we actually do have time in the content process to connect the crash helper after the launch fails. So in order to fix the problem of the GMP shutting down in between select and launch, we can partially revert the changes I made in Bug 1267918 to merge selecting and launching GMPs back into a single operation. MozReview-Commit-ID: 5n4T1Gqlvr3
efff1ff587e32ef436efe95ef3153b44ff0ab1a5: Bug 1316215 - Make GMPParent::IsUsed() take into account whether there are pending GetContentParent calls. r=gerald
Chris Pearce <cpearce@mozilla.com> - Fri, 18 Nov 2016 12:37:14 +1300 - rev 443521
Push 37019 by bmo:jsnajdr@gmail.com at Thu, 24 Nov 2016 16:10:05 +0000
Bug 1316215 - Make GMPParent::IsUsed() take into account whether there are pending GetContentParent calls. r=gerald In a similar vein to the previous patch, while we're waiting on a GetContentParent promise to resolve, we don't want the GMPParent to shutdown. So make IsUsed() check whether we're waiting on a GetContentParent promise to resolve, so we don't pull the rug out from under any code waiting to get a content parent to bridge a GMP. MozReview-Commit-ID: 8cTCuXLXMsK
4be3169b9d0257f3e0182dd1ad5d60a9a98eef48: Bug 1316215 - Block GMPContentParent close while a GMPService::GetContentParent is being processed. r=gerald
Chris Pearce <cpearce@mozilla.com> - Wed, 16 Nov 2016 10:59:08 +1300 - rev 443520
Push 37019 by bmo:jsnajdr@gmail.com at Thu, 24 Nov 2016 16:10:05 +0000
Bug 1316215 - Block GMPContentParent close while a GMPService::GetContentParent is being processed. r=gerald When GMPService::GetContentParent returns a MozPromise, we end up failing in test_peerConnection_scaleResolution.html with e10s enabled because we Close() the GMPContentParent twice. The test causes two GMPVideoEncoderParents to be created. When the number of IPDL actors on the GMPContentParent reach 0, we close the IPC connection. With GetContentParent() returning a MozPromise, it's more async, and so we can end up requesting the content parent in order to create the second GMPVideoEncoderParent, but while we're waiting for the promise to resolve the previous GMPVideoEncoderParent is destroyed and the GMPContentParent closes its IPC connection. Then the GetContentParent promise resolves, and that fails to operate correctly since it's closed its IPC connection. My solution here is to add a "blocker" that prevents the GMPContentParent from being shutdown while we're waiting for the GetContentParent promise to resolve. MozReview-Commit-ID: HxBkFkmv0tV
cb29571e849184f019cf7343afb0ac6d36fa0e11: Bug 1316215 - Promisify GMPService GetGMPContentParent and GetServiceChild. r=gerald
Chris Pearce <cpearce@mozilla.com> - Wed, 09 Nov 2016 15:52:22 +1300 - rev 443519
Push 37019 by bmo:jsnajdr@gmail.com at Thu, 24 Nov 2016 16:10:05 +0000
Bug 1316215 - Promisify GMPService GetGMPContentParent and GetServiceChild. r=gerald MozReview-Commit-ID: 5ydGmZWGzWG
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip