0a92949c536631f98a969f6e02f7ebe2c30154c7: testing: decompress xz archives locally
Gregory Szorc <gps@mozilla.com> - Fri, 05 Feb 2016 16:53:11 -0800 - rev 362223
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
testing: decompress xz archives locally Docker 1.10 can no longer import .tar.xz archives directly. Not sure if this is intentional or a regression. Work around it either way.
9c3f1dd2eaf18f50a30d933b8d6561af54f2c2ff: testing: remove screenshot and log from test-autoland-inbound.py
Dan Minor <dminor@mozilla.com> - Fri, 05 Feb 2016 16:01:03 -0500 - rev 362222
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
testing: remove screenshot and log from test-autoland-inbound.py
f101eefdb703105c7e3538e7332cb3a596679504: mozreview: Move settings out of the MozReviewExtension.settings object into a custom dict (bug 1245524) r=gps
Dan Minor <dminor@mozilla.com> - Thu, 04 Feb 2016 11:14:27 -0500 - rev 362221
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: Move settings out of the MozReviewExtension.settings object into a custom dict (bug 1245524) r=gps This moves everything out the settings object into an external json file. Not everything here is secret, so some of this can probably migrate back into an admin page, but that is best handled by follow on bugs.
dba9648638d5ec2afa1ed6c32df7778fc5014ae0: reviewboard: store commit ID in commit messages instead of extras (bug 1243486); r=dminor
Gregory Szorc <gps@mozilla.com> - Fri, 05 Feb 2016 12:38:18 -0800 - rev 362220
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
reviewboard: store commit ID in commit messages instead of extras (bug 1243486); r=dminor Storing the commit ID in extras was littered with problems. First, the ID wasn't always available from data that Review Board had access to (it sees the commit message but not the extras by default). Second, Mercurial doesn't always preserve extras, as the existing `hg graft` test demonstrated. While there wasn't a test for it, I believe MQ dropped the custom extras entry as well. Third, Git stores the commit ID in the commit message. Both implementations should be consistent to make logic using the commit IDs simpler. This commit moves the commit ID storage from extras to the commit message. Because we changed the content of the commit, SHA-1s change. This resulted in massive test fallout. Most of the changes were basic overwrites of the new SHA-1. Some test commands referenced SHA-1s and these needed updated. In a few cases, uses of `hg commit --amend -m` had to define the commit ID manually to carry it over so a new one wasn't generated on next use of the changeset. The old code for installing a hacked up "rebase" command that preserves extras has been removed. MozReview-Commit-ID: 1WyO65ojxuv
eef5eefc3b2c015a517e1f9e7b53159ac15a2524: mozreview: strip commit metadata from Bugzilla descriptions (bug 1243486); r=dminor
Gregory Szorc <gps@mozilla.com> - Fri, 05 Feb 2016 12:12:52 -0800 - rev 362219
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: strip commit metadata from Bugzilla descriptions (bug 1243486); r=dminor We don't want to litter the Bugzilla descriptions with metadata that isn't relevant to Bugzilla. Strip it. MozReview-Commit-ID: 4rjBfMdpHUF
1af421167a356a8d008529139ad791dd00a3655a: mozautomation: function to strip commit metadata from string (bug 1243486); r=dminor
Gregory Szorc <gps@mozilla.com> - Tue, 02 Feb 2016 13:03:04 -0800 - rev 362218
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozautomation: function to strip commit metadata from string (bug 1243486); r=dminor We want to strip MozReview-Commit-ID and potentially other future metadata from Bugzilla attachment descriptions to cut down on spam. Establish a resuable function for performing the strip. MozReview-Commit-ID: 7eWSjgyjEbp
eb9e43ce04570bc08cfb4bd08f0b9ddbe0fe79c9: reviewboard: move commit message rewriting function into library (bug 1243486); r=dminor
Gregory Szorc <gps@mozilla.com> - Tue, 02 Feb 2016 13:01:51 -0800 - rev 362217
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
reviewboard: move commit message rewriting function into library (bug 1243486); r=dminor This will enable us to use the function from the Mercurial extension. MozReview-Commit-ID: 4Lggkt0kaJL
7a58b51b386c82e76304ff9bba093b7ec86e3bd9: mozreview: add migration script for review request extra_data (bug 1244448). r=smacleod
Mauro Doglio <mdoglio@mozilla.com> - Thu, 04 Feb 2016 15:52:38 +0000 - rev 362216
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: add migration script for review request extra_data (bug 1244448). r=smacleod
d24bbd4c73035eed3f9152aea81917d658cc93a2: mozreview: move MOZREVIEW_KEY to CommitData from extra_data (Bug 1244448). r=mcote
Steven MacLeod <smacleod@mozilla.com> - Thu, 04 Feb 2016 21:16:58 -0500 - rev 362215
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: move MOZREVIEW_KEY to CommitData from extra_data (Bug 1244448). r=mcote MOZREVIEW_KEY was the final piece of data that needed to be moved into the new CommitData model. Now all of the data backing a pushed review request can only be modified by the hg server.
8ea15f064e6ab0f943be5060cb01167da451b716: mozreview: use standard is_pushed function in isPush template filter (Bug 1244448). r=gps
Steven MacLeod <smacleod@mozilla.com> - Thu, 04 Feb 2016 20:45:58 -0500 - rev 362214
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: use standard is_pushed function in isPush template filter (Bug 1244448). r=gps
5b146b119ee0bc1cd47b7360a59d5f98b6308da4: mozreview: move DISCARD_ON_PUBLISH_KEY and UNPUBLISHED_KEY to CommitData from extra_data (Bug 1244448). r=gps
Steven MacLeod <smacleod@mozilla.com> - Thu, 04 Feb 2016 20:15:55 -0500 - rev 362213
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: move DISCARD_ON_PUBLISH_KEY and UNPUBLISHED_KEY to CommitData from extra_data (Bug 1244448). r=gps
98501d7f4a175b73538caa6f91e148cb80679237: mozreview: move COMMITS_KEY to CommitData from extra_data (Bug 1244448). r=gps
Steven MacLeod <smacleod@mozilla.com> - Thu, 04 Feb 2016 19:06:15 -0500 - rev 362212
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: move COMMITS_KEY to CommitData from extra_data (Bug 1244448). r=gps
014c467c87200b03fac84706182e234be31e93ae: mozreview: move SQUASHED_KEY to CommitData from extra_data (Bug 1244448). r=gps
Steven MacLeod <smacleod@mozilla.com> - Thu, 04 Feb 2016 18:03:58 -0500 - rev 362211
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: move SQUASHED_KEY to CommitData from extra_data (Bug 1244448). r=gps
ba65b6e0f2b58bf6bbb55e684046b9473277fd23: mozreview: move BASE_COMMIT_KEY to CommitData from extra_data (Bug 1244448). r=gps
Steven MacLeod <smacleod@mozilla.com> - Thu, 04 Feb 2016 16:36:02 -0500 - rev 362210
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: move BASE_COMMIT_KEY to CommitData from extra_data (Bug 1244448). r=gps
cef3a7274b5df0ba9605943207892eb24940b50e: mozreview: move COMMIT_ID_KEY to CommitData from extra_data (Bug 1244448). r=gps
Steven MacLeod <smacleod@mozilla.com> - Thu, 04 Feb 2016 15:40:35 -0500 - rev 362209
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: move COMMIT_ID_KEY to CommitData from extra_data (Bug 1244448). r=gps Since COMMIT_ID_KEY was the last DRAFTED_EXTRA_DATA_KEY, remove the code for copying the drafted keys for the built-in extra data. Additionally, update some of the extra_data.py helper methods to take in a commit_data object for reuse.
601c5edf9f98b51579cb238c89a77e29a42c23d6: mozreview: move FIRST_PUBLIC_ANCESTOR_KEY to CommitData from extra_data (Bug 1244448). r=gps
Steven MacLeod <smacleod@mozilla.com> - Thu, 04 Feb 2016 13:42:10 -0500 - rev 362208
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: move FIRST_PUBLIC_ANCESTOR_KEY to CommitData from extra_data (Bug 1244448). r=gps
2fbcf9bf2a99435df0644385d334186050dc9c20: mozreview: move IDENTIFIER_KEY to CommitData from extra_data (Bug 1244448). r=gps
Steven MacLeod <smacleod@mozilla.com> - Thu, 04 Feb 2016 11:59:30 -0500 - rev 362207
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: move IDENTIFIER_KEY to CommitData from extra_data (Bug 1244448). r=gps
bc172352ab426c0579f139e99cdb5a7f5ac58478: mozreview: remove direct extra_data key usage from rbbz (Bug 1244448). r=mcote
Steven MacLeod <smacleod@mozilla.com> - Thu, 04 Feb 2016 11:28:00 -0500 - rev 362206
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: remove direct extra_data key usage from rbbz (Bug 1244448). r=mcote To make moving the extra_data storage location easier we remove the final direct usage of extra_data KEY constants from rbbz. We should now be able to completely switch the storage location of the extra data without touching rbbz.
bb937917ebd0daa9b98078f62ce3b57a110d7036: mozreview: move review_request_closed signal handlers into MozReview from rbbz (Bug 1244448). r=mcote
Steven MacLeod <smacleod@mozilla.com> - Thu, 04 Feb 2016 11:19:06 -0500 - rev 362205
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: move review_request_closed signal handlers into MozReview from rbbz (Bug 1244448). r=mcote
7ed0a2d2486ae7893c6e8ae3036a4e48f6db03e5: mozreview: move on_review_request_reopened into MozReview from rbbz (Bug 1244448). r=mcote
Steven MacLeod <smacleod@mozilla.com> - Thu, 04 Feb 2016 10:51:01 -0500 - rev 362204
Push 16998 by rwood@mozilla.com at Mon, 02 May 2016 19:42:03 +0000
mozreview: move on_review_request_reopened into MozReview from rbbz (Bug 1244448). r=mcote This commit mostly just moves code from rbbz into MozReview, centered around what was needed to move on_review_request_reopened(). A few of the functions relating to extra data, and accessing it, were changed from the implementations present in rbbz to those in mozreview.extra_data, but functionality should remain the same.
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip