06242e612265680a1dbc28f47b126146b1be87cc: Bug 1318200 - Pass topsrcdir into decision parameters; r?dustin draft
Gregory Szorc <gps@mozilla.com> - Thu, 17 Nov 2016 17:42:55 -0800 - rev 441328
Push 36394 by bmo:gps@mozilla.com at Fri, 18 Nov 2016 18:38:31 +0000
Bug 1318200 - Pass topsrcdir into decision parameters; r?dustin This will allow filters and other code with access to parameters to examine the source checkout. Previously, we passed in "root" via options. But it was only exposed to the TaskGraphGenerator instance and not available in parameters. MozReview-Commit-ID: G2YKmlT0syB
4e499341a65666cf20149c0dd0d95f1766f6a59f: Bug 1318200 - Introduce task graph filtering; r?dustin draft
Gregory Szorc <gps@mozilla.com> - Thu, 17 Nov 2016 15:53:30 -0800 - rev 441327
Push 36394 by bmo:gps@mozilla.com at Fri, 18 Nov 2016 18:38:31 +0000
Bug 1318200 - Introduce task graph filtering; r?dustin Previously, we ran a single "target task" function to mutate the full task graph into a subset based on input parameters (try syntax, repository being built for, etc). This concept is useful. But the implementation was limiting because we could only have a single "target tasks" function. This commit introduces the concept of "filters." They conceptually do the same thing as "target tasks methods" but you can run more than 1 of them. Filters are simply functions that examine an input graph+parameters and emit nodes that should be retained. Filters, like target tasks methods, are defined via decorated functions in a module. TaskGraphGenerator has been converted to use filters. The list of defined filters can be defined in the parameters dict passed into TaskGraphGenerator. A default filter list is provided in decision.py. The intent is to eventually convert target tasks to filters. Until that happens, we always run the registered target tasks method via a filter proxy function. No new tests have been added because we don't yet have any functionality relying explicitly on filters. Tests will be added in a subsequent commit once we add a new filter. While I was here, I also snuck in some logging on the size of the graphs. MozReview-Commit-ID: ERn2hIYbMRp
9869d8dcd30cc71b14dadd1314dc620fe001e16e: Bug 418833 - Bump fuzzyness on ua-style-sheet-checkbox-radio-1 reftest for Android. r?jrmuizel draft
Mike Conley <mconley@mozilla.com> - Fri, 18 Nov 2016 11:55:53 -0500 - rev 441326
Push 36393 by mconley@mozilla.com at Fri, 18 Nov 2016 18:24:06 +0000
Bug 418833 - Bump fuzzyness on ua-style-sheet-checkbox-radio-1 reftest for Android. r?jrmuizel I talked to mstange about this, and what might be happening here is that there's a difference in rounding going on during (I think) rasterization. The change is very small and not human-noticable, so I think taking this fuzzyness is worth the cost considering the gain in functionality. MozReview-Commit-ID: C0CPNrIdCDu
4e06f2d584f033956d841376e0aa8bf22df88b0a: Bug 418833 - Get rid of some padding rules for checkbox and radio on Fennec that were never being applied. r?snorp draft
Mike Conley <mconley@mozilla.com> - Wed, 16 Nov 2016 14:26:34 -0500 - rev 441325
Push 36393 by mconley@mozilla.com at Fri, 18 Nov 2016 18:24:06 +0000
Bug 418833 - Get rid of some padding rules for checkbox and radio on Fennec that were never being applied. r?snorp MozReview-Commit-ID: LDrUKaP0nN0
aa608c8ee4d69ea3039c1e91cd7c274c72525e0b: Bug 418833 - Make browser_toolbox_computed_view.js have a longer timout to avoid a permaorange on debug builds. r?jryans draft
Mike Conley <mconley@mozilla.com> - Thu, 10 Nov 2016 19:29:33 -0500 - rev 441324
Push 36393 by mconley@mozilla.com at Fri, 18 Nov 2016 18:24:06 +0000
Bug 418833 - Make browser_toolbox_computed_view.js have a longer timout to avoid a permaorange on debug builds. r?jryans MozReview-Commit-ID: D1y1kR4Qkm0
66e159d44c3e9cb6a05d7fb77b374423f078265a: Bug 418833 - Make browser_toolbox_options.js more resilient to things being added to the document loading queue. r?jryans draft
Mike Conley <mconley@mozilla.com> - Wed, 09 Nov 2016 18:08:59 -0500 - rev 441323
Push 36393 by mconley@mozilla.com at Fri, 18 Nov 2016 18:24:06 +0000
Bug 418833 - Make browser_toolbox_options.js more resilient to things being added to the document loading queue. r?jryans Earlier patches in this series add SVG icons for unstyled checkboxes and radio buttons. This causes us to queue extra loads to documents that have those elements, even when we're natively styling those input elements by default. browser_toolbox_options works by loading up the DevTools options iframe, and then clicking on things to make sure that the right prefs are set. There are checkboxes in the iframe document, which means the extra loads I referred to happen. When our presentation subsystems notice that there are extra loads occurring, we do "paint suppression" to avoid flashes of unstyled content. During paint suppression, nothing is displayed (painting is suppressed), and so nothing is clickable. browser_toolbox_options was not waiting for the "load" event before clicking on items. It got lucky up until the SVGs were added, but this was a race waiting to happen. I've added a wait for the "load" event, and this test now passes. MozReview-Commit-ID: EjzvhxhKlDs
afc5364eaec89b52d0ac100c29bba0c77b73d816: Bug 418833 - Make non-native checkbox and radio input styles look right in Fennec. r?mtseng draft
Mike Conley <mconley@mozilla.com> - Thu, 10 Nov 2016 20:46:46 -0500 - rev 441322
Push 36393 by mconley@mozilla.com at Fri, 18 Nov 2016 18:24:06 +0000
Bug 418833 - Make non-native checkbox and radio input styles look right in Fennec. r?mtseng <input>'s of type checkbox and radio are rendered as native widgets by default on Desktop, but on Fennec, we fallback to using the built-in, non-native checkboxes. The earlier patches in this series made it possible for agent, user and page stylesheets to make changes to the non-native checkbox and radio input fields. Unfortunately, some of the default agent styles for those checkbox and radio elements on Fennec were accidentally setting rules that they shouldn't. That wasn't a problem before because the inputs couldn't be styled before. Now that they can, we're failing a bunch of reftests because the inputs look wrong in certain situations. For example: 1) We were setting background: var(--form_background) for every radio and checkbox input. --form_background is just a colour though, and that meant that the rest of the background styles were being overwritten. This has been fixed by setting background-color: var(--form_background) instead. The same also applied to some usage of --form_background_disabled. 2) We were setting border-radius: var(--form_border_radius) on all input elements, but this was putting rounded corners on the checkbox and radio inputs as well. This rule has been modified to skip checkbox and radio inputs. MozReview-Commit-ID: CnpTRXcCxoY
8357d7b259afa178b7f4c824f05e2b206c7bf2c3: Bug 418833 - Remove !important padding and border-radius rules for checkbox and radio form controls. r?tnikkel draft
Mike Conley <mconley@mozilla.com> - Fri, 21 Oct 2016 14:07:43 -0400 - rev 441321
Push 36393 by mconley@mozilla.com at Fri, 18 Nov 2016 18:24:06 +0000
Bug 418833 - Remove !important padding and border-radius rules for checkbox and radio form controls. r?tnikkel MozReview-Commit-ID: 86X3PHxmKFg
41c8a11532ca5c7406e40973e8efe3916e729c52: Bug 418833 - Move default checkbox/radio drawing to images. Allow overriding checkbox/radio styling. r?tnikkel,dao draft
Wes Johnston <we.j@live.com> - Thu, 03 Nov 2016 16:54:49 -0400 - rev 441320
Push 36393 by mconley@mozilla.com at Fri, 18 Nov 2016 18:24:06 +0000
Bug 418833 - Move default checkbox/radio drawing to images. Allow overriding checkbox/radio styling. r?tnikkel,dao MozReview-Commit-ID: HqyXXuYzjrE
20d2e8cdc22709de3cbcbfcd20f46b0b7a5c5266: Bug 1155860 - open a shared link -r?ahunt draft
Shubham <shubham2892@gmail.com> - Fri, 18 Nov 2016 12:50:53 -0500 - rev 441319
Push 36392 by bmo:shubham2892@gmail.com at Fri, 18 Nov 2016 18:13:55 +0000
Bug 1155860 - open a shared link -r?ahunt MozReview-Commit-ID: 6Vwfmpt4UQY
e9b20b0d01afeec91ed2e1b597d0e2f82eeec435: Bug 1316722 - [e10s] <select> dropdown list should handle Full/Text Zoom on Windows. r=mconley draft
Jared Wein <jwein@mozilla.com> - Fri, 18 Nov 2016 13:11:32 -0500 - rev 441318
Push 36391 by jwein@mozilla.com at Fri, 18 Nov 2016 18:13:33 +0000
Bug 1316722 - [e10s] <select> dropdown list should handle Full/Text Zoom on Windows. r=mconley MozReview-Commit-ID: 1QVeHfsBDlM
826459b4da9054cc23a7a1b5e88162475f6fe75b: Bug 1146194 - Multiple cookies with the same name not shown r=gl draft
Michael Ratcliffe <mratcliffe@mozilla.com> - Fri, 11 Nov 2016 15:57:51 +0000 - rev 441317
Push 36390 by bmo:mratcliffe@mozilla.com at Fri, 18 Nov 2016 18:04:44 +0000
Bug 1146194 - Multiple cookies with the same name not shown r=gl MozReview-Commit-ID: F2qgWofemHG
3c9b6a010ece1dfecdab0b6b90aefa7ded2bf2ea: Bug 1318730 - Fire the ScrollInputMethod::MainThreadScrollbarTrackClick telemetry probe in the non-scrollToClick case as well. r=kats draft
Botond Ballo <botond@mozilla.com> - Fri, 18 Nov 2016 13:01:56 -0500 - rev 441316
Push 36389 by bballo@mozilla.com at Fri, 18 Nov 2016 18:02:42 +0000
Bug 1318730 - Fire the ScrollInputMethod::MainThreadScrollbarTrackClick telemetry probe in the non-scrollToClick case as well. r=kats MozReview-Commit-ID: EQRu1NwYQDM
aff2c20d4f148f7c8b073715b7e805aa92518c64: debugging draft
Botond Ballo <botond@mozilla.com> - Wed, 16 Nov 2016 19:34:30 -0500 - rev 441315
Push 36389 by bballo@mozilla.com at Fri, 18 Nov 2016 18:02:42 +0000
debugging MozReview-Commit-ID: rjvT2nP43I
4fff7b04ec2fe58d6e73b2ec11f7fc12bdb611ed: Re-query scroll frame metrics before shipping scroll timeline information to the compositor draft
Botond Ballo <botond@mozilla.com> - Wed, 16 Nov 2016 19:34:22 -0500 - rev 441314
Push 36389 by bballo@mozilla.com at Fri, 18 Nov 2016 18:02:42 +0000
Re-query scroll frame metrics before shipping scroll timeline information to the compositor This ensures the effect of any reflow since the last query is picked up. MozReview-Commit-ID: 7lFmnuHocLs
9521cf4437e4fb49d39a6dd446d487e7767c5d0d: Do ScrollTimeline cleanup from Unlink() instead of the destructor draft
Botond Ballo <botond@mozilla.com> - Fri, 04 Nov 2016 16:27:49 -0400 - rev 441313
Push 36389 by bballo@mozilla.com at Fri, 18 Nov 2016 18:02:42 +0000
Do ScrollTimeline cleanup from Unlink() instead of the destructor MozReview-Commit-ID: Ku0NDS45odp
46099a15b6c4fbbf061a3da3904f088a4510a52c: Update lifetime management of ScrollTimeline to correspond to DocumentTimeline draft
Botond Ballo <botond@mozilla.com> - Wed, 26 Oct 2016 19:26:38 -0400 - rev 441312
Push 36389 by bballo@mozilla.com at Fri, 18 Nov 2016 18:02:42 +0000
Update lifetime management of ScrollTimeline to correspond to DocumentTimeline MozReview-Commit-ID: 7XtJqb9dal4
dceb1c4d6cbc56a7be6d1e2cc291d24e0b5e0c53: Do not disassociate finished animations from a scroll timeline draft
Botond Ballo <botond@mozilla.com> - Wed, 21 Sep 2016 15:10:32 -0400 - rev 441311
Push 36389 by bballo@mozilla.com at Fri, 18 Nov 2016 18:02:42 +0000
Do not disassociate finished animations from a scroll timeline MozReview-Commit-ID: 1hbCiDCenOq
74531155e2906aff1d1ce656dc01dc07db10bac6: Tick scroll timelines directly from the refresh driver draft
Botond Ballo <botond@mozilla.com> - Wed, 21 Sep 2016 12:59:26 -0400 - rev 441310
Push 36389 by bballo@mozilla.com at Fri, 18 Nov 2016 18:02:42 +0000
Tick scroll timelines directly from the refresh driver MozReview-Commit-ID: 1zKhphidi7a
dda5167b5567f14e5014e1786349f5a59d7c1450: Tell the cycle collector about the ScrollTimeline -> mElement link draft
Botond Ballo <botond@mozilla.com> - Fri, 16 Sep 2016 18:04:10 -0400 - rev 441309
Push 36389 by bballo@mozilla.com at Fri, 18 Nov 2016 18:02:42 +0000
Tell the cycle collector about the ScrollTimeline -> mElement link MozReview-Commit-ID: 3R1LyrWkKba
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip