02a11925d21dfec34d0fc6dc9b0f00095fd2452a: Bug 1403185 - Fix button value index lookup oob for Windows Gamepads; r=ted draft
Kyle Machulis <kyle@nonpolynomial.com> - Fri, 16 Mar 2018 18:20:31 -0700 - rev 768896
Push 103002 by bmo:kyle@nonpolynomial.com at Sat, 17 Mar 2018 01:22:10 +0000
Bug 1403185 - Fix button value index lookup oob for Windows Gamepads; r=ted We can get button indexes in HID usage reports that do not actually correspond to a button we store, meaning we can overstep bounds of the button array. Check validity before accessing array. MozReview-Commit-ID: AAQJLEgy2Ua
8b3a70bad7cf809f2ce719c6d69b8bce1348bcbe: Bug 1166986 - Remove unused unwrappedObj generation from maplike/setlike draft
Kyle Machulis <kyle@nonpolynomial.com> - Wed, 14 Mar 2018 17:25:51 -0700 - rev 768895
Push 103002 by bmo:kyle@nonpolynomial.com at Sat, 17 Mar 2018 01:22:10 +0000
Bug 1166986 - Remove unused unwrappedObj generation from maplike/setlike MozReview-Commit-ID: 3U3E77oieC0
834f5bb9ddef30f60e64c7007856873cb3198091: Bug 1446253 - Make EventUtils.synthesizeComposition() dispatch keydown and keyup event in default r?smaug draft
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 16 Mar 2018 22:35:07 +0900 - rev 768894
Push 103001 by masayuki@d-toybox.com at Sat, 17 Mar 2018 01:19:37 +0000
Bug 1446253 - Make EventUtils.synthesizeComposition() dispatch keydown and keyup event in default r?smaug We'll start to dispatch keydown event and keyup event even during composition. So, for testing those events won't break our UI, we should make EventUtils.synhtesizeComposition() and EventUtils.synthesizeCompositionChange() dispatch keydown event and keyup event even if callers don't specify keyboard event explicitly. Typically, "keydown" event is marked as "processed by IME", i.e., keyCode value is set to DOM_VK_PROCESSKEY and key is set to "Process", with our widget which handles native IME and key input. On the other hand, "keyup" is NOT marked as so. Therefore, this patch makes TextInputProcessor emulates this behavior without any new special flags. And for making possible to emulate special cases, this patch adds two flags to nsITextInputProcessor. One is KEY_DONT_MARK_KEYDOWN_AS_PROCESSED. The other is KEY_MARK_KEYUP_AS_PROCESSED. Unfortunately, those flags have opposite meaning but this must be better than making necessary to one flag for emulating usual keydown/keyup events. Finally, this makes some tests specify better keyboard information to synthesizeComposition() and synthesizeCompositionChange() to emulate actual keyboard events during composition. MozReview-Commit-ID: ItYaXILkNQE
bb24b2dbb81d6fd588cea72cdef9fa74cec5681e: Bug 1445569 - part 4: Get rid of EditorBase::GetStartNodeAndOffset() and EditorBase::GetEndNodeAndOffset() r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 15 Mar 2018 21:25:41 +0900 - rev 768893
Push 103001 by masayuki@d-toybox.com at Sat, 17 Mar 2018 01:19:37 +0000
Bug 1445569 - part 4: Get rid of EditorBase::GetStartNodeAndOffset() and EditorBase::GetEndNodeAndOffset() r?m_kato EditorBase::GetStartNodeAndOffset() and EditorBase::GetEndNodeAndOffset() are just wrappers of EditorBase::GetStartPoint() and EditorBase::GetEndPoint(). They may *compute* offset in the container node even if some callers don't need the offset. Therefore, we should get rid of them and make all callers use EditorBase::GetStartPoint() or EditorBase::GetEndPoint() directly. Note that EditorBase::GetStartNodeAndOffset() and EditorBase::GetEndNodeAndOffset() returns NS_ERROR_FAILURE if EditorBase::GetStartPoint() or EditorBase::GetEndPoint() returns not set point. Therefore, checking the result is set equals checking the old nsresult as an error. MozReview-Commit-ID: JLwqRMFLjHC
7165aa3d0a2fad8467b75182d2126c24c75ddf2e: Bug 1445569 - part 3: Make TextEditRules::CheckBidiLevelForDeletion() take |const EditorRawDOMPoint&| instead of |nsINode*| and offset in it r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 15 Mar 2018 18:38:46 +0900 - rev 768892
Push 103001 by masayuki@d-toybox.com at Sat, 17 Mar 2018 01:19:37 +0000
Bug 1445569 - part 3: Make TextEditRules::CheckBidiLevelForDeletion() take |const EditorRawDOMPoint&| instead of |nsINode*| and offset in it r?m_kato There are 2 callers of TextEditRules::CheckBidiLevelForDeletion(). One of them will start to use EditorRawDOMPoint. Therefore, making it take |const EditorRawDOMPoint&| instead of |nsINode*| and offset in it keeps the caller simpler. MozReview-Commit-ID: DRJXo8gnzba
87240369da1623ef85f21fba0da7818f03099e89: Bug 1445569 - part 2: Make WSRunObject::PriorVisibleNode() and WSRunObject::NextVisibleNode() take |const Editor(Raw)DOMPoint&| instead of a pair of |nsINode*| and offset in it r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 15 Mar 2018 18:23:50 +0900 - rev 768891
Push 103001 by masayuki@d-toybox.com at Sat, 17 Mar 2018 01:19:37 +0000
Bug 1445569 - part 2: Make WSRunObject::PriorVisibleNode() and WSRunObject::NextVisibleNode() take |const Editor(Raw)DOMPoint&| instead of a pair of |nsINode*| and offset in it r?m_kato Similar to the constructor of WSRunObject, PriorVisibleNode() and NextVisibleNode() callers may become ugly if the callers start to use Editor(Raw)DOMPoint. So, let's make them take Editor(Raw)DOMPoint instead of a pair of nsINode* and offset in it. Note that a lot of callers of them already use Editor(Raw)DOMPoint. So, we don't need to keep maintain overloads which takes nsINode* and offset in it directly. MozReview-Commit-ID: 3avMtL000nd
d182baca4455c7bde2b93e66741bb751f227df95: Bug 1445569 - part 1: Create WSRunObject constructor which takes |const Editor(Raw)DOMPoint&| instead of |nsINode*| and offset in it r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 15 Mar 2018 17:56:20 +0900 - rev 768890
Push 103001 by masayuki@d-toybox.com at Sat, 17 Mar 2018 01:19:37 +0000
Bug 1445569 - part 1: Create WSRunObject constructor which takes |const Editor(Raw)DOMPoint&| instead of |nsINode*| and offset in it r?m_kato The following patches make some WSRunObject users use EditorRawDOMPoint or EditorDOMPoint instead of a pair of nsINode and offset in it. Then, the code becomes too long like: > WSRunObject object(mHTMLEditor, pointToDoSomething.GetContainer(), > pointToDoSomething.Offset()); This is ugly and not easier to read than: > WSRunObject object(mHTMLEditor, pointToDoSomething); So, we should create alternative constructor of WSRunObject first. MozReview-Commit-ID: GiNWRBLl7zB
42d17b63e35013d82cbb5f3fa20c8fd3cd9cdcdb: Bug 1445929 - Make Editor(Raw)DOMPoint::IsEndOfContainer() check if mParent is container node before checking mChild r?m_kato draft
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 15 Mar 2018 22:08:19 +0900 - rev 768889
Push 103001 by masayuki@d-toybox.com at Sat, 17 Mar 2018 01:19:37 +0000
Bug 1445929 - Make Editor(Raw)DOMPoint::IsEndOfContainer() check if mParent is container node before checking mChild r?m_kato Editor(Raw)DOMPoint::IsEndOfContainer() checks mIsChildInitialized before referring mChild. However, it may be true even if mParent is not a container node like a text node. Therefore, if mParent is a text node and mIsChildInitialized is true, it always returns true (i.e., even if mOffset isn't same as length of mParent). This patch makes it check mParent->IsContainerNode() before checking mIsChildInitialized because after checking mIsChildInitialized, it validates the relation of the members. So, this keeps the validation simple. MozReview-Commit-ID: K2XrAZoNv2I
69e0c2e4bb85e5635fc239318a25e984cf33048d: Bug 1446571: Part 2b - Update update tests to run sequentially. r?aswan draft
Kris Maglione <maglione.k@gmail.com> - Fri, 16 Mar 2018 17:52:20 -0700 - rev 768888
Push 103000 by maglione.k@gmail.com at Sat, 17 Mar 2018 00:55:04 +0000
Bug 1446571: Part 2b - Update update tests to run sequentially. r?aswan MozReview-Commit-ID: AYgDFSTcTtT
42b43717283274a8d6750329550f048ac555bcc2: Bug 1446571: Part 2a - Stop throwing raw numeric values in https.js. r?aswan draft
Kris Maglione <maglione.k@gmail.com> - Fri, 16 Mar 2018 17:48:13 -0700 - rev 768887
Push 103000 by maglione.k@gmail.com at Sat, 17 Mar 2018 00:55:04 +0000
Bug 1446571: Part 2a - Stop throwing raw numeric values in https.js. r?aswan This isn't strictly related, but I ran into it for the nth time while updating tests, and I got fed up with having my tests fail with a useless numeric value with no indication of where it came from. MozReview-Commit-ID: 6OjgVYw7tNd
58db2320b1b710373f111df61089333f2248ad1f: Bug 1446571: Part 1 - Remove support for signed update.rdf files. draft
Kris Maglione <maglione.k@gmail.com> - Fri, 16 Mar 2018 17:51:11 -0700 - rev 768886
Push 103000 by maglione.k@gmail.com at Sat, 17 Mar 2018 00:55:04 +0000
Bug 1446571: Part 1 - Remove support for signed update.rdf files. MozReview-Commit-ID: FAXNRAivRcN
b2be704303519d4189e598cb36522b9a57d7fd4d: Bug 1295510 - Replace all uses of `new String` with POJOs in Sync. r?eoger draft
Dylan Turner <dylan.turner@cgs.act.edu.au>, Kit Cambridge <kit@yakshaving.ninja> - Fri, 16 Mar 2018 17:38:17 -0700 - rev 768885
Push 102999 by bmo:kit@mozilla.com at Sat, 17 Mar 2018 00:43:08 +0000
Bug 1295510 - Replace all uses of `new String` with POJOs in Sync. r?eoger MozReview-Commit-ID: K9jni7AbPsu
662eda99d8aa19b64c251d21795d00dd04271972: Bug 1295510 - Replace all uses of `new String` with POJOs in Sync. r?eoger draft
Dylan Turner <dylan.turner@cgs.act.edu.au> and Kit Cambridge <kit@yakshaving.ninja> - Fri, 16 Mar 2018 17:38:17 -0700 - rev 768884
Push 102998 by bmo:kit@mozilla.com at Sat, 17 Mar 2018 00:41:34 +0000
Bug 1295510 - Replace all uses of `new String` with POJOs in Sync. r?eoger MozReview-Commit-ID: K9jni7AbPsu
b2e82a4a4e85f67e37e94e1d0a875b1457aeb8f7: Bug 1446568: Move a couple other methods from nsDocument to nsIDocument. r=smaug draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Mar 2018 19:46:56 +0100 - rev 768883
Push 102997 by bmo:emilio@crisal.io at Sat, 17 Mar 2018 00:00:09 +0000
Bug 1446568: Move a couple other methods from nsDocument to nsIDocument. r=smaug Need to add an static_cast for nsIDOMDocument, but it'll be temporary, I'd expect. MozReview-Commit-ID: 1cSwlcQZL5N
496598da9d2fbeeeb4056b518c66f69495333dae: Bug 1446568: Move UseCounter stuff and IsSynthesized to nsIDocument. r=smaug draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Mar 2018 19:37:02 +0100 - rev 768882
Push 102997 by bmo:emilio@crisal.io at Sat, 17 Mar 2018 00:00:09 +0000
Bug 1446568: Move UseCounter stuff and IsSynthesized to nsIDocument. r=smaug MozReview-Commit-ID: IeKzmi31e8d
8370ff3b312f1968b1a61f9a60a81796ed9fb600: Bug 1446568: Make SetScriptGlobalObject not pure virtual. r=smaug draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Mar 2018 18:37:51 +0100 - rev 768881
Push 102997 by bmo:emilio@crisal.io at Sat, 17 Mar 2018 00:00:09 +0000
Bug 1446568: Make SetScriptGlobalObject not pure virtual. r=smaug MozReview-Commit-ID: 1kKPq7f50jC
f389c2a63993315c7957cc9a77beecc10c231c3c: Bug 1446568: Make nsIDocument SetContentType / SetDocumentCharacterSet not pure virtual. r=smaug draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Mar 2018 18:34:50 +0100 - rev 768880
Push 102997 by bmo:emilio@crisal.io at Sat, 17 Mar 2018 00:00:09 +0000
Bug 1446568: Make nsIDocument SetContentType / SetDocumentCharacterSet not pure virtual. r=smaug No good reason for them to be. MozReview-Commit-ID: 7bFVD8YFqo2
56273dc25c99b8a0a2224d5f1765a4b187eb502f: Bug 1446568: Move a couple more stuff from nsDocument to nsIDocument. r=smaug draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Mar 2018 19:30:15 +0100 - rev 768879
Push 102997 by bmo:emilio@crisal.io at Sat, 17 Mar 2018 00:00:09 +0000
Bug 1446568: Move a couple more stuff from nsDocument to nsIDocument. r=smaug MozReview-Commit-ID: JC2nqzJEq7U
dfe32f2fe3cb5823529fcf3a29ea1e6a76dd3b53: Bug 1446568: Move a few of the remaining nsDocument members to nsIDocument. r=smaug draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Mar 2018 19:25:16 +0100 - rev 768878
Push 102997 by bmo:emilio@crisal.io at Sat, 17 Mar 2018 00:00:09 +0000
Bug 1446568: Move a few of the remaining nsDocument members to nsIDocument. r=smaug MozReview-Commit-ID: 3FdiyHLFOh
6c5d2cd2e61b92ad2933395fea891a995136f255: Bug 1446568: Remove an unneeded cast. r=smaug draft
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 15 Mar 2018 18:45:29 +0100 - rev 768877
Push 102997 by bmo:emilio@crisal.io at Sat, 17 Mar 2018 00:00:09 +0000
Bug 1446568: Remove an unneeded cast. r=smaug MozReview-Commit-ID: ILtm9ybRwJ7
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip