007b471778c310660823bf7680e116a828bcb1e5: Bug 1393098 part 0: Refactor logic (add helper bool & reduce GetParent calls), in nsTextFrame::CharacterDataChanged. r=jfkthame
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 31 Aug 2017 10:45:36 -0700 - rev 657297
Push 77498 by hikezoe@mozilla.com at Fri, 01 Sep 2017 09:44:58 +0000
Bug 1393098 part 0: Refactor logic (add helper bool & reduce GetParent calls), in nsTextFrame::CharacterDataChanged. r=jfkthame This patch doesn't affect behavior at all -- it just adjusts the logic slightly. Specifically, this patch: (a) Changes some code that currently tracks a frame, to now instead track that frame's parent, since we only ever call GetParent() on it anyway. (b) Drops a null-check that becomes unnecessary as a result of that change. (It was only there to protect us from calling GetParent() on a null pointer during the first loop iteration, and now that's not a risk since we're tracking the parent itself, and a null value will fail the equality comparison and do the right thing.) (c) Captures the "are ancestors already aware of a reflow request for my subtree" if-condition in a named boolean helper-variable. (d) Adds/improves documentation. MozReview-Commit-ID: 7dEflfiERYB
8ab1649365bb4e3cb484fb3bfc76364a1f800cd6: servo: Merge #18330 - stylo: Add a special case for marking something as dirty from invalidation code (from emilio:invalidation-stuff); r=bholley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 31 Aug 2017 14:14:15 -0500 - rev 657296
Push 77498 by hikezoe@mozilla.com at Fri, 01 Sep 2017 09:44:58 +0000
servo: Merge #18330 - stylo: Add a special case for marking something as dirty from invalidation code (from emilio:invalidation-stuff); r=bholley Source-Repo: https://github.com/servo/servo Source-Revision: 09df9c4316779899c7820cac56ecd18793f1f4a3
eff91b4e33156ebcb56b52eb22a87cf034cd8619: Bug 1395613 - import bundles from devtools-source-map 0.12.0; r=bgrins
Tom Tromey <tom@tromey.com> - Thu, 31 Aug 2017 11:44:56 -0600 - rev 657295
Push 77498 by hikezoe@mozilla.com at Fri, 01 Sep 2017 09:44:58 +0000
Bug 1395613 - import bundles from devtools-source-map 0.12.0; r=bgrins MozReview-Commit-ID: n5XTA3YN3G
63b87e31320db96a4af189dfcd468f8134ae1ebd: Bug 1393274 - bustage: Add gravity=start where textAlignment to appease lint. r=mcomella
Michael Comella <michael.l.comella@gmail.com> - Thu, 31 Aug 2017 13:07:32 -0700 - rev 657294
Push 77498 by hikezoe@mozilla.com at Fri, 01 Sep 2017 09:44:58 +0000
Bug 1393274 - bustage: Add gravity=start where textAlignment to appease lint. r=mcomella Lint passes locally. MozReview-Commit-ID: 8f6hBwjzoYJ
a1a1f209f8256e0a9742805d9d832e322b7e5b25: Bug 1393274: Correct webpage RTL padding/margins. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Wed, 30 Aug 2017 13:27:20 -0700 - rev 657293
Push 77498 by hikezoe@mozilla.com at Fri, 01 Sep 2017 09:44:58 +0000
Bug 1393274: Correct webpage RTL padding/margins. r=liuche Previously, I added a comment to explain why the explicit 0dp padding/margins are necessary for RTL but since it's required everywhere padding/margins are used, it's unsustainable and I chose not to do it here. MozReview-Commit-ID: H7H9xgeLy8b
2a39f7aa9629f1871d5ce205093419f1dcc73fa0: Bug 1393274: Align webpage item row text to right in RTL, left in LTR. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Wed, 30 Aug 2017 13:24:46 -0700 - rev 657292
Push 77498 by hikezoe@mozilla.com at Fri, 01 Sep 2017 09:44:58 +0000
Bug 1393274: Align webpage item row text to right in RTL, left in LTR. r=liuche MozReview-Commit-ID: 6VSF73V6Mda
e8bc46732fe116cf263a4e607d8e04ab08b32eb5: Bug 1393274: Rename card_history_item -> webpage_item_row & friends. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Wed, 30 Aug 2017 11:45:27 -0700 - rev 657291
Push 77498 by hikezoe@mozilla.com at Fri, 01 Sep 2017 09:44:58 +0000
Bug 1393274: Rename card_history_item -> webpage_item_row & friends. r=liuche Unrelated to RTL changes but these names are awful and gotta go! MozReview-Commit-ID: Kud6tgfEGkk
bb9206cf5ceb31a15dfd3c352a0dba140394a4af: Bug 1391019 - Replace the py(3) task with py-compat lint task, r=gps
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 31 Aug 2017 10:12:30 -0400 - rev 657290
Push 77498 by hikezoe@mozilla.com at Fri, 01 Sep 2017 09:44:58 +0000
Bug 1391019 - Replace the py(3) task with py-compat lint task, r=gps MozReview-Commit-ID: ABtq9dnPo9T
ad881fc5e6b01f2c74d3a325b6c622a3ccb606c5: Bug 1391019 - Add py2 and py3 compatability linters, r=gps
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 31 Aug 2017 10:12:02 -0400 - rev 657289
Push 77498 by hikezoe@mozilla.com at Fri, 01 Sep 2017 09:44:58 +0000
Bug 1391019 - Add py2 and py3 compatability linters, r=gps check_compat.py was adapted from gps' check-py3-compat.py in mercurial: https://www.mercurial-scm.org/repo/hg/file/tip/contrib/check-py3-compat.py The py3 linter simply runs ast.parse(f) for each file being linted. Any syntax errors are formatted as mozlint results and dumped to stdout as json. I looked into also importing the file (using 3.5+'s importlib.util.spec_from_file_location), but there were too many problems: 1. Lots of false positives (e.g module not found) 2. Some files seemed to run indefinitely on import I decided to punt on importing for now, we can always investigate in a follow-up. The py2 linter runs ast.parse(f), and also checks that the file has: from __future__ import absolute_import, print_function Initially every python file in the tree is excluded from the py2 check, though at least this makes it easy to find+fix, and new files in un-excluded directories will automatically be linted. MozReview-Commit-ID: ABtq9dnPo9T
4c74a9958b31e99aef1e43b05efd7c48d057d595: Bug 1391019 - Move tools/lint/flake_/__init__.py to tools/lint/python/flake8.py, r=gps
Andrew Halberstadt <ahalberstadt@mozilla.com> - Thu, 31 Aug 2017 10:06:08 -0400 - rev 657288
Push 77498 by hikezoe@mozilla.com at Fri, 01 Sep 2017 09:44:58 +0000
Bug 1391019 - Move tools/lint/flake_/__init__.py to tools/lint/python/flake8.py, r=gps This will allow us keep python related linting files in the same place. MozReview-Commit-ID: ABtq9dnPo9T
3ba255876335c727a546dca2f6c0c48576c6e538: Bug 1395327 - Disable webrender samplers, as they're causing MacOS to crash. r=kats
Alexis Beingessner <a.beingessner@gmail.com> - Thu, 31 Aug 2017 14:52:29 -0400 - rev 657287
Push 77498 by hikezoe@mozilla.com at Fri, 01 Sep 2017 09:44:58 +0000
Bug 1395327 - Disable webrender samplers, as they're causing MacOS to crash. r=kats MozReview-Commit-ID: EU599EOaZZ7
4f95bb8143aa3a4d43aca222753bd6aeee1d9394: Bug 1386862: stylo: Turn on the devtools/client/inspector/rules/test/browser_rules_edit-selector_12.js test. r=bholley,jryans
Brad Werth <bwerth@mozilla.com> - Tue, 29 Aug 2017 14:43:18 -0700 - rev 657286
Push 77498 by hikezoe@mozilla.com at Fri, 01 Sep 2017 09:44:58 +0000
Bug 1386862: stylo: Turn on the devtools/client/inspector/rules/test/browser_rules_edit-selector_12.js test. r=bholley,jryans MozReview-Commit-ID: 2hoir7rgybi
250d13bd254cb6aae1caf2d5973c16846027e8e8: Backed out 3 changesets (bug 1393274) for android lint failures a=backout
Wes Kocher <wkocher@mozilla.com> - Thu, 31 Aug 2017 11:40:09 -0700 - rev 657285
Push 77498 by hikezoe@mozilla.com at Fri, 01 Sep 2017 09:44:58 +0000
Backed out 3 changesets (bug 1393274) for android lint failures a=backout Backed out changeset 52e7fa268a65 (bug 1393274) Backed out changeset 29e8bf6a34c1 (bug 1393274) Backed out changeset 03063f77c3f5 (bug 1393274) MozReview-Commit-ID: 5BOV55zQaFf
25801e787df453260f00d106d29816109eac9557: Bug 1388611 - Preserve .sqlite-wal files with a Firefox Reset. r=mak
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Thu, 31 Aug 2017 00:38:55 -0700 - rev 657284
Push 77498 by hikezoe@mozilla.com at Fri, 01 Sep 2017 09:44:58 +0000
Bug 1388611 - Preserve .sqlite-wal files with a Firefox Reset. r=mak MozReview-Commit-ID: At6IY39uNPt
2d2bb8bc3b2ddde10bed7a65d22d447164a45cec: Bug 1388611 - Update mProfileName after a profile reset to handle multiple consecutive resets. r=Dolske
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 30 Aug 2017 23:47:17 -0700 - rev 657283
Push 77498 by hikezoe@mozilla.com at Fri, 01 Sep 2017 09:44:58 +0000
Bug 1388611 - Update mProfileName after a profile reset to handle multiple consecutive resets. r=Dolske Follow-up to bug 1122124 to ensure `SaveWordToEnvIfUnset("XRE_PROFILE_NAME", mProfileName);` saves the updated profile name after reset takes the old profiles name. MozReview-Commit-ID: MTJAQUKktM
52e7fa268a65a5d96177f8ff145a88201b38d3b7: Bug 1393274: Correct webpage RTL padding/margins. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Wed, 30 Aug 2017 13:27:20 -0700 - rev 657282
Push 77498 by hikezoe@mozilla.com at Fri, 01 Sep 2017 09:44:58 +0000
Bug 1393274: Correct webpage RTL padding/margins. r=liuche Previously, I added a comment to explain why the explicit 0dp padding/margins are necessary for RTL but since it's required everywhere padding/margins are used, it's unsustainable and I chose not to do it here. MozReview-Commit-ID: H7H9xgeLy8b
29e8bf6a34c1548c7c28aca618d03795a2f3cbc8: Bug 1393274: Align webpage item row text to right in RTL, left in LTR. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Wed, 30 Aug 2017 13:24:46 -0700 - rev 657281
Push 77498 by hikezoe@mozilla.com at Fri, 01 Sep 2017 09:44:58 +0000
Bug 1393274: Align webpage item row text to right in RTL, left in LTR. r=liuche MozReview-Commit-ID: 6VSF73V6Mda
03063f77c3f566c8d3f05878616b3f4c47171757: Bug 1393274: Rename card_history_item -> webpage_item_row & friends. r=liuche
Michael Comella <michael.l.comella@gmail.com> - Wed, 30 Aug 2017 11:45:27 -0700 - rev 657280
Push 77498 by hikezoe@mozilla.com at Fri, 01 Sep 2017 09:44:58 +0000
Bug 1393274: Rename card_history_item -> webpage_item_row & friends. r=liuche Unrelated to RTL changes but these names are awful and gotta go! MozReview-Commit-ID: Kud6tgfEGkk
530358f38866878c5bd86c0ac6801656de6aac62: Backed out changeset 2a69de9c73c6 (bug 1351081) for dt failures in browser_inspector_highlighter-cssshape_03.js a=backout
Wes Kocher <wkocher@mozilla.com> - Thu, 31 Aug 2017 11:23:52 -0700 - rev 657279
Push 77498 by hikezoe@mozilla.com at Fri, 01 Sep 2017 09:44:58 +0000
Backed out changeset 2a69de9c73c6 (bug 1351081) for dt failures in browser_inspector_highlighter-cssshape_03.js a=backout MozReview-Commit-ID: FYdGE6c4LLh
3442318a1024c691ff97bd1e31bae7889519d6a1: Bug 1369677 - Handle RenderTexture lock() failed. r=nical
JerryShih <hshih@mozilla.com> - Thu, 31 Aug 2017 03:17:00 -0400 - rev 657278
Push 77498 by hikezoe@mozilla.com at Fri, 01 Sep 2017 09:44:58 +0000
Bug 1369677 - Handle RenderTexture lock() failed. r=nical MozReview-Commit-ID: Ghez1SJ6ghf
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip