Backed out changeset 57800baf24a3 (bug 1379864)

Bug 1379890 - Remove unused mozjemalloc stats. r=njn Since bug 1378258 remove malloc_print_stats, there are a bunch of allocator stats that are now unused, reducing the memory footprint of allocator metadata.

Bug 1379878 - Use C++ templates to make _malloc_message calls cleaner. r=njn

Bug 1379878 - Remove umax2s, its last use was removed in bug 1378258. r=njn

Bug 1360772 - Allow to initialize non-zeroed arena chunks. r=njn When initializing a new chunk for use as an arena, we started by zeroing out the chunk (if that wasn't the case) and then initializing a new arena chunk in there. It turns out this can have a noticeable overhead, especially when e.g. the new arena chunk is used for a large allocation filled out by something that is realloc()ated. OTOH, the chunk recycle code only ever keeps zeroed or arena chunks around (there is a "recycled" type too, but in practice, at the moment, this means they were arena chunks before). Arena chunks that were recycled were totally emptied, so all the runs they may contain will contain zeroed-out or poisoned data. They also contain a header, that is overwritten by the new arena chunk initialization. This means we can get away with reusing non-zeroed recycled chunks without zeroing them, as long as the arena chunk header marks the runs as madvised instead of zeroed. Code-wise, this would benefit from getting a ChunkType out of chunk_alloc, but this would require more refactoring than I'm willing to do at the moment.

Bug 1360772 - Indicate to chunk_recycle callers that pages_commit has zeroed the chunk. r=njn Before returning a chunk, chunk_recycle calls pages_commit (when MALLOC_DECOMMIT is enabled), which is guaranteed to zero the chunk. The code further zeroing the chunk afterwards, which is now moved out to chunk_alloc callers, never took advantage of that fact, duplicating the effort of zeroing the chunk on Windows. By indicating to the callers that the chunk has already been zeroed, we allow callers to skip zeroing on their own.

Bug 1360772 - Make chunk_alloc callers handle zeroing when they need it. r=njn The current code only allows chunk_calloc() callers to tell whether they want zeroed memory or not, but some might be okay either way, assuming they act accordingly afterwards. So move the zeroing out of chunk_alloc.

Bug 1360772 - Store the chunk type in chunk recycling queue. r=njn

Bug 1360772 - Make pages_purge return whether the pages were purged. r=njn Many functions in the mozjemalloc codebase like to return the opposite boolean one would tend to expect. Pages_purge is one of them, and this reverses the logic to match expectations. Also make it static.

Bug 1376925 - In the bookmarks folder tree of the edit dialog, don't invalidate elements whilst we are editing. Also improve the stability of browser_bookmarksProperties.js. r?mak MozReview-Commit-ID: IRDgLVACMxG

Bug 1376925 - Avoid some warnings about this._paneInfo being undefined in editBookmarkOverlay.js when an event happens during closing the dialog. r?mak MozReview-Commit-ID: GZKe4z6kpGP

Bug 1376925 - Modernise browser_bookmarksProperties.js to use async functions and assert. r?mak MozReview-Commit-ID: 26PBBgP9tSf

Bug 1308566 - Add a mochitest for the ObjectInspector in the console. r=bgrins MozReview-Commit-ID: GDiZEo7xfPJ

Bug 1308566 - Fixes broken tests due to the ObjectInspector switch. r=bgrins Some tests were failing after switching to ObjectInspector. Here we remove the ones that are specific to the VariableView, and fix the "store as global" one. MozReview-Commit-ID: 4IhNp4MTC2k

Bug 1308566 - Release actors from loaded properties. r=bgrins, Honza Because we need to check in an another property from the store for actors to release, a little refactor of how we deal with actors to be released was needed. So instead of tracking removed messages from the store, we directly track removed actors. We can compute this list directly in the reducer, and it even allow us to simplify the enhancer a bit. Some tests where added to make sure we do handle loaded properties in the store. MozReview-Commit-ID: 72F2wl3UaLA

Bug 1308566 - Use Object Inspector in Console. r=Honza, bgrins MozReview-Commit-ID: 9jzXwHlBu3X

Bug 1308566 - Add a mochitest for the ObjectInspector in the console. r=bgrins MozReview-Commit-ID: GDiZEo7xfPJ

Bug 1308566 - Fixes broken tests due to the ObjectInspector switch. r=bgrins Some tests were failing after switching to ObjectInspector. Here we remove the ones that are specific to the VariableView, and fix the "store as global" one. MozReview-Commit-ID: 4IhNp4MTC2k

Bug 1308566 - Release actors from loaded properties. r=bgrins, Honza Because we need to check in an another property from the store for actors to release, a little refactor of how we deal with actors to be released was needed. So instead of tracking removed messages from the store, we directly track removed actors. We can compute this list directly in the reducer, and it even allow us to simplify the enhancer a bit. Some tests where added to make sure we do handle loaded properties in the store. MozReview-Commit-ID: 72F2wl3UaLA

Bug 1308566 - Use Object Inspector in Console. r=Honza, bgrins MozReview-Commit-ID: 27AKO9qQLq7