[Bug 1324118] RTL support for devtool framework connection screen draft Bug 1324118
authorTomer Cohen <tomer@tomercohen.com>
Sat, 17 Dec 2016 01:08:07 +0200
branchBug 1324118
changeset 450548 2e061c9d36ce575eb749bf4393577129605db44d
parent 447742 c401d72933641748f3738e90e7bbe539705e2f1c
child 724630 fec419744f7757caa14cd2e639e1c4f5a2467807
push id38893
push userbmo:tomer.moz.bugs@tomercohen.com
push dateFri, 16 Dec 2016 23:09:16 +0000
bugs1324118
milestone53.0a1
[Bug 1324118] RTL support for devtool framework connection screen MozReview-Commit-ID: 6h7JdUY4lsT
devtools/client/framework/connect/connect.css
devtools/client/framework/connect/connect.xhtml
--- a/devtools/client/framework/connect/connect.css
+++ b/devtools/client/framework/connect/connect.css
@@ -32,22 +32,26 @@ form {
 label {
   display: block;
   margin: 10px;
 }
 
 label > span {
   display: inline-block;
   min-width: 150px;
-  text-align: right;
-  margin-right: 10px;
+  text-align: end;
+  margin-inline-end: 10px;
 }
 
 #submit {
-  float: right;
+  float: inline-end;
+}
+
+input {
+  direction: ltr;
 }
 
 input:invalid {
   box-shadow: 0 0 2px 2px #F06;
 }
 
 section {
   min-height: 160px;
--- a/devtools/client/framework/connect/connect.xhtml
+++ b/devtools/client/framework/connect/connect.xhtml
@@ -1,19 +1,21 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!-- This Source Code Form is subject to the terms of the Mozilla Public
    - License, v. 2.0. If a copy of the MPL was not distributed with this
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <!DOCTYPE html [
 <!ENTITY % connectionDTD SYSTEM "chrome://devtools/locale/connection-screen.dtd" >
  %connectionDTD;
+<!ENTITY % globalDTD SYSTEM "chrome://global/locale/global.dtd">
+ %globalDTD;
 ]>
 
-<html xmlns="http://www.w3.org/1999/xhtml"
+<html xmlns="http://www.w3.org/1999/xhtml" dir="&locale.dir;"
       xmlns:xul="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">
   <head>
     <title>&title;</title>
     <link rel="stylesheet" href="chrome://devtools/skin/dark-theme.css" type="text/css"/>
     <link rel="stylesheet" href="chrome://devtools/content/framework/connect/connect.css" type="text/css"/>
     <script type="application/javascript;version=1.8" src="connect.js"></script>
   </head>
   <body>