Bug 1076810 - RelEng CI tests should be available over the internet, not just from VPN - allow pep8 failures not to break tests and remove coveralls from README.md,r=pmoore
authorJustin Wood <Callek@gmail.com>
Tue, 06 Jan 2015 11:02:19 +0100
changeset 11599 a599d98c55de09bf0b902d8c588b0e0fd668984d
parent 11598 222b655abc77b015f2e4f1ba450c1e75f976cf0b
child 11600 d2c7fd0ce917d8609528a83818b264b6c25d7540
child 12808 ff8d2391ae2dd7316d65bd5f70f711eeab395ca9
push id3
push userahalberstadt@mozilla.com
push dateWed, 29 Apr 2015 14:58:39 +0000
reviewerspmoore
bugs1076810
Bug 1076810 - RelEng CI tests should be available over the internet, not just from VPN - allow pep8 failures not to break tests and remove coveralls from README.md,r=pmoore
.travis.yml
README.md
tox.ini
--- a/.travis.yml
+++ b/.travis.yml
@@ -3,16 +3,20 @@ python:
   - "2.7"
 
 install:
   - pip install tox
 
 script:
   - tox
 
+after_script:
+  # only in after_script can it run without failing the job
+  - tox -e pep8
+
 # currently cannot customise per user fork, see:
 # https://github.com/travis-ci/travis-ci/issues/1094
 # please comment out this section in your personal fork!
 notifications:
   irc:
     channels:
       - "irc.mozilla.org#releng"
     on_success: always
--- a/README.md
+++ b/README.md
@@ -15,21 +15,19 @@ This bug will get triaged by us.
 ### To run unit tests
 ```
 pip install tox
 tox
 ```
 
 ### To run tests in travis
 Please note if you fork this repository and wish to run the tests in travis,
-you will need to enable your github fork in both travis and coveralls. In both
-cases you can log in with your github account, you do not need to set up a new
-one. To enable:
+you will need to enable your github fork in travis. You can log in with your
+github account, you do not need to set up a new one. To enable:
 * https://travis-ci.org/profile
-* https://coveralls.io/repos/new
 
 After enabling, you will need to push changes to your repo in order for a travis
 job to be triggered.
 
 ### To match commits to upstream hg changesets
 Add this following section to the .git/config file in your local clone:
 ```
 [remote "mozilla"]
--- a/tox.ini
+++ b/tox.ini
@@ -20,14 +20,23 @@ deps =
     distribute==0.6.14
     pyOpenSSL==0.14
     pyasn1==0.0.11a
     pycrypto==2.3
     pytz==2011d
     wsgiref==0.1.2
     zope.interface==3.6.1
     MozillaPulse==0.80
-    pep8
 
 commands =
     ./tox_env.sh "{toxinidir}" "{toxworkdir}"
     ./test-masters.sh -e
+
+
+[testenv:pep8]
+# Don't fail on pep8 yet
+# Would love to enable failing this by default - See:
+# https://bitbucket.org/hpk42/tox/issue/124/ignore-command-exit-codes
+deps=
+    pep8
+    {[testenv]deps}
+commands=
     pep8 --max-line-length=159 --exclude=.svn,CVS,.bzr,.hg,.git,__pycache__,seamonkey,calendar,.tox