Bug 942393 - small nit in Australis' CustomizableUI docs, remove TYPE_BUTTON which is unused and non-useful, r=jaws for the latter, DONTBUILD because comment/dead code only
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Mon, 06 Jan 2014 17:58:16 +0000
changeset 162240 ff1038cbc19511c0f74885c1c2e69edd63f46f5d
parent 162239 be49376c1bd5faf1cb9d5c94cf7ed074894cd1d2
child 162241 f78ec00f29f5ff6d509f71942c6941bcf64e2706
push id25941
push userkwierso@gmail.com
push dateTue, 07 Jan 2014 01:20:54 +0000
treeherdermozilla-central@ce917d3dd7c8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjaws
bugs942393
milestone29.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 942393 - small nit in Australis' CustomizableUI docs, remove TYPE_BUTTON which is unused and non-useful, r=jaws for the latter, DONTBUILD because comment/dead code only
browser/components/customizableui/src/CustomizableUI.jsm
--- a/browser/components/customizableui/src/CustomizableUI.jsm
+++ b/browser/components/customizableui/src/CustomizableUI.jsm
@@ -2142,18 +2142,16 @@ this.CustomizableUI = {
    */
   get SOURCE_BUILTIN() "builtin",
   /**
    * Constant indicating the widget is externally provided
    * (e.g. by add-ons or other items not part of the builtin widget set).
    */
   get SOURCE_EXTERNAL() "external",
 
-  get TYPE_BUTTON() "button",
-
   /**
    * The class used to distinguish items that span the entire menu panel.
    */
   get WIDE_PANEL_CLASS() "panel-wide-item",
   /**
    * The (constant) number of columns in the menu panel.
    */
   get PANEL_COLUMN_COUNT() 3,
@@ -2724,17 +2722,19 @@ this.CustomizableUI = {
    * @param aArea     the area ID you want to move it to.
    * @return true if this is possible, false if it is not. Same caveats as
    *              for isWidgetRemovable apply, however, if no windows are open.
    */
   canWidgetMoveToArea: function(aWidgetId, aArea) {
     return CustomizableUIInternal.canWidgetMoveToArea(aWidgetId, aArea);
   },
   /**
-   * Whether we're in a default state.
+   * Whether we're in a default state. Note that non-removable non-default
+   * widgets and non-existing widgets are not taken into account in determining
+   * whether we're in the default state.
    *
    * NB: this is a property with a getter. The getter is NOT cheap, because
    * it does smart things with non-removable non-default items, non-existent
    * items, and so forth. Please don't call unless necessary.
    */
   get inDefaultState() {
     return CustomizableUIInternal.inDefaultState;
   },