Bug 1462791: [taskgraph] Return list from `generic_worker_hg_commands`; r=dustin a=Aryx
authorTom Prince <mozilla@hocat.ca>
Fri, 25 May 2018 08:55:42 -0600
changeset 419820 fe66c9e30a203531fe312dc052882e25a34f806e
parent 419819 bf4762f10b8d3076d6862e88ca61f90271291508
child 419843 e1db820796b22bb3cbdafad7e6aabab4cc6a6ab2
push id34050
push usermozilla@hocat.ca
push dateFri, 25 May 2018 15:07:14 +0000
treeherdermozilla-central@fe66c9e30a20 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdustin, Aryx
bugs1462791
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1462791: [taskgraph] Return list from `generic_worker_hg_commands`; r=dustin a=Aryx Some code[1] expects to be able to `.extend` the result. [1] https://searchfox.org/mozilla-central/rev/bf4def01bf8f6ff0d18f02f2d7e9efc73e12c63f/taskcluster/taskgraph/transforms/job/mozharness.py#318-331 Differential Revision: https://phabricator.services.mozilla.com/D1384
taskcluster/taskgraph/transforms/job/common.py
--- a/taskcluster/taskgraph/transforms/job/common.py
+++ b/taskcluster/taskgraph/transforms/job/common.py
@@ -133,17 +133,17 @@ def generic_worker_hg_commands(base_repo
         b":: TinderboxPrint:<a href={source_repo}/rev/{revision} "
         b"title='Built from {repo_name} revision {revision}'>{revision}</a>"
         b"\n".format(
             revision=head_rev,
             source_repo=head_repo,
             repo_name=head_repo.split('/')[-1]),
     ]
 
-    return ' '.join(args), ' '.join(logging_args)
+    return [' '.join(args), ' '.join(logging_args)]
 
 
 def docker_worker_setup_secrets(config, job, taskdesc):
     """Set up access to secrets via taskcluster-proxy.  The value of
     run['secrets'] should be a boolean or a list of secret names that
     can be accessed."""
     if not job['run'].get('secrets'):
         return